Attention is currently required from: laforge, neels, osmith.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36772?usp=email )
Change subject: msc: add TC_gsup_mt_sms_lu_delay for X36 (LU delay) timer
......................................................................
Patch Set 4:
(1 comment)
File msc/MSC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36772/comment/a578eb01_2be1…
PS4, Line 3325: mtc.stop;
> Why mtc. […]
Your understanding is correct. This is unfortunately the weak side of TTCN-3: there exists no mechanism that would allow to execute some clean-up code regardless of the testcase execution flow. The is not the only `mtc.stop` that can abort the MTC and leave the IUT in 'unclean' state. We may also run into this problem if, for instance, `Tguard` fires. Likewise, in `f_expect_clear()` we also do `mtc.stop` if we do not receive CLEAR COMMAND in time.
A more fundamental approach to avoid this would be resetting this timer in `f_init()` or `f_init_handler()`. But this timer is not yet in master, so resetting it there would break all testcases.
I can remove this `mtc.stop`, but this would not solve the problem globally/fundamentally.
So I would just keep this as-is and not invest time into that.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36772?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I74fa174ea649adb2112c8e471c0e339a2197a08d
Gerrit-Change-Number: 36772
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 04 Jun 2024 08:36:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment
pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36951?usp=email )
Change subject: asterisk: pjsip.conf: Disable remote bridging between local SIP and IMS
......................................................................
asterisk: pjsip.conf: Disable remote bridging between local SIP and IMS
While implementing a first ttcn3 test validating the MO call scenario
(SIP-UA -> Asterisk -> IMS-CORE) [1] I was running into the scenario
where, after the first SIP INVITE + 200 OK + ACK, Asterisk was sending
a RE-INVITE to both parties to attempt to remotely bridge them (RTP
traffic flowing directly between them without passing through Asterisk).
This happened in part because I'm so far configure A-LAW on both sides
so asterisk figures out it can do so. I still need to change IMS-core
to EVS only.
In any case, regardless of the codecs used, my understanding is that
asterisk should never attempt remote bridging when using the "volte_ims"
endpoint, since that network segment is separate from the local network
where the local SIP UAs are located.
The "direct_media=no" option just addresses the issue; Asterisk no longer
tries to re-invite after the call is established
Related: SYS#6782
Change-Id: I4edea96151b31f02bf292b43b757922389375429
---
M ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf
1 file changed, 29 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf b/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf
index 9400780..9ca85e5 100644
--- a/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf
+++ b/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf
@@ -106,6 +106,7 @@
rewrite_contact=yes
from_user=238010000090828
from_domain=172.18.11.103
+direct_media=no
[volte_ims]
type=auth
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36951?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I4edea96151b31f02bf292b43b757922389375429
Gerrit-Change-Number: 36951
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36948?usp=email )
Change subject: asterisk: AMI_Functions: Fix decoding of empty AccountID field
......................................................................
asterisk: AMI_Functions: Fix decoding of empty AccountID field
While at it, convert the code to a loop since we start to have a bunch
of fields to check.
Change-Id: Ifc0e84a81b24d8ce8194b769a8ff9a0d4f3e85ff
---
M asterisk/AMI_Functions.ttcn
1 file changed, 17 insertions(+), 7 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
osmith: Looks good to me, but someone else must approve
diff --git a/asterisk/AMI_Functions.ttcn b/asterisk/AMI_Functions.ttcn
index a82af97..9c84d00 100644
--- a/asterisk/AMI_Functions.ttcn
+++ b/asterisk/AMI_Functions.ttcn
@@ -419,13 +419,11 @@
private function dec_AMI_Msg_ext(charstring txt) return AMI_Msg {
log("AMI dec: '", txt, "'");
/* TEXT Enc/dec is not happy with empty values, workaround it: */
- var charstring patched_txt := f_str_replace(txt, "Challenge: \r\n", "");
- patched_txt := f_str_replace(patched_txt, "AccountCode: \r\n", "");
- patched_txt := f_str_replace(patched_txt, "Value: \r\n", "");
- patched_txt := f_str_replace(patched_txt, "DestExten: \r\n", "");
- patched_txt := f_str_replace(patched_txt, "Exten: \r\n", "");
- patched_txt := f_str_replace(patched_txt, "Extension: \r\n", "");
- patched_txt := f_str_replace(patched_txt, "Hint: \r\n", "");
+ var Misc_Helpers.ro_charstring fields := { "AccountCode", "AccountID", "Challenge", "DestExten", "Exten", "Extension", "Hint", "Value" };
+ var charstring patched_txt := txt;
+ for (var integer i := 0; i < lengthof(fields); i := i +1) {
+ patched_txt := f_str_replace(patched_txt, fields[i] & ": \r\n", "");
+ }
/* "AppData" field sometimes has a value containing separator ": ", which makes
* TEXT dec not happy. Workaround it for now by removing the whole field line:
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36948?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ifc0e84a81b24d8ce8194b769a8ff9a0d4f3e85ff
Gerrit-Change-Number: 36948
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
