Attention is currently required from: neels.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36893?usp=email )
Change subject: 3-digit MNC: use osmo_plmn_id in struct umts_cell_id
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36893?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Id9a91c80cd2745424a916aef4736993bb7cd8ba0
Gerrit-Change-Number: 36893
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 06 Jun 2024 09:14:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: neels.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36892?usp=email )
Change subject: add umts_cell_id_test.c
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File tests/umts_cell_id/umts_cell_id_test.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36892/comment/0cd9c45e_57022486
PS4, Line 79: /* TODO? There is no bounds checking on RAC and SAC.
do you want to keep this?
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36892?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Ibbb61a2c53a11dea794f451d3074bc9ba50862fe
Gerrit-Change-Number: 36892
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 06 Jun 2024 09:10:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: neels.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36912?usp=email )
Change subject: use osmo_jhash for the hnb_persistent hashtable
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36912?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I5441db4293dc6b57a1c606ef830656fa9fa01943
Gerrit-Change-Number: 36912
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 06 Jun 2024 09:02:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37057?usp=email )
Change subject: jobs/{gerrit,master}: add osmo-s1gw
......................................................................
Patch Set 2:
(2 comments)
File jobs/gerrit-verifications.yml:
https://gerrit.osmocom.org/c/osmo-ci/+/37057/comment/9a2201a5_3d987c80
PS1, Line 210: - osmo-s1gw:
> Aren't you missing this here? […]
Good catch. The gerrit project actually didn't have the erlang/ prefix. But it is more consistent that way, all other erlang projects do have it. I've re-created the gerrit project with the prefix now and updated this patch.
File jobs/master-builds.yml:
https://gerrit.osmocom.org/c/osmo-ci/+/37057/comment/d8627f60_7cd8c2c7
PS1, Line 294: cmd: '{docker_run} {docker_img_erlang} {timeout_cmd} /build/contrib/jenkins.sh'
> same
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37057?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I6d17c920f12a5bb60bd026ca539b6b275bd8848f
Gerrit-Change-Number: 37057
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 06 Jun 2024 08:56:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ci/+/37057?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: jobs/{gerrit,master}: add osmo-s1gw
......................................................................
jobs/{gerrit,master}: add osmo-s1gw
Related: SYS#6772
Change-Id: I6d17c920f12a5bb60bd026ca539b6b275bd8848f
---
M jobs/gerrit-verifications.yml
M jobs/master-builds.yml
2 files changed, 20 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/57/37057/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37057?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I6d17c920f12a5bb60bd026ca539b6b275bd8848f
Gerrit-Change-Number: 37057
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newpatchset
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37105?usp=email )
Change subject: s1ap_proxy: add TODOs for PDUs also containing TLA
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37105?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I1d420481cf78c75c2b7a7a3df5ffb1af1ba9aaa0
Gerrit-Change-Number: 37105
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 06 Jun 2024 08:43:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
