June 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: s1gw: add TC_e_rab_setup

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37245?usp=email ) Change subject: s1gw: add TC_e_rab_setup ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37245?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I94eb8cac4b5659c0f6f1bb248a80692b8cf84b6f Gerrit-Change-Number: 37245 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 11:43:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

58 minutes

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: s1ap: add templates for E-RAB SETUP REQUEST/RESPONSE

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37244?usp=email ) Change subject: s1ap: add templates for E-RAB SETUP REQUEST/RESPONSE ...................................................................... s1ap: add templates for E-RAB SETUP REQUEST/RESPONSE Change-Id: I145e2068ba62cdff8f3075f97c274e248864a9f7 Related: SYS#6772 --- M library/s1ap/S1AP_Templates.ttcn 1 file changed, 167 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/s1ap/S1AP_Templates.ttcn b/library/s1ap/S1AP_Templates.ttcn index 26e1ae1..64167ec 100644 --- a/library/s1ap/S1AP_Templates.ttcn +++ b/library/s1ap/S1AP_Templates.ttcn @@ -971,4 +971,161 @@ tr_S1AP_Reset, tr_S1AP_ResetAck, tr_S1AP_ResetAck_any, tr_S1AP_MMEDirectInfTrans ); + +/* 9.1.3.1 E-RAB SETUP REQUEST */ +template (value) E_RABToBeSetupItemBearerSUReq +ts_S1AP_RABToBeSetupItemBearerSUReq(template (value) E_RAB_ID rab_id, + template (value) E_RABLevelQoSParameters qos_params, + template (value) TransportLayerAddress tla, + template (value) GTP_TEID gtp_teid, + template (value) NAS_PDU nas_pdu) := { + e_RAB_ID := rab_id, + e_RABlevelQoSParameters := qos_params, + transportLayerAddress := tla, + gTP_TEID := gtp_teid, + nAS_PDU := nas_pdu, + iE_Extensions := omit +} +template (value) E_RABToBeSetupListBearerSUReq +ts_S1AP_RABToBeSetupListBearerSUReq(template (value) E_RABToBeSetupItemBearerSUReq it) := { + { + id := S1AP_Constants.id_E_RABToBeSetupItemBearerSUReq, + criticality := reject, + value_ := { E_RABToBeSetupItemBearerSUReq := it } + } +} + +template (value) S1AP_PDU +ts_S1AP_RABSetupReq(template (value) MME_UE_S1AP_ID mme_id, + template (value) ENB_UE_S1AP_ID enb_id, + template (value) E_RABToBeSetupListBearerSUReq rab_setup_items) := { + initiatingMessage := { + procedureCode := S1AP_Constants.id_E_RABSetup, + criticality := reject, + value_ := { + E_RABSetupRequest := { + protocolIEs := { + { + id := S1AP_Constants.id_MME_UE_S1AP_ID, + criticality := reject, + value_ := { MME_UE_S1AP_ID := mme_id } + }, { + id := S1AP_Constants.id_eNB_UE_S1AP_ID, + criticality := reject, + value_ := { ENB_UE_S1AP_ID := enb_id } + }, { + id := S1AP_Constants.id_E_RABToBeSetupListBearerSUReq, + criticality := reject, + value_ := { E_RABToBeSetupListBearerSUReq := rab_setup_items } + } + } + } + } + } +} +template (present) S1AP_PDU +tr_S1AP_RABSetupReq(template (present) MME_UE_S1AP_ID mme_id := ?, + template (present) ENB_UE_S1AP_ID enb_id := ?, + template (present) E_RABToBeSetupListBearerSUReq rab_setup_items := ?) := { + initiatingMessage := { + procedureCode := S1AP_Constants.id_E_RABSetup, + criticality := reject, + value_ := { + E_RABSetupRequest := { + protocolIEs := { + { + id := S1AP_Constants.id_MME_UE_S1AP_ID, + criticality := reject, + value_ := { MME_UE_S1AP_ID := mme_id } + }, { + id := S1AP_Constants.id_eNB_UE_S1AP_ID, + criticality := reject, + value_ := { ENB_UE_S1AP_ID := enb_id } + }, { + id := S1AP_Constants.id_E_RABToBeSetupListBearerSUReq, + criticality := reject, + value_ := { E_RABToBeSetupListBearerSUReq := rab_setup_items } + }, * + } + } + } + } +} + +/* 9.1.3.2 E-RAB SETUP RESPONSE */ +template (value) E_RABSetupItemBearerSURes +ts_S1AP_RABSetupItemBearerSURes(template (value) E_RAB_ID rab_id, + template (value) TransportLayerAddress tla, + template (value) GTP_TEID gtp_teid) := { + e_RAB_ID := rab_id, + transportLayerAddress := tla, + gTP_TEID := gtp_teid, + iE_Extensions := omit +} +template (value) E_RABSetupListBearerSURes +ts_S1AP_RABSetupListBearerSURes(template (value) E_RABSetupItemBearerSURes it) := { + { + id := S1AP_Constants.id_E_RABSetupItemBearerSURes, + criticality := reject, + value_ := { E_RABSetupItemBearerSURes := it } + } +} + +template (value) S1AP_PDU +ts_S1AP_RABSetupRsp(template (value) MME_UE_S1AP_ID mme_id, + template (value) ENB_UE_S1AP_ID enb_id, + template (value) E_RABSetupListBearerSURes rab_setup_items) := { + successfulOutcome := { + procedureCode := S1AP_Constants.id_E_RABSetup, + criticality := reject, + value_ := { + e_RABSetupResponse := { + protocolIEs := { + { + id := S1AP_Constants.id_MME_UE_S1AP_ID, + criticality := reject, + value_ := { MME_UE_S1AP_ID := mme_id } + }, { + id := S1AP_Constants.id_eNB_UE_S1AP_ID, + criticality := reject, + value_ := { ENB_UE_S1AP_ID := enb_id } + }, { + id := S1AP_Constants.id_E_RABSetupListBearerSURes, + criticality := reject, + value_ := { e_RABSetupListBearerSURes := rab_setup_items } + } + } + } + } + } +} +template (present) S1AP_PDU +tr_S1AP_RABSetupRsp(template (present) MME_UE_S1AP_ID mme_id := ?, + template (present) ENB_UE_S1AP_ID enb_id := ?, + template (present) E_RABSetupListBearerSURes rab_setup_items := ?) := { + successfulOutcome := { + procedureCode := S1AP_Constants.id_E_RABSetup, + criticality := reject, + value_ := { + e_RABSetupResponse := { + protocolIEs := { + { + id := S1AP_Constants.id_MME_UE_S1AP_ID, + criticality := reject, + value_ := { MME_UE_S1AP_ID := mme_id } + }, { + id := S1AP_Constants.id_eNB_UE_S1AP_ID, + criticality := reject, + value_ := { ENB_UE_S1AP_ID := enb_id } + }, { + id := S1AP_Constants.id_E_RABSetupListBearerSURes, + criticality := reject, + value_ := { e_RABSetupListBearerSURes := rab_setup_items } + }, * + } + } + } + } +} + } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37244?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I145e2068ba62cdff8f3075f97c274e248864a9f7 Gerrit-Change-Number: 37244 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 hour, 27 minutes

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: rework module parameter naming, add mp_s1gw_mme_ip

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37246?usp=email ) Change subject: s1gw: rework module parameter naming, add mp_s1gw_mme_ip ...................................................................... s1gw: rework module parameter naming, add mp_s1gw_mme_ip Change-Id: Ice665662c8448c8314d5e6cc1e401e62b635872c Related: SYS#6772 --- M s1gw/S1GW_Tests.cfg M s1gw/S1GW_Tests.ttcn 2 files changed, 17 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve diff --git a/s1gw/S1GW_Tests.cfg b/s1gw/S1GW_Tests.cfg index 336be14..536f0ec 100644 --- a/s1gw/S1GW_Tests.cfg +++ b/s1gw/S1GW_Tests.cfg @@ -11,6 +11,9 @@ [TESTPORT_PARAMETERS] [MODULE_PARAMETERS] +S1GW_Tests.mp_s1gw_enb_ip := "127.0.1.1"; +S1GW_Tests.mp_s1gw_mme_ip := "127.0.2.1"; +S1GW_Tests.mp_mme_bind_ip := "127.0.2.10"; [MAIN_CONTROLLER] diff --git a/s1gw/S1GW_Tests.ttcn b/s1gw/S1GW_Tests.ttcn index df988d5..c7c55ef 100644 --- a/s1gw/S1GW_Tests.ttcn +++ b/s1gw/S1GW_Tests.ttcn @@ -32,8 +32,9 @@ import from S1AP_Server all; modulepar { - charstring mp_s1gw_ip := "127.0.1.1"; - charstring mp_mme_bind_ip := "127.0.2.10"; + charstring mp_s1gw_enb_ip; /* eNB facing address of the S1GW */ + charstring mp_s1gw_mme_ip; /* MME facing address of the S1GW */ + charstring mp_mme_bind_ip; /* MME address on which we get connections from S1GW */ } private type record of ConnHdlr ConnHdlrList; @@ -112,7 +113,7 @@ /* initiate SCTP connection establishment */ res := S1AP_CodecPort_CtrlFunct.f_IPL4_connect(S1AP_ENB, - mp_s1gw_ip, 36412, + mp_s1gw_enb_ip, 36412, "0.0.0.0", 0, -1, { sctp := c_SctpTuple_S1AP }); if (not ispresent(res.connId)) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37246?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ice665662c8448c8314d5e6cc1e401e62b635872c Gerrit-Change-Number: 37246 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 hour, 27 minutes

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: add and use f_ConnHdlr_expect_shutdown()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37242?usp=email ) Change subject: s1gw: add and use f_ConnHdlr_expect_shutdown() ...................................................................... s1gw: add and use f_ConnHdlr_expect_shutdown() Change-Id: I7e982f0268a6ee6059e9dfd5fbd6c9019c18359d Related: SYS#6772 --- M s1gw/S1GW_Tests.ttcn 1 file changed, 18 insertions(+), 6 deletions(-) Approvals: pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/s1gw/S1GW_Tests.ttcn b/s1gw/S1GW_Tests.ttcn index 30dcd46..ffc5c9b 100644 --- a/s1gw/S1GW_Tests.ttcn +++ b/s1gw/S1GW_Tests.ttcn @@ -143,6 +143,12 @@ log("eNB connection closed"); } +function f_ConnHdlr_expect_shutdown() runs on ConnHdlr { + S1AP_ENB.receive(tr_SctpShutDownEvent(g_s1ap_conn_id)); + S1AP_ENB.receive(tr_SctpAssocChange(SCTP_SHUTDOWN_COMP, g_s1ap_conn_id)); + S1AP_ENB.receive(PortEvent:{connClosed := ?}); +} + function f_ConnHdlr_setup(Global_ENB_ID genb_id) runs on ConnHdlr { var S1AP_PDU pdu; timer T; @@ -230,9 +236,7 @@ /* MME (S1AP_Server_CT) terminates connection */ f_ConnHdlr_close_conn(genb_id); /* expect our eNB connection to be released gracefully */ - S1AP_ENB.receive(tr_SctpShutDownEvent(g_s1ap_conn_id)); - S1AP_ENB.receive(tr_SctpAssocChange(SCTP_SHUTDOWN_COMP, g_s1ap_conn_id)); - S1AP_ENB.receive(PortEvent:{connClosed := ?}); + f_ConnHdlr_expect_shutdown(); f_ConnHdlr_unregister(genb_id); } @@ -253,9 +257,7 @@ /* establish an eNB connection to the S1GW */ f_ConnHdlr_connect(); /* expect our eNB connection to be released gracefully */ - S1AP_ENB.receive(tr_SctpShutDownEvent(g_s1ap_conn_id)); - S1AP_ENB.receive(tr_SctpAssocChange(SCTP_SHUTDOWN_COMP, g_s1ap_conn_id)); - S1AP_ENB.receive(PortEvent:{connClosed := ?}); + f_ConnHdlr_expect_shutdown(); setverdict(pass); } testcase TC_conn_term_mme_unavail() runs on test_CT { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37242?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7e982f0268a6ee6059e9dfd5fbd6c9019c18359d Gerrit-Change-Number: 37242 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 hour, 27 minutes

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: pass Global_ENB_ID to ConnHdlr

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37243?usp=email ) Change subject: s1gw: pass Global_ENB_ID to ConnHdlr ...................................................................... s1gw: pass Global_ENB_ID to ConnHdlr Change-Id: I9660ca96f13c4e4c890f3957a25d01a27e2e0cac Related: SYS#6772 --- M s1gw/S1GW_Tests.ttcn 1 file changed, 28 insertions(+), 17 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/s1gw/S1GW_Tests.ttcn b/s1gw/S1GW_Tests.ttcn index ffc5c9b..df988d5 100644 --- a/s1gw/S1GW_Tests.ttcn +++ b/s1gw/S1GW_Tests.ttcn @@ -79,10 +79,15 @@ vc_S1APSRV.start(S1AP_Server.main(cpars)); } -type union ConnHdlrPars { - integer seed +type record ConnHdlrPars { + Global_ENB_ID genb_id }; +template (value) ConnHdlrPars +t_ConnHdlrPars(integer enb_id := 0) := { + genb_id := ts_Global_ENB_ID(enb_id) +} + type function void_fn(ConnHdlrPars pars) runs on ConnHdlr; function f_ConnHdlr_spawn(void_fn fn, ConnHdlrPars pars) @@ -184,19 +189,17 @@ function f_TC_setup(ConnHdlrPars pars) runs on ConnHdlr { - var Global_ENB_ID genb_id := valueof(ts_Global_ENB_ID(pars.seed)); - - f_ConnHdlr_register(genb_id); + f_ConnHdlr_register(pars.genb_id); f_ConnHdlr_connect(); - f_ConnHdlr_setup(genb_id); + f_ConnHdlr_setup(pars.genb_id); f_sleep(0.5); /* keep the connection idle for some time */ f_ConnHdlr_disconnect(); - f_ConnHdlr_unregister(genb_id); + f_ConnHdlr_unregister(pars.genb_id); } testcase TC_setup() runs on test_CT { - var ConnHdlrPars pars := { seed := 0 }; + var ConnHdlrPars pars := valueof(t_ConnHdlrPars); var ConnHdlr vc_conn; f_init(); @@ -212,7 +215,7 @@ f_init_s1ap_srv(); for (var integer i := 0; i < 42; i := i + 1) { - var ConnHdlrPars pars := { seed := i }; + var ConnHdlrPars pars := valueof(t_ConnHdlrPars(i)); var ConnHdlr vc_conn := f_ConnHdlr_spawn(refers(f_TC_setup), pars); vc_conns := vc_conns & { vc_conn }; } @@ -225,23 +228,21 @@ /* MME terminates connection, expect S1GW to terminate the eNB connection */ function f_TC_conn_term_by_mme(ConnHdlrPars pars) runs on ConnHdlr { - var Global_ENB_ID genb_id := valueof(ts_Global_ENB_ID(pars.seed)); - - f_ConnHdlr_register(genb_id); + f_ConnHdlr_register(pars.genb_id); f_ConnHdlr_connect(); - f_ConnHdlr_setup(genb_id); + f_ConnHdlr_setup(pars.genb_id); f_sleep(0.5); /* keep the connection idle for some time */ /* MME (S1AP_Server_CT) terminates connection */ - f_ConnHdlr_close_conn(genb_id); + f_ConnHdlr_close_conn(pars.genb_id); /* expect our eNB connection to be released gracefully */ f_ConnHdlr_expect_shutdown(); - f_ConnHdlr_unregister(genb_id); + f_ConnHdlr_unregister(pars.genb_id); } testcase TC_conn_term_by_mme() runs on test_CT { - var ConnHdlrPars pars := { seed := 0 }; + var ConnHdlrPars pars := valueof(t_ConnHdlrPars); var ConnHdlr vc_conn; f_init(); @@ -261,7 +262,7 @@ setverdict(pass); } testcase TC_conn_term_mme_unavail() runs on test_CT { - var ConnHdlrPars pars := { seed := 0 }; + var ConnHdlrPars pars := valueof(t_ConnHdlrPars); var ConnHdlr vc_conn; f_init(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37243?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9660ca96f13c4e4c890f3957a25d01a27e2e0cac Gerrit-Change-Number: 37243 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 hour, 27 minutes

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: asterisk: Test initial IMS REGISTER timeout

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37194?usp=email ) Change subject: asterisk: Test initial IMS REGISTER timeout ...................................................................... asterisk: Test initial IMS REGISTER timeout Add several tests emulating response timeouts at several point in time during IMS REGISTER procedure. Related: SYS#6971 Change-Id: If59d43b2779dfbd14890a88d664077c194f843a1 --- M asterisk/Asterisk_Tests.ttcn M asterisk/IMS_ConnectionHandler.ttcn M asterisk/expected-results.xml 3 files changed, 143 insertions(+), 9 deletions(-) Approvals: Jenkins Builder: Verified jolly: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/asterisk/Asterisk_Tests.ttcn b/asterisk/Asterisk_Tests.ttcn index 7126118..30f04fd 100644 --- a/asterisk/Asterisk_Tests.ttcn +++ b/asterisk/Asterisk_Tests.ttcn @@ -48,6 +48,8 @@ charstring mp_ami_user := "test_user"; charstring mp_ami_secret := "1234"; charstring mp_volte_ims_outbound_registration := "volte_ims"; + /* Current default by pjproject (timeout_timer_val) to 32s, and not changed by Asterisk */ + integer mp_volte_ims_outbound_register_timeout := 32; } type component test_CT { @@ -386,7 +388,9 @@ f_ami_action_PJSIPRegister(AMI_CLIENT, mp_volte_ims_outbound_registration); } -private altstep as_AMI_IMS_register_Auth(IMS_ConnHdlrPars pars, boolean resync := false) runs on test_CT +private altstep as_AMI_IMS_register_Auth(IMS_ConnHdlrPars pars, + boolean resync := false, + boolean exp_ami_ev_registered := true) runs on test_CT { var charstring rand_str := oct2str(pars.subscr.auth.rand); var charstring autn_str := oct2str(pars.subscr.auth.autn); @@ -399,9 +403,11 @@ f_str_tolower(oct2str(pars.subscr.auth.ck)), f_str_tolower(oct2str(pars.subscr.auth.ik))); - AMI_CLIENT.receive(tr_AMI_Event_Registry(f_sip_SipAddr_to_str(pars.subscr.local_sip_record), - "sip:" & mp_ims_domain, - "Registered")); + if (exp_ami_ev_registered) { + AMI_CLIENT.receive(tr_AMI_Event_Registry(f_sip_SipAddr_to_str(pars.subscr.local_sip_record), + "sip:" & mp_ims_domain, + "Registered")); + } } [resync] AMI_CLIENT.receive(tr_AMI_Event_AuthRequest(mp_volte_ims_outbound_registration, rand := pattern @nocase rand_str, @@ -480,6 +486,79 @@ f_shutdown(); } +private function f_TC_ims_registration_timeout_IMS_ConnHdlr(IMS_register_early_return early_ret, boolean exp_auth_resync := false) runs on IMS_ConnHdlr { + f_create_sip_expect(valueof(ts_SipUrl_from_Addr_Union(g_pars.subscr.registrar_sip_record.addr))); + + as_IMS_register(exp_auth_resync := exp_auth_resync, early_ret := early_ret); + + timer Tout; + /* 1.0: Give some margin. */ + Tout.start(int2float(mp_volte_ims_outbound_register_timeout) + 1.0); + /* Make sure no new REGISTER is attempted unless directed by AMI: */ + alt { + [] as_SIP_fail_req("nothing"); + [] as_SIP_fail_resp("nothing"); + [] Tout.timeout { /* Done */ } + } + setverdict(pass); +} +/* Test initial REGISTER against IMS core timing out. */ +private function f_TC_ims_registration_timeout_initial_100Trying(charstring id) runs on IMS_ConnHdlr { + f_TC_ims_registration_timeout_IMS_ConnHdlr(IMS_REG_EARLY_RET_BEFORE_Initial_100Trying); +} +private function f_TC_ims_registration_timeout_initial_401Unauthorized(charstring id) runs on IMS_ConnHdlr { + f_TC_ims_registration_timeout_IMS_ConnHdlr(IMS_REG_EARLY_RET_BEFORE_Initial_401Unauthorized); +} +private function f_TC_ims_registration_timeout_resync_401Unauthorized(charstring id) runs on IMS_ConnHdlr { + f_TC_ims_registration_timeout_IMS_ConnHdlr(IMS_REG_EARLY_RET_BEFORE_Resync_401Unauthorized, exp_auth_resync := true); +} +private function f_TC_ims_registration_timeout_protected_100Trying(charstring id) runs on IMS_ConnHdlr { + f_TC_ims_registration_timeout_IMS_ConnHdlr(IMS_REG_EARLY_RET_BEFORE_Protected_100Trying); +} +private function f_TC_ims_registration_timeout_protected_200OK(charstring id) runs on IMS_ConnHdlr { + f_TC_ims_registration_timeout_IMS_ConnHdlr(IMS_REG_EARLY_RET_BEFORE_Protected_200OK); +} +private function f_TC_ims_registration_timeout_initial(ims_void_fn fn, + boolean answer_register := false, + boolean resync := false) runs on test_CT { + var IMS_ConnHdlrPars pars; + var IMS_ConnHdlr vc_conn; + f_init(); + pars := f_init_IMS_ConnHdlrPars(); + vc_conn := f_start_handler_IMS(fn, pars); + + f_AMI_IMS_start_register(pars); + + if (answer_register) { + as_AMI_IMS_register_Auth(pars, resync := resync, exp_ami_ev_registered := false); + } + + AMI_CLIENT.receive(tr_AMI_Event_Registry(f_sip_SipAddr_to_str(pars.subscr.local_sip_record), + "sip:" & mp_ims_domain, + "Rejected")); + + vc_conn.done; + f_shutdown(); +} +testcase TC_ims_registration_timeout_initial_100Trying() runs on test_CT { + f_TC_ims_registration_timeout_initial(refers(f_TC_ims_registration_timeout_initial_100Trying)); +} +testcase TC_ims_registration_timeout_initial_401Unauthorized() runs on test_CT { + f_TC_ims_registration_timeout_initial(refers(f_TC_ims_registration_timeout_initial_401Unauthorized)); +} +testcase TC_ims_registration_timeout_resync_401Unauthorized() runs on test_CT { + f_TC_ims_registration_timeout_initial(refers(f_TC_ims_registration_timeout_resync_401Unauthorized), + true, true); +} +testcase TC_ims_registration_timeout_protected_100Trying() runs on test_CT { + f_TC_ims_registration_timeout_initial(refers(f_TC_ims_registration_timeout_protected_100Trying), + true, false); +} +testcase TC_ims_registration_timeout_protected_200OK() runs on test_CT { + f_TC_ims_registration_timeout_initial(refers(f_TC_ims_registration_timeout_protected_200OK), + true, false); +} + /* Test SIP registration of local clients */ private function f_TC_ims_call_mo(charstring id) runs on IMS_ConnHdlr { f_create_sip_expect(valueof(ts_SipUrl_from_Addr_Union(g_pars.subscr.registrar_sip_record.addr))); @@ -619,6 +698,11 @@ execute( TC_internal_call_all_4registered() ); execute( TC_ims_registration() ); execute( TC_ims_registration_resync() ); + execute( TC_ims_registration_timeout_initial_100Trying() ); + execute( TC_ims_registration_timeout_initial_401Unauthorized() ); + execute( TC_ims_registration_timeout_resync_401Unauthorized() ); + execute( TC_ims_registration_timeout_protected_100Trying() ); + execute( TC_ims_registration_timeout_protected_200OK() ); execute( TC_ims_call_mo() ); execute( TC_ims_call_mt() ); } diff --git a/asterisk/IMS_ConnectionHandler.ttcn b/asterisk/IMS_ConnectionHandler.ttcn index 7b26980..d396268 100644 --- a/asterisk/IMS_ConnectionHandler.ttcn +++ b/asterisk/IMS_ConnectionHandler.ttcn @@ -208,7 +208,7 @@ charstring domain, charstring imsi, template (omit) IMS_CallPars cp := omit) := { - t_guard := 30.0, + t_guard := 60.0, realm := domain, local_sip_host := local_sip_host, local_sip_port := local_sip_port, @@ -237,7 +237,7 @@ fn.apply(id); } -private altstep as_SIP_fail_req(charstring exp_msg_str := "") runs on IMS_ConnHdlr +altstep as_SIP_fail_req(charstring exp_msg_str := "") runs on IMS_ConnHdlr { var PDU_SIP_Request sip_req; [] SIP.receive(PDU_SIP_Request:?) -> value sip_req { @@ -246,7 +246,7 @@ } } -private altstep as_SIP_fail_resp(charstring exp_msg_str := "") runs on IMS_ConnHdlr +altstep as_SIP_fail_resp(charstring exp_msg_str := "") runs on IMS_ConnHdlr { var PDU_SIP_Response sip_resp; [] SIP.receive(PDU_SIP_Response:?) -> value sip_resp { @@ -533,8 +533,18 @@ return valueof(wwwAuthenticate); } +type enumerated IMS_register_early_return { + IMS_REG_EARLY_RET_BEFORE_None, + IMS_REG_EARLY_RET_BEFORE_Initial_100Trying, + IMS_REG_EARLY_RET_BEFORE_Initial_401Unauthorized, + IMS_REG_EARLY_RET_BEFORE_Resync_401Unauthorized, + IMS_REG_EARLY_RET_BEFORE_Protected_100Trying, + IMS_REG_EARLY_RET_BEFORE_Protected_200OK +} + /* Peer is issuing 1st register, accept it: */ altstep as_IMS_register(boolean exp_auth_resync := false, + IMS_register_early_return early_ret := IMS_REG_EARLY_RET_BEFORE_None, boolean fail_others := true) runs on IMS_ConnHdlr { var template (present) PDU_SIP_Request exp_req := @@ -562,6 +572,10 @@ var template (value) Supported supported := ts_Supported({"sec-agree"}); var integer sip_seq_nr; + if (early_ret == IMS_REG_EARLY_RET_BEFORE_Initial_100Trying) { + return; /* Done */ + } + sip_call_id := g_rx_sip_req.msgHeader.callId.callid; via := g_rx_sip_req.msgHeader.via; via.viaBody[0].viaParams := f_sip_param_set(via.viaBody[0].viaParams, "rport", "1234"); /* TODO: set remote src port of the REGISTER */ @@ -595,6 +609,10 @@ f_ims_parse_register_contact(g_rx_sip_req.msgHeader.contact); f_ims_parse_security_client(g_rx_sip_req.msgHeader.security_client); + if (early_ret == IMS_REG_EARLY_RET_BEFORE_Initial_401Unauthorized) { + return; /* Done */ + } + if (not exp_auth_resync) { /* Delay ipsec setup in ip xfrm, since there will be another * 1st REGISTER with potentially new ports coming in later. */ @@ -636,6 +654,10 @@ authorization := authorization); SIP.receive(exp_req) -> value g_rx_sip_req; + if (early_ret == IMS_REG_EARLY_RET_BEFORE_Resync_401Unauthorized) { + return; /* Done */ + } + via := g_rx_sip_req.msgHeader.via; from_addr := g_rx_sip_req.msgHeader.fromField; to_addr := g_rx_sip_req.msgHeader.toField; @@ -680,7 +702,7 @@ } /* Now we should receive a new REGISTER over ipsec: */ - as_IMS_2nd_register(wwwAuthenticate); + as_IMS_2nd_register(wwwAuthenticate, early_ret := early_ret); } [fail_others] as_SIP_fail_resp(sip_expect_str); [fail_others] as_SIP_fail_req(sip_expect_str); @@ -688,7 +710,9 @@ } /* Peer is issuing 2nd register, accept it: */ -altstep as_IMS_2nd_register(WwwAuthenticate wwwAuthenticate, boolean fail_others := true) runs on IMS_ConnHdlr +altstep as_IMS_2nd_register(WwwAuthenticate wwwAuthenticate, + IMS_register_early_return early_ret := IMS_REG_EARLY_RET_BEFORE_None, + boolean fail_others := true) runs on IMS_ConnHdlr { var template (present) Authorization authorization := f_tr_Authorization_AKAv1MD5(wwwAuthenticate, @@ -713,6 +737,10 @@ var template (value) Supported supported := ts_Supported({"sec-agree"}); var integer sip_seq_nr; + if (early_ret == IMS_REG_EARLY_RET_BEFORE_Protected_100Trying) { + return; /* Done */ + } + sip_call_id := g_rx_sip_req.msgHeader.callId.callid; via := g_rx_sip_req.msgHeader.via; from_addr := g_rx_sip_req.msgHeader.fromField; @@ -737,6 +765,10 @@ /* Validate P-Access-Network-Info: */ f_ims_validate_register_P_Access_Network_info(g_rx_sip_req, exp_present := true); + if (early_ret == IMS_REG_EARLY_RET_BEFORE_Protected_200OK) { + return; /* Done */ + } + g_pars.subscr.p_associated_uri := valueof(ts_P_Associated_Uri({ ts_P_Assoc_uri_spec(ts_NameAddr(ts_SipUrl(ts_HostPort(g_pars.realm), ts_UserInfo(g_pars.subscr.msisdn), diff --git a/asterisk/expected-results.xml b/asterisk/expected-results.xml index 0c9cdd8..6b5def5 100644 --- a/asterisk/expected-results.xml +++ b/asterisk/expected-results.xml @@ -7,6 +7,11 @@ <testcase classname='Asterisk_Tests' name='TC_internal_call_all_4registered' time='MASKED'/> <testcase classname='Asterisk_Tests' name='TC_ims_registration' time='MASKED'/> <testcase classname='Asterisk_Tests' name='TC_ims_registration_resync' time='MASKED'/> + <testcase classname='Asterisk_Tests' name='TC_ims_registration_timeout_initial_100Trying' time='MASKED'/> + <testcase classname='Asterisk_Tests' name='TC_ims_registration_timeout_initial_401Unauthorized' time='MASKED'/> + <testcase classname='Asterisk_Tests' name='TC_ims_registration_timeout_resync_401Unauthorized' time='MASKED'/> + <testcase classname='Asterisk_Tests' name='TC_ims_registration_timeout_protected_100Trying' time='MASKED'/> + <testcase classname='Asterisk_Tests' name='TC_ims_registration_timeout_protected_200OK' time='MASKED'/> <testcase classname='Asterisk_Tests' name='TC_ims_call_mo' time='MASKED'/> <testcase classname='Asterisk_Tests' name='TC_ims_call_mt' time='MASKED'/> </testsuite> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37194?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If59d43b2779dfbd14890a88d664077c194f843a1 Gerrit-Change-Number: 37194 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 hour, 27 minutes

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: asterisk: Implement SIP UA unregister

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37193?usp=email ) Change subject: asterisk: Implement SIP UA unregister ...................................................................... asterisk: Implement SIP UA unregister Change-Id: I1ea6be662db00e52dbd39c4f54bb656dc4587ec7 --- M asterisk/Asterisk_Tests.ttcn M asterisk/SIP_ConnectionHandler.ttcn 2 files changed, 66 insertions(+), 6 deletions(-) Approvals: pespin: Looks good to me, approved neels: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/asterisk/Asterisk_Tests.ttcn b/asterisk/Asterisk_Tests.ttcn index bb1ed90..7126118 100644 --- a/asterisk/Asterisk_Tests.ttcn +++ b/asterisk/Asterisk_Tests.ttcn @@ -183,7 +183,9 @@ private function f_TC_internal_registration(charstring id) runs on SIPConnHdlr { f_SIP_register(); - // f_SIP_deregister(); + /* Trigger unregistration: */ + f_sleep(1.0); + f_SIP_unregister(); setverdict(pass); } testcase TC_internal_registration() runs on test_CT { @@ -209,6 +211,8 @@ COORD.receive(COORD_CMD_HANGUP); f_SIP_do_call_hangup(); + f_SIP_unregister(); + setverdict(pass); } private function f_TC_internal_call_mt(charstring id) runs on SIPConnHdlr { @@ -234,6 +238,8 @@ } as_SIP_exp_call_hangup(g_pars.cp.sip_seq_nr + 1); + f_SIP_unregister(); + setverdict(pass); } testcase TC_internal_call_momt() runs on test_CT { diff --git a/asterisk/SIP_ConnectionHandler.ttcn b/asterisk/SIP_ConnectionHandler.ttcn index 05f872f..892f5a3 100644 --- a/asterisk/SIP_ConnectionHandler.ttcn +++ b/asterisk/SIP_ConnectionHandler.ttcn @@ -61,6 +61,7 @@ SipUrl local_sip_url_ext, SipAddr local_sip_record, Contact local_contact, + Authorization authorization optional, CallPars cp optional } type record of SIPConnHdlrPars SIPConnHdlrParsList; @@ -147,6 +148,7 @@ ts_UserInfo(user))), omit) })), + authorization := omit, cp := cp } @@ -299,10 +301,11 @@ as_SIP_expect_resp(exp); /* Digest Auth: RFC 2617 */ - authorization := f_sip_digest_gen_Authorization_MD5(g_rx_sip_resp.msgHeader.wwwAuthenticate, - g_pars.user, g_pars.password, - "REGISTER", - f_sip_SipUrl_to_str(g_pars.registrar_sip_req_uri)) + g_pars.authorization := + f_sip_digest_gen_Authorization_MD5(g_rx_sip_resp.msgHeader.wwwAuthenticate, + g_pars.user, g_pars.password, + "REGISTER", + f_sip_SipUrl_to_str(g_pars.registrar_sip_req_uri)) /* New transaction: */ g_pars.registrar_sip_seq_nr := g_pars.registrar_sip_seq_nr + 1; @@ -320,7 +323,49 @@ g_pars.registrar_sip_seq_nr, g_pars.local_contact, ts_Expires("7200"), - authorization := authorization)); + authorization := g_pars.authorization)); + + /* Wait for OK answer */ + exp := tr_SIP_Response( + g_pars.registrar_sip_call_id, + from_addr, + to_addr_exp, + f_tr_Via_response(via), + *, + "REGISTER", 200, + g_pars.registrar_sip_seq_nr, "OK"); + as_SIP_expect_resp(exp); + + /* Prepare for next use: */ + g_pars.registrar_sip_seq_nr := g_pars.registrar_sip_seq_nr + 1; + return g_rx_sip_resp; +} + +function f_SIP_unregister() runs on SIPConnHdlr return PDU_SIP_Response +{ + var template (present) PDU_SIP_Response exp; + var Via via := g_pars.local_via; + var From from_addr := valueof(ts_From(g_pars.registrar_sip_record.addr, g_pars.registrar_sip_record.params)); + var To to_addr := valueof(ts_To(g_pars.registrar_sip_record.addr, g_pars.registrar_sip_record.params)); + var template (present) To to_addr_exp := tr_To(tr_Addr_Union_from_val(to_addr.addressField), *); + var charstring branch_value; + + branch_value := f_sip_gen_branch(f_sip_SipAddr_to_str(g_pars.registrar_sip_record), + f_sip_SipAddr_to_str(g_pars.registrar_sip_record), + g_pars.registrar_sip_call_id, + g_pars.registrar_sip_seq_nr); + + via.viaBody[0].viaParams := f_sip_param_set(via.viaBody[0].viaParams, "branch", branch_value); + from_addr.fromParams := f_sip_param_set(from_addr.fromParams, "tag", f_sip_rand_tag()); + SIP.send(ts_SIP_REGISTER(g_pars.registrar_sip_req_uri, + g_pars.registrar_sip_call_id, + from_addr, + to_addr, + via, + g_pars.registrar_sip_seq_nr, + g_pars.local_contact, + ts_Expires("0"), + authorization := g_pars.authorization)); /* Wait for OK answer */ exp := tr_SIP_Response( -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37193?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1ea6be662db00e52dbd39c4f54bb656dc4587ec7 Gerrit-Change-Number: 37193 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 hour, 27 minutes

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: asterisk: Test auth resync procedure

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37191?usp=email ) Change subject: asterisk: Test auth resync procedure ...................................................................... asterisk: Test auth resync procedure A new test is added to validate the procedure, plus all refactoring needed to accomodate for the new procedure. Related: SYS#6961 Change-Id: I2c654c270aa908859ec0bbb4d1da30d58de99be4 --- M asterisk/Asterisk_Tests.ttcn M asterisk/IMS_ConnectionHandler.ttcn M asterisk/expected-results.xml 3 files changed, 250 insertions(+), 90 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/asterisk/Asterisk_Tests.ttcn b/asterisk/Asterisk_Tests.ttcn index 75c51e1..bb1ed90 100644 --- a/asterisk/Asterisk_Tests.ttcn +++ b/asterisk/Asterisk_Tests.ttcn @@ -364,7 +364,7 @@ setverdict(pass); } -private function f_AMI_IMS_register(IMS_ConnHdlrPars pars) runs on test_CT +private function f_AMI_IMS_start_register(IMS_ConnHdlrPars pars) runs on test_CT { /* Give some time for IMS_ConnHdlr to register SIP expect. This could be done through IMS_COORD. */ f_sleep(1.0); @@ -378,22 +378,38 @@ /* Trigger registration: */ f_ami_action_PJSIPRegister(AMI_CLIENT, mp_volte_ims_outbound_registration); +} +private altstep as_AMI_IMS_register_Auth(IMS_ConnHdlrPars pars, boolean resync := false) runs on test_CT +{ var charstring rand_str := oct2str(pars.subscr.auth.rand); var charstring autn_str := oct2str(pars.subscr.auth.autn); - AMI_CLIENT.receive(tr_AMI_Event_AuthRequest(mp_volte_ims_outbound_registration, + [not resync] AMI_CLIENT.receive(tr_AMI_Event_AuthRequest(mp_volte_ims_outbound_registration, rand := pattern @nocase rand_str, - autn := pattern @nocase autn_str)); + autn := pattern @nocase autn_str)) { + f_ami_action_AuthResponse_RES(AMI_CLIENT, + mp_volte_ims_outbound_registration, + f_str_tolower(oct2str(pars.subscr.auth.res)), + f_str_tolower(oct2str(pars.subscr.auth.ck)), + f_str_tolower(oct2str(pars.subscr.auth.ik))); - f_ami_action_AuthResponse_RES(AMI_CLIENT, - mp_volte_ims_outbound_registration, - f_str_tolower(oct2str(pars.subscr.auth.res)), - f_str_tolower(oct2str(pars.subscr.auth.ck)), - f_str_tolower(oct2str(pars.subscr.auth.ik))); + AMI_CLIENT.receive(tr_AMI_Event_Registry(f_sip_SipAddr_to_str(pars.subscr.local_sip_record), + "sip:" & mp_ims_domain, + "Registered")); + } + [resync] AMI_CLIENT.receive(tr_AMI_Event_AuthRequest(mp_volte_ims_outbound_registration, + rand := pattern @nocase rand_str, + autn := pattern @nocase autn_str)) { + f_ami_action_AuthResponse_AUTS(AMI_CLIENT, + mp_volte_ims_outbound_registration, + f_str_tolower(oct2str(pars.subscr.auth.auts))); + } +} - AMI_CLIENT.receive(tr_AMI_Event_Registry(f_sip_SipAddr_to_str(pars.subscr.local_sip_record), - "sip:" & mp_ims_domain, - "Registered")); +private function f_AMI_IMS_register(IMS_ConnHdlrPars pars, boolean resync := false) runs on test_CT +{ + f_AMI_IMS_start_register(pars); + as_AMI_IMS_register_Auth(pars, resync := resync); } private function f_AMI_IMS_unregister(IMS_ConnHdlrPars pars) runs on test_CT @@ -404,7 +420,7 @@ "Unregistered")); } -/* Test SIP registration of local clients */ +/* Test IMS registration of VoLTE UE */ private function f_TC_ims_registration(charstring id) runs on IMS_ConnHdlr { f_create_sip_expect(valueof(ts_SipUrl_from_Addr_Union(g_pars.subscr.registrar_sip_record.addr))); as_IMS_register(); @@ -430,6 +446,34 @@ f_shutdown(); } +/* Test IMS registration of VoLTE UE. ISIM Resync case. */ +private function f_TC_ims_registration_resync(charstring id) runs on IMS_ConnHdlr { + f_create_sip_expect(valueof(ts_SipUrl_from_Addr_Union(g_pars.subscr.registrar_sip_record.addr))); + as_IMS_register(exp_auth_resync := true); + as_IMS_unregister(); + setverdict(pass); +} +testcase TC_ims_registration_resync() runs on test_CT { + var IMS_ConnHdlrPars pars; + var IMS_ConnHdlr vc_conn; + f_init(); + pars := f_init_IMS_ConnHdlrPars(); + vc_conn := f_start_handler_IMS(refers(f_TC_ims_registration_resync), pars); + + /* Emulate first Auth sync failure: */ + f_AMI_IMS_register(pars, resync := true); + /* Second auth goes well: */ + as_AMI_IMS_register_Auth(pars, resync := false); + /* Stay registered for one second */ + f_sleep(1.0); + + /* Trigger unregistration: */ + f_AMI_IMS_unregister(pars); + + vc_conn.done; + f_shutdown(); +} + /* Test SIP registration of local clients */ private function f_TC_ims_call_mo(charstring id) runs on IMS_ConnHdlr { f_create_sip_expect(valueof(ts_SipUrl_from_Addr_Union(g_pars.subscr.registrar_sip_record.addr))); @@ -568,6 +612,7 @@ execute( TC_internal_call_all_3registered() ); execute( TC_internal_call_all_4registered() ); execute( TC_ims_registration() ); + execute( TC_ims_registration_resync() ); execute( TC_ims_call_mo() ); execute( TC_ims_call_mt() ); } diff --git a/asterisk/IMS_ConnectionHandler.ttcn b/asterisk/IMS_ConnectionHandler.ttcn index 9f7d0f1..7b26980 100644 --- a/asterisk/IMS_ConnectionHandler.ttcn +++ b/asterisk/IMS_ConnectionHandler.ttcn @@ -65,7 +65,8 @@ OCT16 autn, OCT8 res, OCT16 ck, - OCT16 ik + OCT16 ik, + OCT14 auts } type record IMS_ConnHdlrSubscrPars { @@ -104,6 +105,7 @@ uint16_t local_sip_port, SipUrl registrar_sip_req_uri, Via local_via, + Server server_name, IMS_ConnHdlrSubscrPars subscr optional } type record of IMS_ConnHdlrPars IMS_ConnHdlrParsList; @@ -175,7 +177,10 @@ autn := 'd42e61db5f15800067393a5b7691a227'O, res := '6f2556bbe4366ab1'O, ck := '0b389d08c833991734936bec55cac800'O, - ik := '17141862125bd30c81c4224391a0909a'O + ik := '17141862125bd30c81c4224391a0909a'O, + /* NOTE: AUTS value randomly crafted. It's fine since it's just forwarded + * AMI -> asterisk -> IMS and we blindly match and accept it. */ + auts := 'd42e61db5f15800067393a5b7691'O }, ipsec_auth_key := "0x17141862125bd30c81c4224391a0909a00000000", ipsec_local_spi_c := 4142, @@ -209,6 +214,7 @@ local_sip_port := local_sip_port, registrar_sip_req_uri := valueof(ts_SipUrlHost(domain)), local_via := ts_Via_from(ts_HostPort(local_sip_host, local_sip_port)), + server_name := valueof(ts_Server({c_sip_server_name})), subscr := t_IMS_SubscrPars(local_sip_host, local_sip_port, domain := domain, imsi := imsi, cp := cp) } @@ -393,6 +399,18 @@ "local_spi_c=", g_pars.subscr.ipsec_local_spi_c, " local_spi_s=", g_pars.subscr.ipsec_local_spi_s); } +private function f_ims_parse_register_contact(Contact contact) runs on IMS_ConnHdlr +{ + var HostPort hp := valueof(contact.contactBody.contactAddresses[0].addressField.nameAddr.addrSpec.hostPort); + + g_pars.subscr.remote_sip_host := hp.host; + if (ispresent(hp.portField)) { + g_pars.subscr.remote_sip_port := hp.portField; + } else { + g_pars.subscr.remote_sip_port := 5060; + } +} + private function f_IMS_exec_sync(charstring cmdline, template (present) integer rc := 0) runs on IMS_ConnHdlr return ASP_PResult { var ASP_PResult res; @@ -480,8 +498,44 @@ return sdp; } +private function f_gen_Security_server() runs on IMS_ConnHdlr return Security_server { + var template (value) Security_server security_server; + /* Security-Server: ipsec-3gpp;q=0.1;prot=esp;mod=trans;spi-c=4096;spi-s=4097;port-c=5104;port-s=6104;alg=hmac-sha-1-96;ealg=null */ + var template (value) SemicolonParam_List sec_params := { + ts_Param("q", "0.1"), + ts_Param("prot", "esp"), + ts_Param("mod", "trans"), + ts_Param("spi-c", int2str(g_pars.subscr.ipsec_local_spi_c)), + ts_Param("spi-s", int2str(g_pars.subscr.ipsec_local_spi_s)), + ts_Param("port-c", int2str(g_pars.local_sip_port)), + ts_Param("port-s", int2str(g_pars.local_sip_port)), + ts_Param("alg", "hmac-sha-1-96"), + ts_Param("ealg", "null") + }; + security_server := ts_Security_server({ + ts_Security_mechanism("ipsec-3gpp", sec_params) + }); + return valueof(security_server); +} + +private function f_gen_WwwAuthenticate() runs on IMS_ConnHdlr return WwwAuthenticate { + var template (value) WwwAuthenticate wwwAuthenticate; + var template (value) CommaParam_List digestCln; + digestCln := { + ts_Param("realm", f_sip_str_quote(g_pars.realm)), + ts_Param("qop", f_sip_str_quote("auth")), + ts_Param("algorithm", "AKAv1-MD5"), + ts_Param("nonce", f_sip_str_quote(f_nonce_from_rand_autn(g_pars.subscr.auth.rand, + g_pars.subscr.auth.autn))) + /* "opaque not needed in IMS "*/ + }; + wwwAuthenticate := ts_WwwAuthenticate( { ts_Challenge_digestCln(digestCln) } ); + return valueof(wwwAuthenticate); +} + /* Peer is issuing 1st register, accept it: */ -altstep as_IMS_register(boolean fail_others := true) runs on IMS_ConnHdlr +altstep as_IMS_register(boolean exp_auth_resync := false, + boolean fail_others := true) runs on IMS_ConnHdlr { var template (present) PDU_SIP_Request exp_req := tr_SIP_REGISTER(g_pars.registrar_sip_req_uri, @@ -500,18 +554,13 @@ var template (value) PDU_SIP_Response tx_resp; var Via via; var CallidString sip_call_id; - var Contact contact; var template (value) From from_addr; var template (value) To to_addr; - var template (value) CommaParam_List digestCln ; - var template (value) WwwAuthenticate wwwAuthenticate; - var template (value) Security_server security_server; - var template (value) Server server_name := ts_Server({c_sip_server_name}); + var WwwAuthenticate wwwAuthenticate; + var Security_server security_server; var template (value) Require require := ts_Require({"sec-agree"}); var template (value) Supported supported := ts_Supported({"sec-agree"}); - var template (present) Authorization authorization; var integer sip_seq_nr; - var charstring tx_sdp; sip_call_id := g_rx_sip_req.msgHeader.callId.callid; via := g_rx_sip_req.msgHeader.via; @@ -520,9 +569,17 @@ to_addr := g_rx_sip_req.msgHeader.toField; sip_seq_nr := g_rx_sip_req.msgHeader.cSeq.seqNumber; - contact := g_rx_sip_req.msgHeader.contact; - f_ims_validate_register_contact(contact); - g_pars.subscr.registered_contact := contact; + /* Tx 100 Tyring */ + tx_resp := ts_SIP_Response_Trying(sip_call_id, + from_addr, + to_addr, + via, + sip_seq_nr, + "REGISTER", + allow := omit, + server := g_pars.server_name, + userAgent := omit); + SIP.send(tx_resp); /* Validate P-Access-Network-Info: rfc7315 6.4: * "3GPP will use the P-Access-Network-Info header field to @@ -534,55 +591,19 @@ */ f_ims_validate_register_P_Access_Network_info(g_rx_sip_req, exp_present := false); - /* Tx 100 Tyring */ - tx_resp := ts_SIP_Response_Trying(sip_call_id, - from_addr, - to_addr, - via, - sip_seq_nr, - "REGISTER", - allow := omit, - server := server_name, - userAgent := omit); - SIP.send(tx_resp); - - var HostPort hp := valueof(contact.contactBody.contactAddresses[0].addressField.nameAddr.addrSpec.hostPort); - g_pars.subscr.remote_sip_host := hp.host; - if (ispresent(hp.portField)) { - g_pars.subscr.remote_sip_port := hp.portField; - } else { - g_pars.subscr.remote_sip_port := 5060; - } + f_ims_validate_register_contact(g_rx_sip_req.msgHeader.contact); + f_ims_parse_register_contact(g_rx_sip_req.msgHeader.contact); f_ims_parse_security_client(g_rx_sip_req.msgHeader.security_client); - f_ims_setup_ipsec(); + + if (not exp_auth_resync) { + /* Delay ipsec setup in ip xfrm, since there will be another + * 1st REGISTER with potentially new ports coming in later. */ + f_ims_setup_ipsec(); + } to_addr.toParams := f_sip_param_set(to_addr.toParams, "tag", f_sip_rand_tag()); - - digestCln := { - ts_Param("realm", f_sip_str_quote(g_pars.realm)), - ts_Param("qop", f_sip_str_quote("auth")), - ts_Param("algorithm", "AKAv1-MD5"), - ts_Param("nonce", f_sip_str_quote(f_nonce_from_rand_autn(g_pars.subscr.auth.rand, - g_pars.subscr.auth.autn))) - /* "opaque not needed in IMS "*/ - }; - wwwAuthenticate := ts_WwwAuthenticate( { ts_Challenge_digestCln(digestCln) } ) - - /* Security-Server: ipsec-3gpp;q=0.1;prot=esp;mod=trans;spi-c=4096;spi-s=4097;port-c=5104;port-s=6104;alg=hmac-sha-1-96;ealg=null */ - var template (value) SemicolonParam_List sec_params := { - ts_Param("q", "0.1"), - ts_Param("prot", "esp"), - ts_Param("mod", "trans"), - ts_Param("spi-c", int2str(g_pars.subscr.ipsec_local_spi_c)), - ts_Param("spi-s", int2str(g_pars.subscr.ipsec_local_spi_s)), - ts_Param("port-c", int2str(g_pars.local_sip_port)), - ts_Param("port-s", int2str(g_pars.local_sip_port)), - ts_Param("alg", "hmac-sha-1-96"), - ts_Param("ealg", "null") - }; - security_server := ts_Security_server({ - ts_Security_mechanism("ipsec-3gpp", sec_params) - }); + wwwAuthenticate := f_gen_WwwAuthenticate(); + security_server := f_gen_Security_server(); /* Tx 401 Unauthorized */ tx_resp := ts_SIP_Response_Unauthorized(sip_call_id, @@ -594,23 +615,103 @@ "REGISTER", p_associated_uri := g_pars.subscr.p_associated_uri, security_server := security_server, - server := server_name, + server := g_pars.server_name, supported := supported, userAgent := omit); SIP.send(tx_resp); + if (exp_auth_resync) { + /* Now we should receive a new non-protected REGISTER + * with Authoritzation containing auts in base64: */ + var template (present) Authorization authorization := + f_tr_Authorization_AKAv1MD5(wwwAuthenticate, + g_pars.subscr.imsi & "@" & g_pars.realm, + f_sip_SipUrl_to_str(g_pars.registrar_sip_req_uri)); + exp_req := + tr_SIP_REGISTER(g_pars.registrar_sip_req_uri, + ?, + tr_From(), + tr_To(), + tr_Via_from(f_tr_HostPort(via.viaBody[0].sentBy.host, via.viaBody[0].sentBy.portField)), + authorization := authorization); + SIP.receive(exp_req) -> value g_rx_sip_req; + + via := g_rx_sip_req.msgHeader.via; + from_addr := g_rx_sip_req.msgHeader.fromField; + to_addr := g_rx_sip_req.msgHeader.toField; + sip_seq_nr := g_rx_sip_req.msgHeader.cSeq.seqNumber; + + /* Tx 100 Tyring */ + tx_resp := ts_SIP_Response_Trying(sip_call_id, + from_addr, + to_addr, + via, + sip_seq_nr, + "REGISTER", + allow := omit, + server := g_pars.server_name, + userAgent := omit); + SIP.send(tx_resp); + + f_sip_param_match_value_or_fail(g_rx_sip_req.msgHeader.authorization.body.digestResponse, + "auts", f_sip_str_quote(enc_MIME_Base64(g_pars.subscr.auth.auts))); + f_ims_validate_register_P_Access_Network_info(g_rx_sip_req, exp_present := false); + f_ims_validate_register_contact(g_rx_sip_req.msgHeader.contact); + f_ims_parse_register_contact(g_rx_sip_req.msgHeader.contact); + f_ims_parse_security_client(g_rx_sip_req.msgHeader.security_client); + f_ims_setup_ipsec(); + + security_server := f_gen_Security_server(); + + /* Tx again 401 Unauthorized, this time our AMI interface will accept it: */ + tx_resp := ts_SIP_Response_Unauthorized(sip_call_id, + from_addr, + to_addr, + via, + wwwAuthenticate, + sip_seq_nr, + "REGISTER", + p_associated_uri := g_pars.subscr.p_associated_uri, + security_server := security_server, + server := g_pars.server_name, + supported := supported, + userAgent := omit); + SIP.send(tx_resp); + } + /* Now we should receive a new REGISTER over ipsec: */ - authorization := f_tr_Authorization_AKAv1MD5(valueof(wwwAuthenticate), - g_pars.subscr.imsi & "@" & g_pars.realm, - f_sip_SipUrl_to_str(g_pars.registrar_sip_req_uri)); - exp_req := + as_IMS_2nd_register(wwwAuthenticate); + } + [fail_others] as_SIP_fail_resp(sip_expect_str); + [fail_others] as_SIP_fail_req(sip_expect_str); + +} + +/* Peer is issuing 2nd register, accept it: */ +altstep as_IMS_2nd_register(WwwAuthenticate wwwAuthenticate, boolean fail_others := true) runs on IMS_ConnHdlr +{ + var template (present) Authorization authorization := + f_tr_Authorization_AKAv1MD5(wwwAuthenticate, + g_pars.subscr.imsi & "@" & g_pars.realm, + f_sip_SipUrl_to_str(g_pars.registrar_sip_req_uri)); + var template (present) PDU_SIP_Request exp_req := tr_SIP_REGISTER(g_pars.registrar_sip_req_uri, ?, tr_From(), tr_To(), tr_Via_from(f_tr_HostPort(g_pars.subscr.remote_sip_host, g_pars.subscr.ipsec_remote_port_s)), authorization := authorization); - SIP.receive(exp_req) -> value g_rx_sip_req; + var charstring sip_expect_str := log2str(exp_req); + + [] SIP.receive(exp_req) -> value g_rx_sip_req { + var template (value) PDU_SIP_Response tx_resp; + var Via via; + var CallidString sip_call_id; + var template (value) From from_addr; + var template (value) To to_addr; + var template (value) Require require := ts_Require({"sec-agree"}); + var template (value) Supported supported := ts_Supported({"sec-agree"}); + var integer sip_seq_nr; sip_call_id := g_rx_sip_req.msgHeader.callId.callid; via := g_rx_sip_req.msgHeader.via; @@ -626,7 +727,7 @@ sip_seq_nr, "REGISTER", allow := omit, - server := server_name, + server := g_pars.server_name, userAgent := omit); SIP.send(tx_resp); @@ -645,6 +746,9 @@ scheme := "tel"))), ts_P_Assoc_uri_spec(g_rx_sip_req.msgHeader.toField.addressField.nameAddr) })); + f_ims_validate_register_contact(g_rx_sip_req.msgHeader.contact); + f_ims_parse_register_contact(g_rx_sip_req.msgHeader.contact); + g_pars.subscr.registered_contact := g_rx_sip_req.msgHeader.contact; /* Tx 200 OK */ to_addr.toParams := f_sip_param_set(to_addr.toParams, "tag", f_sip_rand_tag()); @@ -657,14 +761,13 @@ via, p_associated_uri := g_pars.subscr.p_associated_uri, require := require, - server := server_name, + server := g_pars.server_name, supported := supported, userAgent := omit); SIP.send(tx_resp); } [fail_others] as_SIP_fail_resp(sip_expect_str); [fail_others] as_SIP_fail_req(sip_expect_str); - } /* Peer wants to unregister, accept it: */ @@ -693,12 +796,10 @@ var template (value) CommaParam_List digestCln ; var template (value) WwwAuthenticate wwwAuthenticate; var template (value) Security_server security_server; - var template (value) Server server_name := ts_Server({c_sip_server_name}); var template (value) Require require := ts_Require({"sec-agree"}); var template (value) Supported supported := ts_Supported({"sec-agree"}); var template (present) Authorization authorization; var integer sip_seq_nr; - var charstring tx_sdp; sip_call_id := g_rx_sip_req.msgHeader.callId.callid; via := g_rx_sip_req.msgHeader.via; @@ -727,7 +828,7 @@ sip_seq_nr, "REGISTER", allow := omit, - server := server_name, + server := g_pars.server_name, userAgent := omit); SIP.send(tx_resp); @@ -748,7 +849,7 @@ contact := contact, p_associated_uri := g_pars.subscr.p_associated_uri, require := require, - server := server_name, + server := g_pars.server_name, supported := supported, userAgent := omit); SIP.send(tx_resp); diff --git a/asterisk/expected-results.xml b/asterisk/expected-results.xml index 44d6c01..0c9cdd8 100644 --- a/asterisk/expected-results.xml +++ b/asterisk/expected-results.xml @@ -2,10 +2,11 @@ <testsuite name='Titan' tests='9' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='Asterisk_Tests' name='TC_internal_registration' time='MASKED'/> <testcase classname='Asterisk_Tests' name='TC_internal_call_momt' time='MASKED'/> - <testcase classname='Asterisk_Tests' name='TC_internal_call_all_2registered' time='MASKED'/> - <testcase classname='Asterisk_Tests' name='TC_internal_call_all_3registered' time='MASKED'/> - <testcase classname='Asterisk_Tests' name='TC_internal_call_all_4registered' time='MASKED'/> - <testcase classname='Asterisk_Tests' name='TC_ims_registration' time='MASKED'/> - <testcase classname='Asterisk_Tests' name='TC_ims_call_mo' time='MASKED'/> - <testcase classname='Asterisk_Tests' name='TC_ims_call_mt' time='MASKED'/> + <testcase classname='Asterisk_Tests' name='TC_internal_call_all_2registered' time='MASKED'/> + <testcase classname='Asterisk_Tests' name='TC_internal_call_all_3registered' time='MASKED'/> + <testcase classname='Asterisk_Tests' name='TC_internal_call_all_4registered' time='MASKED'/> + <testcase classname='Asterisk_Tests' name='TC_ims_registration' time='MASKED'/> + <testcase classname='Asterisk_Tests' name='TC_ims_registration_resync' time='MASKED'/> + <testcase classname='Asterisk_Tests' name='TC_ims_call_mo' time='MASKED'/> + <testcase classname='Asterisk_Tests' name='TC_ims_call_mt' time='MASKED'/> </testsuite> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37191?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2c654c270aa908859ec0bbb4d1da30d58de99be4 Gerrit-Change-Number: 37191 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 hour, 27 minutes

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: asterisk: Test initial IMS REGISTER timeout

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37194?usp=email ) Change subject: asterisk: Test initial IMS REGISTER timeout ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37194?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If59d43b2779dfbd14890a88d664077c194f843a1 Gerrit-Change-Number: 37194 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 11:14:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 hour, 27 minutes

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: asterisk: Implement SIP UA unregister

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37193?usp=email ) Change subject: asterisk: Implement SIP UA unregister ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37193?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1ea6be662db00e52dbd39c4f54bb656dc4587ec7 Gerrit-Change-Number: 37193 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 11:14:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 hour, 27 minutes

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: asterisk: Test auth resync procedure

by pespin

Attention is currently required from: laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37191?usp=email ) Change subject: asterisk: Test auth resync procedure ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37191?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2c654c270aa908859ec0bbb4d1da30d58de99be4 Gerrit-Change-Number: 37191 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 18 Jun 2024 11:14:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 hour, 27 minutes

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: pass Global_ENB_ID to ConnHdlr

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37243?usp=email ) Change subject: s1gw: pass Global_ENB_ID to ConnHdlr ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37243?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9660ca96f13c4e4c890f3957a25d01a27e2e0cac Gerrit-Change-Number: 37243 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 11:14:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 hour, 27 minutes

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: s1gw: add TC_e_rab_setup

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37245?usp=email ) Change subject: s1gw: add TC_e_rab_setup ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37245?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I94eb8cac4b5659c0f6f1bb248a80692b8cf84b6f Gerrit-Change-Number: 37245 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 11:13:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 hour, 28 minutes

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: s1ap: add templates for E-RAB SETUP REQUEST/RESPONSE

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37244?usp=email ) Change subject: s1ap: add templates for E-RAB SETUP REQUEST/RESPONSE ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37244?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I145e2068ba62cdff8f3075f97c274e248864a9f7 Gerrit-Change-Number: 37244 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 11:12:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 hour, 30 minutes

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: rework module parameter naming, add mp_s1gw_mme_ip

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37246?usp=email ) Change subject: s1gw: rework module parameter naming, add mp_s1gw_mme_ip ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37246?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ice665662c8448c8314d5e6cc1e401e62b635872c Gerrit-Change-Number: 37246 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 11:11:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 hour, 31 minutes

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: pass Global_ENB_ID to ConnHdlr

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37243?usp=email ) Change subject: s1gw: pass Global_ENB_ID to ConnHdlr ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37243?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9660ca96f13c4e4c890f3957a25d01a27e2e0cac Gerrit-Change-Number: 37243 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 11:10:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 hour, 32 minutes

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: add and use f_ConnHdlr_expect_shutdown()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37242?usp=email ) Change subject: s1gw: add and use f_ConnHdlr_expect_shutdown() ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37242?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7e982f0268a6ee6059e9dfd5fbd6c9019c18359d Gerrit-Change-Number: 37242 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 11:08:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 hour, 33 minutes

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-s1gw-test: align with the moduleparam naming changes

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37247?usp=email ) Change subject: ttcn3-s1gw-test: align with the moduleparam naming changes ...................................................................... Patch Set 1: (1 comment) File ttcn3-s1gw-test/S1GW_Tests.cfg: https://gerrit.osmocom.org/c/docker-playground/+/37247/comment/498bf2e4_c3d… PS1, Line 11: S1GW_Tests.mp_s1gw_mme_ip := "172.18.10.001"; why adding those extra leading zeroes? feels confusing tbh, I never saw that in an IP address representation. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37247?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I37b7d91e9e18df463f54cac3e5586942aea21a69 Gerrit-Change-Number: 37247 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 11:06:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 hour, 35 minutes

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: asterisk: test Precondition extension in IMS MO call

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37248?usp=email ) Change subject: asterisk: test Precondition extension in IMS MO call ...................................................................... asterisk: test Precondition extension in IMS MO call Related: SYS#6969 Change-Id: I1e26f3bb9e54be5b5e15a003b2000ae3e88b9027 --- M asterisk/Asterisk_Tests.ttcn M asterisk/IMS_ConnectionHandler.ttcn M asterisk/expected-results.xml M library/SIP_Templates.ttcn 4 files changed, 164 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/48/37248/1 diff --git a/asterisk/Asterisk_Tests.ttcn b/asterisk/Asterisk_Tests.ttcn index 30f04fd..cfa7ca2 100644 --- a/asterisk/Asterisk_Tests.ttcn +++ b/asterisk/Asterisk_Tests.ttcn @@ -48,7 +48,7 @@ charstring mp_ami_user := "test_user"; charstring mp_ami_secret := "1234"; charstring mp_volte_ims_outbound_registration := "volte_ims"; - /* Current default by pjproject (timeout_timer_val) to 32s, and not changed by Asterisk */ + /* Current default by pjproject (timeout_timer_val) is set to 32s, and not changed by Asterisk */ integer mp_volte_ims_outbound_register_timeout := 32; } @@ -559,8 +559,8 @@ true, false); } -/* Test SIP registration of local clients */ -private function f_TC_ims_call_mo(charstring id) runs on IMS_ConnHdlr { +/* Test IMS MO call emulating an MT which doesn't support precondition */ +private function f_TC_ims_call_mo_IMS_ConnHdlr(charstring id) runs on IMS_ConnHdlr { f_create_sip_expect(valueof(ts_SipUrl_from_Addr_Union(g_pars.subscr.registrar_sip_record.addr))); if (ispresent(g_pars.subscr.cp.called)) { f_create_sip_expect(valueof(ts_SipUrl_from_Addr_Union(g_pars.subscr.cp.called.addr))); @@ -574,7 +574,7 @@ setverdict(pass); as_IMS_unregister(); } -testcase TC_ims_call_mo() runs on test_CT { +private function f_TC_ims_call_mo(boolean use_precondition_ext) runs on test_CT { var SIPConnHdlrPars sip_pars; var IMS_ConnHdlrPars ims_pars; var SIPConnHdlr vc_conn_sip; @@ -593,8 +593,10 @@ ts_UserInfo(ims_pars.subscr.msisdn))); ims_pars.subscr.cp.called := valueof(ts_SipAddr(ts_HostPort(ims_pars.realm), ts_UserInfo(c_ext_msisdn))); + ims_pars.subscr.cp.support_precondition_ext := use_precondition_ext; + ims_pars.subscr.cp.require_precondition_ext := use_precondition_ext; - vc_conn_ims := f_start_handler_IMS(refers(f_TC_ims_call_mo), ims_pars); + vc_conn_ims := f_start_handler_IMS(refers(f_TC_ims_call_mo_IMS_ConnHdlr), ims_pars); vc_conn_sip := f_start_handler(refers(f_TC_internal_call_mo), sip_pars); COORD.receive(COORD_CMD_REGISTERED) from vc_conn_sip; @@ -621,6 +623,12 @@ vc_conn_ims.done; f_shutdown(); } +testcase TC_ims_call_mo() runs on test_CT { + f_TC_ims_call_mo(true); +} +testcase TC_ims_call_mo_noprecondition() runs on test_CT { + f_TC_ims_call_mo(false); +} /* Test SIP registration of local clients */ private function f_TC_ims_call_mt(charstring id) runs on IMS_ConnHdlr { @@ -704,6 +712,7 @@ execute( TC_ims_registration_timeout_protected_100Trying() ); execute( TC_ims_registration_timeout_protected_200OK() ); execute( TC_ims_call_mo() ); + execute( TC_ims_call_mo_noprecondition() ); execute( TC_ims_call_mt() ); } diff --git a/asterisk/IMS_ConnectionHandler.ttcn b/asterisk/IMS_ConnectionHandler.ttcn index d396268..d4bb03f 100644 --- a/asterisk/IMS_ConnectionHandler.ttcn +++ b/asterisk/IMS_ConnectionHandler.ttcn @@ -135,6 +135,8 @@ charstring local_rtp_addr, uint16_t local_rtp_port, + boolean support_precondition_ext, + boolean require_precondition_ext, SDP_Message peer_sdp optional, IMS_CallParsMT mt } @@ -152,6 +154,8 @@ sip_body := omit, local_rtp_addr := local_rtp_addr, local_rtp_port := local_rtp_port, + support_precondition_ext := true, + require_precondition_ext := false, peer_sdp := omit, mt := t_IMS_CallParsMT } @@ -1044,24 +1048,100 @@ var template (value) PDU_SIP_Response tx_resp; var Via via; var charstring tx_sdp; + var boolean peer_support_precondition := match(g_rx_sip_req.msgHeader.supported.optionsTags, superset("precondition")); /* Obtain params: */ f_ConnHdlr_parse_initial_SIP_INVITE(g_rx_sip_req); via := g_rx_sip_req.msgHeader.via; f_ims_validate_register_P_Access_Network_info(g_rx_sip_req, exp_present := true); + if (g_pars.subscr.cp.require_precondition_ext and not peer_support_precondition) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str(g_name & ": Missing 'precondition' in INVITE Supported header: ", + g_rx_sip_req.msgHeader.supported)); + } - - /* Tx 180 Ringing */ - tx_resp := ts_SIP_Response_Ringing(g_pars.subscr.cp.sip_call_id, + /* Tx 100 Tyring */ + tx_resp := ts_SIP_Response_Trying(g_pars.subscr.cp.sip_call_id, g_pars.subscr.cp.from_addr, g_pars.subscr.cp.to_addr, via, - g_pars.subscr.cp.sip_seq_nr); + g_pars.subscr.cp.sip_seq_nr, + "INVITE", + allow := omit, + server := g_pars.server_name, + userAgent := omit); SIP.send(tx_resp); - /* Tx 200 OK */ tx_sdp := f_gen_sdp(); + + /* Use precondition ? */ + if (g_pars.subscr.cp.support_precondition_ext or + (g_pars.subscr.cp.support_precondition_ext and peer_support_precondition)) { + /* Tx 183 Session Progress */ + /* TODO: add a=curr:qos, a=des:qos and a=conf:qos fields to SDP */ + tx_resp := ts_SIP_Response_SessionProgress(g_pars.subscr.cp.sip_call_id, + g_pars.subscr.cp.from_addr, + g_pars.subscr.cp.to_addr, + via, + g_pars.subscr.cp.sip_seq_nr, + body := tx_sdp); + SIP.send(tx_resp); + + /* Rx PRACK */ + exp_req := tr_SIP_PRACK(f_tr_SipUrl_opt_defport(ts_SipUrl_from_Addr_Union(g_pars.subscr.cp.called.addr)), + g_pars.subscr.cp.sip_call_id, + g_pars.subscr.cp.from_addr, + g_pars.subscr.cp.to_addr, + f_tr_Via_response(via), + g_pars.subscr.cp.sip_seq_nr + 1, *); + as_SIP_expect_req(exp_req); + + /* Tx 200 OK (PRACK) */ + tx_resp := ts_SIP_Response(g_pars.subscr.cp.sip_call_id, + g_pars.subscr.cp.from_addr, + g_pars.subscr.cp.to_addr, + "PRACK", 200, + g_pars.subscr.cp.sip_seq_nr + 1, + "OK", + via, + body := omit); + SIP.send(tx_resp); + + /* Rx UPDATE */ + exp_req := tr_SIP_UPDATE(f_tr_SipUrl_opt_defport(ts_SipUrl_from_Addr_Union(g_pars.subscr.cp.called.addr)), + g_pars.subscr.cp.sip_call_id, + g_pars.subscr.cp.from_addr, + g_pars.subscr.cp.to_addr, + f_tr_Via_response(via), + g_pars.subscr.cp.sip_seq_nr + 2, + require := tr_Require(superset("precondition")), + body := ?); + as_SIP_expect_req(exp_req); + + /* Tx 200 OK (UPDATE) */ + /* TODO: add a=curr:qos, a=des:qos and a=conf:qos fields to SDP */ + tx_resp := ts_SIP_Response(g_pars.subscr.cp.sip_call_id, + g_pars.subscr.cp.from_addr, + g_pars.subscr.cp.to_addr, + "UPDATE", 200, + g_pars.subscr.cp.sip_seq_nr + 2, + "OK", + via, + body := tx_sdp); + SIP.send(tx_resp); + } + + /* Tx 180 Ringing */ + tx_resp := ts_SIP_Response_Ringing(g_pars.subscr.cp.sip_call_id, + g_pars.subscr.cp.from_addr, + g_pars.subscr.cp.to_addr, + via, + g_pars.subscr.cp.sip_seq_nr); + SIP.send(tx_resp); + + + /* Tx 200 OK */ tx_resp := ts_SIP_Response(g_pars.subscr.cp.sip_call_id, g_pars.subscr.cp.from_addr, g_pars.subscr.cp.to_addr, diff --git a/asterisk/expected-results.xml b/asterisk/expected-results.xml index 6b5def5..e9d2b82 100644 --- a/asterisk/expected-results.xml +++ b/asterisk/expected-results.xml @@ -13,5 +13,6 @@ <testcase classname='Asterisk_Tests' name='TC_ims_registration_timeout_protected_100Trying' time='MASKED'/> <testcase classname='Asterisk_Tests' name='TC_ims_registration_timeout_protected_200OK' time='MASKED'/> <testcase classname='Asterisk_Tests' name='TC_ims_call_mo' time='MASKED'/> + <testcase classname='Asterisk_Tests' name='TC_ims_call_mo_noprecondition' time='MASKED'/> <testcase classname='Asterisk_Tests' name='TC_ims_call_mt' time='MASKED'/> </testsuite> diff --git a/library/SIP_Templates.ttcn b/library/SIP_Templates.ttcn index 77d4ee0..bf88311 100644 --- a/library/SIP_Templates.ttcn +++ b/library/SIP_Templates.ttcn @@ -905,6 +905,40 @@ payload := omit } +template (present) PDU_SIP_Request +tr_SIP_PRACK(template (present) SipUrl uri, + template CallidString call_id, + template From from_addr, + template To to_addr, + template Via via, + template integer seq_nr, + template charstring body := *) := { + requestLine := tr_SIP_ReqLine(PRACK_E, uri), + msgHeader := tr_SIP_msgh_std(call_id, from_addr, to_addr, *, + via, + "PRACK", seq_nr), + messageBody := body, + payload := omit +} + +template (present) PDU_SIP_Request +tr_SIP_UPDATE(template (present) SipUrl uri, + template CallidString call_id, + template From from_addr, + template To to_addr, + template Via via, + template integer seq_nr, + template Require require := *, + template charstring body) := { + requestLine := tr_SIP_ReqLine(UPDATE_E, uri), + msgHeader := tr_SIP_msgh_std(call_id, from_addr, to_addr, *, + via, + "UPDATE", seq_nr, + require := require), + messageBody := body, + payload := omit +} + template (value) PDU_SIP_Response ts_SIP_Response(template (value) CallidString call_id, template (value) From from_addr, @@ -979,6 +1013,26 @@ payload := omit } +/* 183 Session Progress */ +template (value) PDU_SIP_Response +ts_SIP_Response_SessionProgress( + template (value) CallidString call_id, + template (value) From from_addr, + template (value) To to_addr, + Via via, + integer seq_nr, + charstring method := "INVITE", + template (omit) Require require := ts_Require({"sec-agree"}), + template (omit) charstring body := omit) := { + statusLine := ts_SIP_StatusLine(183, "Session Progress"), + msgHeader := ts_SIP_msgh_std(call_id, from_addr, to_addr, omit, method, seq_nr, + via, + content_length := f_ContentLength(body), + content_type := f_ContentTypeOrOmit(ts_CT_SDP, body)), + messageBody := body, + payload := omit +} + /* 401 Unauthorized */ template (value) PDU_SIP_Response ts_SIP_Response_Unauthorized( -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37248?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1e26f3bb9e54be5b5e15a003b2000ae3e88b9027 Gerrit-Change-Number: 37248 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 hour, 39 minutes

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: asterisk: Test auth resync procedure

by pespin

Attention is currently required from: laforge, neels. Hello Jenkins Builder, laforge, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37191?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by neels, Verified+1 by Jenkins Builder Change subject: asterisk: Test auth resync procedure ...................................................................... asterisk: Test auth resync procedure A new test is added to validate the procedure, plus all refactoring needed to accomodate for the new procedure. Related: SYS#6961 Change-Id: I2c654c270aa908859ec0bbb4d1da30d58de99be4 --- M asterisk/Asterisk_Tests.ttcn M asterisk/IMS_ConnectionHandler.ttcn M asterisk/expected-results.xml 3 files changed, 250 insertions(+), 90 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/91/37191/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37191?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2c654c270aa908859ec0bbb4d1da30d58de99be4 Gerrit-Change-Number: 37191 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 hour, 39 minutes

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: asterisk: Test initial IMS REGISTER timeout

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37194?usp=email ) Change subject: asterisk: Test initial IMS REGISTER timeout ...................................................................... Patch Set 2: (3 comments) File asterisk/Asterisk_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37194/comment/1eb85011_ef9a… PS2, Line 51: /* Current default by pjproject (timeout_timer_val) to 32s, and not changed by Asterisk */ > the comment doesn't seem to be a valid sentence? Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37194/comment/c0857476_ca57… PS2, Line 52: integer mp_volte_ims_outbound_register_timeout := 32; > (wouldn't a float make more sense, since titan handles all timers in float? does it have to be limit […] There's no need to go subsecond here, since it matches a full-second value in Asterisk. File asterisk/IMS_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37194/comment/8ac451c2_dc04… PS2, Line 211: t_guard := 60.0, > in some test suites we can set individual test timeouts to a larger value by f_init(t_guard := 60. […] Yes, I think 60 seconds is actually a usual default we use in most testsuites, so I simply increase it here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37194?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If59d43b2779dfbd14890a88d664077c194f843a1 Gerrit-Change-Number: 37194 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 11:03:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 hour, 39 minutes

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: s1gw: add TC_e_rab_setup

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37245?usp=email ) Change subject: s1gw: add TC_e_rab_setup ...................................................................... Patch Set 4: (1 comment) File s1gw/S1GW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37245/comment/6407b03f_91c5… PS3, Line 181: setverdict(fail, "Rx unexpected S1AP PDU: ", pdu); > Ack Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37245?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I94eb8cac4b5659c0f6f1bb248a80692b8cf84b6f Gerrit-Change-Number: 37245 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 11:02:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 hour, 39 minutes

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: s1gw: add TC_e_rab_setup

by fixeria

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37245?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: s1gw: add TC_e_rab_setup ...................................................................... s1gw: add TC_e_rab_setup Change-Id: I94eb8cac4b5659c0f6f1bb248a80692b8cf84b6f Related: SYS#6772 --- M s1gw/S1GW_Tests.ttcn M s1gw/expected-results.xml 2 files changed, 148 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/45/37245/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37245?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I94eb8cac4b5659c0f6f1bb248a80692b8cf84b6f Gerrit-Change-Number: 37245 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 hour, 40 minutes

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: asterisk: Test auth resync procedure

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37191?usp=email ) Change subject: asterisk: Test auth resync procedure ...................................................................... Patch Set 1: (1 comment) File asterisk/IMS_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37191/comment/e7cbab2f_1ac9… PS1, Line 529: g_pars.subscr.auth.autn))) > (indent off?) Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37191?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2c654c270aa908859ec0bbb4d1da30d58de99be4 Gerrit-Change-Number: 37191 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 11:01:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 hour, 41 minutes

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: s1gw: add TC_e_rab_setup

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37245?usp=email ) Change subject: s1gw: add TC_e_rab_setup ...................................................................... Patch Set 3: (2 comments) File s1gw/S1GW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37245/comment/7d3efa6c_a2d9… PS3, Line 176: S1AP_CONN > is S1AP_CONN and S1AP_ENB swapped in f_ConnHdlr_rx_s1ap_from_enb and f_ConnHdlr_rx_s1ap_from_mme? Yes, and this is correct. The testsuite emulates both eNB (client, connecting to S1GW) and MME (server, accepting connections from S1GW). When we expect to receive something from eNB, we receive on `S1AP_CONN` (MME). Likewise, when we expect to receive something from the MME, we receive on `S1AP_ENB` (eNB). S1GW is just a proxy. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37245/comment/aa7319ec_cd15… PS3, Line 181: setverdict(fail, "Rx unexpected S1AP PDU: ", pdu); > maybe note from eNB / MME here and below? Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37245?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I94eb8cac4b5659c0f6f1bb248a80692b8cf84b6f Gerrit-Change-Number: 37245 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 10:59:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 hour, 42 minutes

1
0
0 0

[S] Change in osmo-msc[master]: debian/copyright: remove include/openbsc/slhc.h (no such file)

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37236?usp=email ) Change subject: debian/copyright: remove include/openbsc/slhc.h (no such file) ...................................................................... debian/copyright: remove include/openbsc/slhc.h (no such file) Change-Id: Ib1f2395798010381d67d79c46778bb0caef17046 --- M debian/copyright 1 file changed, 9 insertions(+), 25 deletions(-) Approvals: neels: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/copyright b/debian/copyright index ac8ed52..1bde2c2 100644 --- a/debian/copyright +++ b/debian/copyright @@ -146,28 +146,3 @@ . On Debian systems, the complete text of the GNU General Public License Version 3 can be found in `/usr/share/common-licenses/GPL-3'. - -Files: include/openbsc/slhc.h -Copyright: 1989 Regents of the University of California. -License: __UNKNOWN__ - Redistribution and use in source and binary forms are permitted - provided that the above copyright notice and this paragraph are - duplicated in all such forms and that any documentation, - advertising materials, and other materials related to such - distribution and use acknowledge that the software was developed - by the University of California, Berkeley. The name of the - University may not be used to endorse or promote products derived - from this software without specific prior written permission. - THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR - IMPLIED WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED - WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. - . - Van Jacobson (van(a)helios.ee.lbl.gov), Dec 31, 1989: - - Initial distribution. - . - modified for KA9Q Internet Software Package by - Katie Stevens (dkstevens(a)ucdavis.edu) - University of California, Davis - Computing Services - - 01-31-90 initial adaptation - -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/37236?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib1f2395798010381d67d79c46778bb0caef17046 Gerrit-Change-Number: 37236 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 hour, 43 minutes

1
0
0 0

[S] Change in osmo-msc[master]: debian/copyright: remove include/openbsc/slhc.h (no such file)

by pespin

Attention is currently required from: fixeria, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37236?usp=email ) Change subject: debian/copyright: remove include/openbsc/slhc.h (no such file) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/37236?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib1f2395798010381d67d79c46778bb0caef17046 Gerrit-Change-Number: 37236 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 10:56:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 hour, 45 minutes

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: respond to enableUsingDD

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37234?usp=email ) Change subject: IPAd_Tests: respond to enableUsingDD ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37234?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I892485368925f9713d1dc0d44bd34277fd992875 Gerrit-Change-Number: 37234 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 10:56:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 hour, 46 minutes

1
0
0 0

[M] Change in libosmocore[master]: codec: make osmo_hr_check_sid() more efficient

by pespin

Attention is currently required from: falconia. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/37227?usp=email ) Change subject: codec: make osmo_hr_check_sid() more efficient ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37227?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib14204102c03c14d6c5aab42b0ffbef2c3dda3fd Gerrit-Change-Number: 37227 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 18 Jun 2024 10:55:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 hour, 47 minutes

1
0
0 0

[S] Change in osmo-msc[master]: utils/smpp_mirror: use OSMO_STRLCPY_ARRAY, fix -Wstringop-overflow

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37239?usp=email ) Change subject: utils/smpp_mirror: use OSMO_STRLCPY_ARRAY, fix -Wstringop-overflow ...................................................................... utils/smpp_mirror: use OSMO_STRLCPY_ARRAY, fix -Wstringop-overflow This patch fixes a warning printed by gcc 14.1.1: CC smpp_mirror-smpp_mirror.o CCLD smpp_mirror In function 'snprintf', inlined from 'bind_transceiver' at smpp_mirror.c:121:2, inlined from 'smpp_esme_init' at smpp_mirror.c:258:9, inlined from 'main' at smpp_mirror.c:299:7: /usr/include/bits/stdio2.h:54:10: warning: '__builtin___snprintf_chk' specified bound 16 exceeds destination size 9 [-Wstringop-overflow=] 54 | return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1, | ^ Take a chance to replace all snprintf() calls with OSMO_STRLCPY_ARRAY. Change-Id: If1df370fbfbca0953abf83ea1840d8bf8a0118be --- M src/utils/smpp_mirror.c 1 file changed, 30 insertions(+), 5 deletions(-) Approvals: neels: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/utils/smpp_mirror.c b/src/utils/smpp_mirror.c index 3356468..340e94f 100644 --- a/src/utils/smpp_mirror.c +++ b/src/utils/smpp_mirror.c @@ -117,9 +117,9 @@ memset(&bind, 0, sizeof(bind)); bind.command_id = BIND_TRANSCEIVER; bind.sequence_number = esme_inc_seq_nr(esme); - snprintf((char *)bind.system_id, SMPP_SYS_ID_LEN + 1, "%s", esme->system_id); - snprintf((char *)bind.password, SMPP_SYS_ID_LEN + 1, "%s", esme->password); - snprintf((char *)bind.system_type, sizeof(bind.system_type), "mirror"); + OSMO_STRLCPY_ARRAY(bind.system_id, esme->system_id); + OSMO_STRLCPY_ARRAY(bind.password, esme->password); + OSMO_STRLCPY_ARRAY(bind.system_type, "mirror"); bind.interface_version = esme->smpp_version; return PACK_AND_SEND(esme, &bind); @@ -287,8 +287,8 @@ if (!esme) exit(2); - snprintf((char *) esme->system_id, sizeof(esme->system_id), "mirror"); - snprintf((char *) esme->password, sizeof(esme->password), "mirror"); + OSMO_STRLCPY_ARRAY(esme->system_id, "mirror"); + OSMO_STRLCPY_ARRAY(esme->password, "mirror"); esme->smpp_version = 0x34; if (argc >= 2) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/37239?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: If1df370fbfbca0953abf83ea1840d8bf8a0118be Gerrit-Change-Number: 37239 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 hour, 48 minutes

1
0
0 0

[S] Change in osmo-msc[master]: smpp: fix typo in comment for SMPP_{SYS_ID,PASSWD}_LEN

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37237?usp=email ) Change subject: smpp: fix typo in comment for SMPP_{SYS_ID,PASSWD}_LEN ...................................................................... smpp: fix typo in comment for SMPP_{SYS_ID,PASSWD}_LEN Change-Id: I3f8d9a8e3739679995ddb037a8f3d58a627d36bc --- M include/osmocom/smpp/smpp.h 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: neels: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmocom/smpp/smpp.h b/include/osmocom/smpp/smpp.h index a2832d3..d48cd79 100644 --- a/include/osmocom/smpp/smpp.h +++ b/include/osmocom/smpp/smpp.h @@ -2,7 +2,7 @@ #include <osmocom/msc/gsm_data.h> -/* Length limits according to SMPP 3.4 spec including NUL-byte: */ +/* Length limits according to SMPP 3.4 spec excluding NUL-byte: */ #define SMPP_SYS_ID_LEN 15 #define SMPP_PASSWD_LEN 8 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/37237?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3f8d9a8e3739679995ddb037a8f3d58a627d36bc Gerrit-Change-Number: 37237 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 hour, 48 minutes

1
0
0 0

[S] Change in osmo-msc[master]: smpp: fix password[] length in struct esme

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37238?usp=email ) Change subject: smpp: fix password[] length in struct esme ...................................................................... smpp: fix password[] length in struct esme Change-Id: I07e7193460580a3c972a24700e75c925d1e50411 --- M include/osmocom/smpp/smpp.h 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved neels: Looks good to me, but someone else must approve diff --git a/include/osmocom/smpp/smpp.h b/include/osmocom/smpp/smpp.h index d48cd79..0d34345 100644 --- a/include/osmocom/smpp/smpp.h +++ b/include/osmocom/smpp/smpp.h @@ -23,7 +23,7 @@ uint8_t smpp_version; char system_id[SMPP_SYS_ID_LEN + 1]; - char password[SMPP_SYS_ID_LEN + 1]; + char password[SMPP_PASSWD_LEN + 1]; }; #define LOGPESME(ESME, LEVEL, FMT, ARGS...) \ -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/37238?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I07e7193460580a3c972a24700e75c925d1e50411 Gerrit-Change-Number: 37238 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 hour, 48 minutes

1
0
0 0

[S] Change in ...osmo-s1gw[master]: osmo_s1gw.app.src: add logger_color_formatter

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37228?usp=email ) Change subject: osmo_s1gw.app.src: add logger_color_formatter ...................................................................... osmo_s1gw.app.src: add logger_color_formatter This patch fixes 'FORMATTER CRASH' in the logging when running escript. Change-Id: I6f10b22af406ef640bc2eaa2dddca34b009f7e6a Fixes: c5d3c625 "Rework logging config, colorize output" --- M src/osmo_s1gw.app.src 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/osmo_s1gw.app.src b/src/osmo_s1gw.app.src index bc2a8d7..6fd8174 100644 --- a/src/osmo_s1gw.app.src +++ b/src/osmo_s1gw.app.src @@ -6,7 +6,8 @@ {registered, []}, {applications, [ kernel, - stdlib + stdlib, + logger_color_formatter ]}, {modules, []}, {mod, {osmo_s1gw_app, []}}, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37228?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I6f10b22af406ef640bc2eaa2dddca34b009f7e6a Gerrit-Change-Number: 37228 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 hour, 49 minutes

1
0
0 0

[S] Change in osmo-msc[master]: utils/smpp_mirror: use OSMO_STRLCPY_ARRAY, fix -Wstringop-overflow

by pespin

Attention is currently required from: fixeria, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37239?usp=email ) Change subject: utils/smpp_mirror: use OSMO_STRLCPY_ARRAY, fix -Wstringop-overflow ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/37239?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: If1df370fbfbca0953abf83ea1840d8bf8a0118be Gerrit-Change-Number: 37239 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 10:52:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 hour, 50 minutes

1
0
0 0

[S] Change in osmo-msc[master]: smpp: fix password[] length in struct esme

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37238?usp=email ) Change subject: smpp: fix password[] length in struct esme ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File include/osmocom/smpp/smpp.h: https://gerrit.osmocom.org/c/osmo-msc/+/37238/comment/8fa6c998_3b1bf346 PS1, Line 26: char password[SMPP_PASSWD_LEN + 1]; > this is probably breaking the ABI, better add it to TODO-RELEASE Ah nevermind, this is not within libsmpp34 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/37238?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I07e7193460580a3c972a24700e75c925d1e50411 Gerrit-Change-Number: 37238 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 10:52:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 hour, 50 minutes

1
0
0 0

[S] Change in osmo-msc[master]: smpp: fix password[] length in struct esme

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37238?usp=email ) Change subject: smpp: fix password[] length in struct esme ...................................................................... Patch Set 1: (1 comment) File include/osmocom/smpp/smpp.h: https://gerrit.osmocom.org/c/osmo-msc/+/37238/comment/411a7102_8dbb2472 PS1, Line 26: char password[SMPP_PASSWD_LEN + 1]; this is probably breaking the ABI, better add it to TODO-RELEASE -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/37238?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I07e7193460580a3c972a24700e75c925d1e50411 Gerrit-Change-Number: 37238 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 10:51:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 hour, 51 minutes

1
0
0 0

[S] Change in osmo-msc[master]: smpp: fix typo in comment for SMPP_{SYS_ID,PASSWD}_LEN

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37237?usp=email ) Change subject: smpp: fix typo in comment for SMPP_{SYS_ID,PASSWD}_LEN ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/37237?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3f8d9a8e3739679995ddb037a8f3d58a627d36bc Gerrit-Change-Number: 37237 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 10:50:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 hour, 52 minutes

1
0
0 0

[S] Change in ...osmo-s1gw[master]: osmo_s1gw.app.src: add logger_color_formatter

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37228?usp=email ) Change subject: osmo_s1gw.app.src: add logger_color_formatter ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37228?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I6f10b22af406ef640bc2eaa2dddca34b009f7e6a Gerrit-Change-Number: 37228 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 10:47:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 hour, 54 minutes

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: msc: test re-assignment to match codec with MT

by pespin

Attention is currently required from: fixeria, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053?usp=email ) Change subject: msc: test re-assignment to match codec with MT ...................................................................... Patch Set 3: Code-Review+2 (2 comments) File msc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053/comment/bcdba343_fb0a… PS2, Line 993: BSSMAP_FIELD_CodecElements re_ass_req_codecs, > it is always {FR} by default, so it is never actually absent. […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053/comment/48334548_0ba0… PS2, Line 995: re_ass_compl_chosen_codec > (s.a. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I402ed0523a2a87b83f29c5577b2c828102005d53 Gerrit-Change-Number: 35053 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 10:46:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 hour, 55 minutes

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: S1GW_Tests.default: fix empty junit-xml-*.log files

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37240?usp=email ) Change subject: s1gw: S1GW_Tests.default: fix empty junit-xml-*.log files ...................................................................... s1gw: S1GW_Tests.default: fix empty junit-xml-*.log files I copied this line from some other testsuite (likely ttcn3-mme-test). For some reason it makes TITAN produce empty junit-xml-*.log files, which are essential for the Test Results Analyzer in Jenkins. Change-Id: Ia80bf9640a465dd748f0a47c543b9a745a236133 Related: SYS#6772 --- M s1gw/S1GW_Tests.default 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/s1gw/S1GW_Tests.default b/s1gw/S1GW_Tests.default index ceca1b2..4ed872b 100644 --- a/s1gw/S1GW_Tests.default +++ b/s1gw/S1GW_Tests.default @@ -1,7 +1,6 @@ [LOGGING] FileMask := LOG_ALL | TTCN_MATCHING; ConsoleMask := ERROR | WARNING | PARALLEL | VERDICTOP | USER; -mtc.FileMask := ERROR | WARNING | PARALLEL | VERDICTOP; [TESTPORT_PARAMETERS] -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37240?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia80bf9640a465dd748f0a47c543b9a745a236133 Gerrit-Change-Number: 37240 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

3 hours, 32 minutes

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: add expected-results.xml

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37241?usp=email ) Change subject: s1gw: add expected-results.xml ...................................................................... s1gw: add expected-results.xml Change-Id: I6ee6cd2d996cf898f19f7eb7222e86fb2e211f07 Related: SYS#6772 --- A s1gw/expected-results.xml 1 file changed, 17 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/s1gw/expected-results.xml b/s1gw/expected-results.xml new file mode 100644 index 0000000..b10fd4a --- /dev/null +++ b/s1gw/expected-results.xml @@ -0,0 +1,7 @@ +<?xml version="1.0"?> +<testsuite name='S1GW_Tests' tests='4' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> + <testcase classname='S1GW_Tests' name='TC_setup' time='MASKED'/> + <testcase classname='S1GW_Tests' name='TC_setup_multi' time='MASKED'/> + <testcase classname='S1GW_Tests' name='TC_conn_term_by_mme' time='MASKED'/> + <testcase classname='S1GW_Tests' name='TC_conn_term_mme_unavail' time='MASKED'/> +</testsuite> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37241?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6ee6cd2d996cf898f19f7eb7222e86fb2e211f07 Gerrit-Change-Number: 37241 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

3 hours, 32 minutes

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: add expected-results.xml

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37241?usp=email ) Change subject: s1gw: add expected-results.xml ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37241?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6ee6cd2d996cf898f19f7eb7222e86fb2e211f07 Gerrit-Change-Number: 37241 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 09:10:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 hours, 32 minutes

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: S1GW_Tests.default: fix empty junit-xml-*.log files

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37240?usp=email ) Change subject: s1gw: S1GW_Tests.default: fix empty junit-xml-*.log files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37240?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia80bf9640a465dd748f0a47c543b9a745a236133 Gerrit-Change-Number: 37240 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 09:09:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 hours, 32 minutes

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: s1gw: add TC_e_rab_setup

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37245?usp=email ) Change subject: s1gw: add TC_e_rab_setup ...................................................................... Patch Set 3: (2 comments) File s1gw/S1GW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37245/comment/e8c3b295_265e… PS3, Line 176: S1AP_CONN is S1AP_CONN and S1AP_ENB swapped in f_ConnHdlr_rx_s1ap_from_enb and f_ConnHdlr_rx_s1ap_from_mme? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37245/comment/d01ce712_64f9… PS3, Line 181: setverdict(fail, "Rx unexpected S1AP PDU: ", pdu); maybe note from eNB / MME here and below? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37245?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I94eb8cac4b5659c0f6f1bb248a80692b8cf84b6f Gerrit-Change-Number: 37245 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 07:43:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

4 hours, 58 minutes

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: s1ap: add templates for E-RAB SETUP REQUEST/RESPONSE

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37244?usp=email ) Change subject: s1ap: add templates for E-RAB SETUP REQUEST/RESPONSE ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37244?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I145e2068ba62cdff8f3075f97c274e248864a9f7 Gerrit-Change-Number: 37244 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 07:35:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

5 hours, 6 minutes

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: rework module parameter naming, add mp_s1gw_mme_ip

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37246?usp=email ) Change subject: s1gw: rework module parameter naming, add mp_s1gw_mme_ip ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37246?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ice665662c8448c8314d5e6cc1e401e62b635872c Gerrit-Change-Number: 37246 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 07:33:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

5 hours, 8 minutes

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: pass Global_ENB_ID to ConnHdlr

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37243?usp=email ) Change subject: s1gw: pass Global_ENB_ID to ConnHdlr ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37243?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9660ca96f13c4e4c890f3957a25d01a27e2e0cac Gerrit-Change-Number: 37243 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 07:33:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

5 hours, 9 minutes

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: add and use f_ConnHdlr_expect_shutdown()

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37242?usp=email ) Change subject: s1gw: add and use f_ConnHdlr_expect_shutdown() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37242?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7e982f0268a6ee6059e9dfd5fbd6c9019c18359d Gerrit-Change-Number: 37242 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 07:27:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

5 hours, 14 minutes

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: add expected-results.xml

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37241?usp=email ) Change subject: s1gw: add expected-results.xml ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37241?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6ee6cd2d996cf898f19f7eb7222e86fb2e211f07 Gerrit-Change-Number: 37241 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 07:27:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

5 hours, 15 minutes

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: S1GW_Tests.default: fix empty junit-xml-*.log files

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37240?usp=email ) Change subject: s1gw: S1GW_Tests.default: fix empty junit-xml-*.log files ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37240?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia80bf9640a465dd748f0a47c543b9a745a236133 Gerrit-Change-Number: 37240 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 07:26:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

5 hours, 15 minutes

1
0
0 0

2024

2023

2022

gerrit-log June 2024