April 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: jobs/ttcn3: io_uring: set memlock to unlimited

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/36626?usp=email ) Change subject: jobs/ttcn3: io_uring: set memlock to unlimited ...................................................................... jobs/ttcn3: io_uring: set memlock to unlimited io_uring in the kernel memlocks a big amount of space with older kernels, such as the kernel on host2-deb11build-ansible. It seemed to be enough to increase it to 1 GiB. However now we see it failing again with: failure during io_uring_queue_init(): Cannot allocate memory Aborted (core dumped) Set it to unlimited to ensure that a low limit is not the reason we see it failing. If it still happens after this, we probably need to make sure that we don't run too many SUTs with io_uring in parallel on jenkins nodes with older kernels. Related: OS#6405 Change-Id: I39aaa2ed7d0310a12d0c4493a79ff46b2e7e2864 --- M jobs/ttcn3-testsuites.yml 1 file changed, 25 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/26/36626/1 diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 2e01645..2c3e07d 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -301,8 +301,8 @@ ;; *-io_uring) DIR="$(echo "{job-name}" | sed s/\-io_uring$//)" - # OS#6405: set memlock to 1 GB for older kernels - export DOCKER_ARGS="-e LIBOSMO_IO_BACKEND=IO_URING --ulimit memlock=1000000" + # OS#6405: set memlock to unlimited for older kernels + export DOCKER_ARGS="-e LIBOSMO_IO_BACKEND=IO_URING --ulimit memlock=-1" ;; *-latest) DIR="$(echo "{job-name}" | sed s/\-latest$//)" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36626?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I39aaa2ed7d0310a12d0c4493a79ff46b2e7e2864 Gerrit-Change-Number: 36626 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: allow body to be "omit"

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email ) Change subject: HTTP_Adapter: allow body to be "omit" ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifedc8c2a590835663d1ba0b08b1fe4d54bdd0fff Gerrit-Change-Number: 36505 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Apr 2024 10:38:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd

by Jenkins Builder

Attention is currently required from: dexter. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email ) Change subject: IPAd_Tests: add testsuite for an IPAd ...................................................................... Patch Set 6: (13 comments) File ipad/example_ca/pki/certs_by_serial/11192A13CF3A3BC43FE1594BA8567DF0.pem: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/c4d5dc85_6c18… PS6, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/a275a220_d72a… PS6, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/8a831858_332e… PS6, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/9ef18c1c_6756… PS6, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/3c08f20c_3688… PS6, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/bb1033d0_5d96… PS6, Line 49: X509v3 Subject Alternative Name: trailing whitespace File ipad/example_ca/pki/issued/alttest.crt: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/9353f380_8958… PS6, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/c337e41d_2470… PS6, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/27532674_f568… PS6, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/fe629262_3542… PS6, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/19826810_778e… PS6, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/edb942d3_408a… PS6, Line 49: X509v3 Subject Alternative Name: trailing whitespace File ipad/example_ca/vars: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/264e6d6f_f935… PS6, Line 30: # trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Gerrit-Change-Number: 36229 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Apr 2024 10:19:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: ipad: add an extra certificate+bundle for host "testsuite"

by Jenkins Builder

Attention is currently required from: dexter. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621?usp=email ) Change subject: ipad: add an extra certificate+bundle for host "testsuite" ...................................................................... Patch Set 3: (12 comments) File ipad/example_ca/pki/certs_by_serial/1D1B580C1B235125A87BE06C70121913.pem: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/9d332259_ec81… PS3, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/9208d852_24e5… PS3, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/9907abf0_5f53… PS3, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/72b015f5_a6f7… PS3, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/62041970_fd5c… PS3, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/1de452cf_4a85… PS3, Line 49: X509v3 Subject Alternative Name: trailing whitespace File ipad/example_ca/pki/issued/testsuite.crt: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/848c428e_fa97… PS3, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/c0482b2b_63cc… PS3, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/476d2c94_a030… PS3, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/298ab1dc_57c4… PS3, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/e1dd91f7_a8cf… PS3, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/3885f348_4ac5… PS3, Line 49: X509v3 Subject Alternative Name: trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2d4ba8b710b9cf518b90c7f7acc8982350705531 Gerrit-Change-Number: 36621 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Apr 2024 10:19:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: allow body to be "omit"

by dexter

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email ) Change subject: HTTP_Adapter: allow body to be "omit" ...................................................................... Patch Set 5: (1 comment) File library/HTTP_Adapter.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505/comment/fc03802c_9cb6… PS3, Line 106: header := valueof(f_ts_HTTP_Header(body, host, custom_hdr)), > You don't need to call valueof() here. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifedc8c2a590835663d1ba0b08b1fe4d54bdd0fff Gerrit-Change-Number: 36505 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Apr 2024 10:18:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: allow body to be "omit"

by dexter

Attention is currently required from: pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: HTTP_Adapter: allow body to be "omit" ...................................................................... HTTP_Adapter: allow body to be "omit" In HTTP not all requests have a body. At the moment we describe a missing body with body := "". This is not 100% correct since the rest of the code interprets this as a present body with zero length and will put a content_length = 0 header line into the HTTP header, even in the GET request. This will most likely be ignored by any HTTP server, but it is still not 100% spec compliant. Related: SYS#6824 Change-Id: Ifedc8c2a590835663d1ba0b08b1fe4d54bdd0fff --- M library/HTTP_Adapter.ttcn 1 file changed, 29 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/05/36505/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifedc8c2a590835663d1ba0b08b1fe4d54bdd0fff Gerrit-Change-Number: 36505 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 2 months

1
0
0 0

[S] Change in libosmocore[master]: tests: do not copy *.cfg files to the build directory

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36614?usp=email ) Change subject: tests: do not copy *.cfg files to the build directory ...................................................................... tests: do not copy *.cfg files to the build directory When running 'make check' in-tree ($builddir == $srcdir), those *.cfg files end up in tests/ and show up as git-add candidates. Instead of copying them, just let the test binaries know where to find those files via the cmdline parameters. Change-Id: I74e428f0548418fdecada3d25049d6e110e790fe --- M tests/Makefile.am M tests/msgfile/msgfile_test.c M tests/testsuite.at M tests/vty/vty_test.c 4 files changed, 32 insertions(+), 11 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/tests/Makefile.am b/tests/Makefile.am index 8b1731d..45490f2 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -550,8 +550,7 @@ gea/gea_test \ >$(srcdir)/gea/gea_test.ok if ENABLE_MSGFILE - cp $(srcdir)/msgfile/msgconfig.cfg . - msgfile/msgfile_test \ + msgfile/msgfile_test $(srcdir)/msgfile/msgconfig.cfg \ >$(srcdir)/msgfile/msgfile_test.ok endif sms/sms_test \ @@ -606,8 +605,7 @@ strrb/strrb_test \ >$(srcdir)/strrb/strrb_test.ok if ENABLE_VTY - cp $(srcdir)/vty/*.cfg . - vty/vty_test \ + vty/vty_test $(srcdir)/vty \ >$(srcdir)/vty/vty_test.ok \ 2>$(srcdir)/vty/vty_test.err endif diff --git a/tests/msgfile/msgfile_test.c b/tests/msgfile/msgfile_test.c index 3fe173d..ec58816 100644 --- a/tests/msgfile/msgfile_test.c +++ b/tests/msgfile/msgfile_test.c @@ -17,6 +17,7 @@ #include <osmocom/core/msgfile.h> #include <osmocom/core/talloc.h> +#include <osmocom/core/utils.h> #include <stdio.h> @@ -39,8 +40,8 @@ { struct osmo_config_list *entries; - /* todo use msgfile_test.c.in and replace the path */ - entries = osmo_config_list_parse(NULL, "msgconfig.cfg"); + OSMO_ASSERT(argc > 1); + entries = osmo_config_list_parse(NULL, argv[1]); dump_entries(entries); talloc_free(entries); diff --git a/tests/testsuite.at b/tests/testsuite.at index 9ff64ac..9f17ba3 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -84,9 +84,8 @@ if ENABLE_MSGFILE AT_SETUP([msgfile]) AT_KEYWORDS([msgfile]) -cp $abs_srcdir/msgfile/msgconfig.cfg . cat $abs_srcdir/msgfile/msgfile_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/msgfile/msgfile_test], [0], [expout]) +AT_CHECK([$abs_top_builddir/tests/msgfile/msgfile_test $abs_srcdir/msgfile/msgconfig.cfg], [0], [expout]) AT_CLEANUP endif @@ -243,8 +242,7 @@ AT_KEYWORDS([vty]) cat $abs_srcdir/vty/vty_test.ok > expout cat $abs_srcdir/vty/vty_test.err > experr -cp $abs_srcdir/vty/*.cfg . -AT_CHECK([$abs_top_builddir/tests/vty/vty_test], [0], [expout], [experr]) +AT_CHECK([$abs_top_builddir/tests/vty/vty_test $abs_srcdir/vty], [0], [expout], [experr]) AT_CLEANUP AT_SETUP([gprs-bssgp]) diff --git a/tests/vty/vty_test.c b/tests/vty/vty_test.c index 01e323e..a3f8489 100644 --- a/tests/vty/vty_test.c +++ b/tests/vty/vty_test.c @@ -39,6 +39,7 @@ #include <osmocom/vty/stats.h> static enum event last_vty_connection_event = -1; +static const char *cfg_path = NULL; void *ctx = NULL; static void test_cmd_string_from_valstr(void) @@ -292,9 +293,12 @@ void test_exit_by_indent(const char *fname, int expect_rc) { + char fpath[PATH_MAX]; int rc; + printf("reading file %s, expecting rc=%d\n", fname, expect_rc); - rc = vty_read_config_file(fname, NULL); + snprintf(&fpath[0], sizeof(fpath), "%s/%s", cfg_path, fname); + rc = vty_read_config_file(fpath, NULL); printf("got rc=%d\n", rc); OSMO_ASSERT(rc == expect_rc); } @@ -618,6 +622,12 @@ }; void *stats_ctx; + if (argc < 2) { + fprintf(stderr, "Usage: %s CFG_PATH\n", argv[0]); + return 1; + } + cfg_path = argv[1]; + ctx = talloc_named_const(NULL, 0, "stats test context"); stats_ctx = talloc_named_const(ctx, 1, "stats test context"); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36614?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I74e428f0548418fdecada3d25049d6e110e790fe Gerrit-Change-Number: 36614 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

[S] Change in libosmocore[master]: tests: rename logging_test_gsmtap -> logging_gsmtap_test

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36615?usp=email ) Change subject: tests: rename logging_test_gsmtap -> logging_gsmtap_test ...................................................................... tests: rename logging_test_gsmtap -> logging_gsmtap_test This way the naming is consistent with existing tests and matches the 'tests/*/*_test' pattern in .gitignore. Change-Id: I280fc0cc1bda9ba445af71f00bc8f1ccfd2b2091 --- M tests/Makefile.am R tests/logging/logging_gsmtap_test.c R tests/logging/logging_gsmtap_test.err M tests/testsuite.at 4 files changed, 19 insertions(+), 7 deletions(-) Approvals: osmith: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/tests/Makefile.am b/tests/Makefile.am index 45490f2..3b4325e 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -15,7 +15,7 @@ gsm0808/gsm0808_test gsm0408/gsm0408_test \ gprs/gprs_test kasumi/kasumi_test gea/gea_test \ logging/logging_test codec/codec_test \ - logging/logging_test_gsmtap \ + logging/logging_gsmtap_test \ loggingrb/loggingrb_test strrb/strrb_test \ comp128/comp128_test \ bitvec/bitvec_test msgb/msgb_test bits/bitcomp_test \ @@ -246,7 +246,7 @@ logging_logging_vty_test_SOURCES = logging/logging_vty_test.c logging_logging_vty_test_LDADD = $(top_builddir)/src/vty/libosmovty.la $(LDADD) -logging_logging_test_gsmtap_SOURCES = logging/logging_test_gsmtap.c +logging_logging_gsmtap_test_SOURCES = logging/logging_gsmtap_test.c vty_vty_transcript_test_SOURCES = vty/vty_transcript_test.c vty_vty_transcript_test_LDADD = $(top_builddir)/src/vty/libosmovty.la $(LDADD) @@ -431,7 +431,7 @@ msgfile/msgfile_test.ok msgfile/msgconfig.cfg \ logging/logging_test.ok logging/logging_test.err \ logging/logging_vty_test.vty \ - logging/logging_test_gsmtap.err \ + logging/logging_gsmtap_test.err \ fr/fr_test.ok loggingrb/logging_test.ok \ loggingrb/logging_test.err strrb/strrb_test.ok \ codec/codec_test.ok \ @@ -589,8 +589,8 @@ logging/logging_test \ >$(srcdir)/logging/logging_test.ok \ 2>$(srcdir)/logging/logging_test.err - logging/logging_test_gsmtap \ - 2>&1 |grep -v "enqueueing message failed" >$(srcdir)/logging/logging_test_gsmtap.err + logging/logging_gsmtap_test \ + 2>&1 |grep -v "enqueueing message failed" >$(srcdir)/logging/logging_gsmtap_test.err codec/codec_test \ >$(srcdir)/codec/codec_test.ok codec/codec_ecu_fr_test \ diff --git a/tests/logging/logging_test_gsmtap.c b/tests/logging/logging_gsmtap_test.c similarity index 100% rename from tests/logging/logging_test_gsmtap.c rename to tests/logging/logging_gsmtap_test.c diff --git a/tests/logging/logging_test_gsmtap.err b/tests/logging/logging_gsmtap_test.err similarity index 100% rename from tests/logging/logging_test_gsmtap.err rename to tests/logging/logging_gsmtap_test.err diff --git a/tests/testsuite.at b/tests/testsuite.at index 9f17ba3..e721b93 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -202,8 +202,8 @@ AT_SETUP([logging_gsmtap]) AT_KEYWORDS([logging_gsmtap]) -cat $abs_srcdir/logging/logging_test_gsmtap.err > experr -AT_CHECK([$abs_top_builddir/tests/logging/logging_test_gsmtap 3>&1 1>&2 2>&3 |grep -v "enqueueing message failed" 3>&1 1>&2 2>&3 ], [], [ignore], [experr]) +cat $abs_srcdir/logging/logging_gsmtap_test.err > experr +AT_CHECK([$abs_top_builddir/tests/logging/logging_gsmtap_test 3>&1 1>&2 2>&3 |grep -v "enqueueing message failed" 3>&1 1>&2 2>&3 ], [], [ignore], [experr]) AT_CLEANUP AT_SETUP([codec]) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36615?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I280fc0cc1bda9ba445af71f00bc8f1ccfd2b2091 Gerrit-Change-Number: 36615 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

[S] Change in libosmocore[master]: vty: fix memleak in host_config_set()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36616?usp=email ) Change subject: vty: fix memleak in host_config_set() ...................................................................... vty: fix memleak in host_config_set() Not only we call this function from vty_read_config_file(), but also from config_write_file_cmd. Thus we leak memory when doing 'write file FILE' in the VTY. Change-Id: I356818aae3addab6db39de9a625453b7435b7cc1 --- M src/vty/command.c 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/src/vty/command.c b/src/vty/command.c index a3e0e36..1719690 100644 --- a/src/vty/command.c +++ b/src/vty/command.c @@ -4297,7 +4297,7 @@ /* Set config filename. Called from vty.c */ void host_config_set(const char *filename) { - host.config = talloc_strdup(tall_vty_cmd_ctx, filename); + osmo_talloc_replace_string(tall_vty_cmd_ctx, &host.config, filename); } const char *host_config_file(void) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36616?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I356818aae3addab6db39de9a625453b7435b7cc1 Gerrit-Change-Number: 36616 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-sgsn-test: add missing SGSN_Tests_NS.control

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36622?usp=email ) Change subject: ttcn3-sgsn-test: add missing SGSN_Tests_NS.control ...................................................................... ttcn3-sgsn-test: add missing SGSN_Tests_NS.control This does not enable the SNS testcases though. We need a separate job with its own configuration files for running the SNS testcases. Change-Id: I605526dff6d3c0ec4c5dc58dc00ca51b4ccd68a7 Related: osmo-ttcn3-hacks.git Ib2bffbb110961474928f35d212cb492d4b6fdee0 --- M ttcn3-sgsn-test/SGSN_Tests.cfg 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/ttcn3-sgsn-test/SGSN_Tests.cfg b/ttcn3-sgsn-test/SGSN_Tests.cfg index 6fd2ae8..d3d1ee7 100644 --- a/ttcn3-sgsn-test/SGSN_Tests.cfg +++ b/ttcn3-sgsn-test/SGSN_Tests.cfg @@ -74,3 +74,4 @@ [EXECUTE] SGSN_Tests.control SGSN_Tests_Iu.control +SGSN_Tests_NS.control -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36622?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I605526dff6d3c0ec4c5dc58dc00ca51b4ccd68a7 Gerrit-Change-Number: 36622 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2024