Attention is currently required from: msuraev, osmith.
osmith has uploaded a new patch set (#3) to the change originally created by msuraev. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29722?usp=email )
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: .deb/.rpm: add osmocom user during package install
......................................................................
.deb/.rpm: add osmocom user during package install
Create osmocom user & group during package installation.
Fix the configuration dir/files permission to match.
Related: OS#4107
Tweaked-By: Oliver Smith <osmith(a)sysmocom.de>
Change-Id: I63e147961f93d62904ae64f5f3794839d047e4a6
---
M contrib/libosmo-sccp.spec.in
M contrib/systemd/osmo-stp.service
M debian/control
A debian/osmo-stp.postinst
4 files changed, 74 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/22/29722/3
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29722?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I63e147961f93d62904ae64f5f3794839d047e4a6
Gerrit-Change-Number: 29722
Gerrit-PatchSet: 3
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: msuraev, osmith, pespin.
osmith has uploaded a new patch set (#3) to the change originally created by msuraev. ( https://gerrit.osmocom.org/c/osmo-cbc/+/29717?usp=email )
The following approvals got outdated and were removed:
Code-Review-1 by pespin, Verified+1 by Jenkins Builder
Change subject: .deb/.rpm: add osmocom user during package install
......................................................................
.deb/.rpm: add osmocom user during package install
Create osmocom user & group during package installation.
Fix the configuration dir/files permission to match.
Related: OS#4107
Tweaked-By: Oliver Smith <osmith(a)sysmocom.de>
Change-Id: Ifcc882125a22d8f2e1bfcd19622aed4e8a723e6c
---
M contrib/osmo-cbc.spec.in
M contrib/systemd/osmo-cbc.service
M debian/control
A debian/postinst
4 files changed, 71 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/17/29717/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/29717?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: Ifcc882125a22d8f2e1bfcd19622aed4e8a723e6c
Gerrit-Change-Number: 29717
Gerrit-PatchSet: 3
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: msuraev, osmith, pespin.
osmith has uploaded a new patch set (#3) to the change originally created by msuraev. ( https://gerrit.osmocom.org/c/osmo-smlc/+/29720?usp=email )
The following approvals got outdated and were removed:
Code-Review-1 by pespin, Verified+1 by Jenkins Builder
Change subject: .deb/.rpm: add osmocom user during package install
......................................................................
.deb/.rpm: add osmocom user during package install
Create osmocom user & group during package installation.
Fix the configuration dir/files permission to match.
Related: OS#4107
Tweaked-By: Oliver Smith <osmith(a)sysmocom.de>
Change-Id: I459ac6b80526afa0f5d47a8b56f40d5f636dbe28
---
M contrib/osmo-smlc.spec.in
M contrib/systemd/osmo-smlc.service
M debian/control
A debian/postinst
4 files changed, 70 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-smlc refs/changes/20/29720/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/29720?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-smlc
Gerrit-Branch: master
Gerrit-Change-Id: I459ac6b80526afa0f5d47a8b56f40d5f636dbe28
Gerrit-Change-Number: 29720
Gerrit-PatchSet: 3
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: dexter, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email )
Change subject: HTTP_Adapter: allow API users to specifiy custom header
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
File library/HTTP_Adapter.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/464528a9_6fe1…
PS3, Line 73: var HeaderLines hdr := { };
> I am not sure if that really works. […]
I see, no need to spend more time if it doesn't work out, was worth a try though.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/5bc53de6_98c7…
PS3, Line 77: hdr := hdr & {valueof(ts_HeaderLine("Host", valueof(host)))};
> (see above, I removed the valueof as suggested)
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I115fd14254e0957c0955649aeb47059dc180bf57
Gerrit-Change-Number: 36504
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 24 Apr 2024 14:09:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email )
Change subject: IPAd_Tests: add testsuite for an IPAd
......................................................................
Patch Set 7:
(3 comments)
File ipad/IPAd_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/bce29a62_2717…
PS1, Line 445: for (i := 0; i < sizeof(esipa_res.getBoundProfilePackageResponseEsipa.getBoundProfilePackageOkEsipa.boundProfilePackage.firstSequenceOf87); i := i + 1) {
> lol. […]
Yeah much better now :)
File ipad/IPAd_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/295a7b9d_2ce1…
PS7, Line 161: f_sleep(2.0);
is this time something configurable in IPAd? If so, add a mp_ float module parameter and add a comment regarding having to sync that with the config in IPAd.
File ipad/example_ca/pki/issued/alttest.notes:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/922a94f7_8334…
PS7, Line 7: The alttest.cabundle file has been created manually (alttest certificate at the
Explain how did you create it manually.
Also, explicitly state how to update the certificate when it expires in 2027 ;)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d
Gerrit-Change-Number: 36229
Gerrit-PatchSet: 7
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 24 Apr 2024 14:07:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment