April 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-e1-hardware[master]: icE1usb fw: Rework the way LEDs are used and updated

by tnt

tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36686?usp=email ) Change subject: icE1usb fw: Rework the way LEDs are used and updated ...................................................................... icE1usb fw: Rework the way LEDs are used and updated Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: Ib3215a676716cc60e27c5857e4559135928a8cf7 --- M firmware/ice40-riscv/icE1usb/e1.c 1 file changed, 91 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/86/36686/1 diff --git a/firmware/ice40-riscv/icE1usb/e1.c b/firmware/ice40-riscv/icE1usb/e1.c index 6baee16..17c1786 100644 --- a/firmware/ice40-riscv/icE1usb/e1.c +++ b/firmware/ice40-riscv/icE1usb/e1.c @@ -270,6 +270,11 @@ } linemon; struct e1_error_count errors; + + struct { + enum e1_platform_led_state green; + enum e1_platform_led_state yellow; + } led; }; static struct e1_state g_e1[NUM_E1_PORTS]; @@ -326,6 +331,76 @@ } } +static void +_e1_update_leds(int port) +{ + struct e1_state *e1 = _get_state(port); + + enum e1_platform_led_state green; + enum e1_platform_led_state yellow; + + /* + * Green Yellow Condition + * OFF / LOS + * BLINK OFF LOF + * BLINK ON LOF + AIS + * ON OFF ALIGNED + * ON ON ALIGNED + RAI + */ + + /* Compute expected state */ + if (e1->errors.flags & E1_ERR_F_LOS) { + green = E1P_LED_ST_OFF; + yellow = E1P_LED_ST_OFF; + } else if (e1->errors.flags & E1_ERR_F_ALIGN_ERR) { + green = E1P_LED_ST_BLINK; + yellow = (e1->errors.flags & E1_ERR_F_AIS) ? E1P_LED_ST_ON : E1P_LED_ST_OFF; + } else { + green = E1P_LED_ST_ON; + yellow = (e1->errors.flags & E1_ERR_F_RAI) ? E1P_LED_ST_ON : E1P_LED_ST_OFF; + } + + /* Update actual leds */ + if (e1->led.green != green) + e1_platform_led_set(port, E1P_LED_GREEN, green); + + if (e1->led.yellow != yellow) + e1_platform_led_set(port, E1P_LED_YELLOW, yellow); + + e1->led.green = green; + e1->led.yellow = yellow; + + /* Update the shared RGB led */ + if (port == (NUM_E1_PORTS - 1)) + { + static bool c_ok = true, c_flow = false; + bool n_ok = false, n_flow = false; + + for (int port=0; port<NUM_E1_PORTS; port++) + { + struct e1_state *e1 = _get_state(port); + n_ok |= !(e1->errors.flags & E1_ERR_F_ALIGN_ERR); + n_flow |= (e1->rx.state != IDLE); + n_flow |= (e1->tx.state != IDLE); + } + + if (n_ok != c_ok) { + if (n_ok) + led_color(0, 48, 0); // Green + else + led_color(48, 0, 0); // Red + } + + if (n_flow != c_flow) { + led_blink(n_flow, 200, 1000); + led_breathe(n_flow, 100, 200); + } + + c_ok = n_ok; + c_flow = n_flow; + } +} + void e1_init(int port, uint16_t rx_cr, uint16_t tx_cr) { @@ -490,13 +565,10 @@ } if (rai_possible) { - if (rai_received) { + if (rai_received) e1->errors.flags |= E1_ERR_F_RAI; - e1_platform_led_set(port, E1P_LED_YELLOW, E1P_LED_ST_ON); - } else { + else e1->errors.flags &= ~E1_ERR_F_RAI; - e1_platform_led_set(port, E1P_LED_YELLOW, E1P_LED_ST_OFF); - } } return tot_frames; @@ -561,10 +633,8 @@ uint32_t bd; unsigned int ofs; - /* HACK: LED link status */ + /* Update error flags */ if (e1_regs->rx.csr & E1_RX_SR_ALIGNED) { - e1_platform_led_set(port, E1P_LED_GREEN, E1P_LED_ST_ON); - led_color(0, 48, 0); e1->errors.flags &= ~( E1_ERR_F_LOS | E1_ERR_F_AIS | @@ -572,14 +642,13 @@ E1_ERR_F_ALIGN_ERR ); } else { - e1_platform_led_set(port, E1P_LED_GREEN, E1P_LED_ST_BLINK); - e1_platform_led_set(port, E1P_LED_YELLOW, E1P_LED_ST_OFF); - led_color(48, 0, 0); e1->errors.flags |= E1_ERR_F_ALIGN_ERR; e1->errors.flags &= ~E1_ERR_F_RAI; - /* TODO: completely off if rx tick counter not incrementing */ } + /* Update leds */ + _e1_update_leds(port); + /* Active ? */ if ((e1->rx.state == IDLE) && (e1->tx.state == IDLE)) return; @@ -605,9 +674,6 @@ if (e1->tx.state == STARTING) { if (e1f_unseen_frames(&e1->tx.fifo) < (16 * 5)) return; - /* HACK: LED flow status */ - led_blink(true, 200, 1000); - led_breathe(true, 100, 200); } /* Handle RX */ -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36686?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Ib3215a676716cc60e27c5857e4559135928a8cf7 Gerrit-Change-Number: 36686 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-MessageType: newchange

2 weeks, 2 days

1
0
0 0

[S] Change in osmo-e1-hardware[master]: icE1usb fw: Fix OIS -> AIS typo

by tnt

tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36678?usp=email ) Change subject: icE1usb fw: Fix OIS -> AIS typo ...................................................................... icE1usb fw: Fix OIS -> AIS typo Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: I23f242c31483533adb9cb60b4aac9b95a7b807e8 --- M firmware/ice40-riscv/icE1usb/e1.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/78/36678/1 diff --git a/firmware/ice40-riscv/icE1usb/e1.c b/firmware/ice40-riscv/icE1usb/e1.c index 6597124..bfc042e 100644 --- a/firmware/ice40-riscv/icE1usb/e1.c +++ b/firmware/ice40-riscv/icE1usb/e1.c @@ -309,7 +309,7 @@ /* TX */ if (e1->tx.state == IDLE) { - /* "Off" state: We TX only OIS */ + /* "Off" state: We TX only AIS */ e1->tx.cr.val = (e1->tx.cr.cfg & ~(E1_TX_CR_MODE_MASK | E1_TX_CR_ALARM)) | E1_TX_CR_ENABLE | E1_TX_CR_MODE_TRSP; } else { /* "On state: Enabled + User config */ -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36678?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I23f242c31483533adb9cb60b4aac9b95a7b807e8 Gerrit-Change-Number: 36678 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-MessageType: newchange

2 weeks, 2 days

1
0
0 0

[S] Change in osmo-e1-hardware[master]: gateware/cores: Update no2e1

by tnt

tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36677?usp=email ) Change subject: gateware/cores: Update no2e1 ...................................................................... gateware/cores: Update no2e1 This pulls in the support for non-crc4 framing modes and also setting the Sa bits (for osmo-v5) Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: Ica1bbaa052988f5b7e71c7fa51f87eb0bfea6f67 --- M gateware/cores/no2e1 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/77/36677/1 diff --git a/gateware/cores/no2e1 b/gateware/cores/no2e1 index 074f293..9a11118 160000 --- a/gateware/cores/no2e1 +++ b/gateware/cores/no2e1 @@ -1 +1 @@ -Subproject commit 074f293d350a1698de16bf942fb2f5f2d61857cc +Subproject commit 9a1111855cb265a6271a8a43fd3809e7ad6ac040 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36677?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Ica1bbaa052988f5b7e71c7fa51f87eb0bfea6f67 Gerrit-Change-Number: 36677 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-MessageType: newchange

2 weeks, 2 days

1
0
0 0

[S] Change in osmo-e1-hardware[master]: icE1usb fw: Avoid casting random pointer to struct in set_{rx,tx}_mode

by tnt

tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36676?usp=email ) Change subject: icE1usb fw: Avoid casting random pointer to struct in set_{rx,tx}_mode ...................................................................... icE1usb fw: Avoid casting random pointer to struct in set_{rx,tx}_mode There is really no need here, we can use `memcpy` just as well. Not sure if this was a problem here but newer gcc are annoying with aliasing rules and such so better safe than sorry. Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: I110ee4c014e8cfe058f7fc357decb7ab99e0be64 --- M firmware/ice40-riscv/icE1usb/usb_e1.c 1 file changed, 19 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/76/36676/1 diff --git a/firmware/ice40-riscv/icE1usb/usb_e1.c b/firmware/ice40-riscv/icE1usb/usb_e1.c index 328ff3f..11c7401 100644 --- a/firmware/ice40-riscv/icE1usb/usb_e1.c +++ b/firmware/ice40-riscv/icE1usb/usb_e1.c @@ -345,27 +345,25 @@ static bool _set_tx_mode_done(struct usb_xfer *xfer) { - const struct ice1usb_tx_config *cfg = (const struct ice1usb_tx_config *) xfer->data; struct usb_ctrl_req *req = xfer->cb_ctx; int port = _ifnum2port(req->wIndex); struct usb_e1_state *usb_e1 = _get_state(port); printf("set_tx_mode[%d] %02x%02x%02x%02x\r\n", port, xfer->data[0], xfer->data[1], xfer->data[2], xfer->data[3]); - usb_e1->tx_cfg = *cfg; - e1_tx_config(port, _tx_config_reg(cfg)); + memcpy(&usb_e1->tx_cfg, xfer->data, sizeof(struct ice1usb_tx_config)); + e1_tx_config(port, _tx_config_reg(&usb_e1->tx_cfg)); return true; } static bool _set_rx_mode_done(struct usb_xfer *xfer) { - const struct ice1usb_rx_config *cfg = (const struct ice1usb_rx_config *) xfer->data; struct usb_ctrl_req *req = xfer->cb_ctx; int port = _ifnum2port(req->wIndex); struct usb_e1_state *usb_e1 = _get_state(port); printf("set_rx_mode[%d] %02x\r\n", port, xfer->data[0]); - usb_e1->rx_cfg = *cfg; - e1_rx_config(port, _rx_config_reg(cfg)); + memcpy(&usb_e1->rx_cfg, xfer->data, sizeof(struct ice1usb_rx_config)); + e1_rx_config(port, _rx_config_reg(&usb_e1->rx_cfg)); return true; } -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36676?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I110ee4c014e8cfe058f7fc357decb7ab99e0be64 Gerrit-Change-Number: 36676 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-MessageType: newchange

2 weeks, 2 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: improve ts_initiateAuthenticationRequestE...

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36647?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: SGP32Definitions_Templates: improve ts_initiateAuthenticationRequestEsipa ...................................................................... SGP32Definitions_Templates: improve ts_initiateAuthenticationRequestEsipa The template ts_initiateAuthenticationRequestEsipa has a field for smdpAddress and euiccInfo1. Those fields are optional fields, but they still play a central role in the protocol, so that they are effectively mandatory. Let's make the fields available to the template user and populate them with meaningful default values. Related: SYS#6824 Change-Id: I97aa039810ad9fffea4226254fa675fd24647de1 --- M library/euicc/SGP32Definitions_Templates.ttcn 1 file changed, 20 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/library/euicc/SGP32Definitions_Templates.ttcn b/library/euicc/SGP32Definitions_Templates.ttcn index c178a9c..86c2055 100644 --- a/library/euicc/SGP32Definitions_Templates.ttcn +++ b/library/euicc/SGP32Definitions_Templates.ttcn @@ -77,11 +77,13 @@ } } template (value) EsipaMessageFromIpaToEim -ts_initiateAuthenticationRequestEsipa(template (value) octetstring euiccChallenge := '00112233445566778899aabbccddeeff'O) := { +ts_initiateAuthenticationRequestEsipa(template (value) octetstring euiccChallenge := '00112233445566778899aabbccddeeff'O, + template (omit) charstring smdpAddress := "smdp.example.com", + template (omit) EUICCInfo1 euiccInfo1 := ts_EUICCInfo1) := { initiateAuthenticationRequestEsipa := { euiccChallenge := euiccChallenge, - smdpAddress := omit, - euiccInfo1 := omit + smdpAddress := smdpAddress, + euiccInfo1 := euiccInfo1 } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36647?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I97aa039810ad9fffea4226254fa675fd24647de1 Gerrit-Change-Number: 36647 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 weeks, 2 days

1
0
0 0

[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd

by dexter

Attention is currently required from: laforge, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email ) Change subject: IPAd_Tests: add testsuite for an IPAd ...................................................................... Patch Set 9: (1 comment) This change is ready for review. Patchset: PS9: Thanks for reviewing. I have only changed a few comments and removed some deleted files that easyrsa had created. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Gerrit-Change-Number: 36229 Gerrit-PatchSet: 9 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Apr 2024 10:07:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 weeks, 2 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: RSPDefinitions: add separate template for CtxParams1

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36673?usp=email ) Change subject: RSPDefinitions: add separate template for CtxParams1 ...................................................................... RSPDefinitions: add separate template for CtxParams1 Fields of type CtxParams1 are used in other messages too, so it might be helpful to add a separate template for them. Related: SYS#6824 Change-Id: Iba6c3780f9f3aec5742d53b3bd7b0c0392b25761 --- M library/euicc/RSPDefinitions_Templates.ttcn 1 file changed, 68 insertions(+), 52 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/73/36673/1 diff --git a/library/euicc/RSPDefinitions_Templates.ttcn b/library/euicc/RSPDefinitions_Templates.ttcn index 7c1707d..ae1ea78 100644 --- a/library/euicc/RSPDefinitions_Templates.ttcn +++ b/library/euicc/RSPDefinitions_Templates.ttcn @@ -93,6 +93,59 @@ serverChallenge := serverChallenge } +template (present) CtxParams1 tr_ctxParams1 := { + ctxParamsForCommonAuthentication := { + matchingId := *, + deviceInfo := { + tac := ?, + deviceCapabilities := { + gsmSupportedRelease := *, + utranSupportedRelease := *, + cdma2000onexSupportedRelease := *, + cdma2000hrpdSupportedRelease := *, + cdma2000ehrpdSupportedRelease := *, + eutranEpcSupportedRelease := *, + contactlessSupportedRelease := *, + rspCrlSupportedVersion := *, + nrEpcSupportedRelease := *, + nr5gcSupportedRelease := *, + eutran5gcSupportedRelease := *, + lpaSvn := *, + catSupportedClasses := *, + euiccFormFactorType := *, + deviceAdditionalFeatureSupport := * + }, + imei := * + } + } +} +template (value) CtxParams1 ts_ctxParams1 := { + ctxParamsForCommonAuthentication := { + matchingId := omit, + deviceInfo := { + tac := '12345678'O, + deviceCapabilities := { + gsmSupportedRelease := omit, + utranSupportedRelease := omit, + cdma2000onexSupportedRelease := omit, + cdma2000hrpdSupportedRelease := omit, + cdma2000ehrpdSupportedRelease := omit, + eutranEpcSupportedRelease := omit, + contactlessSupportedRelease := omit, + rspCrlSupportedVersion := omit, + nrEpcSupportedRelease := omit, + nr5gcSupportedRelease := omit, + eutran5gcSupportedRelease := omit, + lpaSvn := omit, + catSupportedClasses := omit, + euiccFormFactorType := omit, + deviceAdditionalFeatureSupport := omit + }, + imei := omit + } + } +} + /* GSMA SGP.22, section 2.5.6 */ template (present) ProfileInstallationResult tr_profileInstallationResult := { @@ -481,32 +534,7 @@ serverAddress := ?, serverChallenge := ?, euiccInfo2 := ?, - ctxParams1 := { - ctxParamsForCommonAuthentication := { - matchingId := *, - deviceInfo := { - tac := ?, - deviceCapabilities := { - gsmSupportedRelease := *, - utranSupportedRelease := *, - cdma2000onexSupportedRelease := *, - cdma2000hrpdSupportedRelease := *, - cdma2000ehrpdSupportedRelease := *, - eutranEpcSupportedRelease := *, - contactlessSupportedRelease := *, - rspCrlSupportedVersion := *, - nrEpcSupportedRelease := *, - nr5gcSupportedRelease := *, - eutran5gcSupportedRelease := *, - lpaSvn := *, - catSupportedClasses := *, - euiccFormFactorType := *, - deviceAdditionalFeatureSupport := * - }, - imei := * - } - } - } + ctxParams1 := tr_ctxParams1 }, euiccSignature1 := ?, euiccCertificate := ?, @@ -521,32 +549,7 @@ serverAddress := "smdp.example.com", serverChallenge := '01020304050607080910111213141516'O, euiccInfo2 := ts_EUICCInfo2, - ctxParams1 := { - ctxParamsForCommonAuthentication := { - matchingId := omit, - deviceInfo := { - tac := '12345678'O, - deviceCapabilities := { - gsmSupportedRelease := omit, - utranSupportedRelease := omit, - cdma2000onexSupportedRelease := omit, - cdma2000hrpdSupportedRelease := omit, - cdma2000ehrpdSupportedRelease := omit, - eutranEpcSupportedRelease := omit, - contactlessSupportedRelease := omit, - rspCrlSupportedVersion := omit, - nrEpcSupportedRelease := omit, - nr5gcSupportedRelease := omit, - eutran5gcSupportedRelease := omit, - lpaSvn := omit, - catSupportedClasses := omit, - euiccFormFactorType := omit, - deviceAdditionalFeatureSupport := omit - }, - imei := omit - } - } - } + ctxParams1 := ts_ctxParams1 }, euiccSignature1 := '12345678'O, euiccCertificate := ts_cert_euicc_nist, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36673?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iba6c3780f9f3aec5742d53b3bd7b0c0392b25761 Gerrit-Change-Number: 36673 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 weeks, 2 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: RSPDefinitions: add defaults values to ts_authenticateClientResponseEs9

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36674?usp=email ) Change subject: RSPDefinitions: add defaults values to ts_authenticateClientResponseEs9 ...................................................................... RSPDefinitions: add defaults values to ts_authenticateClientResponseEs9 The template ts_authenticateClientResponseEs9 has no default values, let's add some default values to make it easier to use Related: SYS#6824 Change-Id: I07d942a58a3c1c29c37fcaa50d3a274ce8b026bc --- M library/euicc/RSPDefinitions_Templates.ttcn 1 file changed, 58 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/74/36674/1 diff --git a/library/euicc/RSPDefinitions_Templates.ttcn b/library/euicc/RSPDefinitions_Templates.ttcn index ae1ea78..9e64083 100644 --- a/library/euicc/RSPDefinitions_Templates.ttcn +++ b/library/euicc/RSPDefinitions_Templates.ttcn @@ -146,6 +146,46 @@ } } +template (present) StoreMetadataRequest tr_storeMetadataRequest := { + iccid := ?, + serviceProviderName := ?, + profileName := ?, + iconType := *, + icon := *, + profileClass := ?, + notificationConfigurationInfo := *, + profileOwner := *, + profilePolicyRules := *, + serviceSpecificDataStoredInEuicc := *, + serviceSpecificDataNotStoredInEuicc := * +} +template (value) StoreMetadataRequest ts_storeMetadataRequest := { + iccid := '123456789ABCDEFFAAAA'O, + serviceProviderName := "testsuite", + profileName := "testprofile", + iconType := omit, + icon := omit, + profileClass := 2, /* operational */ + notificationConfigurationInfo := omit, + profileOwner := omit, + profilePolicyRules := omit, + serviceSpecificDataStoredInEuicc := omit, + serviceSpecificDataNotStoredInEuicc := omit +} + +template (present) SmdpSigned2 tr_smdpSigned2(template (present) octetstring transactionId := ?, + template (present) boolean ccRequiredFlag := ?) := { + transactionId := transactionId, + ccRequiredFlag := ccRequiredFlag, + bppEuiccOtpk := ? +} +template (value) SmdpSigned2 ts_smdpSigned2(template (value) octetstring transactionId := 'ABCDEF'O, + template (value) boolean ccRequiredFlag := false) := { + transactionId := transactionId, + ccRequiredFlag := ccRequiredFlag, + bppEuiccOtpk := omit +} + /* GSMA SGP.22, section 2.5.6 */ template (present) ProfileInstallationResult tr_profileInstallationResult := { @@ -310,11 +350,11 @@ } } template (value) RemoteProfileProvisioningResponse -ts_authenticateClientResponseEs9(template (value) octetstring transactionId, - template (value) StoreMetadataRequest profileMetaData, - template (value) SmdpSigned2 smdpSigned2, - template (value) octetstring smdpSignature2, - template (value) Certificate smdpCertificate) := { +ts_authenticateClientResponseEs9(template (value) octetstring transactionId := 'ABCDEF'O, + template (value) StoreMetadataRequest profileMetaData := ts_storeMetadataRequest, + template (value) SmdpSigned2 smdpSigned2 := ts_smdpSigned2, + template (value) octetstring smdpSignature2 := 'BBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB'O, + template (value) Certificate smdpCertificate := ts_cert_s_sm_dpauth_nist) := { authenticateClientResponseEs9 := { authenticateClientOk := { transactionId := transactionId, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36674?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I07d942a58a3c1c29c37fcaa50d3a274ce8b026bc Gerrit-Change-Number: 36674 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 weeks, 2 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: SGP32Definitions: add ts template for authenticateClientRequestEsipa

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36675?usp=email ) Change subject: SGP32Definitions: add ts template for authenticateClientRequestEsipa ...................................................................... SGP32Definitions: add ts template for authenticateClientRequestEsipa The template ts_authenticateClientRequestEsipa is still missing, let's add one. Related: SYS#6824 Change-Id: I9490a2ee59a89511876bb1055a056a43fbf172bb --- M library/euicc/RSPDefinitions_Templates.ttcn M library/euicc/SGP32Definitions_Templates.ttcn 2 files changed, 50 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/75/36675/1 diff --git a/library/euicc/RSPDefinitions_Templates.ttcn b/library/euicc/RSPDefinitions_Templates.ttcn index 9e64083..7e0884f 100644 --- a/library/euicc/RSPDefinitions_Templates.ttcn +++ b/library/euicc/RSPDefinitions_Templates.ttcn @@ -146,6 +146,29 @@ } } +template (present) EuiccSigned1 tr_euiccSigned1(template (present) octetstring transactionId := ?, + template (present) universal charstring serverAddress := ?, + template (present) octetstring serverChallenge := ?, + template (present) EUICCInfo2 euiccInfo2 := ?, + template (present) CtxParams1 ctxParams1 := ?) := { + transactionId := transactionId, + serverAddress := serverAddress, + serverChallenge := serverChallenge, + euiccInfo2 := euiccInfo2, + ctxParams1 := ctxParams1 +} +template (value) EuiccSigned1 ts_euiccSigned1(template (value) octetstring transactionId := 'ABCDEF'O, + template (value) universal charstring serverAddress := "smdp.example.com", + template (value) octetstring serverChallenge := '01020304050607080910111213141516'O, + template (value) EUICCInfo2 euiccInfo2 := ts_EUICCInfo2, + template (value) CtxParams1 ctxParams1 := ts_ctxParams1) := { + transactionId := transactionId, + serverAddress := serverAddress, + serverChallenge := serverChallenge, + euiccInfo2 := euiccInfo2, + ctxParams1 := ctxParams1 +} + template (present) StoreMetadataRequest tr_storeMetadataRequest := { iccid := ?, serviceProviderName := ?, diff --git a/library/euicc/SGP32Definitions_Templates.ttcn b/library/euicc/SGP32Definitions_Templates.ttcn index 98a2bba..26ded29 100644 --- a/library/euicc/SGP32Definitions_Templates.ttcn +++ b/library/euicc/SGP32Definitions_Templates.ttcn @@ -87,7 +87,20 @@ } } } -/* TODO: create coresponding ts_ template */ +template (value) EsipaMessageFromIpaToEim +ts_authenticateClientRequestEsipa(template (value) octetstring transactionId := 'ABCDEF'O) := { + authenticateClientRequestEsipa := { + transactionId := transactionId, + authenticateServerResponse := { + authenticateResponseOk := { + euiccSigned1 := ts_euiccSigned1, + euiccSignature1 := '1234567890'O, + euiccCertificate := ts_cert_eum_nist, + eumCertificate := ts_cert_s_sm_dpauth_nist + } + } + } +} /* GSMA SGP.32, section 6.3.2.2 */ template (present) EsipaMessageFromEimToIpa -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36675?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9490a2ee59a89511876bb1055a056a43fbf172bb Gerrit-Change-Number: 36675 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 weeks, 2 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: improve ts_initiateAuthenticationRequestE...

by dexter

Attention is currently required from: dexter. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36647?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: SGP32Definitions_Templates: improve ts_initiateAuthenticationRequestEsipa ...................................................................... SGP32Definitions_Templates: improve ts_initiateAuthenticationRequestEsipa The template ts_initiateAuthenticationRequestEsipa has a field for smdpAddress and euiccInfo1. Those fields are optional fields, but they still play a central role in the protocol, so that they are effectively mandatory. Let's make the fields available to the template user and populate them with meaningful default values. Related: SYS#6824 Change-Id: I97aa039810ad9fffea4226254fa675fd24647de1 --- M library/euicc/SGP32Definitions_Templates.ttcn 1 file changed, 20 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/47/36647/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36647?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I97aa039810ad9fffea4226254fa675fd24647de1 Gerrit-Change-Number: 36647 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 weeks, 2 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: add support for binary messages

by dexter

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36645?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: HTTP_Adapter: add support for binary messages ...................................................................... HTTP_Adapter: add support for binary messages The HTTP_Adapter currently only supports text only HTTP messages. However, the HTTPmsg testport API also has a way to deal with binary HTTP messages. Related: SYS#6824 Change-Id: I18340f19ed462bf80af683dc9f2831b602f4bdf7 --- M library/HTTP_Adapter.ttcn 1 file changed, 76 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/45/36645/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36645?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I18340f19ed462bf80af683dc9f2831b602f4bdf7 Gerrit-Change-Number: 36645 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 weeks, 2 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: add support for binary messages

by dexter

Attention is currently required from: laforge, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36645?usp=email ) Change subject: HTTP_Adapter: add support for binary messages ...................................................................... Patch Set 2: (1 comment) File library/HTTP_Adapter.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36645/comment/b6ddf3d8_d8ce… PS1, Line 93: if (not istemplatekind(binary_body, "omit")) { > else if Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36645?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I18340f19ed462bf80af683dc9f2831b602f4bdf7 Gerrit-Change-Number: 36645 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Apr 2024 10:04:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 weeks, 2 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: HTTP_Adaptor: allow keeping an HTTP client connection

by dexter

Attention is currently required from: laforge, osmith. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36646?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by osmith, Verified-1 by Jenkins Builder Change subject: HTTP_Adaptor: allow keeping an HTTP client connection ...................................................................... HTTP_Adaptor: allow keeping an HTTP client connection At the moment the HTTP_Adaptor automatically creates a new connection, performs the HTTP request and closes the connection again. This means the connection lives only for a single request. Let's add some flexibility so that we can perform multiple consecutive requests through the same connection. Change-Id: Ic6994c504143820dde498c1a2bad2ad6a523dd70 Related: SYS#6824 --- M library/HTTP_Adapter.ttcn 1 file changed, 78 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/46/36646/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36646?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic6994c504143820dde498c1a2bad2ad6a523dd70 Gerrit-Change-Number: 36646 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 weeks, 2 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: RSPDefinitions: add separate template for serverSigned1

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36671?usp=email ) Change subject: RSPDefinitions: add separate template for serverSigned1 ...................................................................... RSPDefinitions: add separate template for serverSigned1 The field serverSigned1 is used in many messages, so it might be helpful to add a separate template for it. Change-Id: Ic50676ac2863173b72765afc44794a56d03413a5 Related: SYS#6824 --- M library/euicc/RSPDefinitions_EncDec.cc M library/euicc/RSPDefinitions_Templates.ttcn M library/euicc/RSPDefinitions_Types.ttcn M library/euicc/SGP32Definitions_Templates.ttcn 4 files changed, 75 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/71/36671/1 diff --git a/library/euicc/RSPDefinitions_EncDec.cc b/library/euicc/RSPDefinitions_EncDec.cc index 6441201..b46a73c 100644 --- a/library/euicc/RSPDefinitions_EncDec.cc +++ b/library/euicc/RSPDefinitions_EncDec.cc @@ -278,4 +278,38 @@ return msg; } +OCTETSTRING enc__RemoteProfileProvisioningResponse(const RemoteProfileProvisioningResponse &msg) { + TTCN_Buffer buf; + + buf.clear(); + msg.encode(RemoteProfileProvisioningResponse_descr_, buf, TTCN_EncDec::CT_BER, BER_ENCODE_DER); + return OCTETSTRING(buf.get_len(), buf.get_data()); +} + +RemoteProfileProvisioningResponse dec__RemoteProfileProvisioningResponse(const OCTETSTRING &stream) { + TTCN_Buffer buf; + RemoteProfileProvisioningResponse msg; + buf.put_os(stream); + + msg.decode(RemoteProfileProvisioningResponse_descr_, buf, TTCN_EncDec::CT_BER, BER_ACCEPT_ALL); + return msg; +} + +OCTETSTRING enc__RemoteProfileProvisioningRequest(const RemoteProfileProvisioningRequest &msg) { + TTCN_Buffer buf; + + buf.clear(); + msg.encode(RemoteProfileProvisioningRequest_descr_, buf, TTCN_EncDec::CT_BER, BER_ENCODE_DER); + return OCTETSTRING(buf.get_len(), buf.get_data()); +} + +RemoteProfileProvisioningRequest dec__RemoteProfileProvisioningRequest(const OCTETSTRING &stream) { + TTCN_Buffer buf; + RemoteProfileProvisioningRequest msg; + buf.put_os(stream); + + msg.decode(RemoteProfileProvisioningRequest_descr_, buf, TTCN_EncDec::CT_BER, BER_ACCEPT_ALL); + return msg; +} + } diff --git a/library/euicc/RSPDefinitions_Templates.ttcn b/library/euicc/RSPDefinitions_Templates.ttcn index 86cdb0c..52e1788 100644 --- a/library/euicc/RSPDefinitions_Templates.ttcn +++ b/library/euicc/RSPDefinitions_Templates.ttcn @@ -74,6 +74,25 @@ '515151515151515151515151515151515151515151515151515151515151515151515151515151515151515151515151515151515151515151515151'O} } +template (present) ServerSigned1 tr_serverSigned1(template (present) octetstring transactionId := ?, + template (present) octetstring euiccChallenge := ?, + template (present) universal charstring serverAddress := ?, + template (present) octetstring serverChallenge := ?) := { + transactionId := transactionId, + euiccChallenge := euiccChallenge, + serverAddress := serverAddress, + serverChallenge := serverChallenge +} +template (value) ServerSigned1 ts_serverSigned1(template (value) octetstring transactionId := 'ABCDEF'O, + template (value) octetstring euiccChallenge := '00112233445566778899AABBCCDDEEFF'O, + template (value) universal charstring serverAddress := "smdp.example.com", + template (value) octetstring serverChallenge := '01020304050607080910111213141516'O) := { + transactionId := transactionId, + euiccChallenge := euiccChallenge, + serverAddress := serverAddress, + serverChallenge := serverChallenge +} + /* GSMA SGP.22, section 2.5.6 */ template (present) ProfileInstallationResult tr_profileInstallationResult := { @@ -576,4 +595,4 @@ eidValue := eidValue } -} \ No newline at end of file +} diff --git a/library/euicc/RSPDefinitions_Types.ttcn b/library/euicc/RSPDefinitions_Types.ttcn index b031aa3..5bb3925 100644 --- a/library/euicc/RSPDefinitions_Types.ttcn +++ b/library/euicc/RSPDefinitions_Types.ttcn @@ -51,4 +51,10 @@ external function dec_SmdpSigned2(in octetstring stream) return SmdpSigned2; external function enc_SmdpSigned2(in SmdpSigned2 msg) return octetstring; +external function dec_RemoteProfileProvisioningResponse(in octetstring stream) return RemoteProfileProvisioningResponse; +external function enc_RemoteProfileProvisioningResponse(in RemoteProfileProvisioningResponse msg) return octetstring; + +external function dec_RemoteProfileProvisioningRequest(in octetstring stream) return RemoteProfileProvisioningRequest; +external function enc_RemoteProfileProvisioningRequest(in RemoteProfileProvisioningRequest msg) return octetstring; + } diff --git a/library/euicc/SGP32Definitions_Templates.ttcn b/library/euicc/SGP32Definitions_Templates.ttcn index 86c2055..98a2bba 100644 --- a/library/euicc/SGP32Definitions_Templates.ttcn +++ b/library/euicc/SGP32Definitions_Templates.ttcn @@ -28,12 +28,7 @@ initiateAuthenticationResponseEsipa := { initiateAuthenticationOkEsipa := { transactionId := *, - serverSigned1 := { - transactionId := ?, - euiccChallenge := euiccChallenge, - serverAddress := serverAddress, - serverChallenge := ? - }, + serverSigned1 := tr_serverSigned1(euiccChallenge := euiccChallenge, serverAddress := serverAddress), serverSignature1 := ?, euiccCiPKIdToBeUsed := ?, serverCertificate := ?, @@ -49,12 +44,7 @@ initiateAuthenticationResponseEsipa := { initiateAuthenticationOkEsipa := { transactionId := omit, - serverSigned1 := { - transactionId := 'ABCDEF'O, - euiccChallenge := euiccChallenge, - serverAddress := "smdp.example.com", - serverChallenge := '01020304050607080910111213141516'O - }, + serverSigned1 := ts_serverSigned1(euiccChallenge := euiccChallenge, serverAddress := serverAddress), serverSignature1 := '01020304'O, euiccCiPKIdToBeUsed := 'F54172BDF98A95D65CBEB88A38A1C11D800A85C3'O, /* NIST */ serverCertificate := ts_cert_s_sm_dpauth_nist, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36671?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic50676ac2863173b72765afc44794a56d03413a5 Gerrit-Change-Number: 36671 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 weeks, 2 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: HTTP_Adaptor: allow keeping an HTTP client connection

by dexter

Attention is currently required from: laforge, osmith. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36646?usp=email ) Change subject: HTTP_Adaptor: allow keeping an HTTP client connection ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36646/comment/8b62e7e7_6c86… PS1, Line 9: At the moment the HTTP_Adaptor automatically creates a new connection, performs > (if you break lines at 72 characters max - except for error/log messages - it wraps properly in gerr […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36646?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic6994c504143820dde498c1a2bad2ad6a523dd70 Gerrit-Change-Number: 36646 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 30 Apr 2024 10:04:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

2 weeks, 2 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: RSPDefinitions: add defaults for initiateAuthenticationResponse/Request

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36672?usp=email ) Change subject: RSPDefinitions: add defaults for initiateAuthenticationResponse/Request ...................................................................... RSPDefinitions: add defaults for initiateAuthenticationResponse/Request Related: SYS#6824 Change-Id: I3842569f36dfb94e61afffaa03353b552e001c72 --- M library/euicc/RSPDefinitions_Templates.ttcn 1 file changed, 18 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/72/36672/1 diff --git a/library/euicc/RSPDefinitions_Templates.ttcn b/library/euicc/RSPDefinitions_Templates.ttcn index 52e1788..7c1707d 100644 --- a/library/euicc/RSPDefinitions_Templates.ttcn +++ b/library/euicc/RSPDefinitions_Templates.ttcn @@ -143,9 +143,9 @@ } } template (value) RemoteProfileProvisioningRequest -ts_initiateAuthenticationRequest(template (value) octetstring euiccChallenge, - template (value) charstring smdpAddress, - template (value) EUICCInfo1 euiccInfo1) := { +ts_initiateAuthenticationRequest(template (value) octetstring euiccChallenge := '00112233445566778899aabbccddeeff'O, + template (value) charstring smdpAddress := "smdp.example.com", + template (value) EUICCInfo1 euiccInfo1 := ts_EUICCInfo1) := { initiateAuthenticationRequest := { euiccChallenge := euiccChallenge, smdpAddress := smdpAddress, @@ -169,11 +169,11 @@ } } template (value) RemoteProfileProvisioningResponse -ts_initiateAuthenticationResponse(template (value) octetstring transactionId, - template (value) ServerSigned1 serverSigned1, - template (value) octetstring serverSignature1, - template (value) SubjectKeyIdentifier euiccCiPKIdToBeUsed, - template (value) Certificate serverCertificate) := { +ts_initiateAuthenticationResponse(template (value) octetstring transactionId := 'ABCDEF'O, + template (value) ServerSigned1 serverSigned1 := ts_serverSigned1, + template (value) octetstring serverSignature1 := '01020304'O, + template (value) SubjectKeyIdentifier euiccCiPKIdToBeUsed := 'F54172BDF98A95D65CBEB88A38A1C11D800A85C3'O, /* NIST */ + template (value) Certificate serverCertificate := ts_cert_s_sm_dpauth_nist) := { initiateAuthenticationResponse := { initiateAuthenticationOk := { transactionId := transactionId, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36672?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3842569f36dfb94e61afffaa03353b552e001c72 Gerrit-Change-Number: 36672 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 weeks, 2 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: bsc: make use of IpaUnitId codec

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36612?usp=email ) Change subject: bsc: make use of IpaUnitId codec ...................................................................... bsc: make use of IpaUnitId codec Change-Id: Iaf38fdb0a1c3ada5af6f1a05c7a9008e4eae0727 --- M bsc/BSC_Tests.ttcn 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 5e4ebbc..8dcff83 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -981,7 +981,7 @@ clnt.vc_IPA := IPA_Emulation_CT.create(clnt.id & "-IPA") alive; clnt.ccm_pars := c_IPA_default_ccm_pars; clnt.ccm_pars.name := "Osmocom TTCN-3 BTS Simulator"; - clnt.ccm_pars.unit_id := int2str(1234 + idx.bts) & "/0/" & int2str(idx.trx); + clnt.ccm_pars.unit_id := enc_IpaUnitId({1234 + idx.bts, 0, idx.trx}); if (handler_mode) { clnt.vc_RSL := RSL_Emulation_CT.create(clnt.id & "-RSL") alive; connect(clnt.vc_RSL:CCHAN_PT, self:RSL_CCHAN[idx.bts]); @@ -3946,7 +3946,7 @@ client.vc_IPA := IPA_Emulation_CT.create(client.id & "-IPA") alive; client.ccm_pars := c_IPA_default_ccm_pars; client.ccm_pars.name := "Osmocom TTCN-3 BTS Simulator"; - client.ccm_pars.unit_id := "99/0/0"; /* value which is unknown at BTS */ + client.ccm_pars.unit_id := enc_IpaUnitId({99, 0, 0}); /* value which is unknown at BTS */ f_ipa_ctrl_start_client(mp_bsc_ip, mp_bsc_ctrl_port); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36612?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaf38fdb0a1c3ada5af6f1a05c7a9008e4eae0727 Gerrit-Change-Number: 36612 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 weeks, 2 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: bsc: make use of IpaUnitId codec

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36612?usp=email ) Change subject: bsc: make use of IpaUnitId codec ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36612?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaf38fdb0a1c3ada5af6f1a05c7a9008e4eae0727 Gerrit-Change-Number: 36612 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Apr 2024 09:22:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 weeks, 2 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library/RSL_Emulation: make use of IpaUnitId codec

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36611?usp=email ) Change subject: library/RSL_Emulation: make use of IpaUnitId codec ...................................................................... library/RSL_Emulation: make use of IpaUnitId codec Change-Id: I20e1ac35707affc6aab60397a22e33fe2bd1106e --- M library/RSL_Emulation.ttcn 1 file changed, 19 insertions(+), 20 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/library/RSL_Emulation.ttcn b/library/RSL_Emulation.ttcn index 891e565..17e35ab 100644 --- a/library/RSL_Emulation.ttcn +++ b/library/RSL_Emulation.ttcn @@ -370,9 +370,7 @@ private function f_trx_conn_map_register(integer conn_id, in IpaCcmIdResp id_resp) runs on RSL_Emulation_CT return IpaStreamId { - var template charstring unit_id_fmt := pattern "(\d+)/(\d+)/(\d+)"; - var charstring unit_id; - var integer trx_nr; + var IpaUnitId unit_id; var integer idx; /* Check if we have room for a new connection */ @@ -386,29 +384,21 @@ testcase.stop("IPA IDENTITY RESPONSE contains no unit-id"); } - /* Make sure that IPA unit-id is valid */ - unit_id := oct2char(id_resp[idx].data); - if (not match(unit_id, unit_id_fmt)) { - testcase.stop("IPA unit-id has unknown/unexpected format"); - } + /* Parse IPA unit-id */ + unit_id := dec_IpaUnitId(oct2char(id_resp[idx].data)); - /* Parse transceiver number (site/bts/trx). - * TODO: implement and use declaratice types. */ - unit_id := regexp(unit_id, unit_id_fmt, 2); - trx_nr := str2int(unit_id); - - if (trx_nr >= sizeof(TrxConnMap)) { - testcase.stop("Transceiver #", trx_nr, " does not fit"); - } else if (TrxConnMap[trx_nr] != -1) { - testcase.stop("Transceiver #", trx_nr, " is already connected?!?"); + if (unit_id.trx_id >= sizeof(TrxConnMap)) { + testcase.stop("Transceiver #", unit_id.trx_id, " does not fit"); + } else if (TrxConnMap[unit_id.trx_id] != -1) { + testcase.stop("Transceiver #", unit_id.trx_id, " is already connected?!?"); } /* Finally, store the connection ID */ - log("Mapped TRX#", trx_nr, " to TCP/IP conn_id=", conn_id); - TrxConnMap[trx_nr] := conn_id; + log("Mapped TRX#", unit_id.trx_id, " to TCP/IP conn_id=", conn_id); + TrxConnMap[unit_id.trx_id] := conn_id; TrxConnNum := TrxConnNum + 1; - return f_streamId_by_trx(trx_nr); + return f_streamId_by_trx(unit_id.trx_id); } private function f_trx_conn_map_unregister(integer conn_id) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36611?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I20e1ac35707affc6aab60397a22e33fe2bd1106e Gerrit-Change-Number: 36611 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 weeks, 2 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library/RSL_Emulation: make use of IpaUnitId codec

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36611?usp=email ) Change subject: library/RSL_Emulation: make use of IpaUnitId codec ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36611?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I20e1ac35707affc6aab60397a22e33fe2bd1106e Gerrit-Change-Number: 36611 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Apr 2024 09:21:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 weeks, 2 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library/IPA_Types: add codec for IPA UnitID

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26458?usp=email ) Change subject: library/IPA_Types: add codec for IPA UnitID ...................................................................... library/IPA_Types: add codec for IPA UnitID Change-Id: I68eb0d9e28bbf5d2d8ffe916aae5a66a0fdb9bd0 --- M library/IPA_Types.ttcn 1 file changed, 41 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/IPA_Types.ttcn b/library/IPA_Types.ttcn index 95623ef..fc729fb 100644 --- a/library/IPA_Types.ttcn +++ b/library/IPA_Types.ttcn @@ -132,6 +132,38 @@ extension "decode(RAW)" } +/* Example: 1234/0/0 (site_id=1234, bts_id=0, trx_id=0) */ +type record IpaUnitId { + integer site_id, + integer bts_id, + integer trx_id +} with { + encode "TEXT" + variant "SEPARATOR('/')" + /* workaround for https://gitlab.eclipse.org/eclipse/titan/titan.core/-/issues/725 */ + variant (trx_id) "TEXT_CODING(,,'\d+')" +}; + +external function enc_IpaUnitId(in IpaUnitId unit_id) return charstring + with { extension "prototype(convert) encode(TEXT)" } +external function dec_IpaUnitId(in charstring stream) return IpaUnitId + with { extension "prototype(convert) decode(TEXT)" } + +template (value) IpaUnitId ts_IpaUnitId(integer site_id := 1234, + integer bts_id := 0, + integer trx_id := 0) := { + site_id := site_id, + bts_id := bts_id, + trx_id := trx_id +}; +template (present) IpaUnitId tr_IpaUnitId(template (present) integer site_id := ?, + template (present) integer bts_id := ?, + template (present) integer trx_id := ?) := { + site_id := site_id, + bts_id := bts_id, + trx_id := trx_id +}; + /* Finds an IE with the given tag in IPA IDENTITY RESPONSE. * Returns index of an IE if found, -1 otherwise. */ function f_ipa_id_resp_find_ie(in IpaCcmIdResp resp, IpaCcmIdTag tag) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26458?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I68eb0d9e28bbf5d2d8ffe916aae5a66a0fdb9bd0 Gerrit-Change-Number: 26458 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 weeks, 2 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library/IPA_Types: add codec for IPA UnitID

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26458?usp=email ) Change subject: library/IPA_Types: add codec for IPA UnitID ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26458?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I68eb0d9e28bbf5d2d8ffe916aae5a66a0fdb9bd0 Gerrit-Change-Number: 26458 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Apr 2024 08:49:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 weeks, 2 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library/IPA_Types: WIP codec for IPA UnitID (site/bts/trx)

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26458?usp=email ) Change subject: library/IPA_Types: WIP codec for IPA UnitID (site/bts/trx) ...................................................................... Patch Set 3: (1 comment) File library/IPA_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26458/comment/96dd60e7_53a1… PS1, Line 172: log("Dec: ", dec_IpaUnitId(unit_id_enc & "\00")); > https://gitlab.eclipse.org/eclipse/titan/titan. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26458?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I68eb0d9e28bbf5d2d8ffe916aae5a66a0fdb9bd0 Gerrit-Change-Number: 26458 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Apr 2024 08:48:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 weeks, 2 days

1
0
0 0

[M] Change in osmo-upf[master]: .deb/.rpm: various fixes related to non-root

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/36666?usp=email ) Change subject: .deb/.rpm: various fixes related to non-root ...................................................................... .deb/.rpm: various fixes related to non-root * Explicitly chown /var/lib/osmocom to osmocom:osmocom, instead of relying on systemd to do it when the service starts up. This does not work with the systemd versions in debian 10 and almalinux 8. * deb: Use "useradd" instead of the interactive "adduser" perl script from Debian. This makes it consistent with how we do it in rpm, and avoids the dependency on "adduser". * deb: Consistently use tabs through the file, instead of mixing tabs and spaces. * deb: Remove support for the "dpkg-statoverride --list" logic. This seems to be a rather obscure feature to override permissions for certain files or directories, for which it does not seem to be a good idea to make the postinst script less maintainable. Something similar can be achieved by using your own Osmocom config file in a different path with different permissions. Related: OS#4107 Change-Id: Ib129217f6aff713d1d0e7aa831b4b54823e9bade --- M contrib/osmo-upf.spec.in M debian/control M debian/postinst 3 files changed, 50 insertions(+), 32 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/contrib/osmo-upf.spec.in b/contrib/osmo-upf.spec.in index fb8438c..bc6c5ed 100644 --- a/contrib/osmo-upf.spec.in +++ b/contrib/osmo-upf.spec.in @@ -84,6 +84,8 @@ chmod 0660 /etc/osmocom/osmo-upf.cfg chown root:osmocom /etc/osmocom chmod 2775 /etc/osmocom +mkdir -p /var/lib/osmocom +chown -R osmocom:osmocom /var/lib/osmocom %check make %{?_smp_mflags} check || (find . -name testsuite.log -exec cat {} +) diff --git a/debian/control b/debian/control index 7681c46..5c26faf 100644 --- a/debian/control +++ b/debian/control @@ -25,7 +25,7 @@ Package: osmo-upf Architecture: any Multi-Arch: foreign -Depends: ${misc:Depends}, ${shlibs:Depends}, adduser +Depends: ${misc:Depends}, ${shlibs:Depends} Description: OsmoUPF: Osmocom User Plane Function Package: osmo-upf-dbg diff --git a/debian/postinst b/debian/postinst index a84d9b2..4310e7e 100755 --- a/debian/postinst +++ b/debian/postinst @@ -1,37 +1,28 @@ #!/bin/sh -e -# Create 'osmocom' user and group (if it doesn't exist yet) and adjust permissions -# of directories which are not automatically adjusted by systemd from previous (root-owned) -# install. - -# N. B: the user is intentionally NOT removed during package uninstall: -# see https://wiki.debian.org/AccountHandlingInMaintainerScripts for reasoning. -chperms() { - # chperms <user> <group> <perms> <file> - if ! OVERRIDE=`dpkg-statoverride --list $4 2>&1`; then - if [ -e $4 ]; then - chown $1:$2 $4 - chmod $3 $4 - fi - fi -} - case "$1" in - configure) - if ! getent passwd osmocom > /dev/null; then - adduser --quiet \ - --system \ - --group \ - --no-create-home \ - --disabled-password \ - --home /var/lib/osmocom \ - --gecos "Open Source Mobile Communications" \ - osmocom - fi -# Set permissions according to https://www.debian.org/doc/debian-policy/ch-files.html#s-permissions-owners - chperms osmocom osmocom 0660 /etc/osmocom/osmo-upf.cfg - chperms root osmocom 2775 /etc/osmocom + configure) + # Create the osmocom group and user (if it doesn't exist yet) + if ! getent group osmocom >/dev/null; then + groupadd --system osmocom + fi + if ! getent passwd osmocom >/dev/null; then + useradd \ + --system \ + --gid osmocom \ + --home-dir /var/lib/osmocom \ + --shell /sbin/nologin \ + --comment "Open Source Mobile Communications" \ + osmocom + fi - ;; + # Fix permissions of previous (root-owned) install (OS#4107) + chown osmocom:osmocom /etc/osmocom/osmo-upf.cfg + chmod 0660 /etc/osmocom/osmo-upf.cfg + chown root:osmocom /etc/osmocom + chmod 2775 /etc/osmocom + mkdir -p /var/lib/osmocom + chown -R osmocom:osmocom /var/lib/osmocom + ;; esac # dh_installdeb(1) will replace this with shell code automatically -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/36666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ib129217f6aff713d1d0e7aa831b4b54823e9bade Gerrit-Change-Number: 36666 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 weeks, 2 days

1
0
0 0

[M] Change in osmo-upf[master]: .deb/.rpm: various fixes related to non-root

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/36666?usp=email ) Change subject: .deb/.rpm: various fixes related to non-root ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/36666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ib129217f6aff713d1d0e7aa831b4b54823e9bade Gerrit-Change-Number: 36666 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Apr 2024 08:48:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 weeks, 2 days

1
0
0 0

[S] Change in osmo-upf[master]: contrib/systemd: AmbientCapabilities=CAP_NET_ADMIN

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/36670?usp=email ) Change subject: contrib/systemd: AmbientCapabilities=CAP_NET_ADMIN ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/36670?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I17b21ad92837ad360d667248f3f002d44251891c Gerrit-Change-Number: 36670 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Apr 2024 08:45:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 weeks, 2 days

1
0
0 0

[M] Change in osmo-upf[master]: .deb/.rpm: various fixes related to non-root

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/36666?usp=email ) Change subject: .deb/.rpm: various fixes related to non-root ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/36666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ib129217f6aff713d1d0e7aa831b4b54823e9bade Gerrit-Change-Number: 36666 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Apr 2024 08:43:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 weeks, 2 days

1
0
0 0

[S] Change in osmo-upf[master]: contrib/systemd: AmbientCapabilities=CAP_NET_ADMIN

by osmith

osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-upf/+/36670?usp=email ) Change subject: contrib/systemd: AmbientCapabilities=CAP_NET_ADMIN ...................................................................... contrib/systemd: AmbientCapabilities=CAP_NET_ADMIN Set CAP_NET_ADMIN so osmo-upf can set up GTP tunends and tunmaps even if running as user. Fix for: Operation not permitted (you must be root) netlink: Error: cache initialization failed: Operation not permitted 20240430095022378 DNFT ERROR error running nft ruleset: rc=-1 ruleset="add table inet osmo-upf { flags owner; };\n" (upf_nft.c:79) 20240430095022378 DNFT ERROR Failed to create nft table "osmo-upf" (upf_nft.c:111) Fixes: OS#6444 Change-Id: I17b21ad92837ad360d667248f3f002d44251891c --- M contrib/systemd/osmo-upf.service 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/70/36670/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/36670?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I17b21ad92837ad360d667248f3f002d44251891c Gerrit-Change-Number: 36670 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

2 weeks, 2 days

1
0
0 0

[S] Change in osmo-upf[master]: contrib/systemd: AmbientCapabilities=CAP_NET_ADMIN

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/36670?usp=email ) Change subject: contrib/systemd: AmbientCapabilities=CAP_NET_ADMIN ...................................................................... contrib/systemd: AmbientCapabilities=CAP_NET_ADMIN Set CAP_NET_ADMIN so osmo-upf can set up GTP tunends and tunmaps even if running as user. Fix for: Operation not permitted (you must be root) netlink: Error: cache initialization failed: Operation not permitted 20240430095022378 DNFT ERROR error running nft ruleset: rc=-1 ruleset="add table inet osmo-upf { flags owner; };\n" (upf_nft.c:79) 20240430095022378 DNFT ERROR Failed to create nft table "osmo-upf" (upf_nft.c:111) Fixes: OS#6444 Change-Id: I17b21ad92837ad360d667248f3f002d44251891c --- M contrib/systemd/osmo-upf.service 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/70/36670/1 diff --git a/contrib/systemd/osmo-upf.service b/contrib/systemd/osmo-upf.service index 93dd84f..7e658d5 100644 --- a/contrib/systemd/osmo-upf.service +++ b/contrib/systemd/osmo-upf.service @@ -12,6 +12,8 @@ Group=osmocom ExecStart=/usr/bin/osmo-upf -c /etc/osmocom/osmo-upf.cfg RestartSec=2 +AmbientCapabilities=CAP_NET_ADMIN + [Install] WantedBy=multi-user.target -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/36670?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I17b21ad92837ad360d667248f3f002d44251891c Gerrit-Change-Number: 36670 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 weeks, 2 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SIP_Emulation: Rename component id

by laforge

Attention is currently required from: fixeria, osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36641?usp=email ) Change subject: SIP_Emulation: Rename component id ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36641/comment/cff515fd_d460… PS1, Line 9: it makes it impossible to reference the : component name under TESTPORT_PARAMETERS > > If renaming stuff & refactoring code is easier for you, then I have nothing to say :D […] I find the discussion a bit bizarre. Yes, spaces in file names require proper quoting. so do many other characters. It's not an insurmountable difficulty, but a basic fact of life in IT ;) Likewise for component names. If there's a way to quote them, then that is no a hack or impossible. It's just how things are done. Patchset: PS1: Sorry, I had written this comment on Apri 26th but apparently not posted it... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36641?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iecefe7d98a5842872f1efc55e013f672186ef1a8 Gerrit-Change-Number: 36641 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Apr 2024 06:10:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 weeks, 2 days

1
0
0 0

[S] Change in libosmocore[master]: gsm0808: add knowledge of TW-TS-003 BSSMAP IE

by falconia

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/36669?usp=email ) Change subject: gsm0808: add knowledge of TW-TS-003 BSSMAP IE ...................................................................... gsm0808: add knowledge of TW-TS-003 BSSMAP IE Themyscira Wireless Technical Specification TW-TS-003 adds a non-standard IE to GSM 08.08 BSSMAP whose purpose is to signal the use of enhanced RTP payload formats that go against the stipulations of TS 26.102 (referenced from 48.103 for AoIP), but allow an IP-based GSM network implementation to mimic the workings of TDM-based GSM more faithfully. Spec reference: https://www.freecalypso.org/specs/tw-ts-003-v010001.txt Change-Id: Idd6f1838bdc0cd71a2f6357e9b6d8b8fa4f7c46c --- M include/osmocom/gsm/protocol/gsm_08_08.h M src/gsm/gsm0808.c 2 files changed, 24 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/69/36669/1 diff --git a/include/osmocom/gsm/protocol/gsm_08_08.h b/include/osmocom/gsm/protocol/gsm_08_08.h index 1e211dc..4539656 100644 --- a/include/osmocom/gsm/protocol/gsm_08_08.h +++ b/include/osmocom/gsm/protocol/gsm_08_08.h @@ -332,9 +332,10 @@ GSM0808_IE_PS_REGISTERED_OPERATOR = 0x99, GSM0808_IE_CS_REGISTERED_OPERATOR = 0x9a, - /* Osmocom extensions: */ + /* Osmocom and Themyscira extensions: */ GSM0808_IE_OSMO_OSMUX_SUPPORT = 0xf0, GSM0808_IE_OSMO_OSMUX_CID = 0xf1, + GSM0808_IE_THEMWI_RTP_EXTENSIONS = 0xf2, }; /* 3GPP TS 48.008 3.2.3 Signalling Field Element Coding. diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c index 529dbdf..84618dc 100644 --- a/src/gsm/gsm0808.c +++ b/src/gsm/gsm0808.c @@ -2310,9 +2310,10 @@ [GSM0808_IE_PS_REGISTERED_OPERATOR] = { TLV_TYPE_FIXED, 3 }, [GSM0808_IE_CS_REGISTERED_OPERATOR] = { TLV_TYPE_FIXED, 3 }, - /* Osmocom extensions */ + /* Osmocom and Themyscira extensions */ [GSM0808_IE_OSMO_OSMUX_SUPPORT] = { TLV_TYPE_T }, [GSM0808_IE_OSMO_OSMUX_CID] = { TLV_TYPE_TV }, + [GSM0808_IE_THEMWI_RTP_EXTENSIONS] = { TLV_TYPE_TV }, }, }; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36669?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idd6f1838bdc0cd71a2f6357e9b6d8b8fa4f7c46c Gerrit-Change-Number: 36669 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newchange

2 weeks, 3 days

1
0
0 0

[S] Change in osmo-hnbgw[master]: jenkins.sh: add NFTABLES axis

by neels

Attention is currently required from: neels. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36537?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: jenkins.sh: add NFTABLES axis ...................................................................... jenkins.sh: add NFTABLES axis Related: osmo-ci I9828b70708dbe466c37df6ffb87b04362f14c71c Related: OS#6425 Change-Id: I331cce7b187cf427a5cbffb3aedb17054918bcc8 --- M contrib/jenkins.sh 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/37/36537/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36537?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I331cce7b187cf427a5cbffb3aedb17054918bcc8 Gerrit-Change-Number: 36537 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 weeks, 3 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SIP_Emulation: Rename component id

by pespin

Attention is currently required from: fixeria, laforge, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36641?usp=email ) Change subject: SIP_Emulation: Rename component id ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36641/comment/da9b97f4_4e32… PS1, Line 9: it makes it impossible to reference the : component name under TESTPORT_PARAMETERS > > If renaming stuff & refactoring code is easier for you, then I have nothing to say :D […] @laforge@gnumonks.org inpute welcome here to see if we can merge this. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36641?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iecefe7d98a5842872f1efc55e013f672186ef1a8 Gerrit-Change-Number: 36641 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Apr 2024 21:33:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 weeks, 3 days

1
0
0 0

[M] Change in docker-playground[master]: asterisk-master: Use pjproject from external git repo

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36649?usp=email ) Change subject: asterisk-master: Use pjproject from external git repo ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I'm wondering if we should have this [as a commit] in our forked asterisk. […] That would mean modifying several makefiles to just limit what can be done now by simply cloning whatever repo you want and adding a symlink with a couple extra bash lines. I think it's better like it is now. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36649?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I73f3323db1b6897fc43215578b0a011fdb6909c5 Gerrit-Change-Number: 36649 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 29 Apr 2024 21:32:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 weeks, 3 days

1
0
0 0

[S] Change in dahdi-linux[master]: icE1usb: Use ICE1USB_TX_MODE_TS0_CRC4_E to set E bits automatically

by laforge

Attention is currently required from: tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/36654?usp=email ) Change subject: icE1usb: Use ICE1USB_TX_MODE_TS0_CRC4_E to set E bits automatically ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/36654?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Iea936a6c908ef5e175be3090a8fbcafaeb5a0aed Gerrit-Change-Number: 36654 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Mon, 29 Apr 2024 19:41:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 weeks, 3 days

1
0
0 0

[M] Change in dahdi-linux[master]: icE1usb: Configure the RX mode according to CRC4 mode

by laforge

Attention is currently required from: tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/36655?usp=email ) Change subject: icE1usb: Configure the RX mode according to CRC4 mode ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/36655?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Ic9da7d2a32f9aa9bf5de296dc4885eeaf56b138e Gerrit-Change-Number: 36655 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Mon, 29 Apr 2024 19:40:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-e1d[master]: iCE1usb: Add support to configure CRC4 mode for TX/RX

by laforge

Attention is currently required from: tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/36653?usp=email ) Change subject: iCE1usb: Add support to configure CRC4 mode for TX/RX ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File src/vty.c: https://gerrit.osmocom.org/c/osmo-e1d/+/36653/comment/b6db3d53_7ebb7f0c PS1, Line 434: framing-tx (no-crc4|crc4)", > Done indeed, there are a lot of constraints in the possible/accepted VTY syntax. File src/vty.c: https://gerrit.osmocom.org/c/osmo-e1d/+/36653/comment/6c0146b8_8f41ed33 PS2, Line 465: if (line->intf->drv == E1_DRIVER_USB) { one could check if rx == tx and then use just the "framing" command -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/36653?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I9b627a9617af4ae9ed98214d672c7d0391f801eb Gerrit-Change-Number: 36653 Gerrit-PatchSet: 2 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Mon, 29 Apr 2024 19:40:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: tnt <tnt(a)246tNt.com> Gerrit-MessageType: comment

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-hnodeb[master]: .deb/.rpm: various fixes related to non-root

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/36661?usp=email ) Change subject: .deb/.rpm: various fixes related to non-root ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/36661?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6dd0205fb65d4ad5a79821c111865e67fb293a73 Gerrit-Change-Number: 36661 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Apr 2024 19:39:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-cbc[master]: .deb/.rpm: various fixes related to non-root

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/36658?usp=email ) Change subject: .deb/.rpm: various fixes related to non-root ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/36658?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I6dd0205fb65d4ad5a79821c111865e67fb293a73 Gerrit-Change-Number: 36658 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Apr 2024 19:39:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 weeks, 3 days

1
0
0 0

[M] Change in libosmo-sccp[master]: .deb/.rpm: various fixes related to non-root

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/36656?usp=email ) Change subject: .deb/.rpm: various fixes related to non-root ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/36656?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ie34e7aa65e576cf1742a33530a6f44d2344c39d0 Gerrit-Change-Number: 36656 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Apr 2024 19:38:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-msc[master]: .deb/.rpm: various fixes related to non-root

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36662?usp=email ) Change subject: .deb/.rpm: various fixes related to non-root ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36662?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I406ff0d625b02991d580c8382aa4be04dba45a00 Gerrit-Change-Number: 36662 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Apr 2024 19:38:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-upf[master]: .deb/.rpm: various fixes related to non-root

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/36666?usp=email ) Change subject: .deb/.rpm: various fixes related to non-root ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/36666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ib129217f6aff713d1d0e7aa831b4b54823e9bade Gerrit-Change-Number: 36666 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Apr 2024 19:38:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-sip-connector[master]: .deb/.rpm: various fixes related to non-root

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/36664?usp=email ) Change subject: .deb/.rpm: various fixes related to non-root ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/36664?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ib129217f6aff713d1d0e7aa831b4b54823e9bade Gerrit-Change-Number: 36664 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Apr 2024 19:38:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-smlc[master]: .deb/.rpm: various fixes related to non-root

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/36665?usp=email ) Change subject: .deb/.rpm: various fixes related to non-root ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/36665?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: Ib129217f6aff713d1d0e7aa831b4b54823e9bade Gerrit-Change-Number: 36665 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Apr 2024 19:38:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 weeks, 3 days

1
0
0 0

[S] Change in osmo-ci[master]: ansible/setup-jenkins: install rsync

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36667?usp=email ) Change subject: ansible/setup-jenkins: install rsync ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36667?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic8ffd61fc2c89574085e9c3abbceb554f3c5da6a Gerrit-Change-Number: 36667 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Apr 2024 19:38:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-hnbgw[master]: .deb/.rpm: various fixes related to non-root

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36660?usp=email ) Change subject: .deb/.rpm: various fixes related to non-root ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36660?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I6dd0205fb65d4ad5a79821c111865e67fb293a73 Gerrit-Change-Number: 36660 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Apr 2024 19:38:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-bsc[master]: .deb/.rpm: various fixes related to non-root

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36657?usp=email ) Change subject: .deb/.rpm: various fixes related to non-root ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36657?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie34e7aa65e576cf1742a33530a6f44d2344c39d0 Gerrit-Change-Number: 36657 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Apr 2024 19:38:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-hlr[master]: .deb/.rpm: various fixes related to non-root

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/36659?usp=email ) Change subject: .deb/.rpm: various fixes related to non-root ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/36659?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ib20406dd253f5e8720552e92e9002e45591218fa Gerrit-Change-Number: 36659 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Apr 2024 19:38:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-sgsn[master]: .deb/.rpm: various fixes related to non-root

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/36663?usp=email ) Change subject: .deb/.rpm: various fixes related to non-root ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/36663?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I406ff0d625b02991d580c8382aa4be04dba45a00 Gerrit-Change-Number: 36663 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Apr 2024 19:38:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 weeks, 3 days

1
0
0 0

[S] Change in osmo-ci[master]: ttcn3-bsc-test-io_uring: limit jenkins nodes again

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36668?usp=email ) Change subject: ttcn3-bsc-test-io_uring: limit jenkins nodes again ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36668?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iddf2d47a641998860fd1ef615de976104667c5ab Gerrit-Change-Number: 36668 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Apr 2024 19:37:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 weeks, 3 days

1
0
0 0

2024

2023

2022

gerrit-log April 2024