laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/36036?usp=email )
Change subject: ipa_keepalive: Make FSM a bit less quiet
......................................................................
ipa_keepalive: Make FSM a bit less quiet
Let's make sure we log meaningful log messages whenever an IPA keepalive
FSM is started, stopped or if it times out. This allows the user to
observe whether IPA keepalive is actually enabled (using what timeout),
and also to learn why exactly the connection was dropped.
Change-Id: Iad20b86f893c1036affaf14f978099fa858a0031
Related: SYS#6801
---
M src/input/ipa_keepalive.c
1 file changed, 20 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/36/36036/1
diff --git a/src/input/ipa_keepalive.c b/src/input/ipa_keepalive.c
index 7fc28f1..275fa64 100644
--- a/src/input/ipa_keepalive.c
+++ b/src/input/ipa_keepalive.c
@@ -147,6 +147,7 @@
ifp->params.wait_for_resp, T_PONG_NOT_RECEIVED);
return 0;
case T_PONG_NOT_RECEIVED:
+ LOGPFSML(fi, LOGL_NOTICE, "IPA keep-alive FSM timed out: PONG not received\n");
/* PONG not received within time */
if (ifp->srv_conn)
conn = ifp->srv_conn;
@@ -320,7 +321,10 @@
/*! Start the ping/pong procedure of the IPA Keepalive FSM. */
void ipa_keepalive_fsm_start(struct osmo_fsm_inst *fi)
{
+ struct ipa_fsm_priv *ifp = fi->priv;
OSMO_ASSERT(fi->fsm == &ipa_keepalive_fsm);
+ LOGPFSML(fi, LOGL_INFO, "Starting IPA keep-alive FSM (interval=%u wait=%u)\n",
+ ifp->params.interval, ifp->params.wait_for_resp);
osmo_fsm_inst_dispatch(fi, OSMO_IPA_KA_E_START, NULL);
}
@@ -328,5 +332,6 @@
void ipa_keepalive_fsm_stop(struct osmo_fsm_inst *fi)
{
OSMO_ASSERT(fi->fsm == &ipa_keepalive_fsm);
+ LOGPFSML(fi, LOGL_INFO, "Stopping IPA keep-alive FSM\n");
osmo_fsm_inst_dispatch(fi, OSMO_IPA_KA_E_STOP, NULL);
}
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36036?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Iad20b86f893c1036affaf14f978099fa858a0031
Gerrit-Change-Number: 36036
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36031?usp=email )
Change subject: kernel-gtp: support IPv6 on outer layer
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36031?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I257fff1dcd9d030a7f9ea936b2693a3f13208230
Gerrit-Change-Number: 36031
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Feb 2024 16:11:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36031?usp=email )
Change subject: kernel-gtp: support IPv6 on outer layer
......................................................................
Patch Set 1:
(4 comments)
File gtp/gsn.c:
https://gerrit.osmocom.org/c/osmo-ggsn/+/36031/comment/9f8da66d_47daf4f8
PS1, Line 424: int domain = in46a_to_af(listen);
> can we call it family at some point? I had to fiugre out what "domain" meant here.
Done
https://gerrit.osmocom.org/c/osmo-ggsn/+/36031/comment/4fd38ec8_0e2f286c
PS1, Line 446: addr.sin_len = sizeof(struct addr);
> wrong indentation.
Done
https://gerrit.osmocom.org/c/osmo-ggsn/+/36031/comment/c06f2cf8_41fe7af2
PS1, Line 461: if (bind(*fd, &addr, sizeof(addr)) < 0)
> the bind can be deduplicated by moving it below.
Done
File tests/gtp/Makefile.am:
https://gerrit.osmocom.org/c/osmo-ggsn/+/36031/comment/78e1273a_c962488f
PS1, Line 25: $(top_builddir)/lib/libmisc.a \
> why is this libmisc needed here now?
Because gsn.c and gtp.c use functions from in46a now, not having libmisc.a leads to undefined reference errors.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36031?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I257fff1dcd9d030a7f9ea936b2693a3f13208230
Gerrit-Change-Number: 36031
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Feb 2024 15:24:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ggsn/+/36031?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: kernel-gtp: support IPv6 on outer layer
......................................................................
kernel-gtp: support IPv6 on outer layer
Related: OS#1953, OS#6096
Change-Id: I257fff1dcd9d030a7f9ea936b2693a3f13208230
---
M ggsn/ggsn.c
M gtp/gsn.c
M gtp/gsn.h
M gtp/gtp.c
M lib/in46_addr.c
M lib/in46_addr.h
M sgsnemu/sgsnemu.c
M tests/gtp/Makefile.am
8 files changed, 71 insertions(+), 40 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/31/36031/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36031?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I257fff1dcd9d030a7f9ea936b2693a3f13208230
Gerrit-Change-Number: 36031
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newpatchset
pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36021?usp=email )
Change subject: rebar.lock: Update after dependency fixes/updates
......................................................................
rebar.lock: Update after dependency fixes/updates
This contains 32bit compilation fixes for gen_socket and support to set
tundev iface name in gtp_u_kmod.
Change-Id: Iea501aca2a15df48aaae2672dcb9d39716ea585c
---
M config/sys.config
M rebar.lock
2 files changed, 29 insertions(+), 17 deletions(-)
Approvals:
osmith: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/config/sys.config b/config/sys.config
index 660aded..8ed5ca6 100755
--- a/config/sys.config
+++ b/config/sys.config
@@ -42,20 +42,20 @@
%% ===========================================
{gtp_u_kmod, [
%% grx: Name used to log by the module.
- {sockets, [{grx, [%% ip: IP Address assigned at the tunnel, used as local GTP-U IP Address.
- {ip, {127,0,0,2}},
- %% Create the tun socket on a given netns:
- %%{netns, "mynetns"},
- %% Bind tun socket to a particular interface (SO_BINDTODEVICE):
- %%{netdev, "grx"},
- %% Allow binding to an IP address that is nonlocal or does not (yet) exist (IP_FREEBIND):
- freebind,
- % Create gtp tundev with role SGSN:
- {role, sgsn}%,
- %{vrf, [{routes, [{{10, 180, 0, 0}, 16}]}%%,
- % %%{netdev, "upstream"}
- % ]
- %}
+ {sockets, [{gtp0, [%% ip: IP Address assigned at the tunnel, used as local GTP-U IP Address.
+ {ip, {127,0,0,2}},
+ %% Create the tun socket on a given netns:
+ %%{netns, "mynetns"},
+ %% Bind tun socket to a particular interface (SO_BINDTODEVICE):
+ %%{netdev, "grx"},
+ %% Allow binding to an IP address that is nonlocal or does not (yet) exist (IP_FREEBIND):
+ freebind,
+ % Create gtp tundev with role SGSN:
+ {role, sgsn}%,
+ %{vrf, [{routes, [{{10, 180, 0, 0}, 16}]}%%,
+ % %%{netdev, "upstream"}
+ % ]
+ %}
]
}]
}
diff --git a/rebar.lock b/rebar.lock
index 4eefe8e..0a492b3 100644
--- a/rebar.lock
+++ b/rebar.lock
@@ -6,7 +6,7 @@
1},
{<<"erlando">>,
{git,"https://github.com/travelping/erlando.git",
- {ref,"2cb56e06308beb4d65ae2217a02dc60bafc99b9d"}},
+ {ref,"7ed3a732d1af082a3a2745c36dfd9406148391be"}},
1},
{<<"gen_netlink">>,
{git,"https://github.com/osmocom/gen_netlink",
@@ -14,12 +14,12 @@
1},
{<<"gen_socket">>,
{git,"https://github.com/osmocom/gen_socket",
- {ref,"35e11d6e2f6d87b02dcfc7507a9500bf7ca7329e"}},
+ {ref,"e32b2a3bd5de8088f509aad9c197553cc3acbc6c"}},
2},
{<<"goldrush">>,{pkg,<<"goldrush">>,<<"0.1.9">>},1},
{<<"gtp_u_kmod">>,
{git,"https://github.com/osmocom/gtp_u_kmod",
- {ref,"1dc27ed724403026431f51dd4c3f882499a036b0"}},
+ {ref,"b3656ebb11528a2db3171dbf94f1a8bf0d6ffd00"}},
0},
{<<"gtplib">>,{pkg,<<"gtplib">>,<<"3.2.0">>},0},
{<<"lager">>,
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36021?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Iea501aca2a15df48aaae2672dcb9d39716ea585c
Gerrit-Change-Number: 36021
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: laforge, lynxis lazus, osmith, pespin.
Hello Jenkins Builder, laforge, lynxis lazus, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36021?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+2 by osmith, Code-Review+2 by pespin, Verified+1 by Jenkins Builder
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: rebar.lock: Update after dependency fixes/updates
......................................................................
rebar.lock: Update after dependency fixes/updates
This contains 32bit compilation fixes for gen_socket and support to set
tundev iface name in gtp_u_kmod.
Change-Id: Iea501aca2a15df48aaae2672dcb9d39716ea585c
---
M config/sys.config
M rebar.lock
2 files changed, 29 insertions(+), 17 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/21/36021/3
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36021?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Iea501aca2a15df48aaae2672dcb9d39716ea585c
Gerrit-Change-Number: 36021
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-MessageType: newpatchset