February 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bsc[master]: abis_nm: misc/cosmetic changes to abis_nm_sw_act_req_ack()

by jolly

Attention is currently required from: fixeria. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35794?usp=email ) Change subject: abis_nm: misc/cosmetic changes to abis_nm_sw_act_req_ack() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35794?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2849a22647805e7477d66055c18614a3a9f80748 Gerrit-Change-Number: 35794 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Feb 2024 12:49:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in osmocom-bb[master]: mobile: fix GAPK I/O producing too many UL frames

by pespin

Attention is currently required from: Hoernchen, fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35870?usp=email ) Change subject: mobile: fix GAPK I/O producing too many UL frames ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35870?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3a7fa223cb592acd5b850819e0682c9c8f81e9d1 Gerrit-Change-Number: 35870 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Feb 2024 12:24:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in osmocom-bb[master]: mobile: fix GAPK I/O producing too many UL frames

by fixeria

Attention is currently required from: Hoernchen, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35870?usp=email ) Change subject: mobile: fix GAPK I/O producing too many UL frames ...................................................................... Patch Set 1: (1 comment) File src/host/layer23/src/mobile/gapk_io.c: https://gerrit.osmocom.org/c/osmocom-bb/+/35870/comment/754ea21f_c5b58a52 PS1, Line 521: /* Serves both UL/DL TCH frame I/O buffers */ > This line needs to be updated to remove the DL part I think. Done -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35870?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3a7fa223cb592acd5b850819e0682c9c8f81e9d1 Gerrit-Change-Number: 35870 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Feb 2024 12:15:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in osmocom-bb[master]: mobile: fix GAPK I/O producing too many UL frames

by fixeria

Attention is currently required from: Hoernchen, fixeria, laforge. Hello Hoernchen, Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/35870?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: mobile: fix GAPK I/O producing too many UL frames ...................................................................... mobile: fix GAPK I/O producing too many UL frames GAPK I/O is currently generating too many UL voice frames, causing Tx queue overflow in the L1 PHY. Change the logic to make DL voice frames drive the Uplink processing chain, like we do for CSD. Change-Id: I3a7fa223cb592acd5b850819e0682c9c8f81e9d1 --- M src/host/layer23/include/osmocom/bb/mobile/gapk_io.h M src/host/layer23/include/osmocom/bb/mobile/tch.h M src/host/layer23/src/mobile/app_mobile.c M src/host/layer23/src/mobile/gapk_io.c M src/host/layer23/src/mobile/tch.c M src/host/layer23/src/mobile/tch_voice.c 6 files changed, 31 insertions(+), 71 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/70/35870/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35870?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3a7fa223cb592acd5b850819e0682c9c8f81e9d1 Gerrit-Change-Number: 35870 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 5 months

1
0
0 0

[S] Change in osmo-mgw[master]: mgw: do not fail MGCP on codec mismatch

by fixeria

Attention is currently required from: dexter, neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35302?usp=email ) Change subject: mgw: do not fail MGCP on codec mismatch ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35302?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I3d1163fe622bdd7dc42a485f796072524ab39db9 Gerrit-Change-Number: 35302 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Feb 2024 12:12:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: epdg: Expect GSUP CancelLocationReq as consequence of DeleteBearerReq

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35883?usp=email ) Change subject: epdg: Expect GSUP CancelLocationReq as consequence of DeleteBearerReq ...................................................................... epdg: Expect GSUP CancelLocationReq as consequence of DeleteBearerReq Change-Id: Ibc37a9ef53315edab18f7b97a55cf504a40a4bf1 --- M epdg/EPDG_Tests.ttcn M library/GSUP_Templates.ttcn 2 files changed, 46 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/83/35883/1 diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn index becf2e9..e5cdafd 100644 --- a/epdg/EPDG_Tests.ttcn +++ b/epdg/EPDG_Tests.ttcn @@ -504,6 +504,7 @@ private function f_GTP2C_DeleteBearer_success() runs on EPDG_ConnHdlr { var integer proc_trans_id := 3; GTP2.send(ts_GTP2C_DeleteBearerReq(g_pars.teic_remote, proc_trans_id, g_pars.bearer.ebi, Access_changed_from_Non_3GPP_to_3GPP)); + as_GSUP_CancelLocation_success(); as_GTP2C_DeleteBearer_success(); } @@ -585,6 +586,18 @@ setverdict(pass); } +/* Expect CancelLocationReq */ +private altstep as_GSUP_CancelLocation_success() runs on EPDG_ConnHdlr { + var GSUP_PDU rx_gsup; + + [] GSUP.receive(tr_GSUP_CL_REQ(g_pars.imsi)) -> value rx_gsup { + GSUP.send(ts_GSUP_CL_RES(g_pars.imsi)); + } + [] GSUP.receive(GSUP_PDU:?) -> value rx_gsup { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Unexpected GSUP msg rx: ", rx_gsup)); + } +} + private function f_initial_attach() runs on EPDG_ConnHdlr { f_GSUP_AI_success(); f_GSUP_LU_success(); diff --git a/library/GSUP_Templates.ttcn b/library/GSUP_Templates.ttcn index 291b59a..3a616a6 100644 --- a/library/GSUP_Templates.ttcn +++ b/library/GSUP_Templates.ttcn @@ -403,6 +403,14 @@ template GSUP_PDU tr_GSUP_AUTH_FAIL_IND(hexstring imsi) := tr_GSUP_IMSI(OSMO_GSUP_MSGT_AUTH_FAIL_REPORT, imsi); +template (present) GSUP_PDU tr_GSUP_CL_REQ(template (present) hexstring imsi := ?, + template GSUP_CnDomain dom := omit, + template GSUP_CancelType ctype := omit) := + tr_GSUP(OSMO_GSUP_MSGT_LOCATION_CANCEL_REQUEST, + f_gen_tr_ies(imsi, + cancel_type := ctype, + cn_domain := dom)); + template (value) GSUP_PDU ts_GSUP_CL_REQ(hexstring imsi, GSUP_CancelType ctype) := ts_GSUP(OSMO_GSUP_MSGT_LOCATION_CANCEL_REQUEST, { valueof(ts_GSUP_IE_IMSI(imsi)), valueof(ts_GSUP_IE_CancelType(ctype)) }); @@ -410,6 +418,9 @@ template GSUP_PDU tr_GSUP_CL_RES(template hexstring imsi) := tr_GSUP_IMSI(OSMO_GSUP_MSGT_LOCATION_CANCEL_RESULT, imsi); +template (value) GSUP_PDU ts_GSUP_CL_RES(template (value) hexstring imsi) := + ts_GSUP(OSMO_GSUP_MSGT_LOCATION_CANCEL_RESULT, {valueof(ts_GSUP_IE_IMSI(imsi))}); + template GSUP_PDU tr_GSUP_CL_ERR(template hexstring imsi, template integer cause := ?) := tr_GSUP(OSMO_GSUP_MSGT_LOCATION_CANCEL_ERROR, { tr_GSUP_IE_IMSI(imsi), tr_GSUP_IE_Cause(cause), * }); @@ -548,7 +559,7 @@ val := val } -template (value) GSUP_IE ts_GSUP_IE_IMSI(hexstring imsi) := { +template (value) GSUP_IE ts_GSUP_IE_IMSI(template (value) hexstring imsi) := { tag := OSMO_GSUP_IMSI_IE, len := 0, /* overwritten */ val := { @@ -1184,8 +1195,10 @@ template GSUP_IEs pdp_info := omit, template GSUP_Message_Class message_class := omit, template integer cause := omit, + template GSUP_CancelType cancel_type := omit, template hexstring msisdn := omit, template GSUP_IMEIResult imei_result := omit, + template GSUP_CnDomain cn_domain := omit, template octetstring source_name := omit, template octetstring destination_name := omit ) return template GSUP_IEs { @@ -1204,6 +1217,11 @@ idx := idx + 1; } + if (not istemplatekind(cancel_type, "omit")) { + ies[idx] := tr_GSUP_IE_CancelType(cancel_type); + idx := idx + 1; + } + if (not istemplatekind(pdp_info_compl, "omit")) { ies[idx] := tr_GSUP_IE_PdpInfoCompl; idx := idx + 1; @@ -1214,6 +1232,11 @@ idx := idx + 1; } + if (not istemplatekind(cn_domain, "omit")) { + ies[idx] := tr_GSUP_IE_CnDomain(cn_domain); + idx := idx + 1; + } + if (not istemplatekind(imei_result, "omit")) { ies[idx] := tr_GSUP_IE_IMEI_Result(imei_result); idx := idx + 1; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35883?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibc37a9ef53315edab18f7b97a55cf504a40a4bf1 Gerrit-Change-Number: 35883 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[M] Change in libosmo-gprs[master]: tbf_ul: Clean and assert code path generating new UL data block

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/35882?usp=email ) Change subject: tbf_ul: Clean and assert code path generating new UL data block ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/35882?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I6d4ae377a60839f76295c0e7e6aaa1fe53e37315 Gerrit-Change-Number: 35882 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Feb 2024 11:24:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in libosmo-gprs[master]: rlcmac: uncomment RLC/MAC msg_type checking in DATA.cnf

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/35858?usp=email ) Change subject: rlcmac: uncomment RLC/MAC msg_type checking in DATA.cnf ...................................................................... Patch Set 3: (1 comment) File tests/rlcmac/rlcmac_prim_test.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/35858/comment/dcc9347f_302637f4 PS3, Line 640: rlcmac_prim = osmo_gprs_rlcmac_prim_alloc_l1ctl_pdch_data_cnf(ts_nr, rts_fn, NULL, 0); // FIXME: pass a valid RLC/MAC block here The easiest is probably that you memcpy() the buffer in line 495 when receiveign the DATA.req in the callback where this test emulates the lower layer. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/35858?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I4a0c553201d51453d9197d254f796f6574a2dab0 Gerrit-Change-Number: 35858 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Feb 2024 10:50:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmo-mgw[master]: mgw: do not fail MGCP on codec mismatch

by pespin

Attention is currently required from: dexter, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35302?usp=email ) Change subject: mgw: do not fail MGCP on codec mismatch ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35302?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I3d1163fe622bdd7dc42a485f796072524ab39db9 Gerrit-Change-Number: 35302 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Feb 2024 10:48:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in libosmo-gprs[master]: tbf_ul: Clean and assert code path generating new UL data block

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/35882?usp=email ) Change subject: tbf_ul: Clean and assert code path generating new UL data block ...................................................................... tbf_ul: Clean and assert code path generating new UL data block Clarify the several paths when generating a new BSN (UL data block). The function create_new_bsn() is only called if there's some LLC frame ready to be transmitted and put in ul_tbf->llc_tx_msg, so the do while {} condition checking for no llc_tx_msg is guaranteed to only be run in the event some LLC frame chunks have been included in the UL RLC block. This fact allows simplifying the code and at the same time fix a Coverity CID regarding a code path which could not really happen. We now guard this case with an ASSERT. Related: Coverity CID#345063 Change-Id: I6d4ae377a60839f76295c0e7e6aaa1fe53e37315 --- M src/rlcmac/tbf_ul.c 1 file changed, 37 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/82/35882/1 diff --git a/src/rlcmac/tbf_ul.c b/src/rlcmac/tbf_ul.c index 0ea0a9c..67c9e98 100644 --- a/src/rlcmac/tbf_ul.c +++ b/src/rlcmac/tbf_ul.c @@ -684,6 +684,7 @@ if (!ul_tbf->llc_tx_msg || msgb_length(ul_tbf->llc_tx_msg) == 0) gprs_rlcmac_ul_tbf_schedule_next_llc_frame(ul_tbf); + /* This function shall only be called if there's some LLC payload not yet transmitted: */ OSMO_ASSERT(ul_tbf->llc_tx_msg); OSMO_ASSERT(gprs_rlcmac_mcs_is_valid(cs)); @@ -734,27 +735,29 @@ int payload_written = 0; if (!ul_tbf->llc_tx_msg || msgb_length(ul_tbf->llc_tx_msg) == 0) { + const int space = block_data_len - write_offset; + /* Only get here in case we already encoded the end of + * some LLC payload chunk and there's no more new LLC + * payloads to send */ + OSMO_ASSERT(num_chunks > 0); + /* The data just drained, store the current fn */ if (ul_tbf->last_ul_drained_fn < 0) ul_tbf->last_ul_drained_fn = bi->fn; - int space = block_data_len - write_offset; + /* Nothing to send, and we already put some data in + * rlcmac data block, we are done */ + LOGPTBFUL(ul_tbf, LOGL_DEBUG, + "LLC queue completely drained and there's " + "still %d free bytes in rlcmac data block\n", space); - if (num_chunks != 0) { - /* Nothing to send, and we already put some data in - * rlcmac data block, we are done */ - LOGPTBFUL(ul_tbf, LOGL_DEBUG, - "LLC queue completely drained and there's " - "still %d free bytes in rlcmac data block\n", space); - - if (gprs_rlcmac_mcs_is_edge(cs)) { - /* in EGPRS there's no M bit, so we need - * to flag padding with LI=127 */ - gprs_rlcmac_rlc_data_to_ul_append_egprs_li_padding( - rdbi, &write_offset, &num_chunks, data); - } - break; + if (gprs_rlcmac_mcs_is_edge(cs)) { + /* in EGPRS there's no M bit, so we need to flag + * padding with LI=127 */ + gprs_rlcmac_rlc_data_to_ul_append_egprs_li_padding( + rdbi, &write_offset, &num_chunks, data); } + break; } ar = gprs_rlcmac_enc_append_ul_data(rdbi, cs, ul_tbf->llc_tx_msg, &write_offset, -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/35882?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I6d4ae377a60839f76295c0e7e6aaa1fe53e37315 Gerrit-Change-Number: 35882 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2024