December 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: bsc: Add missing testcase in expected-results.xml

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38998?usp=email ) Change subject: bsc: Add missing testcase in expected-results.xml ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38998?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6416e5cf4c12912f5094841d3738302bbd6228bb Gerrit-Change-Number: 38998 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Dec 2024 14:02:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[S] Change in osmocom-bb[master]: debian: add subpackage osmocom-bb-virtphy

by osmith

osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmocom-bb/+/39001?usp=email ) Change subject: debian: add subpackage osmocom-bb-virtphy ...................................................................... debian: add subpackage osmocom-bb-virtphy I've decided to name the package osmocom-bb-virtphy so there is no underscore in it (would look weird in addition to the minus character) and because it matches the name of the binary "virtphy". Change-Id: I09d98aba81ab6c76ad46aae36e7369114cef7dd7 --- M debian/control M debian/rules 2 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/01/39001/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39001?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I09d98aba81ab6c76ad46aae36e7369114cef7dd7 Gerrit-Change-Number: 39001 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder

6 months, 3 weeks

1
0
0 0

[S] Change in osmocom-bb[master]: debian: add subpackage osmocom-bb-trxcon

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39000?usp=email ) Change subject: debian: add subpackage osmocom-bb-trxcon ...................................................................... debian: add subpackage osmocom-bb-trxcon Change-Id: I548cec7427d70706b1b477c0845234efe6cf825f --- M debian/control M debian/rules 2 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/00/39000/1 diff --git a/debian/control b/debian/control index c90b6a7..fbcda98 100644 --- a/debian/control +++ b/debian/control @@ -27,3 +27,9 @@ Multi-Arch: foreign Depends: ${misc:Depends}, ${shlibs:Depends} Description: MS-side implementation of L2 and L3 GSM protocols + +Package: osmocom-bb-trxcon +Architecture: any +Multi-Arch: foreign +Depends: ${misc:Depends}, ${shlibs:Depends} +Description: OsmocomBB <-> SDR connection bridge diff --git a/debian/rules b/debian/rules index df0520e..c3f71ad 100755 --- a/debian/rules +++ b/debian/rules @@ -7,6 +7,10 @@ export SUBPKG_CFG=--with-gapk-io; \ dh $@ $(DH_ARGS) + export SUBPKG=trxcon; \ + export SUBPKG_DIR=trxcon; \ + dh $@ $(DH_ARGS) + # We need to run autoreconf multiple times, but dh_autoreconf can only run once # (see dh-autoreconf(7)). Run autoreconf directly to work around this. override_dh_autoreconf: -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39000?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I548cec7427d70706b1b477c0845234efe6cf825f Gerrit-Change-Number: 39000 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[S] Change in osmocom-bb[master]: debian: prepare for more subpackages

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/38999?usp=email ) Change subject: debian: prepare for more subpackages ...................................................................... debian: prepare for more subpackages Prepare to add these subpackages in follow-up patches: * osmocom-bb-trx-toolkit * osmocom-bb-trxcon * osmocom-bb-virtphy We need these components to run some of the ttnc3 testsuites. By having them packaged, we can just install them from the binary repositories along with the SUT. trxcon and virtphy are autootols based, so rework debian/rules to support building multiple autotools projects. Related: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851/1..2//COMMIT_MSG#b9 Change-Id: I77ad988f5405e6fa9e585eeb646e513ac7d92485 --- M debian/rules 1 file changed, 21 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/99/38999/1 diff --git a/debian/rules b/debian/rules index 8dd0df8..df0520e 100755 --- a/debian/rules +++ b/debian/rules @@ -1,7 +1,26 @@ #!/usr/bin/make -f +DH_ARGS := -D src/host/$$SUBPKG_DIR --with-autoreconf %: - dh $@ -D src/host/layer23 --with-autoreconf + export SUBPKG=layer23; \ + export SUBPKG_DIR=layer23; \ + export SUBPKG_CFG=--with-gapk-io; \ + dh $@ $(DH_ARGS) + +# We need to run autoreconf multiple times, but dh_autoreconf can only run once +# (see dh-autoreconf(7)). Run autoreconf directly to work around this. +override_dh_autoreconf: + cd src/host/$$SUBPKG_DIR && autoreconf -fi override_dh_auto_configure: - dh_auto_configure -D src/host/layer23 -- --with-gapk-io + dh_auto_configure -D src/host/$$SUBPKG_DIR -- $$SUBPKG_CFG + +override_dh_auto_install: + dh_auto_install -O-Dsrc/host/$$SUBPKG_DIR --destdir=debian/osmocom-bb-$$SUBPKG/ + +# Run dh_prep only for the first subpackage. Otherwise previously built +# binaries get removed and we end up with empty packages. +override_dh_prep: + if [ "$$SUBPKG" = "layer23" ]; then \ + dh_prep; \ + fi -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/38999?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I77ad988f5405e6fa9e585eeb646e513ac7d92485 Gerrit-Change-Number: 38999 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[S] Change in osmocom-bb[master]: debian: add subpackage osmocom-bb-virtphy

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39001?usp=email ) Change subject: debian: add subpackage osmocom-bb-virtphy ...................................................................... debian: add subpackage osmocom-bb-virtphy Change-Id: I09d98aba81ab6c76ad46aae36e7369114cef7dd7 --- M debian/control M debian/rules 2 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/01/39001/1 diff --git a/debian/control b/debian/control index fbcda98..7c5306c 100644 --- a/debian/control +++ b/debian/control @@ -33,3 +33,9 @@ Multi-Arch: foreign Depends: ${misc:Depends}, ${shlibs:Depends} Description: OsmocomBB <-> SDR connection bridge + +Package: osmocom-bb-virtphy +Architecture: any +Multi-Arch: foreign +Depends: ${misc:Depends}, ${shlibs:Depends} +Description: Osmocom virtual physical layer diff --git a/debian/rules b/debian/rules index c3f71ad..e4f5cb0 100755 --- a/debian/rules +++ b/debian/rules @@ -11,6 +11,10 @@ export SUBPKG_DIR=trxcon; \ dh $@ $(DH_ARGS) + export SUBPKG=virtphy; \ + export SUBPKG_DIR=virt_phy; \ + dh $@ $(DH_ARGS) + # We need to run autoreconf multiple times, but dh_autoreconf can only run once # (see dh-autoreconf(7)). Run autoreconf directly to work around this. override_dh_autoreconf: -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39001?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I09d98aba81ab6c76ad46aae36e7369114cef7dd7 Gerrit-Change-Number: 39001 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[XS] Change in osmocom-bb[master]: debian: add subpackage osmocom-bb-trx-toolkit

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39002?usp=email ) Change subject: debian: add subpackage osmocom-bb-trx-toolkit ...................................................................... debian: add subpackage osmocom-bb-trx-toolkit Change-Id: I3d8140991afaf08b6fff0e80d45dd0310c98ea30 --- M debian/control A debian/osmocom-bb-trx-toolkit.install 2 files changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/02/39002/1 diff --git a/debian/control b/debian/control index 7c5306c..c746022 100644 --- a/debian/control +++ b/debian/control @@ -28,6 +28,12 @@ Depends: ${misc:Depends}, ${shlibs:Depends} Description: MS-side implementation of L2 and L3 GSM protocols +Package: osmocom-bb-trx-toolkit +Architecture: any +Multi-Arch: foreign +Depends: python3 +Description: Tools for the TRX interface and emulating a virtual Um-interface + Package: osmocom-bb-trxcon Architecture: any Multi-Arch: foreign diff --git a/debian/osmocom-bb-trx-toolkit.install b/debian/osmocom-bb-trx-toolkit.install new file mode 100644 index 0000000..f323b17 --- /dev/null +++ b/debian/osmocom-bb-trx-toolkit.install @@ -0,0 +1 @@ +src/target/trx_toolkit/* /usr/share/osmocom-bb/trx_toolkit -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39002?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3d8140991afaf08b6fff0e80d45dd0310c98ea30 Gerrit-Change-Number: 39002 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[S] Change in osmo-hlr[master]: Drop use of libosmo-abis osmocom/abis/ipaccess.h

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/38989?usp=email ) Change subject: Drop use of libosmo-abis osmocom/abis/ipaccess.h ...................................................................... Drop use of libosmo-abis osmocom/abis/ipaccess.h That header is only really used to provide an old hack for ipaccess-proxy tool in openbsc.h/osmo-bsc.h, and will be deprecated soon. Take the chance to organize a bit better the includes based on dependency chain. Change-Id: I393cd23a09af6d1eefa68dc955415f4fe334d71b --- M include/osmocom/hlr/gsup_server.h M src/gsup_server.c 2 files changed, 5 insertions(+), 5 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/hlr/gsup_server.h b/include/osmocom/hlr/gsup_server.h index 86ae4ec..5767dec 100644 --- a/include/osmocom/hlr/gsup_server.h +++ b/include/osmocom/hlr/gsup_server.h @@ -2,9 +2,9 @@ #include <osmocom/core/linuxlist.h> #include <osmocom/core/msgb.h> -#include <osmocom/abis/ipa.h> -#include <osmocom/abis/ipaccess.h> #include <osmocom/gsm/gsup.h> +#include <osmocom/gsm/protocol/ipaccess.h> +#include <osmocom/abis/ipa.h> #include <osmocom/gsupclient/cni_peer_id.h> #include <osmocom/gsupclient/gsup_req.h> diff --git a/src/gsup_server.c b/src/gsup_server.c index 1510bd0..2df2d3d 100644 --- a/src/gsup_server.c +++ b/src/gsup_server.c @@ -24,12 +24,12 @@ #include <osmocom/core/msgb.h> #include <osmocom/core/logging.h> #include <osmocom/core/linuxlist.h> -#include <osmocom/abis/ipa.h> -#include <osmocom/abis/ipaccess.h> -#include <osmocom/gsm/ipa.h> #include <osmocom/gsm/gsm48_ie.h> #include <osmocom/gsm/apn.h> +#include <osmocom/gsm/protocol/ipaccess.h> +#include <osmocom/gsm/ipa.h> #include <osmocom/gsm/gsm23003.h> +#include <osmocom/abis/ipa.h> #include <osmocom/hlr/gsup_server.h> #include <osmocom/hlr/gsup_router.h> -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/38989?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I393cd23a09af6d1eefa68dc955415f4fe334d71b Gerrit-Change-Number: 38989 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[M] Change in osmo-bsc[master]: Drop use of libosmo-abis osmocom/abis/ipaccess.h

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38991?usp=email ) Change subject: Drop use of libosmo-abis osmocom/abis/ipaccess.h ...................................................................... Drop use of libosmo-abis osmocom/abis/ipaccess.h That header is only really used to provide an old hack for ipaccess-proxy tool in openbsc.h/osmo-bsc.h, and will be deprecated soon. src/ipaccess/ipaccess-config.c already has an explicit extern declaration for ipacces_fd_cb() anyway, so drop the header in advance. Take the chance to organize a bit better the includes based on dependency chain. Change-Id: I5f9daaf7789a56a08d2ec24b5e25e2e3b65b8b5b --- M src/ipaccess/ipaccess-config.c M src/ipaccess/ipaccess-proxy.c M src/osmo-bsc/bts_ipaccess_nanobts.c M src/osmo-bsc/bts_osmobts.c M src/osmo-bsc/e1_config.c 5 files changed, 30 insertions(+), 34 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c index 720837e..15dcc54 100644 --- a/src/ipaccess/ipaccess-config.c +++ b/src/ipaccess/ipaccess-config.c @@ -40,21 +40,21 @@ #include <osmocom/core/application.h> #include <osmocom/core/select.h> #include <osmocom/core/timer.h> -#include <osmocom/bsc/ipaccess.h> +#include <osmocom/core/talloc.h> +#include <osmocom/gsm/protocol/gsm_12_21.h> +#include <osmocom/gsm/protocol/ipaccess.h> +#include <osmocom/abis/abis.h> #include <osmocom/abis/e1_input.h> +#include <osmocom/bsc/ipaccess.h> #include <osmocom/bsc/abis_nm.h> #include <osmocom/bsc/signal.h> #include <osmocom/bsc/debug.h> #include <osmocom/bsc/network_listen.h> -#include <osmocom/abis/ipaccess.h> #include <osmocom/bsc/gsm_data.h> #include <osmocom/bsc/abis_nm.h> #include <osmocom/bsc/signal.h> #include <osmocom/bsc/debug.h> #include <osmocom/bsc/network_listen.h> -#include <osmocom/core/talloc.h> -#include <osmocom/abis/abis.h> -#include <osmocom/gsm/protocol/gsm_12_21.h> #include <osmocom/bsc/bss.h> #include <osmocom/bsc/bts.h> diff --git a/src/ipaccess/ipaccess-proxy.c b/src/ipaccess/ipaccess-proxy.c index 62e79cd..e659708 100644 --- a/src/ipaccess/ipaccess-proxy.c +++ b/src/ipaccess/ipaccess-proxy.c @@ -37,18 +37,18 @@ #define _GNU_SOURCE #include <getopt.h> -#include <osmocom/bsc/gsm_data.h> #include <osmocom/core/application.h> #include <osmocom/core/select.h> -#include <osmocom/gsm/tlv.h> #include <osmocom/core/msgb.h> -#include <osmocom/gsm/ipa.h> -#include <osmocom/abis/ipa.h> -#include <osmocom/abis/ipaccess.h> -#include <osmocom/bsc/debug.h> -#include <osmocom/bsc/ipaccess.h> #include <osmocom/core/socket.h> #include <osmocom/core/talloc.h> +#include <osmocom/gsm/tlv.h> +#include <osmocom/gsm/protocol/ipaccess.h> +#include <osmocom/gsm/ipa.h> +#include <osmocom/abis/ipa.h> +#include <osmocom/bsc/gsm_data.h> +#include <osmocom/bsc/debug.h> +#include <osmocom/bsc/ipaccess.h> /* one instance of an ip.access protocol proxy */ struct ipa_proxy { diff --git a/src/osmo-bsc/bts_ipaccess_nanobts.c b/src/osmo-bsc/bts_ipaccess_nanobts.c index 9382fa4..9f6d048 100644 --- a/src/osmo-bsc/bts_ipaccess_nanobts.c +++ b/src/osmo-bsc/bts_ipaccess_nanobts.c @@ -25,25 +25,23 @@ #include <osmocom/gsm/tlv.h> -#include <osmocom/bsc/gsm_data.h> -#include <osmocom/bsc/signal.h> -#include <osmocom/bsc/abis_nm.h> -#include <osmocom/abis/e1_input.h> -#include <osmocom/gsm/tlv.h> #include <osmocom/core/msgb.h> #include <osmocom/core/socket.h> #include <osmocom/core/stat_item.h> #include <osmocom/core/talloc.h> #include <osmocom/core/utils.h> +#include <osmocom/core/logging.h> +#include <osmocom/gsm/tlv.h> +#include <osmocom/gsm/protocol/ipaccess.h> +#include <osmocom/gsm/ipa.h> +#include <osmocom/abis/e1_input.h> +#include <osmocom/abis/subchan_demux.h> #include <osmocom/bsc/gsm_data.h> +#include <osmocom/bsc/signal.h> #include <osmocom/bsc/abis_nm.h> #include <osmocom/bsc/abis_rsl.h> #include <osmocom/bsc/abis_osmo.h> #include <osmocom/bsc/debug.h> -#include <osmocom/abis/subchan_demux.h> -#include <osmocom/gsm/ipa.h> -#include <osmocom/abis/ipaccess.h> -#include <osmocom/core/logging.h> #include <osmocom/bsc/ipaccess.h> #include <osmocom/bsc/bts_ipaccess_nanobts_omlattr.h> #include <osmocom/bsc/paging.h> diff --git a/src/osmo-bsc/bts_osmobts.c b/src/osmo-bsc/bts_osmobts.c index 9312a2a..1df9497 100644 --- a/src/osmo-bsc/bts_osmobts.c +++ b/src/osmo-bsc/bts_osmobts.c @@ -24,21 +24,19 @@ #include <osmocom/gsm/tlv.h> +#include <osmocom/core/msgb.h> +#include <osmocom/core/talloc.h> +#include <osmocom/core/logging.h> +#include <osmocom/gsm/tlv.h> +#include <osmocom/gsm/protocol/ipaccess.h> +#include <osmocom/abis/e1_input.h> +#include <osmocom/abis/subchan_demux.h> #include <osmocom/bsc/gsm_data.h> #include <osmocom/bsc/signal.h> #include <osmocom/bsc/abis_nm.h> #include <osmocom/bsc/bts.h> -#include <osmocom/abis/e1_input.h> -#include <osmocom/gsm/tlv.h> -#include <osmocom/core/msgb.h> -#include <osmocom/core/talloc.h> -#include <osmocom/bsc/gsm_data.h> -#include <osmocom/bsc/abis_nm.h> #include <osmocom/bsc/abis_rsl.h> #include <osmocom/bsc/debug.h> -#include <osmocom/abis/subchan_demux.h> -#include <osmocom/abis/ipaccess.h> -#include <osmocom/core/logging.h> extern struct gsm_bts_model bts_model_nanobts; diff --git a/src/osmo-bsc/e1_config.c b/src/osmo-bsc/e1_config.c index dbea3e9..aaf8b70 100644 --- a/src/osmo-bsc/e1_config.c +++ b/src/osmo-bsc/e1_config.c @@ -23,11 +23,11 @@ #include <time.h> #include <netinet/in.h> -#include <osmocom/bsc/gsm_data.h> -#include <osmocom/abis/e1_input.h> -#include <osmocom/bsc/misdn.h> -#include <osmocom/abis/ipaccess.h> #include <osmocom/core/talloc.h> +#include <osmocom/gsm/protocol/ipaccess.h> +#include <osmocom/abis/e1_input.h> +#include <osmocom/bsc/gsm_data.h> +#include <osmocom/bsc/misdn.h> #include <osmocom/bsc/debug.h> #include <osmocom/bsc/abis_rsl.h> #include <osmocom/bsc/bts.h> -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38991?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5f9daaf7789a56a08d2ec24b5e25e2e3b65b8b5b Gerrit-Change-Number: 38991 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[M] Change in osmo-bsc[master]: Drop use of libosmo-abis osmocom/abis/ipaccess.h

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38991?usp=email ) Change subject: Drop use of libosmo-abis osmocom/abis/ipaccess.h ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38991?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5f9daaf7789a56a08d2ec24b5e25e2e3b65b8b5b Gerrit-Change-Number: 38991 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Dec 2024 13:04:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[XS] Change in osmo-bts[master]: Drop use of libosmo-abis osmocom/abis/ipaccess.h

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/38990?usp=email ) Change subject: Drop use of libosmo-abis osmocom/abis/ipaccess.h ...................................................................... Drop use of libosmo-abis osmocom/abis/ipaccess.h That header is only really used to provide an old hack for ipaccess-proxy tool in openbsc.h/osmo-bsc.h, and will be deprecated soon. Take the chance to organize a bit better the includes based on dependency chain. Change-Id: Ie4540eb6f535375a1e4ddf3849602aecb6260914 --- M src/common/abis.c M src/common/oml.c 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: osmith: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/common/abis.c b/src/common/abis.c index e619ec8..d9c56e9 100644 --- a/src/common/abis.c +++ b/src/common/abis.c @@ -39,10 +39,10 @@ #include <osmocom/core/signal.h> #include <osmocom/core/macaddr.h> #include <osmocom/core/fsm.h> +#include <osmocom/gsm/protocol/ipaccess.h> +#include <osmocom/gsm/ipa.h> #include <osmocom/abis/abis.h> #include <osmocom/abis/e1_input.h> -#include <osmocom/abis/ipaccess.h> -#include <osmocom/gsm/ipa.h> #include <osmo-bts/abis.h> #include <osmo-bts/logging.h> diff --git a/src/common/oml.c b/src/common/oml.c index a9e13b5..35b8664 100644 --- a/src/common/oml.c +++ b/src/common/oml.c @@ -36,10 +36,10 @@ #include <osmocom/core/msgb.h> #include <osmocom/core/utils.h> #include <osmocom/gsm/protocol/gsm_12_21.h> +#include <osmocom/gsm/protocol/ipaccess.h> #include <osmocom/gsm/abis_nm.h> #include <osmocom/gsm/tlv.h> #include <osmocom/abis/e1_input.h> -#include <osmocom/abis/ipaccess.h> #include <osmo-bts/logging.h> #include <osmo-bts/gsm_data.h> -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38990?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie4540eb6f535375a1e4ddf3849602aecb6260914 Gerrit-Change-Number: 38990 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2024