December 2024 - gerrit-log - lists.osmocom.org

[L] Change in libosmo-abis[master]: ipaccess: Convert BSC OML & RSL link to use stream_srv

by pespin

Attention is currently required from: daniel, fixeria, laforge, pespin. Hello Jenkins Builder, daniel, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/38983?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: ipaccess: Convert BSC OML & RSL link to use stream_srv ...................................................................... ipaccess: Convert BSC OML & RSL link to use stream_srv This in turn allows running BSC Abis interfaces through io-uring backend, which should provide performance improvements when used. Drop ipaccess_fd_cb() since it has no real implementation anymore. That was only used by ipaccess-config in osmo-bsc.git, which got its own ipaccess specific e1_line driver recently. The use of that API was a quick dirty hack at the time which should have never happened. Related: SYS#7063 Related: OS#5755 Related: OS#5756 Change-Id: Idf241c8f2fdb86d090d4132a9b316b7236402232 --- M TODO-RELEASE M include/osmocom/abis/ipaccess.h M src/input/ipaccess.c 3 files changed, 274 insertions(+), 337 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/83/38983/5 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38983?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Idf241c8f2fdb86d090d4132a9b316b7236402232 Gerrit-Change-Number: 38983 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[S] Change in pysim[master]: Modem related fixes.

by fixeria

Attention is currently required from: JPM, dexter. fixeria has posted comments on this change by JPM. ( https://gerrit.osmocom.org/c/pysim/+/38993?usp=email ) Change subject: Modem related fixes. ...................................................................... Patch Set 1: Code-Review-1 (5 comments) Patchset: PS1: This patch should be split into smaller ones, ideally with some description and motivation in their COMMIT_MSGs. File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/38993/comment/cf65b68a_87491944?usp=em… : PS1, Line 43: return [] #return empty ATR This change looks suspicious. The type hint for this function is `Optional[Hexstr]`, indicating that it returns either a `Hexstr` or `None`. Now you're changing it to return a `list` instead of `None`. Why? What's the goal? File pySim/transport/modem_atcmd.py: https://gerrit.osmocom.org/c/pysim/+/38993/comment/afe707b3_cd79d3ee?usp=em… : PS1, Line 59: timeout=1.5, patience=0.1 This should be proposed in a separate patch with some explanation why the values need to be increased. https://gerrit.osmocom.org/c/pysim/+/38993/comment/94c922c9_75f0d08a?usp=em… : PS1, Line 111: def get_atr(self) -> Hexstr: This also looks like a separate patch. I see we also have `get_atr()` in `PcscSimLink` and `SerialSimLink`, but not in `CalypsoSimLink`. Neither this method is defined in `LinkBase` (the abstract class). I don't remember seeing this method when writing this module... https://gerrit.osmocom.org/c/pysim/+/38993/comment/8643752e_9d3cd0b3?usp=em… : PS1, Line 137: Rebooting the modem to force card reset AFAICS, you're reading the current `AT+CFUN` (operational) mode and then sending `AT+CFUN` with exactly that same mode value that was read. Could you explain and/or give a spec. reference on how is that supposed to reset the card? I would expect doing `AT+CFUN=0` followed by `AT+CFUN=1` to reset the card, since the modem would likely power off the card to ensure that the "minimum power is drawn". -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38993?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3e45603a13496fff41b9f859de486143252fb28d Gerrit-Change-Number: 38993 Gerrit-PatchSet: 1 Gerrit-Owner: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Dec 2024 11:59:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[S] Change in pysim[master]: Handling Long APDU response

by fixeria

Attention is currently required from: JPM, dexter. fixeria has posted comments on this change by JPM. ( https://gerrit.osmocom.org/c/pysim/+/38992?usp=email ) Change subject: Handling Long APDU response ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/pysim/+/38992/comment/6c539209_9610c578?usp=em… : PS1, Line 7: Handling Long APDU response Please change to `modem_atcmd: Handling Long APDU response` so that the commit message clearly tells where you're adding handling of long APDU response(s). File pySim/transport/modem_atcmd.py: https://gerrit.osmocom.org/c/pysim/+/38992/comment/f6631eb8_7682131f?usp=em… : PS1, Line 172: b'CME ERROR:' You're removing the `+` sign here (was `b'+CME ERROR:'`), is this intentional? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38992?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3c09d4dd1ed68bb982e23c90a6762fd9c2dfdd7f Gerrit-Change-Number: 38992 Gerrit-PatchSet: 1 Gerrit-Owner: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Dec 2024 11:34:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

6 months, 3 weeks

1
0
0 0

[L] Change in libosmo-abis[master]: ipaccess: Convert BSC OML & RSL link to use stream_srv

by fixeria

Attention is currently required from: daniel, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38983?usp=email ) Change subject: ipaccess: Convert BSC OML & RSL link to use stream_srv ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File TODO-RELEASE: https://gerrit.osmocom.org/c/libosmo-abis/+/38983/comment/f023b5a1_c321de9d… : PS4, Line 14: ABI You're removing a symbol, so it's actually API breakage, not ABI. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38983?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Idf241c8f2fdb86d090d4132a9b316b7236402232 Gerrit-Change-Number: 38983 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Dec 2024 11:15:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[S] Change in osmocom-bb[master]: Bump version: 0.1.0 → 0.2.0

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39004?usp=email ) Change subject: Bump version: 0.1.0 → 0.2.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39004?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ifbfaead7ae89d9ac747d1bb495f061c5cbe7a241 Gerrit-Change-Number: 39004 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Dec 2024 11:13:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[S] Change in osmocom-bb[master]: Bump version: 0.1.0 → 0.2.0

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39004?usp=email ) Change subject: Bump version: 0.1.0 → 0.2.0 ...................................................................... Bump version: 0.1.0 → 0.2.0 Prepare a release tag, so we get binary packages for osmocom-bb-trx-toolkit, osmocom-bb-trxcon, osmocom-bb-virtphy in the osmocom:latest repository. Then we can use these packages when running TTCN-3 testsuites. This is not an official release, as discussed here: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851/1..2//COMMIT_MSG#b9 Change-Id: Ifbfaead7ae89d9ac747d1bb495f061c5cbe7a241 --- M debian/changelog 1 file changed, 28 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/04/39004/1 diff --git a/debian/changelog b/debian/changelog index 2335d18..f1b2a64 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,31 @@ +osmocom-bb (0.2.0) unstable; urgency=medium + + [ Harald Welte ] + * Add funding link to github mirror + + [ Vadim Yanitskiy ] + * trxcon/l1sched: fix sending dummy TCH/A[FH]S blocks + * trxcon/l1sched: fix NULL pointer dereference in tx_tch[fh]_fn() + * trxcon/l1sched: make l1sched_lchan_emit_data_cnf() NULL-safe + * trxcon/l1sched: refactor prim management in tx_tch[fh]_fn() + * mobile: cosmetic: fix -Wswitch in tch_voice_state_init() + * mobile: fix -Wmaybe-uninitialized in gsm48_rr_tx_meas_rep() + * firmware: rename 'se_k2x0' -> 'se_k2xx' (include K205) + * firmware: k2xx: fix comments about flash organization + * trxcon/l1sched: fix decoding of DL FACCH/H for TCH/H4.8 and TCH/H2.4 + * trxcon/l1sched: replace old API with sched_tchh_ul_facch_map[] + * trxcon/l1sched: fix FACCH/H regression in rx_tchh_fn() + * trxcon/l1sched: check-in trx_sched_tch.txt from osmo-bts.git + * trxcon/l1sched: clarify TDMA Fn (mod 26) maps + + [ Oliver Smith ] + * debian: prepare for more subpackages + * debian: add subpackage osmocom-bb-trxcon + * debian: add subpackage osmocom-bb-virtphy + * debian: add subpackage osmocom-bb-trx-toolkit + + -- Oliver Smith <osmith(a)sysmocom.de> Tue, 03 Dec 2024 12:02:10 +0100 + osmocom-bb (0.1.0) unstable; urgency=medium * Initial debian packaging for layer23 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39004?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ifbfaead7ae89d9ac747d1bb495f061c5cbe7a241 Gerrit-Change-Number: 39004 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[L] Change in libosmo-abis[master]: ipaccess: Convert BSC OML & RSL link to use stream_srv

by osmith

Attention is currently required from: daniel, fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38983?usp=email ) Change subject: ipaccess: Convert BSC OML & RSL link to use stream_srv ...................................................................... Patch Set 4: (3 comments) File src/input/ipaccess.c: https://gerrit.osmocom.org/c/libosmo-abis/+/38983/comment/6a6b46f6_679f54b2… : PS4, Line 387: ballback callback https://gerrit.osmocom.org/c/libosmo-abis/+/38983/comment/a8b77763_b34c999c… : PS4, Line 470: default: maybe put a log msg here? https://gerrit.osmocom.org/c/libosmo-abis/+/38983/comment/62ef51f2_327840c9… : PS4, Line 705: /* PESPIN: TODO: use osmo_stream_srv_send() instead */ did you leave this TODO intentionally? -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38983?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Idf241c8f2fdb86d090d4132a9b316b7236402232 Gerrit-Change-Number: 38983 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Dec 2024 10:32:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

6 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/master: add osmocom-android-binaries

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/38984?usp=email ) Change subject: jobs/master: add osmocom-android-binaries ...................................................................... jobs/master: add osmocom-android-binaries Add a job that runs contrib/jenkins.sh of the new osmocom-android-binaries repository to deploy it. Related: SYS#7197 Change-Id: I9153fd60ed6cea150096c0e462284bc7f9605beb --- M jobs/master-builds.yml 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index 6f255fd..dce4849 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -594,6 +594,12 @@ - dahdi-tools + - osmocom-android-binaries: + ssh: + - binaries_ftp.osmocom.org + concurrent: false + repos_url: 'https://gitea.osmocom.org/osmocom/osmocom-android-binaries' + - xgoldmon: repos_url: 'https://github.com/2b-as/{repos}' cmd: | -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38984?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9153fd60ed6cea150096c0e462284bc7f9605beb Gerrit-Change-Number: 38984 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/master: add osmocom-android-binaries

by osmith

Attention is currently required from: dexter, fixeria. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38984?usp=email ) Change subject: jobs/master: add osmocom-android-binaries ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38984?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9153fd60ed6cea150096c0e462284bc7f9605beb Gerrit-Change-Number: 38984 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Dec 2024 10:05:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[XS] Change in libasn1c[master]: Bump version: 0.9.37.1-2d31 → 0.9.38

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libasn1c/+/38994?usp=email ) Change subject: Bump version: 0.9.37.1-2d31 → 0.9.38 ...................................................................... Bump version: 0.9.37.1-2d31 → 0.9.38 Change-Id: I5f87965ef761e7d2fb639642ffcf698b23197f3b --- M debian/changelog 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/debian/changelog b/debian/changelog index a9c9282..10c5d2a 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +libasn1c (0.9.38) unstable; urgency=medium + + * debian/control: Build-Depends: add pkg-config + + -- Oliver Smith <osmith(a)sysmocom.de> Mon, 02 Dec 2024 09:41:20 +0100 + libasn1c (0.9.37) unstable; urgency=medium [ Harald Welte ] -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/38994?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: I5f87965ef761e7d2fb639642ffcf698b23197f3b Gerrit-Change-Number: 38994 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2024