Attention is currently required from: lynxis lazus.
laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38399?usp=email )
Change subject: SGSN: f_TC_attach_timeout_after_pdp_act: allow authentication
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
Patchset:
PS5:
I'm still wondering if it wouldn't make sense to explicitly expect the old behaviour when testing the old VLR and explicitly expect the new behaviour when running the new VLR?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38399?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I11c628ecebbe7c4c1b2c28e63133a33cfc171e12
Gerrit-Change-Number: 38399
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 21 Nov 2024 13:36:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38850?usp=email )
Change subject: bts/run_fake_trx.sh: tweak cd logic
......................................................................
bts/run_fake_trx.sh: tweak cd logic
Don't test if FAKE_TRX_DIR is empty, because it is never empty at that
point. If it was empty, then the line above would assign a default
value.
Change-Id: I63f9720487b564de5c5609eb52a6bb9d5a8aa74f
---
M bts/run_fake_trx.sh
1 file changed, 1 insertion(+), 4 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/bts/run_fake_trx.sh b/bts/run_fake_trx.sh
index 2209972..6243ce2 100755
--- a/bts/run_fake_trx.sh
+++ b/bts/run_fake_trx.sh
@@ -4,8 +4,5 @@
# fake trx is part of osmo-trx
FAKE_TRX_DIR="${FAKE_TRX_DIR:-../../osmo-trx/osmocom-bb/src/target/trx_toolkit}"
-if [ -n "$FAKE_TRX_DIR" ] ; then
- cd "$FAKE_TRX_DIR"
-fi
-
+cd "$FAKE_TRX_DIR"
exec ./fake_trx.py --trx TRX1@127.0.0.1:5700/1 --trx TRX2@127.0.0.1:5700/2 --trx TRX3@127.0.0.1:5700/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38850?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I63f9720487b564de5c5609eb52a6bb9d5a8aa74f
Gerrit-Change-Number: 38850
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38849?usp=email )
Change subject: testenv: pass env var for --binary-repo
......................................................................
testenv: pass env var for --binary-repo
Pass TESTENV_BINARY_REPO=1 to the podman container if the --binary-repo
argument is set. This will be used for the BTS testsuite to figure out
from where we need to run fake-trx.
Change-Id: Ia88906147e2e579145e3c8d04090c58f533febd5
---
M _testenv/testenv/podman.py
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/_testenv/testenv/podman.py b/_testenv/testenv/podman.py
index 1281b3b..f8812e4 100644
--- a/_testenv/testenv/podman.py
+++ b/_testenv/testenv/podman.py
@@ -243,7 +243,12 @@
"PODMAN=1",
]
- if not testenv.args.binary_repo:
+ if testenv.args.binary_repo:
+ cmd += [
+ "-e",
+ "TESTENV_BINARY_REPO=1",
+ ]
+ else:
cmd += [
"--volume",
f"{osmo_dev_dir}:{osmo_dev_dir}",
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38849?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia88906147e2e579145e3c8d04090c58f533febd5
Gerrit-Change-Number: 38849
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>