November 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: l1sap: make send_ul_rtp_packet_hrdata() NULL-safe

by osmith

Attention is currently required from: falconia, fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38697?usp=email ) Change subject: l1sap: make send_ul_rtp_packet_hrdata() NULL-safe ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38697?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I05d88a739dc54ca68e50d20b2d0d0b097ae8ca4a Gerrit-Change-Number: 38697 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 08 Nov 2024 13:06:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: old-tags-against-master: ignore last osmo-bsc tags

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38698?usp=email ) Change subject: old-tags-against-master: ignore last osmo-bsc tags ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38698?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iac7e6ea7815dd2c3eb9c2636c0caa661161654ed Gerrit-Change-Number: 38698 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 08 Nov 2024 13:04:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: old-tags-against-master: ignore last osmo-bsc tags

by osmith

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/38698?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: old-tags-against-master: ignore last osmo-bsc tags ...................................................................... old-tags-against-master: ignore last osmo-bsc tags This script tests if the last 3 tags of various Osmocom programs build with current master libraries. Mark the last 3 OsmoBSC releases as known failures, because of the unavoidable API break in libosmo-sigtran so the job does not fail anymore. Mark as known error: bsc_ctrl.c:639:18: error: invalid use of undefined type 'struct osmo_ss7_route' 639 | return rt->dest.as; Related: OS#6617 Change-Id: Iac7e6ea7815dd2c3eb9c2636c0caa661161654ed --- M scripts/osmocom-build-old-tags-against-master.sh 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/98/38698/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38698?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iac7e6ea7815dd2c3eb9c2636c0caa661161654ed Gerrit-Change-Number: 38698 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-bts[master]: l1sap: make send_ul_rtp_packet_hrdata() NULL-safe

by pespin

Attention is currently required from: falconia, fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38697?usp=email ) Change subject: l1sap: make send_ul_rtp_packet_hrdata() NULL-safe ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38697?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I05d88a739dc54ca68e50d20b2d0d0b097ae8ca4a Gerrit-Change-Number: 38697 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 08 Nov 2024 13:01:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: old-tags-against-master: ignore last osmo-bsc tags

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/38698?usp=email ) Change subject: old-tags-against-master: ignore last osmo-bsc tags ...................................................................... old-tags-against-master: ignore last osmo-bsc tags This script tests if the last 3 tags of various Osmocom programs build with current master libraries. Mark the last 3 OsmoBSC releases as known failures, because of the intentional API break in libosmo-sigtran so the job does not fail anymore. Mark as known error: bsc_ctrl.c:639:18: error: invalid use of undefined type 'struct osmo_ss7_route' 639 | return rt->dest.as; Related: OS#6617 Change-Id: Iac7e6ea7815dd2c3eb9c2636c0caa661161654ed --- M scripts/osmocom-build-old-tags-against-master.sh 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/98/38698/1 diff --git a/scripts/osmocom-build-old-tags-against-master.sh b/scripts/osmocom-build-old-tags-against-master.sh index eaf73088..94f0fd3 100755 --- a/scripts/osmocom-build-old-tags-against-master.sh +++ b/scripts/osmocom-build-old-tags-against-master.sh @@ -63,6 +63,10 @@ # this script (we put that legacy lib into a different temp install dir). Fixed in 1.2.2. echo "1.2.1" echo "1.4.0" # testsuite + # Intentional API break: https://gerrit.osmocom.org/c/libosmo-sigtran/+/38636 + echo "1.11.1" + echo "1.12.0" + echo "1.12.1" ;; osmo-bts) echo "1.0.0" # missing gsm0808.h include, fixed in 1.0.1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38698?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iac7e6ea7815dd2c3eb9c2636c0caa661161654ed Gerrit-Change-Number: 38698 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: bts: add TC_data_facch_*: test FACCH/[FH] on data channels

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696?usp=email ) Change subject: bts: add TC_data_facch_*: test FACCH/[FH] on data channels ...................................................................... Patch Set 3: (3 comments) File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696/comment/dae79ff2_e2ff… : PS3, Line 9552: /* TODO: execute( TC_data_facch_tchh48() ); */ maybe write down in the comment that it crashes osmo-bts. Is there a related osmocom ticket? maybe also put it there. File bts/expected-results.xml: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696/comment/d4e11997_da96… : PS3, Line 2: <testsuite name='Titan' tests='242' failures='5' errors='0' skipped='0' inconc='0' time='MASKED'> missing increment here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696/comment/9f95c2d4_486c… : PS3, Line 205: <testcase classname='BTS_Tests' name='TC_data_facch_tchh48' time='MASKED'/> but we are not running this yet right? so it shouldn't appear here, and it shouldn't for sure be as passed, since it crashes the bts? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2098ccd651fc2a81f62e70be64af386ab0ca6148 Gerrit-Change-Number: 38696 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 08 Nov 2024 12:59:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: TC_data_rtp_tchh*: fix timeslot number in comments

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38695?usp=email ) Change subject: bts: TC_data_rtp_tchh*: fix timeslot number in comments ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38695?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I771e616d52315a26679acb1be17cd4f36eaa52b2 Gerrit-Change-Number: 38695 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 08 Nov 2024 12:56:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: use proper ActType in f_TC_data_rtp_loopback()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38694?usp=email ) Change subject: bts: use proper ActType in f_TC_data_rtp_loopback() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38694?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ide773c3fcfdab881756d5fe5b6c314b0c0335043 Gerrit-Change-Number: 38694 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 08 Nov 2024 12:55:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[S] Change in ...pyosmocom[master]: Fixing 3-digit MNC PlmnAdapter encoding and decoding. Adding test_plm...

by JPM

Attention is currently required from: dexter, laforge. JPM has posted comments on this change by JPM. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email ) Change subject: Fixing 3-digit MNC PlmnAdapter encoding and decoding. Adding test_plmn_adapter. ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: 3GPP TS 24.008 § 10.5.1.3 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I3811b227d629bd4e051a480c9622967e31f8a376 Gerrit-Change-Number: 38687 Gerrit-PatchSet: 1 Gerrit-Owner: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 08 Nov 2024 12:55:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library/rsl: rename t_RSL_IE_ActType_* -> c_RSL_IE_ActType_*

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38693?usp=email ) Change subject: library/rsl: rename t_RSL_IE_ActType_* -> c_RSL_IE_ActType_* ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38693?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4ae8f6c35f6f823060833f24a0cad41cc9894750 Gerrit-Change-Number: 38693 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 08 Nov 2024 12:55:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024