November 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ci[master]: old-tags-against-master: ignore last osmo-bsc tags

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38698?usp=email ) Change subject: old-tags-against-master: ignore last osmo-bsc tags ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File scripts/osmocom-build-old-tags-against-master.sh: https://gerrit.osmocom.org/c/osmo-ci/+/38698/comment/55d3b09e_902632ed?usp=… : PS2, Line 67: echo "1.11.1" : These two are predating libosmo-sigtran.git, can we still test them against libosmo-sccp.git? Just curious, not blocking. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38698?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iac7e6ea7815dd2c3eb9c2636c0caa661161654ed Gerrit-Change-Number: 38698 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 08 Nov 2024 15:43:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[S] Change in ...pyosmocom[master]: Fixing 3-digit MNC PlmnAdapter encoding and decoding. Adding test_plm...

by fixeria

Attention is currently required from: JPM, dexter, laforge. fixeria has posted comments on this change by JPM. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email ) Change subject: Fixing 3-digit MNC PlmnAdapter encoding and decoding. Adding test_plmn_adapter. ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > 3GPP TS 24.008 § 10.5.1. […] I meant this should be mentioned in the code, in a comment. -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I3811b227d629bd4e051a480c9622967e31f8a376 Gerrit-Change-Number: 38687 Gerrit-PatchSet: 1 Gerrit-Owner: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 08 Nov 2024 15:37:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca>

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-hnbgw[master]: Use new libosmo-sigtran APIs to access osmo_ss7_instance

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38655?usp=email ) Change subject: Use new libosmo-sigtran APIs to access osmo_ss7_instance ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38655?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3549ff3ace641f0b0574a9ddec14120299446434 Gerrit-Change-Number: 38655 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 08 Nov 2024 15:27:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-msc[master]: Use new libosmo-sigtran APIs to access osmo_ss7_instance

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-msc/+/38654?usp=email ) Change subject: Use new libosmo-sigtran APIs to access osmo_ss7_instance ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Patchset: PS2: Feel free to CR+2 and merge after adding `const`. File src/osmo-msc/msc_main.c: https://gerrit.osmocom.org/c/osmo-msc/+/38654/comment/07a6122a_c7ad9083?usp… : PS2, Line 628: struct osmo_ss7_instance *ss7 can be `const`? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38654?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4c4f833cfcc4e65ee5372e7736dbef9c65c2f3de Gerrit-Change-Number: 38654 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 08 Nov 2024 15:26:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: bts: add TC_data_facch_*: test FACCH/[FH] on data channels

by fixeria

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: bts: add TC_data_facch_*: test FACCH/[FH] on data channels ...................................................................... bts: add TC_data_facch_*: test FACCH/[FH] on data channels So far we have been testing the actual traffic on TCH/[FH] in data mode (CSD), but not FACCH/[FH]. Add separate testcases for that. Half-rate variants of the new testcases crash osmo-bts-trx, so comment them out in the control section until the problem is fixed. Change-Id: I2098ccd651fc2a81f62e70be64af386ab0ca6148 Related: OS#6618 --- M bts/BTS_Tests.ttcn M bts/expected-results.xml 2 files changed, 130 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/96/38696/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2098ccd651fc2a81f62e70be64af386ab0ca6148 Gerrit-Change-Number: 38696 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: bts: add TC_data_facch_*: test FACCH/[FH] on data channels

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696?usp=email ) Change subject: bts: add TC_data_facch_*: test FACCH/[FH] on data channels ...................................................................... Patch Set 3: (3 comments) File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696/comment/05c7e533_4295… : PS3, Line 9552: /* TODO: execute( TC_data_facch_tchh48() ); */ > maybe write down in the comment that it crashes osmo-bts. […] I have fixed the problem meanwhile: * here we call `f_rtpem_activate()`, which does CRCX/MDCX * osmo-bts fix: https://gerrit.osmocom.org/c/osmo-bts/+/38697 so we can uncomment them. Done. File bts/expected-results.xml: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696/comment/2ef193e5_580b… : PS3, Line 2: <testsuite name='Titan' tests='242' failures='5' errors='0' skipped='0' inconc='0' time='MASKED'> > missing increment here. Indeed, thanks. Done. Somehow I remember about this when doing code review but now when writing my own code :P https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696/comment/bac0e484_d498… : PS3, Line 205: <testcase classname='BTS_Tests' name='TC_data_facch_tchh48' time='MASKED'/> > but we are not running this yet right? so it shouldn't appear here, and it shouldn't for sure be as […] See the other comment. Marking as resolved. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2098ccd651fc2a81f62e70be64af386ab0ca6148 Gerrit-Change-Number: 38696 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 08 Nov 2024 15:19:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-bts[master]: l1sap: make send_ul_rtp_packet_hrdata() NULL-safe

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/38697?usp=email ) Change subject: l1sap: make send_ul_rtp_packet_hrdata() NULL-safe ...................................................................... l1sap: make send_ul_rtp_packet_hrdata() NULL-safe lchan->abis_ip.rtp_socket is NULL before the BSC indicates the RTP parameters using the CRCX/MDCX procedures. send_ul_rtp_packet() does check lchan->abis_ip.rtp_socket against NULL before calling osmo_rtp_send_frame_ext(), so should send_ul_rtp_packet_hrdata(). Take a chance to make send_ul_rtp_packet_hrdata() more consistent with the send_ul_rtp_packet() by reordering code a bit. Change-Id: I05d88a739dc54ca68e50d20b2d0d0b097ae8ca4a Fixes: 59686cd27 ("CSD: implement half-rate modes correctly") Related: OS#6618 --- M src/common/l1sap.c 1 file changed, 10 insertions(+), 9 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/common/l1sap.c b/src/common/l1sap.c index 06ab051..dc83e77 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -2097,7 +2097,7 @@ if (lchan->abis_ip.osmux.use) { lchan_osmux_send_frame(lchan, rtp_pl, rtp_pl_len, fn_ms_adj(fn, lchan), lchan->rtp_tx_marker); - } else if (lchan->abis_ip.rtp_socket) { + } else if (lchan->abis_ip.rtp_socket != NULL) { osmo_rtp_send_frame_ext(lchan->abis_ip.rtp_socket, rtp_pl, rtp_pl_len, fn_ms_adj(fn, lchan), lchan->rtp_tx_marker); rate_ctr_inc2(bts->ctrs, BTS_CTR_RTP_TX_TOTAL); @@ -2116,14 +2116,15 @@ { struct gsm_bts *bts = lchan->ts->trx->bts; - rate_ctr_inc2(bts->ctrs, BTS_CTR_RTP_TX_TOTAL); - if (lchan->rtp_tx_marker) - rate_ctr_inc2(bts->ctrs, BTS_CTR_RTP_TX_MARKER); - - osmo_rtp_send_frame_ext(lchan->abis_ip.rtp_socket, - rtp_pl, rtp_pl_len, - GSM_RTP_DURATION, - lchan->rtp_tx_marker); + if (lchan->abis_ip.rtp_socket != NULL) { + osmo_rtp_send_frame_ext(lchan->abis_ip.rtp_socket, + rtp_pl, rtp_pl_len, + GSM_RTP_DURATION, + lchan->rtp_tx_marker); + rate_ctr_inc2(bts->ctrs, BTS_CTR_RTP_TX_TOTAL); + if (lchan->rtp_tx_marker) + rate_ctr_inc2(bts->ctrs, BTS_CTR_RTP_TX_MARKER); + } /* Only clear the marker bit once we have sent a RTP packet with it */ lchan->rtp_tx_marker = false; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38697?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I05d88a739dc54ca68e50d20b2d0d0b097ae8ca4a Gerrit-Change-Number: 38697 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library/rsl: rename t_RSL_IE_ActType_* -> c_RSL_IE_ActType_*

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38693?usp=email ) Change subject: library/rsl: rename t_RSL_IE_ActType_* -> c_RSL_IE_ActType_* ...................................................................... library/rsl: rename t_RSL_IE_ActType_* -> c_RSL_IE_ActType_* We use prefix 't_' for templates and prefix 'c_' for constants. Change-Id: I4ae8f6c35f6f823060833f24a0cad41cc9894750 --- M bts/BTS_Tests.ttcn M library/RSL_Types.ttcn 2 files changed, 19 insertions(+), 19 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 07e824a..64804f5 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -867,7 +867,7 @@ friend function f_rsl_chan_act(RSL_IE_ChannelMode mode, boolean encr_enable := false, RSL_IE_List more_ies := {}, - RSL_IE_ActivationType act_type := t_RSL_IE_ActType_IA) + RSL_IE_ActivationType act_type := c_RSL_IE_ActType_IA) runs on ConnHdlr { var RSL_Message ch_act := valueof(ts_RSL_CHAN_ACT(g_chan_nr, mode, act_type)); if (encr_enable) { @@ -1497,7 +1497,7 @@ }; /* Activate channel on BTS side */ - f_rsl_chan_act(g_pars.chan_mode, more_ies := addl_ies, act_type := t_RSL_IE_ActType_HO_ASYNC); + f_rsl_chan_act(g_pars.chan_mode, more_ies := addl_ies, act_type := c_RSL_IE_ActType_HO_ASYNC); /* don't perform immediate assignment here, as we're testing non-IA case */ /* enable dedicated mode */ f_l1ctl_est_dchan(L1CTL, g_pars); @@ -1525,7 +1525,7 @@ ho_ref_ie, valueof(t_RSL_IE(RSL_IE_MS_POWER, RSL_IE_Body:{ms_power := ts_RSL_IE_MS_Power(0)})) }; - f_rsl_chan_act(g_pars.chan_mode, more_ies := addl_ies, act_type := t_RSL_IE_ActType_HO_ASYNC); + f_rsl_chan_act(g_pars.chan_mode, more_ies := addl_ies, act_type := c_RSL_IE_ActType_HO_ASYNC); /* don't perform immediate assignment here, as we're testing non-IA case */ /* enable dedicated mode */ f_l1ctl_est_dchan(L1CTL, g_pars); @@ -1578,7 +1578,7 @@ }; /* Activate channel on BTS side */ - f_rsl_chan_act(g_pars.chan_mode, more_ies := addl_ies, act_type := t_RSL_IE_ActType_HO_SYNC); + f_rsl_chan_act(g_pars.chan_mode, more_ies := addl_ies, act_type := c_RSL_IE_ActType_HO_SYNC); /* don't perform immediate assignment here, as we're testing non-IA case */ /* enable dedicated mode */ f_l1ctl_est_dchan(L1CTL, g_pars); @@ -1606,7 +1606,7 @@ ho_ref_ie, valueof(t_RSL_IE(RSL_IE_MS_POWER, RSL_IE_Body:{ms_power := ts_RSL_IE_MS_Power(0)})) }; - f_rsl_chan_act(g_pars.chan_mode, more_ies := addl_ies, act_type := t_RSL_IE_ActType_HO_SYNC); + f_rsl_chan_act(g_pars.chan_mode, more_ies := addl_ies, act_type := c_RSL_IE_ActType_HO_SYNC); /* don't perform immediate assignment here, as we're testing non-IA case */ /* enable dedicated mode */ f_l1ctl_est_dchan(L1CTL, g_pars); @@ -1635,7 +1635,7 @@ ho_ref_ie, valueof(t_RSL_IE(RSL_IE_TIMING_ADVANCE, RSL_IE_Body:{timing_adv := 0})) }; - f_rsl_chan_act(g_pars.chan_mode, more_ies := addl_ies, act_type := t_RSL_IE_ActType_HO_SYNC); + f_rsl_chan_act(g_pars.chan_mode, more_ies := addl_ies, act_type := c_RSL_IE_ActType_HO_SYNC); /* don't perform immediate assignment here, as we're testing non-IA case */ /* enable dedicated mode */ f_l1ctl_est_dchan(L1CTL, g_pars); @@ -1664,7 +1664,7 @@ valueof(t_RSL_IE(RSL_IE_TIMING_ADVANCE, RSL_IE_Body:{timing_adv := 0})), valueof(t_RSL_IE(RSL_IE_MS_POWER, RSL_IE_Body:{ms_power := ts_RSL_IE_MS_Power(0)})) }; - f_rsl_chan_act(g_pars.chan_mode, more_ies := addl_ies, act_type := t_RSL_IE_ActType_HO_SYNC); + f_rsl_chan_act(g_pars.chan_mode, more_ies := addl_ies, act_type := c_RSL_IE_ActType_HO_SYNC); /* don't perform immediate assignment here, as we're testing non-IA case */ /* enable dedicated mode */ f_l1ctl_est_dchan(L1CTL, g_pars); @@ -1997,7 +1997,7 @@ /* Activate a channel on the BTS side (no encryption) */ f_rsl_chan_act(g_pars.chan_mode, more_ies := { ho_ref_ie }, - act_type := t_RSL_IE_ActType_HO_SYNC); + act_type := c_RSL_IE_ActType_HO_SYNC); /* Switch the MS side (e.g. trxcon) to a dedicated channel without * waiting for Immediate Assignment and sending Access Burst */ @@ -2069,7 +2069,7 @@ /* Activate a channel on the BTS side (no encryption) */ f_rsl_chan_act(g_pars.chan_mode, more_ies := { ho_ref_ie }, - act_type := t_RSL_IE_ActType_HO_SYNC); + act_type := c_RSL_IE_ActType_HO_SYNC); /* Switch the MS side (e.g. trxcon) to a dedicated channel without * waiting for Immediate Assignment and sending of an Access Burst. */ @@ -2527,7 +2527,7 @@ /* Establish dedicated channel: L1CTL + RSL side */ private function f_est_dchan(boolean encr_enable := false, RSL_IE_List more_ies := {}, - RSL_IE_ActivationType act_type := t_RSL_IE_ActType_IA) runs on ConnHdlr { + RSL_IE_ActivationType act_type := c_RSL_IE_ActType_IA) runs on ConnHdlr { var ChannelDescription ch_desc; /* Activate channel on BTS side */ @@ -7182,7 +7182,7 @@ friend template RllTestCase t_EITC(template (present) uint3_t sapi, template (present) RslLinkId id, octetstring l3, boolean exp, - RSL_IE_ActivationType act_type := t_RSL_IE_ActType_IA) := { + RSL_IE_ActivationType act_type := c_RSL_IE_ActType_IA) := { sapi := sapi, link_id := id, l3 := l3, @@ -7263,7 +7263,7 @@ /* normal SAPI0 establishment (immediate assignment) */ valueof(t_EITC(0, ts_RslLinkID_DCCH(0), ''O, false)), /* normal SAPI0 establishment (normal assignment) */ - valueof(t_EITC(0, ts_RslLinkID_DCCH(0), ''O, true, t_RSL_IE_ActType_ASS)), + valueof(t_EITC(0, ts_RslLinkID_DCCH(0), ''O, true, c_RSL_IE_ActType_ASS)), /* SAPI 3 doesn't support contention resolution */ valueof(t_EITC(3, ts_RslLinkID_DCCH(3), '01020304'O, false)), valueof(t_EITC(3, ts_RslLinkID_SACCH(3), '01020304'O, false)), @@ -8860,7 +8860,7 @@ [] L1CTL.receive { repeat; } [] T.timeout; } - RSL.send(ts_RSL_CHAN_ACT(g_chan_nr, g_pars.chan_mode, t_RSL_IE_ActType_IA)); + RSL.send(ts_RSL_CHAN_ACT(g_chan_nr, g_pars.chan_mode, c_RSL_IE_ActType_IA)); RSL.receive(tr_RSL_CHAN_ACT_ACK(g_chan_nr)); /* Now expect the IMM ASS on Um */ diff --git a/library/RSL_Types.ttcn b/library/RSL_Types.ttcn index 1940b09..4597cc0 100644 --- a/library/RSL_Types.ttcn +++ b/library/RSL_Types.ttcn @@ -298,22 +298,22 @@ ACT_REL_TO_OSMO_PDCH ('111'B) } with { variant "FIELDLENGTH(3)" }; - const RSL_IE_ActivationType t_RSL_IE_ActType_IA := { + const RSL_IE_ActivationType c_RSL_IE_ActType_IA := { reactivation := false, reserved := 0, a_bits := ACT_REL_TO_IMM_ASSIGN } - const RSL_IE_ActivationType t_RSL_IE_ActType_ASS := { + const RSL_IE_ActivationType c_RSL_IE_ActType_ASS := { reactivation := false, reserved := 0, a_bits := ACT_REL_TO_NORM_ASSIGN } - const RSL_IE_ActivationType t_RSL_IE_ActType_HO_ASYNC := { + const RSL_IE_ActivationType c_RSL_IE_ActType_HO_ASYNC := { reactivation := false, reserved := 0, a_bits := ACT_REL_TO_ASYNC_HANDOVER } - const RSL_IE_ActivationType t_RSL_IE_ActType_HO_SYNC := { + const RSL_IE_ActivationType c_RSL_IE_ActType_HO_SYNC := { reactivation := false, reserved := 0, a_bits := ACT_REL_TO_SYNC_HANDOVER @@ -1614,7 +1614,7 @@ /* 8.4.1 BSC -> BTS */ template (value) RSL_Message ts_RSL_CHAN_ACT(template (value) RslChannelNr chan_nr, template (value) RSL_IE_ChannelMode mode, - template (value) RSL_IE_ActivationType at := t_RSL_IE_ActType_IA) := { + template (value) RSL_IE_ActivationType at := c_RSL_IE_ActType_IA) := { msg_disc := ts_RSL_MsgDisc(RSL_MDISC_DCHAN, false), msg_type := RSL_MT_CHAN_ACTIV, ies :={ @@ -1626,7 +1626,7 @@ } template RSL_Message tr_RSL_CHAN_ACT(template RslChannelNr chan_nr, template RSL_IE_ChannelMode mode, - template (value) RSL_IE_ActivationType at := t_RSL_IE_ActType_IA) := { + template (value) RSL_IE_ActivationType at := c_RSL_IE_ActType_IA) := { msg_disc := tr_RSL_MsgDisc(RSL_MDISC_DCHAN, false), msg_type := RSL_MT_CHAN_ACTIV, ies :={ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38693?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4ae8f6c35f6f823060833f24a0cad41cc9894750 Gerrit-Change-Number: 38693 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-hnbgw[pespin/rel-1.6.0]: Bump version: 1.6.0.7-a253 → 1.6.1

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38714?usp=email ) Change subject: Bump version: 1.6.0.7-a253 → 1.6.1 ...................................................................... Bump version: 1.6.0.7-a253 → 1.6.1 Change-Id: I1cccf6c3851b05787dcd82026065d74af08ddc84 --- M debian/changelog 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/14/38714/1 diff --git a/debian/changelog b/debian/changelog index 094805b..1e98786 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,18 @@ +osmo-hnbgw (1.6.1) unstable; urgency=medium + + [ Neels Janosch Hofmeyr ] + * drop config.vty tests from make check + * coverity CID#358071 + * coverity CID#358072 + * coverity CID#358070 + * coverity CID#358069 + + [ Pau Espin Pedrol ] + * ps_rab_ass_fsm: Fix uninitialized ptr access + * hnbgw: Fix wrong map object retrieved from hashtable + + -- Pau Espin Pedrol <pespin(a)sysmocom.de> Fri, 08 Nov 2024 16:10:50 +0100 + osmo-hnbgw (1.6.0) unstable; urgency=medium [ Pau Espin Pedrol ] -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38714?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: pespin/rel-1.6.0 Gerrit-Change-Id: I1cccf6c3851b05787dcd82026065d74af08ddc84 Gerrit-Change-Number: 38714 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-hnbgw[pespin/rel-1.6.0]: drop config.vty tests from make check

by pespin

Attention is currently required from: fixeria, osmith. Hello Jenkins Builder, fixeria, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38700?usp=email to look at the new patch set (#2). Change subject: drop config.vty tests from make check ...................................................................... drop config.vty tests from make check The intention of those tests was to test various osmo-hnbgw startup scenarios. It seemed the fastest/simplest way to do it at the time, but the output depends on another library, regularly causing test fallout. Keep the tests around for reference. They can still be invoked manually with 'make config-tests'. Related: OS#6380 Change-Id: I9c1540904b13d25db1c7933a88f6cc4b028fdd2b (cherry picked from commit 4468d8728e07d9e74a8b08d8bf2d903cc4c5bbfc) --- M tests/Makefile.am 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/00/38700/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38700?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-hnbgw Gerrit-Branch: pespin/rel-1.6.0 Gerrit-Change-Id: I9c1540904b13d25db1c7933a88f6cc4b028fdd2b Gerrit-Change-Number: 38700 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024