October 2024 - gerrit-log - lists.osmocom.org

[XS] Change in libosmo-sigtran[master]: ss7 vty: Limit route priority range to 1-9

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38426?usp=email ) Change subject: ss7 vty: Limit route priority range to 1-9 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38426?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I36ceee5d7cb1b2287c4a2d7ad67f478843300a0b Gerrit-Change-Number: 38426 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 16 Oct 2024 09:08:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

8 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: sgsn: Introduce test TC_attach_pdp_act_user_addr_itu_x213_ipv4toolarge

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38437?usp=email ) Change subject: sgsn: Introduce test TC_attach_pdp_act_user_addr_itu_x213_ipv4toolarge ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File sgsn/SGSN_Tests_Iu.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38437/comment/1526f265_eea4… : PS1, Line 172: the "the PDP Context"? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38437?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id2501e38565db491a6248552e754f03f7b973997 Gerrit-Change-Number: 38437 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 16 Oct 2024 09:06:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

8 months, 2 weeks

1
0
0 0

[XS] Change in docker-playground[master]: make/Makefile: Update git branch references for asterisk and pjproject

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/38439?usp=email ) Change subject: make/Makefile: Update git branch references for asterisk and pjproject ...................................................................... make/Makefile: Update git branch references for asterisk and pjproject The branches were modified a while ago to point to a development branch while in heavy development phase. The work has been merged into feature branches now, so move to those now that bulk of work is done. Change-Id: I28e86f8d9ce5d46e1a891f83ec365ac9ca4e289f --- M make/Makefile 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: jolly: Looks good to me, approved Jenkins Builder: Verified diff --git a/make/Makefile b/make/Makefile index 4ee4525..c39f2a8 100644 --- a/make/Makefile +++ b/make/Makefile @@ -17,7 +17,7 @@ USERNAME?=$(USER) UID=$(shell id -u) NAME?=$(shell basename $(CURDIR)) -ASTERISK_BRANCH?=jolly/work +ASTERISK_BRANCH?=sysmocom/20.7.0 LIBOSMOCORE_BRANCH?=master OSMO_TTCN3_BRANCH?=master OSMO_BB_BRANCH?=master @@ -42,7 +42,7 @@ OSMO_STP_BRANCH?=master OSMO_UECUPS_BRANCH?=master OPEN5GS_BRANCH?=main -PJPROJECT_BRANCH?=jolly/work +PJPROJECT_BRANCH?=sysmocom/2.14 BUILD_ARGS?= RUN_ARGS?=-it UPSTREAM_DISTRO?=debian:bookworm -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/38439?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I28e86f8d9ce5d46e1a891f83ec365ac9ca4e289f Gerrit-Change-Number: 38439 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

8 months, 2 weeks

1
0
0 0

[XS] Change in docker-playground[master]: make/Makefile: Update git branch references for asterisk and pjproject

by jolly

Attention is currently required from: pespin. jolly has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/docker-playground/+/38439?usp=email ) Change subject: make/Makefile: Update git branch references for asterisk and pjproject ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/38439?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I28e86f8d9ce5d46e1a891f83ec365ac9ca4e289f Gerrit-Change-Number: 38439 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 16 Oct 2024 08:50:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

8 months, 2 weeks

1
0
0 0

[XS] Change in docker-playground[master]: make/Makefile: Update git branch references for asterisk and pjproject

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/38439?usp=email ) Change subject: make/Makefile: Update git branch references for asterisk and pjproject ...................................................................... make/Makefile: Update git branch references for asterisk and pjproject The branches were modified a while ago to point to a development branch while in heavy development phase. The work has been merged into feature branches now, so move to those now that bulk of work is done. Change-Id: I28e86f8d9ce5d46e1a891f83ec365ac9ca4e289f --- M make/Makefile 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/39/38439/1 diff --git a/make/Makefile b/make/Makefile index 4ee4525..c39f2a8 100644 --- a/make/Makefile +++ b/make/Makefile @@ -17,7 +17,7 @@ USERNAME?=$(USER) UID=$(shell id -u) NAME?=$(shell basename $(CURDIR)) -ASTERISK_BRANCH?=jolly/work +ASTERISK_BRANCH?=sysmocom/20.7.0 LIBOSMOCORE_BRANCH?=master OSMO_TTCN3_BRANCH?=master OSMO_BB_BRANCH?=master @@ -42,7 +42,7 @@ OSMO_STP_BRANCH?=master OSMO_UECUPS_BRANCH?=master OPEN5GS_BRANCH?=main -PJPROJECT_BRANCH?=jolly/work +PJPROJECT_BRANCH?=sysmocom/2.14 BUILD_ARGS?= RUN_ARGS?=-it UPSTREAM_DISTRO?=debian:bookworm -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/38439?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I28e86f8d9ce5d46e1a891f83ec365ac9ca4e289f Gerrit-Change-Number: 38439 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

8 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: sgsn: Test tx Rab Ass Resp with ITU X.213 IPv4 address format

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38434?usp=email ) Change subject: sgsn: Test tx Rab Ass Resp with ITU X.213 IPv4 address format ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38434?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I38dd85f617600a974cbe8fd17597282eaf950a78 Gerrit-Change-Number: 38434 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 16 Oct 2024 08:42:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

8 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: sgsn: Validate TLI received in RAB Ass Req

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38433?usp=email ) Change subject: sgsn: Validate TLI received in RAB Ass Req ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38433?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3a3699cea981caa89b30742c031d5f232418b0ee Gerrit-Change-Number: 38433 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 16 Oct 2024 08:41:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

8 months, 2 weeks

1
0
0 0

[XS] Change in libosmo-sigtran[master]: osmo_ss7_route_destroy(): Fix potential null ptr deref

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38438?usp=email ) Change subject: osmo_ss7_route_destroy(): Fix potential null ptr deref ...................................................................... osmo_ss7_route_destroy(): Fix potential null ptr deref rt ptr was being dereferenced already before checking for null. Related: Coverity CID#425367 Change-Id: Idf7613e174e564fb388cd82dca897ff13001217b --- M src/osmo_ss7.c 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/38/38438/1 diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c index bcbe76c..93bcfc2 100644 --- a/src/osmo_ss7.c +++ b/src/osmo_ss7.c @@ -908,17 +908,16 @@ /*! \brief Destroy a given SS7 route */ void osmo_ss7_route_destroy(struct osmo_ss7_route *rt) { - struct osmo_ss7_route_table *rtbl = rt->rtable; - OSMO_ASSERT(ss7_initialized); if (!rt) return; if (ss7_route_inserted(rt)) { - LOGSS7(rtbl->inst, LOGL_INFO, + struct osmo_ss7_instance *inst = rt->rtable->inst; + LOGSS7(inst, LOGL_INFO, "Destroying route: pc=%u=%s mask=0x%x via linkset/ASP '%s'\n", - rt->cfg.pc, osmo_ss7_pointcode_print(rtbl->inst, rt->cfg.pc), + rt->cfg.pc, osmo_ss7_pointcode_print(inst, rt->cfg.pc), rt->cfg.mask, rt->cfg.linkset_name); llist_del(&rt->list); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38438?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Idf7613e174e564fb388cd82dca897ff13001217b Gerrit-Change-Number: 38438 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

8 months, 2 weeks

1
0
0 0

[S] Change in osmo-msc[master]: vlr: set the correct CN domain on GSUP messages

by laforge

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38406?usp=email ) Change subject: vlr: set the correct CN domain on GSUP messages ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: > Not all GSUP Messages has it according to the hlr manual. […] never-ending then. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38406?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I045f29647b0f122a653881030d09de35b64f4dd1 Gerrit-Change-Number: 38406 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 15 Oct 2024 17:35:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

8 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: sgsn: Test tx Rab Ass Resp with ITU X.213 IPv4 address format

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38434?usp=email ) Change subject: sgsn: Test tx Rab Ass Resp with ITU X.213 IPv4 address format ...................................................................... Patch Set 3: (1 comment) File sgsn/SGSN_Tests_Iu.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38434/comment/37d3bba7_4605… : PS2, Line 151: function f_TC_attach_pdp_act_user_addr_itu_x213_ipv4len(octetstring padding) runs on test_CT { > I may actually want to pass the imsi_suffix (1055) here as a param. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38434?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I38dd85f617600a974cbe8fd17597282eaf950a78 Gerrit-Change-Number: 38434 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Oct 2024 17:30:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

8 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2024