Attention is currently required from: fixeria, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375?usp=email )
Change subject: ss7 vty: Fix insert order of routes with higher priority
......................................................................
Patch Set 3:
(4 comments)
File src/osmo_ss7.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/9dd43fb6_8ce85… :
PS3, Line 664: insertd
> inserted
Done
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/8bc371a9_66b09… :
PS3, Line 736: return -ENODEV;
> other error returns above log a message. […]
I prefer keeping it this way since the typology of return is different here.
The others are really unexpected state problems which deserve logging. This one here, on the other hand, is just the lookup failing and makes more sense that the caller logs whatever it pleases.
Otherwise for instance if some VTY user types in some asp with a typo we end up with a error in log which really doesn't have any kind of problem during the normal operation of the program.
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/706a655f_eca27… :
PS3, Line 857: LOGSS7(rtbl->inst, LOGL_ERROR, "Refusing to create duplicate route: "
> maybe be more specific here: "Refusing to create route with existing linkset name"
Done
File src/osmo_ss7_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/56e15297_69056… :
PS3, Line 401: find
> set?
The real only expected cause of this failing here is that the linkset cannot be found, so it's far more informative as it is now.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I6e7b5e3f06ae2c9468da58c55d2f42cbcd777218
Gerrit-Change-Number: 38375
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 10 Oct 2024 15:07:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Attention is currently required from: laforge, osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38341?usp=email )
Change subject: ggsn: testenv: run SUT on bridge instead of lo
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38341?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib768603b0050fe62baff39cab982a850eb91f49a
Gerrit-Change-Number: 38341
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 10 Oct 2024 14:58:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/38368?usp=email )
Change subject: publish-manuals-for-tags: fix build deps install
......................................................................
publish-manuals-for-tags: fix build deps install
Use the absolute path when checking for debian/control in
build_publish_manuals(), as we aren't in the /build directory at that
point.
Fixes: 072b1eae88 ("manuals: publish pyosmocom manuals for releases")
Change-Id: I8749107b974a4a8d57da868829a8f548404f3fa3
---
M scripts/manuals/publish-manuals-for-tags.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
pespin: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/scripts/manuals/publish-manuals-for-tags.sh b/scripts/manuals/publish-manuals-for-tags.sh
index 50b7a3b..610457a 100755
--- a/scripts/manuals/publish-manuals-for-tags.sh
+++ b/scripts/manuals/publish-manuals-for-tags.sh
@@ -368,7 +368,7 @@
# Install dependencies
case $repo in
*)
- if [ -e debian/control ]; then
+ if [ -e /build/debian/control ]; then
apt-get -y build-dep /build
fi
;;
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38368?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I8749107b974a4a8d57da868829a8f548404f3fa3
Gerrit-Change-Number: 38368
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/38376?usp=email )
Change subject: netdev: osmo_netdev_set_ifupdown_ind_cb(): Fix documentation copy-paste error
......................................................................
netdev: osmo_netdev_set_ifupdown_ind_cb(): Fix documentation copy-paste error
Change-Id: I334bc7aa2fde4a880fdf25d57d24b05be8e8df85
---
M src/core/netdev.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/76/38376/1
diff --git a/src/core/netdev.c b/src/core/netdev.c
index 318134a..7ef7657 100644
--- a/src/core/netdev.c
+++ b/src/core/netdev.c
@@ -750,9 +750,9 @@
return netdev->priv_data;
}
-/*! Set data_ind_cb callback, called when a new packet is received on the network interface.
+/*! Set ifupdown_ind_cb callback, called when the link status (UP/DOWN) changes.
* \param[in] netdev The netdev object where the field is set
- * \param[in] data_ind_cb the user provided function to be called when the link status (UP/DOWN) changes
+ * \param[in] ifupdown_ind_cb the user provided function to be called when the link status (UP/DOWN) changes
*/
void osmo_netdev_set_ifupdown_ind_cb(struct osmo_netdev *netdev, osmo_netdev_ifupdown_ind_cb_t ifupdown_ind_cb)
{
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38376?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I334bc7aa2fde4a880fdf25d57d24b05be8e8df85
Gerrit-Change-Number: 38376
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38370?usp=email )
Change subject: testenv: bridge: change default IPs 201 -> 1
......................................................................
testenv: bridge: change default IPs 201 -> 1
During code review it was decided that we want to keep the 127.0.0.1
(and other 127.0.0.x) IPs in the configs, so one can start the testsuite
with osmo-ggsn directly on the host without using testenv scripts too,
with the same config.
The testenv script for osmo-ggsn will replace 127.0.0.x with 172.18.3.x
on the fly before the testsuite starts, so we can run osmo-ggsn
optionally in QEMU on 172.18.3.2, which will be bridged to the host.
172.18.3.1 will be used by the GGSN testsuite now, instead of
172.18.3.201 as previously planned, so change the default IP of the
bridge. The bridge is not used for another testsuite yet.
Add the 201 IPs as EXTRA_IPS for the non-QEMU case, as they are
configured as DNS IPs and tests need to be able to reach them.
Change-Id: Ied055e6e4d6214fd5247694e697a35a1e8ff1966
---
M _testenv/data/scripts/add_remove_testenv0_bridge.sh
M ggsn_tests/open5gs/testenv.sh
M ggsn_tests/osmo-ggsn/testenv.sh
3 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
diff --git a/_testenv/data/scripts/add_remove_testenv0_bridge.sh b/_testenv/data/scripts/add_remove_testenv0_bridge.sh
index cb1b6a3..71036e1 100755
--- a/_testenv/data/scripts/add_remove_testenv0_bridge.sh
+++ b/_testenv/data/scripts/add_remove_testenv0_bridge.sh
@@ -3,8 +3,8 @@
# bridge device, which can be used to talk to a SUT running in QEMU.
# Set env var EXTRA_IPS to add additional IP addresses to the device.
DEV="testenv0"
-IP4="172.18.3.201/24"
-IP6="fd02:db8:3::201/128"
+IP4="172.18.3.1/24"
+IP6="fd02:db8:3::1/128"
set -x
add_bridge() {
diff --git a/ggsn_tests/open5gs/testenv.sh b/ggsn_tests/open5gs/testenv.sh
index e06d771..32563fb 100755
--- a/ggsn_tests/open5gs/testenv.sh
+++ b/ggsn_tests/open5gs/testenv.sh
@@ -69,7 +69,7 @@
# Add a bridge reachable through the GTP tunnel that can answer ICMP
# pings (for e.g. TC_pdp4_act_deact_gtpu_access). The bridge is also used to
# connect the SUT when it runs in QEMU.
-add_remove_testenv0_bridge.sh
+EXTRA_IPS="172.18.3.201 fd02:db8:3::201" add_remove_testenv0_bridge.sh
case "$TESTENV_CLEAN_REASON" in
prepare)
diff --git a/ggsn_tests/osmo-ggsn/testenv.sh b/ggsn_tests/osmo-ggsn/testenv.sh
index 0275ad2..bded804 100755
--- a/ggsn_tests/osmo-ggsn/testenv.sh
+++ b/ggsn_tests/osmo-ggsn/testenv.sh
@@ -52,7 +52,7 @@
# Add a bridge reachable through the GTP tunnel that can answer ICMP
# pings (for e.g. TC_pdp4_act_deact_gtpu_access). The bridge is also used to
# connect the SUT when it runs in QEMU.
-add_remove_testenv0_bridge.sh
+EXTRA_IPS="172.18.3.201 fd02:db8:3::201" add_remove_testenv0_bridge.sh
case "$TESTENV_CLEAN_REASON" in
prepare)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38370?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ied055e6e4d6214fd5247694e697a35a1e8ff1966
Gerrit-Change-Number: 38370
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: osmith.
fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38343?usp=email )
Change subject: testenv: support running SUT in QEMU
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38343?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic9cb7092fd029b7ba530fc755b5d4d73a9d86350
Gerrit-Change-Number: 38343
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 10 Oct 2024 14:40:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes