January 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-hnbgw[master]: tweak vty doc: "UDP port"
by neels 25 Jan '24

25 Jan '24

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35642?usp=email ) Change subject: tweak vty doc: "UDP port" ...................................................................... tweak vty doc: "UDP port" Change-Id: I24e52143a8f3d0c9f92985f6bb0420b34926eb33 --- M src/osmo-hnbgw/hnbgw_vty.c 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-hnbgw/hnbgw_vty.c b/src/osmo-hnbgw/hnbgw_vty.c index 62fe4aa..674832b 100644 --- a/src/osmo-hnbgw/hnbgw_vty.c +++ b/src/osmo-hnbgw/hnbgw_vty.c @@ -836,7 +836,7 @@ DEFUN(cfg_pfcp_local_port, cfg_pfcp_local_port_cmd, "local-port <1-65535>", "Local port for PFCP\n" - "IP port\n") + "UDP port\n") { g_hnbgw->config.pfcp.local_port = atoi(argv[0]); return CMD_SUCCESS; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35642?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I24e52143a8f3d0c9f92985f6bb0420b34926eb33 Gerrit-Change-Number: 35642 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-hnbgw[master]: add tests/pfcp_cfg.vty.with_pfcp
by neels 25 Jan '24

25 Jan '24

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35643?usp=email ) Change subject: add tests/pfcp_cfg.vty.with_pfcp ...................................................................... add tests/pfcp_cfg.vty.with_pfcp So far, we had no pfcp.vty test, because PFCP support is built conditionally, and the pfcp.vty test would always fail without PFCP support. Add a pfcp test for the VTY, conditionally: use suffix .vty.with_pfcp to identify tests that need PFCP support, and run those only when configured with --enable-pfcp. Related: SYS#5895 Change-Id: Ibb1797bb43a18f26fc693e0c8920cfd1f5fb9ede --- M tests/Makefile.am A tests/pfcp_cfg.vty.with_pfcp 2 files changed, 78 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/tests/Makefile.am b/tests/Makefile.am index d499c33..df9e5a9 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -26,6 +26,7 @@ $(TESTSUITE) \ osmo-hnbgw-vty-test.cfg \ $(srcdir)/*.vty \ + $(srcdir)/*.vty.with_pfcp \ $(srcdir)/*.ctrl \ $(srcdir)/config/*.cfg \ $(srcdir)/config/*.vty \ @@ -50,7 +51,11 @@ endif # Run a specific test with: 'make vty-test VTY_TEST=osmo-hnbgw.vty' +if ENABLE_PFCP +VTY_TEST ?= *.vty* +else VTY_TEST ?= *.vty +endif # To update the VTY script from current application behavior, # pass -u to vty_script_runner.py by doing: diff --git a/tests/pfcp_cfg.vty.with_pfcp b/tests/pfcp_cfg.vty.with_pfcp new file mode 100644 index 0000000..a093ffb --- /dev/null +++ b/tests/pfcp_cfg.vty.with_pfcp @@ -0,0 +1,55 @@ +OsmoHNBGW> enable +OsmoHNBGW# configure terminal + +OsmoHNBGW(config)# hnbgw +OsmoHNBGW(config-hnbgw)# list +... + pfcp +... +OsmoHNBGW(config-hnbgw)# pfcp? + pfcp Configure PFCP for GTP tunnel mapping + +OsmoHNBGW(config-hnbgw)# pfcp +OsmoHNBGW(config-hnbgw-pfcp)# list +... + local-addr IP_ADDR + local-port <1-65535> + remote-addr IP_ADDR + +OsmoHNBGW(config-hnbgw-pfcp)# local-addr? + local-addr Local address for PFCP +OsmoHNBGW(config-hnbgw-pfcp)# local-addr ? + IP_ADDR IP address + +OsmoHNBGW(config-hnbgw-pfcp)# local-port? + local-port Local port for PFCP +OsmoHNBGW(config-hnbgw-pfcp)# local-port ? + <1-65535> UDP port + +OsmoHNBGW(config-hnbgw-pfcp)# remote-addr? + remote-addr Remote UPF's listen IP address; where to send PFCP requests +OsmoHNBGW(config-hnbgw-pfcp)# remote-addr ? + IP_ADDR IP address + + +OsmoHNBGW(config-hnbgw-pfcp)# show running-config +... +hnbgw +... + pfcp +msc 0 +... + +OsmoHNBGW(config-hnbgw-pfcp)# remote-addr 127.0.0.2 +OsmoHNBGW(config-hnbgw-pfcp)# local-addr 127.0.0.1 +OsmoHNBGW(config-hnbgw-pfcp)# local-port 8805 + +OsmoHNBGW(config-hnbgw-pfcp)# show running-config +... +hnbgw +... + pfcp + local-addr 127.0.0.1 + remote-addr 127.0.0.2 +msc 0 +... -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35643?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ibb1797bb43a18f26fc693e0c8920cfd1f5fb9ede Gerrit-Change-Number: 35643 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-hnbgw[master]: pfcp: fix missing vty_write of pfcp local-port
by neels 25 Jan '24

25 Jan '24

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35644?usp=email ) Change subject: pfcp: fix missing vty_write of pfcp local-port ...................................................................... pfcp: fix missing vty_write of pfcp local-port Change-Id: I180e67b8abdd3c0d91b30f1e7668b02f1a323809 --- M src/osmo-hnbgw/hnbgw_vty.c M tests/pfcp_cfg.vty.with_pfcp 2 files changed, 12 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/osmo-hnbgw/hnbgw_vty.c b/src/osmo-hnbgw/hnbgw_vty.c index 674832b..d401279 100644 --- a/src/osmo-hnbgw/hnbgw_vty.c +++ b/src/osmo-hnbgw/hnbgw_vty.c @@ -945,6 +945,8 @@ vty_out(vty, " pfcp%s", VTY_NEWLINE); if (g_hnbgw->config.pfcp.local_addr) vty_out(vty, " local-addr %s%s", g_hnbgw->config.pfcp.local_addr, VTY_NEWLINE); + if (g_hnbgw->config.pfcp.local_port) + vty_out(vty, " local-port %u%s", g_hnbgw->config.pfcp.local_port, VTY_NEWLINE); if (g_hnbgw->config.pfcp.remote_addr) vty_out(vty, " remote-addr %s%s", g_hnbgw->config.pfcp.remote_addr, VTY_NEWLINE); diff --git a/tests/pfcp_cfg.vty.with_pfcp b/tests/pfcp_cfg.vty.with_pfcp index a093ffb..44b922c 100644 --- a/tests/pfcp_cfg.vty.with_pfcp +++ b/tests/pfcp_cfg.vty.with_pfcp @@ -50,6 +50,7 @@ ... pfcp local-addr 127.0.0.1 + local-port 8805 remote-addr 127.0.0.2 msc 0 ... -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35644?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I180e67b8abdd3c0d91b30f1e7668b02f1a323809 Gerrit-Change-Number: 35644 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-hnbgw[master]: pfcp: fix modification of wrong FAR ID
by neels 25 Jan '24

25 Jan '24

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35641?usp=email ) Change subject: pfcp: fix modification of wrong FAR ID ...................................................................... pfcp: fix modification of wrong FAR ID Do not update the Core-facing Forwarding Action Rule with the Access side's remote TEID, update the Access-facing FAR as we should. This is a seemingly small but very grave bug in osmo-hnbgw's PFCP implementation, and proof that no-one anywhere has tested osmo-hnbgw's PFCP support properly yet. Related: SYS#5895 Change-Id: I596f1785d280d7e53e0cef649d6bb5df01ebf648 --- M src/osmo-hnbgw/ps_rab_fsm.c 1 file changed, 20 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-hnbgw/ps_rab_fsm.c b/src/osmo-hnbgw/ps_rab_fsm.c index df98826..512c983 100644 --- a/src/osmo-hnbgw/ps_rab_fsm.c +++ b/src/osmo-hnbgw/ps_rab_fsm.c @@ -519,7 +519,8 @@ static void ps_rab_fsm_wait_pfcp_mod_resp_onenter(struct osmo_fsm_inst *fi, uint32_t prev_state) { /* We have been given the Access side's remote F-TEID, now in rab->access.remote, and we need to tell the UPF - * about it. */ + * about it. This affects the Core to Access direction: now we know where to forward payloads coming from Core. + */ struct ps_rab *rab = fi->priv; struct osmo_pfcp_msg *m; @@ -531,7 +532,7 @@ m = ps_rab_new_pfcp_msg_req(rab, OSMO_PFCP_MSGT_SESSION_MOD_REQ); - if (rab_to_pfcp_session_mod_req_upd_far(&m->ies.session_mod_req, ID_ACCESS_TO_CORE, &rab->access.remote)) { + if (rab_to_pfcp_session_mod_req_upd_far(&m->ies.session_mod_req, ID_CORE_TO_ACCESS, &rab->access.remote)) { LOG_PS_RAB(rab, LOGL_ERROR, "error composing Update FAR IE in PFCP msg\n"); ps_rab_failure(rab); return; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35641?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I596f1785d280d7e53e0cef649d6bb5df01ebf648 Gerrit-Change-Number: 35641 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-upf[master]: manual: explain GTP Echo workaround for tunmap
by neels 25 Jan '24

25 Jan '24

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/35667?usp=email ) Change subject: manual: explain GTP Echo workaround for tunmap ...................................................................... Patch Set 1: (1 comment) File doc/manuals/chapters/running.adoc: https://gerrit.osmocom.org/c/osmo-upf/+/35667/comment/86d4bc94_429a9657 PS1, Line 105: serving as GTP tunnel endpoint. do you mean this section? -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/35667?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic824fc876d1fad181254cb6894e51464c443b53c Gerrit-Change-Number: 35667 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 25 Jan 2024 01:07:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: gsm: add more definitions from Table 10.5.112/3GPP TS 24.008
by fixeria 24 Jan '24

24 Jan '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35680?usp=email ) Change subject: gsm: add more definitions from Table 10.5.112/3GPP TS 24.008 ...................................................................... gsm: add more definitions from Table 10.5.112/3GPP TS 24.008 Change-Id: I25e40853ace09fa98b614f3893eeba600be8fcdc Related: OS#4396 --- M include/osmocom/gsm/protocol/gsm_04_08.h 1 file changed, 32 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/80/35680/1 diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h b/include/osmocom/gsm/protocol/gsm_04_08.h index 84b2b2a..5d1da74 100644 --- a/include/osmocom/gsm/protocol/gsm_04_08.h +++ b/include/osmocom/gsm/protocol/gsm_04_08.h @@ -2210,6 +2210,28 @@ GSM48_BCAP_MT_AUTO_1 = 8, }; +/*! Table 10.5.112/3GPP TS 24.008: Other modem type (octet 6d) */ +enum gsm48_bcap_other_modem_type { + GSM48_BCAP_OTHER_MT_NONE = 0, /*!< No other modem type specified */ + GSM48_BCAP_OTHER_MT_V34 = 2, /*!< According to ITU-T Rec. V.34 */ +}; + +/*! Table 10.5.112/3GPP TS 24.008: Fixed network user rate (octet 6d) */ +enum gsm48_bcap_fixed_net_user_rate { + GSM48_BCAP_FNUR_NONE = 0, /*!< FNUR not applicable / No meaning associated */ + GSM48_BCAP_FNUR_X1_V110_9600 = 1, /*!< 9.6 kbit/s (according to ITU-T Rec. X.1 and V.110) */ + GSM48_BCAP_FNUR_X1_V110_14400 = 2, /*!< 14.4 kbit/s (according to ITU-T Rec. X.1 and V.110) */ + GSM48_BCAP_FNUR_X1_V110_19200 = 3, /*!< 19.2 kbit/s (according to ITU-T Rec. X.1 and V.110) */ + GSM48_BCAP_FNUR_X1_V110_28800 = 4, /*!< 28.8 kbit/s (according to ITU-T Rec. X.1 and V.110) */ + GSM48_BCAP_FNUR_X1_V110_38400 = 5, /*!< 38.4 kbit/s (according to ITU-T Rec. X.1 and V.110) */ + GSM48_BCAP_FNUR_X1_V110_48000 = 6, /*!< 48.0 kbit/s (according to ITU-T Rec. X.1 and V.110) */ + GSM48_BCAP_FNUR_X1_V110_56000 = 7, /*!< 56.0 kbit/s (according to ITU-T Rec. X.1 and V.110) */ + GSM48_BCAP_FNUR_BT_64000 = 8, /*!< 64.0 kbit/s bit transparent */ + GSM48_BCAP_FNUR_BT_33600 = 9, /*!< 33.6 kbit/s bit transparent */ + GSM48_BCAP_FNUR_I460_32000 = 10, /*!< 32.0 kbit/s (according to ITU-T Rec. I.460) */ + GSM48_BCAP_FNUR_V34_31200 = 11, /*!< 31.2 kbit/s (according to ITU-T Rec. V.34) */ +}; + /*! GSM 04.08 Bearer Capability: Speech Version Indication * (See also 3GPP TS 24.008, Table 10.5.103) */ enum gsm48_bcap_speech_ver { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35680?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I25e40853ace09fa98b614f3893eeba600be8fcdc Gerrit-Change-Number: 35680 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in libosmocore[master]: [WIP] gsm: gsm48_{en,de}code_bearer_cap: support octet 6d fields
by fixeria 24 Jan '24

24 Jan '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35681?usp=email ) Change subject: [WIP] gsm: gsm48_{en,de}code_bearer_cap: support octet 6d fields ...................................................................... [WIP] gsm: gsm48_{en,de}code_bearer_cap: support octet 6d fields Unfortunately, adding new fields to struct gsm_mncc_bearer_cap is not an option. This struct is part of the MNCC PDU, and doing so would result in breaking backwards compatibility :( Change-Id: I53ef5aee38e3a2f34d22f2745fdffdaf334ce0b6 Related: OS#4396 --- M include/osmocom/gsm/mncc.h M src/gsm/gsm48_ie.c M tests/gsm0408/gsm0408_test.c M tests/gsm0408/gsm0408_test.err M tests/gsm0408/gsm0408_test.ok 5 files changed, 64 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/81/35681/1 diff --git a/include/osmocom/gsm/mncc.h b/include/osmocom/gsm/mncc.h index db70235..4d96ee6 100644 --- a/include/osmocom/gsm/mncc.h +++ b/include/osmocom/gsm/mncc.h @@ -27,6 +27,8 @@ enum gsm48_bcap_interm_rate interm_rate; enum gsm48_bcap_transp transp; enum gsm48_bcap_modem_type modem_type; + enum gsm48_bcap_other_modem_type other_modem_type; + enum gsm48_bcap_fixed_net_user_rate fixed_net_user_rate; } data; }; diff --git a/src/gsm/gsm48_ie.c b/src/gsm/gsm48_ie.c index b95609f..2ab2452 100644 --- a/src/gsm/gsm48_ie.c +++ b/src/gsm/gsm48_ie.c @@ -289,6 +289,15 @@ return 0; bcap->data.transp = (lv[i] >> 5) & 3; bcap->data.modem_type = lv[i] & 0x1F; + + /* octet 6d */ + if (!(lv[i] & 0x80)) { + i++; + if (in_len < i) + return 0; + bcap->data.other_modem_type = (lv[i] >> 5) & 0x03; + bcap->data.fixed_net_user_rate = lv[i] & 0x1f; + } } } @@ -357,6 +366,14 @@ lv[i] = 0x80 | ((bcap->data.transp & 3) << 5) | (bcap->data.modem_type & 0x1f); + /* octet 6d */ + if (bcap->data.other_modem_type != GSM48_BCAP_OTHER_MT_NONE || + bcap->data.fixed_net_user_rate != GSM48_BCAP_FNUR_NONE) { + lv[i++] &= ~0x80; /* octet 6c becomes extended */ + lv[i] = 0x80 /* octet 6d is not extended */ + | (bcap->data.other_modem_type & 0x03) << 5 + | (bcap->data.fixed_net_user_rate & 0x1f); + } break; default: return -EINVAL; diff --git a/tests/gsm0408/gsm0408_test.c b/tests/gsm0408/gsm0408_test.c index 8a89357..2124227 100644 --- a/tests/gsm0408/gsm0408_test.c +++ b/tests/gsm0408/gsm0408_test.c @@ -75,6 +75,30 @@ }, }; +static const uint8_t csd_9600_v34_lv[] = { 0x08, 0xa2, 0xb8, 0x81, 0x21, 0x15, 0x63, 0x06, 0xc0 }; + +static const struct gsm_mncc_bearer_cap bcap_csd_9600_v34 = { + .transfer = GSM48_BCAP_ITCAP_3k1_AUDIO, + .mode = GSM48_BCAP_TMOD_CIRCUIT, + .coding = GSM48_BCAP_CODING_GSM_STD, + .radio = GSM48_BCAP_RRQ_FR_ONLY, + .speech_ver[0] = -1, + .data = { + .rate_adaption = GSM48_BCAP_RA_NONE, + .sig_access = GSM48_BCAP_SA_I440_I450, + .async = 1, + .nr_stop_bits = 1, + .nr_data_bits = 8, + .user_rate = GSM48_BCAP_UR_9600, + .parity = GSM48_BCAP_PAR_NONE, + .interm_rate = GSM48_BCAP_IR_16k, + .transp = GSM48_BCAP_TR_TRANSP, + .modem_type = GSM48_BCAP_MT_V32, + .other_modem_type = GSM48_BCAP_OTHER_MT_V34, + .fixed_net_user_rate = GSM48_BCAP_FNUR_NONE, + }, +}; + static const uint8_t csd_2400_v22bis_lv[] = { 0x07, 0xa2, 0xb8, 0x81, 0x21, 0x13, 0x43, 0x83 }; static const struct gsm_mncc_bearer_cap bcap_csd_2400_v22bis = { @@ -133,6 +157,9 @@ { csd_4800_rlp_lv, &bcap_csd_4800_rlp, "CSD 4800/RLP/non-transparent" }, { /* XXX: this testcase is expected to fail because octet 4 is not represented in * 'struct gsm_mncc_bearer_cap' and the encoder unconditionally hard-codes it to 0x88. */ + csd_9600_v34_lv, &bcap_csd_9600_v34, "CSD 9600/V.34/transparent" }, + { /* XXX: this testcase is expected to fail because octet 4 is not represented in + * 'struct gsm_mncc_bearer_cap' and the encoder unconditionally hard-codes it to 0x88. */ csd_2400_v22bis_lv, &bcap_csd_2400_v22bis, "CSD 2400/V.22bis/transparent" }, { speech_all_lv, &bcap_speech_all, "Speech, all codecs" }, { speech_no3a_lv, &bcap_speech_no3a, "Speech, without octet 3a" }, diff --git a/tests/gsm0408/gsm0408_test.err b/tests/gsm0408/gsm0408_test.err index 0102de0..bcf1294 100644 --- a/tests/gsm0408/gsm0408_test.err +++ b/tests/gsm0408/gsm0408_test.err @@ -1,3 +1,6 @@ +Incorrect encoded result of CSD 9600/V.34/transparent: + should: 08 a2 b8 81 21 15 63 06 c0 + is: 08 a2 88 81 21 15 63 06 c0 Incorrect encoded result of CSD 2400/V.22bis/transparent: should: 07 a2 b8 81 21 13 43 83 is: 07 a2 88 81 21 13 43 83 diff --git a/tests/gsm0408/gsm0408_test.ok b/tests/gsm0408/gsm0408_test.ok index 721e2c5..3002cc6 100644 --- a/tests/gsm0408/gsm0408_test.ok +++ b/tests/gsm0408/gsm0408_test.ok @@ -1,5 +1,6 @@ Test `CSD 9600/V.110/transparent' passed Test `CSD 4800/RLP/non-transparent' passed +Test `CSD 9600/V.34/transparent' failed Test `CSD 2400/V.22bis/transparent' failed Test `Speech, all codecs' passed Test `Speech, without octet 3a' failed -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35681?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I53ef5aee38e3a2f34d22f2745fdffdaf334ce0b6 Gerrit-Change-Number: 35681 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: tests/a5: fix bit-wise vs logical and in test_a5[34]()
by fixeria 24 Jan '24

24 Jan '24

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35679?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: tests/a5: fix bit-wise vs logical and in test_a5[34]() ...................................................................... tests/a5: fix bit-wise vs logical and in test_a5[34]() This fixes a -Wbitwise-instead-of-logical warning thrown by clang. Change-Id: I6ae0d13882ab7a6b1ca35ccd7f9a5e1d9cac911d --- M tests/a5/a5_test.c 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/79/35679/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35679?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6ae0d13882ab7a6b1ca35ccd7f9a5e1d9cac911d Gerrit-Change-Number: 35679 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmocore[master]: tests/iuup: fix duplicate assignment in def_configure_req
by fixeria 24 Jan '24

24 Jan '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35677?usp=email ) Change subject: tests/iuup: fix duplicate assignment in def_configure_req ...................................................................... tests/iuup: fix duplicate assignment in def_configure_req This fixes a -Winitializer-overrides warning thrown by clang. Change-Id: Id29237d212a05dec1c57bbfd53d9cb7e71ca0991 --- M tests/iuup/iuup_test.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/77/35677/1 diff --git a/tests/iuup/iuup_test.c b/tests/iuup/iuup_test.c index f3aba66..7798aa2 100644 --- a/tests/iuup/iuup_test.c +++ b/tests/iuup/iuup_test.c @@ -26,7 +26,6 @@ {.used = 1, .id = 2, .IPTI = 1, .subflow_sizes = {0, 0, 0} }, }, /* .delivery_err_sdu = All set to 0 (YES) by default, */ - .IPTIs_present = true, .t_init = { .t_ms = IUUP_TIMER_INIT_T_DEFAULT, .n_max = IUUP_TIMER_INIT_N_DEFAULT }, .t_ta = { .t_ms = IUUP_TIMER_TA_T_DEFAULT, .n_max = IUUP_TIMER_TA_N_DEFAULT }, .t_rc = { .t_ms = IUUP_TIMER_RC_T_DEFAULT, .n_max = IUUP_TIMER_RC_N_DEFAULT }, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35677?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id29237d212a05dec1c57bbfd53d9cb7e71ca0991 Gerrit-Change-Number: 35677 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: tests/sockaddr_str: comment out unused code (make clang happy)
by fixeria 24 Jan '24

24 Jan '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35678?usp=email ) Change subject: tests/sockaddr_str: comment out unused code (make clang happy) ...................................................................... tests/sockaddr_str: comment out unused code (make clang happy) This fixes a -Wunused-function warning thrown by clang. Change-Id: I45e9044f80e1f634c811e729f4314ec9bcf6a9ad --- M tests/sockaddr_str/sockaddr_str_test.c 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/78/35678/1 diff --git a/tests/sockaddr_str/sockaddr_str_test.c b/tests/sockaddr_str/sockaddr_str_test.c index 541c3a1..434a536 100644 --- a/tests/sockaddr_str/sockaddr_str_test.c +++ b/tests/sockaddr_str/sockaddr_str_test.c @@ -68,6 +68,7 @@ } } +#if 0 static const struct value_string err_names[] = { { -EINVAL, "-EINVAL" }, {} @@ -75,6 +76,7 @@ static inline const char *err_name(int err) { return get_value_string(err_names, err); } +#endif static inline const char *rc_name(int rc) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35678?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I45e9044f80e1f634c811e729f4314ec9bcf6a9ad Gerrit-Change-Number: 35678 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0