January 2024 - gerrit-log - lists.osmocom.org

[M] Change in pysim[master]: add contrib/eidtool.py: Tool for checking + computing EID checksum
by laforge 25 Jan '24

25 Jan '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/35682?usp=email ) Change subject: add contrib/eidtool.py: Tool for checking + computing EID checksum ...................................................................... add contrib/eidtool.py: Tool for checking + computing EID checksum Change-Id: If6c560a2de51718948fb99b816e080f2aff4d0ed --- A contrib/eidtool.py 1 file changed, 82 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/eidtool.py b/contrib/eidtool.py new file mode 100755 index 0000000..cd5992b --- /dev/null +++ b/contrib/eidtool.py @@ -0,0 +1,73 @@ +#!/usr/bin/env python3 + +# Command line tool to compute or verify EID (eUICC ID) values +# +# (C) 2024 by Harald Welte <laforge(a)osmocom.org> +# +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +import sys +import argparse + +from pySim.euicc import compute_eid_checksum, verify_eid_checksum + + +option_parser = argparse.ArgumentParser(formatter_class=argparse.RawDescriptionHelpFormatter, + description="""pySim EID Tool +This utility program can be used to compute or verify the checksum of an EID +(eUICC Identifier). See GSMA SGP.29 for the algorithm details. + +Example (verification): + $ eidtool.py --verify 89882119900000000000000000001654 + EID checksum verified successfully + +Example (generation, passing first 30 digits): + $ eidtool.py --compute 898821199000000000000000000016 + 89882119900000000000000000001654 + +Example (generation, passing all 32 digits): + $ eidtool.py --compute 89882119900000000000000000001600 + 89882119900000000000000000001654 + +Example (generation, specifying base 30 digits and number to add): + $ eidtool.py --compute 898821199000000000000000000000 --add 16 + 89882119900000000000000000001654 +""") +group = option_parser.add_mutually_exclusive_group(required=True) +group.add_argument('--verify', help='Verify given EID csum') +group.add_argument('--compute', help='Generate EID csum') +option_parser.add_argument('--add', type=int, help='Add value to EID base before computing') + + +if __name__ == '__main__': + opts = option_parser.parse_args() + + if opts.verify: + res = verify_eid_checksum(opts.verify) + if res: + print("EID checksum verified successfully") + sys.exit(0) + else: + print("EID checksum invalid") + sys.exit(1) + elif opts.compute: + eid = opts.compute + if opts.add: + if len(eid) != 30: + print("EID base must be 30 digits when using --add") + sys.exit(2) + eid = str(int(eid) + int(opts.add)) + res = compute_eid_checksum(eid) + print(res) + -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35682?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If6c560a2de51718948fb99b816e080f2aff4d0ed Gerrit-Change-Number: 35682 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: docs: Add missing global_platform store_data command docs
by laforge 25 Jan '24

25 Jan '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/35683?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: docs: Add missing global_platform store_data command docs ...................................................................... docs: Add missing global_platform store_data command docs In If30c5d31b4e7dd60d3a5cfb1d1cbdcf61741a50e we introduced a store_data comamnd, but forgot to add it to the pySim-shell manual. Change-Id: I6039818c2c0c5373b4a4ef1e33e152de7fbbd01a --- M docs/shell.rst 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/docs/shell.rst b/docs/shell.rst index 7022b5a..89a0d0a 100644 --- a/docs/shell.rst +++ b/docs/shell.rst @@ -941,6 +941,12 @@ :module: pySim.global_platform :func: ADF_SD.AddlShellCommands.get_data_parser +store_data +~~~~~~~~~~ +.. argparse:: + :module: pySim.global_platform + :func: ADF_SD.AddlShellCommands.store_data_parser + eUICC ISD-R commands -------------------- -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35683?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6039818c2c0c5373b4a4ef1e33e152de7fbbd01a Gerrit-Change-Number: 35683 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in libosmocore[master]: Prevent poll() in select.c to timeout too early
by jolly 25 Jan '24

25 Jan '24

Attention is currently required from: Hoernchen, fixeria, laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35672?usp=email ) Change subject: Prevent poll() in select.c to timeout too early ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > rounding up should be fine, but tbh, I can't quite see the actual real world issue here - it would r […] I have no idea how the scheduler works, but if a process is not running (during poll()), I guess the CPU thread will be directly switched to another process that is running (due to an event). I have an application that uses timer to schedule RTP stream at a rate of 50 frames per second. This is 20 ms delay between frames. Without this patch, the CPU usage at "top" command shows around 5% CPU usage, with a patch (round up or change from 0 to 1) it shows below 1% CPU usage. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35672?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I79de77c79af4d50d1eb9ca0c5417123ff760dca3 Gerrit-Change-Number: 35672 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 Jan 2024 18:31:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: modem: fix assigning .timer_cb twice (-Winitializer-overrides)
by fixeria 25 Jan '24

25 Jan '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35693?usp=email ) Change subject: modem: fix assigning .timer_cb twice (-Winitializer-overrides) ...................................................................... modem: fix assigning .timer_cb twice (-Winitializer-overrides) Change-Id: Id2d565a5035c47053c0dfa5ad9be3378471b6e14 --- M src/host/layer23/src/common/apn_fsm.c 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/93/35693/1 diff --git a/src/host/layer23/src/common/apn_fsm.c b/src/host/layer23/src/common/apn_fsm.c index 7014b83..7636b0a 100644 --- a/src/host/layer23/src/common/apn_fsm.c +++ b/src/host/layer23/src/common/apn_fsm.c @@ -220,7 +220,6 @@ .timer_cb = apn_fsm_timer_cb, .event_names = apn_fsm_event_names, .log_subsys = DTUN, - .timer_cb = apn_fsm_timer_cb, }; int apn_fsm_ctx_init(struct apn_fsm_ctx *ctx, struct osmobb_apn *apn) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35693?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id2d565a5035c47053c0dfa5ad9be3378471b6e14 Gerrit-Change-Number: 35693 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in pysim[master]: add contrib/eidtool.py: Tool for checking + computing EID checksum
by laforge 25 Jan '24

25 Jan '24

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35682?usp=email ) Change subject: add contrib/eidtool.py: Tool for checking + computing EID checksum ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35682?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If6c560a2de51718948fb99b816e080f2aff4d0ed Gerrit-Change-Number: 35682 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 Jan 2024 18:18:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: docs: Update osmo-smdpp with pointer to sysmoEUICC1-C2T and SGP.26
by laforge 25 Jan '24

25 Jan '24

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35692?usp=email ) Change subject: docs: Update osmo-smdpp with pointer to sysmoEUICC1-C2T and SGP.26 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35692?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id031ca48549a3c2ac21c93a169262570843d8e2d Gerrit-Change-Number: 35692 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 25 Jan 2024 18:18:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: docs: Add missing global_platform store_data command docs
by laforge 25 Jan '24

25 Jan '24

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/35683?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: docs: Add missing global_platform store_data command docs ...................................................................... docs: Add missing global_platform store_data command docs In If30c5d31b4e7dd60d3a5cfb1d1cbdcf61741a50e we introduced a store_data comamnd, but forgot to add it to the pySim-shell manual. Change-Id: I6039818c2c0c5373b4a4ef1e33e152de7fbbd01a --- M docs/shell.rst 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/83/35683/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35683?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6039818c2c0c5373b4a4ef1e33e152de7fbbd01a Gerrit-Change-Number: 35683 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in pysim[master]: add contrib/eidtool.py: Tool for checking + computing EID checksum
by laforge 25 Jan '24

25 Jan '24

Attention is currently required from: dexter. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/35682?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: add contrib/eidtool.py: Tool for checking + computing EID checksum ...................................................................... add contrib/eidtool.py: Tool for checking + computing EID checksum Change-Id: If6c560a2de51718948fb99b816e080f2aff4d0ed --- A contrib/eidtool.py 1 file changed, 82 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/82/35682/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35682?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If6c560a2de51718948fb99b816e080f2aff4d0ed Gerrit-Change-Number: 35682 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in pysim[master]: osmo-smdpp: Constrain selection of CI certificate
by laforge 25 Jan '24

25 Jan '24

Attention is currently required from: dexter. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/35685?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: osmo-smdpp: Constrain selection of CI certificate ...................................................................... osmo-smdpp: Constrain selection of CI certificate We can only choose a CI certificate which is supported both by the eUICC as well as which has signed our own SM-DP+ certificates. Change-Id: I0b9130f06d501ca7d484063d56d606cfdd2544f4 --- M osmo-smdpp.py 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/85/35685/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35685?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0b9130f06d501ca7d484063d56d606cfdd2544f4 Gerrit-Change-Number: 35685 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in pysim[master]: docs: Update osmo-smdpp with pointer to sysmoEUICC1-C2T and SGP.26
by laforge 25 Jan '24

25 Jan '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35692?usp=email ) Change subject: docs: Update osmo-smdpp with pointer to sysmoEUICC1-C2T and SGP.26 ...................................................................... docs: Update osmo-smdpp with pointer to sysmoEUICC1-C2T and SGP.26 Change-Id: Id031ca48549a3c2ac21c93a169262570843d8e2d --- M docs/osmo-smdpp.rst 1 file changed, 28 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/92/35692/1 diff --git a/docs/osmo-smdpp.rst b/docs/osmo-smdpp.rst index 5687fc6..a84ebee 100644 --- a/docs/osmo-smdpp.rst +++ b/docs/osmo-smdpp.rst @@ -19,6 +19,8 @@ osmo-smdpp currently +* uses test certificates copied from GSMA SGP.26 into `./smdpp-data/certs`, assuming that your osmo-smdppp + would be running at the host name `testsmdpplus1.example.com` * always provides the exact same profile to every request. The profile always has the same IMSI and ICCID. * **is absolutely insecure**, as it @@ -91,3 +93,20 @@ It must also accept the TLS certificates used by your TLS proxy. +Supported eUICC +~~~~~~~~~~~~~~~ + +If you run osmo-smdpp with the included SGP.26 certificates, you must use an eUICC with matching SGP.26 +certificates, i.e. the EUM certificate must be signed by a SGP.26 test root CA and the eUICC certificate +in turn must be signed by that SGP.26 EUM certificate. + +sysmocom (sponsoring development and maintenance of pySim and osmo-smdpp) is selling SGP.26 test eUICC +as `sysmoEUICC1-C2T`. They are publicly sold in the `sysmocom webshop <https://shop.sysmocom.de/eUICC-for-consumer-eSIM-RSP-with-SGP.26-Test-Certi…>`_. + +In general you can use osmo-smdpp also with certificates signed by any other certificate authority. You +just always must ensure that the certificates of the SM-DP+ are signed by the same root CA as those of your +eUICCs. + +Hypothetically, osmo-smdpp could also be operated with GSMA production certificates, but it would require +that somebody brings the code in-line with all the GSMA security requirements (HSM support, ...) and operate +it in a GSMA SAS-SM accredited environment and pays for the related audits. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35692?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id031ca48549a3c2ac21c93a169262570843d8e2d Gerrit-Change-Number: 35692 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0