January 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-msc[master]: SMS-over-GSUP: set Source Name IE for *all* messages
by laforge 09 Jan '24

09 Jan '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35522?usp=email ) Change subject: SMS-over-GSUP: set Source Name IE for *all* messages ...................................................................... SMS-over-GSUP: set Source Name IE for *all* messages We do include this IE in result and error messages, but somehow not in the request messages. For the sake of consistency, let's ensure that the Source Name IE is present in all SMS related PDUs. This additionally brings osmo-msc in sync with ttcn3-msc-test, which was modified to expect the Source Name IE in all receive templates, and makes the following testcases pass [again]: * MSC_Tests.TC_gsup_mo_sms * MSC_Tests.TC_gsup_mo_smma * MSC_Tests.TC_gsup_mo_mt_sms_rp_mr Change-Id: I65f5e3b7a0688e258979bb2679598659881a4321 Related: osmo-ttcn3-hacks.git Ic24d3082fe3dce08e43e8f3ecb6d6132503c55c6 Related: OS#6135 --- M src/libmsc/gsm_04_11_gsup.c 1 file changed, 25 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libmsc/gsm_04_11_gsup.c b/src/libmsc/gsm_04_11_gsup.c index d1c2f27..1afdfab 100644 --- a/src/libmsc/gsm_04_11_gsup.c +++ b/src/libmsc/gsm_04_11_gsup.c @@ -98,6 +98,7 @@ gsup_msg.sm_rp_ui_len = msgb_l4len(msg); gsup_msg.sm_rp_ui = (uint8_t *) msgb_sms(msg); + gsup_client_mux_tx_set_source(trans->net->gcm, &gsup_msg); return gsup_client_mux_tx(trans->net->gcm, &gsup_msg); } @@ -120,6 +121,7 @@ /* Indicate SMMA as the Alert Reason */ gsup_msg.sm_alert_rsn = OSMO_GSUP_SMS_SM_ALERT_RSN_MEM_AVAIL; + gsup_client_mux_tx_set_source(trans->net->gcm, &gsup_msg); return gsup_client_mux_tx(trans->net->gcm, &gsup_msg); } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35522?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I65f5e3b7a0688e258979bb2679598659881a4321 Gerrit-Change-Number: 35522 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in osmo-msc[master]: SMS-over-GSUP: set Source Name IE for *all* messages
by laforge 09 Jan '24

09 Jan '24

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35522?usp=email ) Change subject: SMS-over-GSUP: set Source Name IE for *all* messages ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35522?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I65f5e3b7a0688e258979bb2679598659881a4321 Gerrit-Change-Number: 35522 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 09 Jan 2024 15:48:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: logging: add log level cache
by laforge 09 Jan '24

09 Jan '24

Attention is currently required from: Hoernchen, arehbein, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30633?usp=email ) Change subject: logging: add log level cache ...................................................................... Patch Set 15: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30633?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I35f8dd9127dd6e7feae392094fd6b3ce2d32558d Gerrit-Change-Number: 30633 Gerrit-PatchSet: 15 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: arehbein <arehbein(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 09 Jan 2024 15:48:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: SMS-over-GSUP: set Source Name IE for *all* messages
by fixeria 09 Jan '24

09 Jan '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/35522?usp=email ) Change subject: SMS-over-GSUP: set Source Name IE for *all* messages ...................................................................... SMS-over-GSUP: set Source Name IE for *all* messages We do include this IE in result and error messages, but somehow not in the request messages. For the sake of consistency, let's ensure that the Source Name IE is present in all SMS related PDUs. This additionally brings osmo-msc in sync with ttcn3-msc-test, which was modified to expect the Source Name IE in all receive templates, and makes the following testcases pass [again]: * MSC_Tests.TC_gsup_mo_sms * MSC_Tests.TC_gsup_mo_smma * MSC_Tests.TC_gsup_mo_mt_sms_rp_mr Change-Id: I65f5e3b7a0688e258979bb2679598659881a4321 Related: osmo-ttcn3-hacks.git Ic24d3082fe3dce08e43e8f3ecb6d6132503c55c6 Related: OS#6135 --- M src/libmsc/gsm_04_11_gsup.c 1 file changed, 25 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/22/35522/1 diff --git a/src/libmsc/gsm_04_11_gsup.c b/src/libmsc/gsm_04_11_gsup.c index d1c2f27..1afdfab 100644 --- a/src/libmsc/gsm_04_11_gsup.c +++ b/src/libmsc/gsm_04_11_gsup.c @@ -98,6 +98,7 @@ gsup_msg.sm_rp_ui_len = msgb_l4len(msg); gsup_msg.sm_rp_ui = (uint8_t *) msgb_sms(msg); + gsup_client_mux_tx_set_source(trans->net->gcm, &gsup_msg); return gsup_client_mux_tx(trans->net->gcm, &gsup_msg); } @@ -120,6 +121,7 @@ /* Indicate SMMA as the Alert Reason */ gsup_msg.sm_alert_rsn = OSMO_GSUP_SMS_SM_ALERT_RSN_MEM_AVAIL; + gsup_client_mux_tx_set_source(trans->net->gcm, &gsup_msg); return gsup_client_mux_tx(trans->net->gcm, &gsup_msg); } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35522?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I65f5e3b7a0688e258979bb2679598659881a4321 Gerrit-Change-Number: 35522 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in libosmocore[master]: logging: add log level cache
by Hoernchen 09 Jan '24

09 Jan '24

Attention is currently required from: arehbein, fixeria, laforge. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30633?usp=email ) Change subject: logging: add log level cache ...................................................................... Patch Set 15: (3 comments) Patchset: PS9: > how often do you still want me to ping you, @ewild@sysmocom. […] Done File src/core/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/30633/comment/1797363d_329bd809 PS12, Line 153: logging > I would suggest […] Done https://gerrit.osmocom.org/c/libosmocore/+/30633/comment/297a0f7e_72ee505b PS12, Line 1557: talloc_free(osmo_log_info); > do `osmo_log_info = NULL` like below? Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30633?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I35f8dd9127dd6e7feae392094fd6b3ce2d32558d Gerrit-Change-Number: 30633 Gerrit-PatchSet: 15 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: arehbein <arehbein(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 09 Jan 2024 15:29:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-msc-test: also execute ASCI (VBS/VGCS) testcases
by fixeria 09 Jan '24

09 Jan '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/35521?usp=email ) Change subject: ttcn3-msc-test: also execute ASCI (VBS/VGCS) testcases ...................................................................... ttcn3-msc-test: also execute ASCI (VBS/VGCS) testcases These new testcases were added to osmo-ttcn3-hacks.git back in August 2023 (see the related patch), but have never been executed automatically on Jenkins because the config file was not updated in this repo... Change-Id: I9ec0a03658ead382eaaef175090cfc3650ffd9b7 Related: osmo-ttcn3-hacks.git I4bbe739ea55ecf9f7ebf9ee413df69f29aa642f8 --- M ttcn3-msc-test/MSC_Tests.cfg 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/21/35521/1 diff --git a/ttcn3-msc-test/MSC_Tests.cfg b/ttcn3-msc-test/MSC_Tests.cfg index 83c18c7..66ad4d1 100644 --- a/ttcn3-msc-test/MSC_Tests.cfg +++ b/ttcn3-msc-test/MSC_Tests.cfg @@ -57,3 +57,4 @@ [EXECUTE] MSC_Tests.control MSC_Tests_Iu.control +MSC_Tests_ASCI.control -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35521?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9ec0a03658ead382eaaef175090cfc3650ffd9b7 Gerrit-Change-Number: 35521 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libsmpp34[master]: fix warnings about implicit declaration of strtol()
by fixeria 09 Jan '24

09 Jan '24

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/35503?usp=email ) Change subject: fix warnings about implicit declaration of strtol() ...................................................................... fix warnings about implicit declaration of strtol() This commit fixes several warnings like this one: In file included from ../../../src/libsmpp34/test_apps/smpp.c:40: test_apps/smpp.c: In function ‘do_smpp_send_message2’: test_apps/esme.h:32:16: warning: implicit declaration of function ‘strtol’; did you mean ‘strtok’? [-Wimplicit-function-declaration] 32 | dst = strtol((char*)clave, NULL, 10);\ | ^~~~~~ test_apps/smpp.c:223:5: note: in expansion of macro ‘GET_PROP_INT’ 223 | GET_PROP_INT( req.source_addr_ton, p, "source_addr_ton" ); | ^~~~~~~~~~~~ Change-Id: I16d9e0171d4c26f721c300e22c78b77f6db4895c --- M test_apps/esme.c M test_apps/sendwp.c M test_apps/smpp.c M test_apps/tcp.c 4 files changed, 25 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/test_apps/esme.c b/test_apps/esme.c index 77fb198..5d9dafd 100644 --- a/test_apps/esme.c +++ b/test_apps/esme.c @@ -23,6 +23,7 @@ */ #include <stdio.h> +#include <stdlib.h> #include <unistd.h> #include <string.h> #include <libxml/xmlmemory.h> diff --git a/test_apps/sendwp.c b/test_apps/sendwp.c index b719c45..f75af76 100644 --- a/test_apps/sendwp.c +++ b/test_apps/sendwp.c @@ -23,6 +23,7 @@ */ #include <stdio.h> +#include <stdlib.h> #include <unistd.h> #include <string.h> #include <libxml/xmlmemory.h> diff --git a/test_apps/smpp.c b/test_apps/smpp.c index c764907..2cdb138 100644 --- a/test_apps/smpp.c +++ b/test_apps/smpp.c @@ -23,6 +23,7 @@ */ #include <stdio.h> +#include <stdlib.h> #include <unistd.h> #include <string.h> #include <sys/types.h> diff --git a/test_apps/tcp.c b/test_apps/tcp.c index 4cf681d..3051df2 100644 --- a/test_apps/tcp.c +++ b/test_apps/tcp.c @@ -28,6 +28,7 @@ #include <arpa/inet.h> #include <netdb.h> #include <stdio.h> +#include <stdlib.h> #include <unistd.h> #include <string.h> #include <libxml/xmlmemory.h> -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/35503?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I16d9e0171d4c26f721c300e22c78b77f6db4895c Gerrit-Change-Number: 35503 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmocom-bb[master]: mobile: fix segfault on empty TRAFFIC.ind
by fixeria 09 Jan '24

09 Jan '24

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35507?usp=email ) Change subject: mobile: fix segfault on empty TRAFFIC.ind ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: > wouldn't we have to inject a silence frame, or a duplicate of the previous, or something? Otherweis […] Ideally, yes. I think there's even ECU for FR in the playback chain. The problem is that there's currently no _proper_ way to signal to the ECU block that it's a bad frame and that it needs to be engaged. Another problem is that there's a format converter block between the fb and the ECU, which does expect a fixed number of bytes at the input. So this is quite a lot of work and TODO... PS2: > Maybe it would be better to avoid enqueuing an empty frame in first place, to avoid allocating and f […] See Harald's comment about injecting silence frames. We may want to implement this at some point in the future. But for now let's make sure that at least the whole process does not crash. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35507?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ice11b72ddfd51fbfb17a4c609c664b86a8f69591 Gerrit-Change-Number: 35507 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 09 Jan 2024 13:20:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-msc-test: set 'hlr' / 'ipa-name' explicitly
by laforge 09 Jan '24

09 Jan '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35520?usp=email ) Change subject: ttcn3-msc-test: set 'hlr' / 'ipa-name' explicitly ...................................................................... ttcn3-msc-test: set 'hlr' / 'ipa-name' explicitly Old osmo-msc versions do not include the Source Name IE in SMS related GSUP messages, unless it's set explicitly in the config file ('hlr' / 'ipa-name'). Recent osmo-msc versions (see the related osmo-msc patch) do include this IE even if it's not set explicitly ('unnamed-MSC'). Because of this, some testcases in ttcn3-msc-test are currently failing for osmo-msc master, but still passing for the -latest. Let's set the 'ipa-name' explicitly in osmo-msc.cfg, so that we can expect both -master and -latest to include the Source Name IE. Change-Id: I7757aae1d01b679f530b5c0a6c95b224cb9f204f Related: osmo-ttcn3-hacks.git Ic24d3082fe3dce08e43e8f3ecb6d6132503c55c6 Related: osmo-msc.git I7bacd001b81326c32bc262c7d0c0491ded822fa8 Related: OS#6135 --- M ttcn3-msc-test/osmo-msc.cfg 1 file changed, 24 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/ttcn3-msc-test/osmo-msc.cfg b/ttcn3-msc-test/osmo-msc.cfg index dabf142..b7b39f9 100644 --- a/ttcn3-msc-test/osmo-msc.cfg +++ b/ttcn3-msc-test/osmo-msc.cfg @@ -95,3 +95,4 @@ hlr remote-ip 172.18.20.103 remote-port 4222 + ipa-name test-MSC -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35520?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I7757aae1d01b679f530b5c0a6c95b224cb9f204f Gerrit-Change-Number: 35520 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: library/GSUP_Types: set Message Class IE in send templates for SMS
by laforge 09 Jan '24

09 Jan '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35518?usp=email ) Change subject: library/GSUP_Types: set Message Class IE in send templates for SMS ...................................................................... library/GSUP_Types: set Message Class IE in send templates for SMS We do expect it in receive templates for SMS, so let's also indluce it in the send templates. Change-Id: I6468d8606eb85c811d86e4a1407ee60c8a36fbea Related: OS#6135 --- M library/GSUP_Types.ttcn 1 file changed, 31 insertions(+), 9 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/library/GSUP_Types.ttcn b/library/GSUP_Types.ttcn index c3563bc..323776f 100644 --- a/library/GSUP_Types.ttcn +++ b/library/GSUP_Types.ttcn @@ -1616,7 +1616,8 @@ valueof(ts_GSUP_IE_SM_RP_MR(sm_rp_mr)), valueof(ts_GSUP_IE_SM_RP_DA(sm_rp_da)), valueof(ts_GSUP_IE_SM_RP_OA(sm_rp_oa)), - valueof(ts_GSUP_IE_SM_RP_UI(sm_rp_ui)) + valueof(ts_GSUP_IE_SM_RP_UI(sm_rp_ui)), + valueof(ts_GSUP_IE_Message_Class(OSMO_GSUP_MESSAGE_CLASS_SMS)) } ); template GSUP_PDU tr_GSUP_MO_FORWARD_SM_REQ( @@ -1644,7 +1645,8 @@ OSMO_GSUP_MSGT_MO_FORWARD_SM_RESULT, { valueof(ts_GSUP_IE_IMSI(imsi)), - valueof(ts_GSUP_IE_SM_RP_MR(sm_rp_mr)) + valueof(ts_GSUP_IE_SM_RP_MR(sm_rp_mr)), + valueof(ts_GSUP_IE_Message_Class(OSMO_GSUP_MESSAGE_CLASS_SMS)) } ); template GSUP_PDU tr_GSUP_MO_FORWARD_SM_RES( @@ -1668,7 +1670,8 @@ { valueof(ts_GSUP_IE_IMSI(imsi)), valueof(ts_GSUP_IE_SM_RP_MR(sm_rp_mr)), - valueof(ts_GSUP_IE_SM_RP_CAUSE(sm_rp_cause)) + valueof(ts_GSUP_IE_SM_RP_CAUSE(sm_rp_cause)), + valueof(ts_GSUP_IE_Message_Class(OSMO_GSUP_MESSAGE_CLASS_SMS)) } ); template GSUP_PDU tr_GSUP_MO_FORWARD_SM_ERR( @@ -1705,7 +1708,8 @@ valueof(ts_GSUP_IE_SM_RP_DA(sm_rp_da)), valueof(ts_GSUP_IE_SM_RP_OA(sm_rp_oa)), valueof(ts_GSUP_IE_SM_RP_UI(sm_rp_ui)), - valueof(ts_GSUP_IE_SM_RP_MMS(sm_rp_mms)) + valueof(ts_GSUP_IE_SM_RP_MMS(sm_rp_mms)), + valueof(ts_GSUP_IE_Message_Class(OSMO_GSUP_MESSAGE_CLASS_SMS)) } ); template GSUP_PDU tr_GSUP_MT_FORWARD_SM_REQ( @@ -1740,7 +1744,8 @@ OSMO_GSUP_MSGT_MT_FORWARD_SM_RESULT, { valueof(ts_GSUP_IE_IMSI(imsi)), - valueof(ts_GSUP_IE_SM_RP_MR(sm_rp_mr)) + valueof(ts_GSUP_IE_SM_RP_MR(sm_rp_mr)), + valueof(ts_GSUP_IE_Message_Class(OSMO_GSUP_MESSAGE_CLASS_SMS)) } ); template GSUP_PDU tr_GSUP_MT_FORWARD_SM_RES( @@ -1764,7 +1769,8 @@ { valueof(ts_GSUP_IE_IMSI(imsi)), valueof(ts_GSUP_IE_SM_RP_MR(sm_rp_mr)), - valueof(ts_GSUP_IE_SM_RP_CAUSE(sm_rp_cause)) + valueof(ts_GSUP_IE_SM_RP_CAUSE(sm_rp_cause)), + valueof(ts_GSUP_IE_Message_Class(OSMO_GSUP_MESSAGE_CLASS_SMS)) } ); template GSUP_PDU tr_GSUP_MT_FORWARD_SM_ERR( @@ -1790,7 +1796,8 @@ { valueof(ts_GSUP_IE_IMSI(imsi)), valueof(ts_GSUP_IE_SM_RP_MR(sm_rp_mr)), - valueof(ts_GSUP_IE_SM_ALERT_RSN(sm_alert_rsn)) + valueof(ts_GSUP_IE_SM_ALERT_RSN(sm_alert_rsn)), + valueof(ts_GSUP_IE_Message_Class(OSMO_GSUP_MESSAGE_CLASS_SMS)) } ); template GSUP_PDU tr_GSUP_MO_READY_FOR_SM_REQ( @@ -1814,7 +1821,8 @@ OSMO_GSUP_MSGT_READY_FOR_SM_RESULT, { valueof(ts_GSUP_IE_IMSI(imsi)), - valueof(ts_GSUP_IE_SM_RP_MR(sm_rp_mr)) + valueof(ts_GSUP_IE_SM_RP_MR(sm_rp_mr)), + valueof(ts_GSUP_IE_Message_Class(OSMO_GSUP_MESSAGE_CLASS_SMS)) } ); template GSUP_PDU tr_GSUP_MO_READY_FOR_SM_RES( @@ -1838,7 +1846,8 @@ { valueof(ts_GSUP_IE_IMSI(imsi)), valueof(ts_GSUP_IE_SM_RP_MR(sm_rp_mr)), - valueof(ts_GSUP_IE_SM_RP_CAUSE(sm_rp_cause)) + valueof(ts_GSUP_IE_SM_RP_CAUSE(sm_rp_cause)), + valueof(ts_GSUP_IE_Message_Class(OSMO_GSUP_MESSAGE_CLASS_SMS)) } ); template GSUP_PDU tr_GSUP_MO_READY_FOR_SM_ERR( -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35518?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6468d8606eb85c811d86e4a1407ee60c8a36fbea Gerrit-Change-Number: 35518 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0