January 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-e1d[master]: Add functions to events from server to client
by jolly 15 Jan '24

15 Jan '24

Attention is currently required from: jolly, laforge. Hello Jenkins Builder, laforge, tnt, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-e1d/+/35558?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: Add functions to events from server to client ...................................................................... Add functions to events from server to client The client may register a callback function to receive events. Because there is no relation between the connected client and the interface, all events are broadcasted to all clients that are connected to the server. Change-Id: I5ee3268f8349b611c3cf3fa0572dc5eab280ab2e --- M include/osmocom/e1d/proto_clnt.h M include/osmocom/e1d/proto_srv.h M src/e1d.h M src/osmo-e1d.c M src/osmo-e1gen.c M src/proto_clnt.c M src/proto_srv.c 7 files changed, 74 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/58/35558/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/35558?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I5ee3268f8349b611c3cf3fa0572dc5eab280ab2e Gerrit-Change-Number: 35558 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-bsc[master]: Also track downtime when OML link is lost
by fixeria 15 Jan '24

15 Jan '24

Attention is currently required from: jolly, lynxis lazus. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35566?usp=email ) Change subject: Also track downtime when OML link is lost ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/osmo-bsc/bts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/35566/comment/4637eff3_ae293e19 PS1, Line 831: !bts->oml_link A note for other reviewers: this is the key change of this patch. File src/osmo-bsc/bts_ctrl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/35566/comment/e1fd827b_a6a45626 PS1, Line 375: bts_updowntime The command is called `oml-uptime`. Maybe emulate the old behavior here (like you do in `bts_store_uptime()`)? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35566?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1776099cbfef51af1d5a3a056fb0654abd7366a9 Gerrit-Change-Number: 35566 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 15 Jan 2024 18:18:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: NAS_Templates: Allow passing old_guti and ptmsi_sig to TAU Req template
by fixeria 15 Jan '24

15 Jan '24

Attention is currently required from: daniel, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35510?usp=email ) Change subject: NAS_Templates: Allow passing old_guti and ptmsi_sig to TAU Req template ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35510?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5e0204e772edefc49a63b73fc4aad2fed5c14cac Gerrit-Change-Number: 35510 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Jan 2024 18:15:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: GTP_Templates: Add gtp1_requests template to match GTPv1C req messages
by fixeria 15 Jan '24

15 Jan '24

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35574?usp=email ) Change subject: GTP_Templates: Add gtp1_requests template to match GTPv1C req messages ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35574?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibf4b98e19ff13f23c552f50ca91832f0d317bbbf Gerrit-Change-Number: 35574 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Jan 2024 18:00:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: mme: Fix seq_nr=0 being used everytime in Tx SGSNContextReq
by fixeria 15 Jan '24

15 Jan '24

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35573?usp=email ) Change subject: mme: Fix seq_nr=0 being used everytime in Tx SGSNContextReq ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35573?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9a1a2dbceb4c4f30a8408c6f58bf645656e900bc Gerrit-Change-Number: 35573 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Jan 2024 17:59:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: mme: Add code to derive NAS token from NAS ul_count
by fixeria 15 Jan '24

15 Jan '24

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35570?usp=email ) Change subject: mme: Add code to derive NAS token from NAS ul_count ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35570?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5e6003a2fe3e74cc93cfe4a288e6c114aa288d0b Gerrit-Change-Number: 35570 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Jan 2024 17:59:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: mme: Fix seq_nr=0 being used everytime in Tx SGSNContextReq
by pespin 15 Jan '24

15 Jan '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35573?usp=email ) Change subject: mme: Fix seq_nr=0 being used everytime in Tx SGSNContextReq ...................................................................... mme: Fix seq_nr=0 being used everytime in Tx SGSNContextReq Change-Id: I9a1a2dbceb4c4f30a8408c6f58bf645656e900bc --- M mme/MME_Tests.ttcn 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/73/35573/1 diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn index 50b89b3..2194e8a 100644 --- a/mme/MME_Tests.ttcn +++ b/mme/MME_Tests.ttcn @@ -890,6 +890,7 @@ var OCT3 ptmsi_sig; var Gtp1cUnitdata gtpc_pdu; var OCT4 old_mme_local_teid; + var uint16_t gtpc_seq_nr := f_rnd_int(65535); /* Derive NAS Token (and post-increment ul_count): */ var OCT32 nas_token := f_s1apem_derive_nas_token(g_pars.ue_pars.kasme); @@ -899,7 +900,7 @@ SGSNContextReqPDU := ts_SGSNContextReqPDU(rai, new_sgsn_local_teid, f_inet_addr(mp_gn_local_ip), ptmsi := ts_PTMSI(ptmsi), ptmsi_sig := ts_PTMSI_sig(ptmsi_sig)); - GTP.send(ts_GTPC_SGSNContextReq(g_gn_iface_peer, 0, SGSNContextReqPDU)); + GTP.send(ts_GTPC_SGSNContextReq(g_gn_iface_peer, gtpc_seq_nr, SGSNContextReqPDU)); timer T := 5.0; T.start; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35573?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9a1a2dbceb4c4f30a8408c6f58bf645656e900bc Gerrit-Change-Number: 35573 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: GTP_Templates: Add gtp1_requests template to match GTPv1C req messages
by pespin 15 Jan '24

15 Jan '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35574?usp=email ) Change subject: GTP_Templates: Add gtp1_requests template to match GTPv1C req messages ...................................................................... GTP_Templates: Add gtp1_requests template to match GTPv1C req messages I'm finally not using it for now, but since it takes a while to write, leave it there for some lucky future user. Change-Id: Ibf4b98e19ff13f23c552f50ca91832f0d317bbbf --- M library/GTP_Templates.ttcn 1 file changed, 43 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/74/35574/1 diff --git a/library/GTP_Templates.ttcn b/library/GTP_Templates.ttcn index 30e42e6..3788725 100644 --- a/library/GTP_Templates.ttcn +++ b/library/GTP_Templates.ttcn @@ -19,6 +19,37 @@ import from IPCP_Types all; import from GSM_Types all; // RoutingAreaIdentification, CellIdentity + template (present) OCT1 gtp1_requests := ( + '10'O, /* createPDPContextRequest */ + '12'O, /* updatePDPContextRequest */ + '14'O, /* */ + '16'O, /* deletePDPContextRequest */ + '1B'O, /* pdu_NotificationRequest */ + '1D'O, /* pdu_NotificationRejectRequest */ + '1F'O, /* supportedExtensionHeadersNotification */ + '20'O, /* sendRouteingInformationForGPRSRequest */ + '22'O, /* failureReportRequest */ + '24'O, /* noteMS_GPRSPresentRequest */ + '30'O, /* identificationRequest */ + '32'O, /* sgsn_ContextRequest */ + '35'O, /* forwardRelocationRequest */ + '38'O, /* relocationCancelRequest */ + '3A'O, /* forwardSRNSContext */ + '3D'O, /* uERegistrationQueryRequest */ + '46'O, /* ranInformationRelay */ + '60'O, /* mBMSNotificationRequest */ + '62'O, /* mBMSNotificationRejectRequest */ + '64'O, /* createMBMSContextRequest */ + '66'O, /* updateMBMSContextRequest */ + '68'O, /* deleteMBMSContextRequest */ + '70'O, /* mBMSRegistrationRequest */ + '72'O, /* mBMSDeRegistrationRequest */ + '74'O, /* mBMSSessionStartRequest */ + '76'O, /* mBMSSessionStopRequest */ + '78'O, /* mBMSSessionUpdateRequest */ + '80'O /* mS_InfoChangeNotificationRequest */ + ); + type record GTP_CellId { RoutingAreaIdentification ra_id, CellIdentity cell_id -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35574?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibf4b98e19ff13f23c552f50ca91832f0d317bbbf Gerrit-Change-Number: 35574 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: Add logging category for libosmo-cc
by pespin 15 Jan '24

15 Jan '24

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35572?usp=email ) Change subject: Add logging category for libosmo-cc ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: FYI you may want to let the app set an idx dynamically at runtime, like we did in libosmo-gprs.git libraries: https://gitea.osmocom.org/osmocom/libosmo-gprs/src/branch/master/src/llc/mi… https://gitea.osmocom.org/osmocom/libosmo-gprs/src/branch/master/include/os… This also allows maintaining a set of different log categories per library whithout reuqiring touching libosmocore everytime. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35572?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9df433b2cfb51f04dbf16e9f8dee567a59ab5cb7 Gerrit-Change-Number: 35572 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 15 Jan 2024 17:39:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: Add logging category for libosmo-cc
by jolly 15 Jan '24

15 Jan '24

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35572?usp=email ) Change subject: Add logging category for libosmo-cc ...................................................................... Add logging category for libosmo-cc A new library is introduced: https://gitea.osmocom.org/cc/libosmo-cc It depends on logging API of libosmocore. The new category is DLCC. Change-Id: I9df433b2cfb51f04dbf16e9f8dee567a59ab5cb7 --- M include/osmocom/core/logging.h M src/core/logging.c 2 files changed, 20 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/72/35572/1 diff --git a/include/osmocom/core/logging.h b/include/osmocom/core/logging.h index e8433a1..61c3aa3 100644 --- a/include/osmocom/core/logging.h +++ b/include/osmocom/core/logging.h @@ -155,7 +155,8 @@ #define DLM2PA -27 /*!< Osmocom M2PA (libosmo-sigtran) */ #define DLM2UA -28 /*!< Reserved for future Osmocom M2UA (libosmo-sigtran) */ #define DLIO -29 /*!< Osmocom IO sub-system */ -#define OSMO_NUM_DLIB 29 /*!< Number of logging sub-systems in libraries */ +#define DLCC -30 /*!< Osmocom CC layer */ +#define OSMO_NUM_DLIB 30 /*!< Number of logging sub-systems in libraries */ /* Colors that can be used in log_info_cat.color */ #define OSMO_LOGCOLOR_NORMAL NULL diff --git a/src/core/logging.c b/src/core/logging.c index 6941f9b..bb9c4e4 100644 --- a/src/core/logging.c +++ b/src/core/logging.c @@ -319,6 +319,12 @@ .enabled = 1, .loglevel = LOGL_NOTICE, .color = "\033[38;5;67m", }, + [INT2IDX(DLCC)] = { + .name = "DLCC", + .description = "CC layer", + .enabled = 1, .loglevel = LOGL_NOTICE, + .color = "\033[38;5;255m", + }, }; void assert_loginfo(const char *src) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35572?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9df433b2cfb51f04dbf16e9f8dee567a59ab5cb7 Gerrit-Change-Number: 35572 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

1 0