July 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: S1AP_Emulation: improve accessibility of unit-data
by dexter 24 Jul '23

24 Jul '23

Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33898 ) Change subject: S1AP_Emulation: improve accessibility of unit-data ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I'm am wondering if a separate table is making things more complicated than needed. […] An expect mechanism where I can register a template sounds like a good idea. This way we would prevent getting unit-data that we are not interested in. I think I will try that. (I think broadcasting to all components requires a list with subscribed components - thats what I currently do. I was also trying to add a new port for unit-data. There is even something like this but it works only for MCT_CT. I tried different patterns here but it was always a mess.) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33898 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I041b45b247e365b0d4ee8645c07dc5f26007af82 Gerrit-Change-Number: 33898 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 24 Jul 2023 13:17:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: S1AP_Templates: Add templates for MMEDirectInformationTransfer
by dexter 24 Jul '23

24 Jul '23

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33897 ) Change subject: S1AP_Templates: Add templates for MMEDirectInformationTransfer ...................................................................... S1AP_Templates: Add templates for MMEDirectInformationTransfer We do not have S1AP_Templates for MMEDirectInformationTransfer yet. Related: OS#5760 Change-Id: Iebad3ab1f6a3bdf24dc2aead29652f98f3a92d75 --- M library/s1ap/S1AP_Templates.ttcn 1 file changed, 51 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/library/s1ap/S1AP_Templates.ttcn b/library/s1ap/S1AP_Templates.ttcn index 69e3f8b..46ec779 100644 --- a/library/s1ap/S1AP_Templates.ttcn +++ b/library/s1ap/S1AP_Templates.ttcn @@ -895,13 +895,50 @@ } } +/* 9.1.14 eNB DIRECT INFORMATION TRANSFER */ +template (value) S1AP_PDU +ts_S1AP_eNBDirectInfTrans(template (value) Inter_SystemInformationTransferType inf) := { + initiatingMessage := { + procedureCode := id_eNBDirectInformationTransfer, + criticality := reject, + value_ := { + eNBDirectInformationTransfer := { + protocolIEs := { + { + id := S1AP_Constants.id_Inter_SystemInformationTransferTypeEDT, + criticality := ignore, + value_ := {Inter_SystemInformationTransferType := inf} + } + } + } + } + } +} +/* 9.1.15 MME DIRECT INFORMATION TRANSFER */ +template (present) S1AP_PDU +tr_S1AP_MMEDirectInfTrans(template (present) Inter_SystemInformationTransferType inf := ?) := { + initiatingMessage := { + procedureCode := id_MMEDirectInformationTransfer, + criticality := ignore, + value_ := { + MMEDirectInformationTransfer := { + protocolIEs := { + { + id := S1AP_Constants.id_Inter_SystemInformationTransferTypeMDT, + criticality := reject, + value_ := {Inter_SystemInformationTransferType := inf} + }, * + } + } + } + } +} /* all non-UE-related S1AP messages */ template (present) S1AP_PDU tr_S1AP_nonUErelated := (tr_S1AP_SetupReq, tr_S1AP_SetupResp, tr_S1AP_SetupFail, - tr_S1AP_Reset, tr_S1AP_ResetAck + tr_S1AP_Reset, tr_S1AP_ResetAck, tr_S1AP_MMEDirectInfTrans ); - } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33897 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iebad3ab1f6a3bdf24dc2aead29652f98f3a92d75 Gerrit-Change-Number: 33897 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-ttcn3-hacks[master]: S1AP_Emulation: improve accessibility of unit-data
by laforge 24 Jul '23

24 Jul '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33898 ) Change subject: S1AP_Emulation: improve accessibility of unit-data ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I'm am wondering if a separate table is making things more complicated than needed. We could simply broadcast unitdata to all components, or we could introduce an "expect" mechanism where the handler component can indicate is is expecting data matching a certain template to arrive. I think both paradigms are used in different of our TTCN3 protocol stacks so far. A separate list of "componentes interested in unitdata" is new. If you're worried that unexpected unitdata would upset existing test cases (if broadcast to all components), we could also introduce a separate/new port to handle only unitdata. If a test doesn't care about what arrives on that port, it simply never reads/receives from it. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33898 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I041b45b247e365b0d4ee8645c07dc5f26007af82 Gerrit-Change-Number: 33898 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Jul 2023 13:07:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: GTP_Templates: add template tr_GTPC_RAN_Information_Request
by dexter 24 Jul '23

24 Jul '23

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33896 ) Change subject: GTP_Templates: add template tr_GTPC_RAN_Information_Request ...................................................................... GTP_Templates: add template tr_GTPC_RAN_Information_Request We have a template ts_GTPC_RAN_Information_Request not no tr_GTPC_RAN_Information_Request yet. Related: OS#5760 Change-Id: Ibf737ddc7a9867f0a73646bc0d86550fea6f6dbd --- M library/GTP_Templates.ttcn 1 file changed, 23 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/library/GTP_Templates.ttcn b/library/GTP_Templates.ttcn index 0d833a5..198a3b8 100644 --- a/library/GTP_Templates.ttcn +++ b/library/GTP_Templates.ttcn @@ -1112,6 +1112,16 @@ source_Cell_Identifier := src, rIM_Container := cont } + template PDU_BSSGP_RAN_INFORMATION_REQUEST_GTPC + tr_GTPC_RAN_Information_Request(template RIM_Routing_Information_GTPC dest := ?, + template RIM_Routing_Information_GTPC src := ?, + template RAN_Information_Request_RIM_Container_GTPC cont := ?) := { + bssgpPduType := '71'O, + destination_Cell_Identifier := dest, + source_Cell_Identifier := src, + rIM_Container := cont + } + template (value) RANTransparentContainer ts_RANTransparentContainer_RAN_INFO_REQ(template (value) PDU_BSSGP_RAN_INFORMATION_REQUEST_GTPC pdu) := { type_gtpc := '90'O, lengthf := 0, /* FIXME */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibf737ddc7a9867f0a73646bc0d86550fea6f6dbd Gerrit-Change-Number: 33896 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: GTP_Templates: Add RIM_RoutingAddress to RANInfoRelay templates
by dexter 24 Jul '23

24 Jul '23

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33894 ) Change subject: GTP_Templates: Add RIM_RoutingAddress to RANInfoRelay templates ...................................................................... GTP_Templates: Add RIM_RoutingAddress to RANInfoRelay templates The RIM_RoutingAddress tells a relaying RIM node (SGSN, MME) where to route a RIM RANTransparentContainer. The RANTransparentContainer also contains source and detination, but is not meant to be interpreted by a relaying node. That is why a RIM_RoutingAddress exists. Related: OS#5760 Change-Id: I4d497389226b12368cc0ed4e3d469cde8e812ba6 --- M library/GTP_Templates.ttcn 1 file changed, 24 insertions(+), 5 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/library/GTP_Templates.ttcn b/library/GTP_Templates.ttcn index 9782a3a..0d833a5 100644 --- a/library/GTP_Templates.ttcn +++ b/library/GTP_Templates.ttcn @@ -1226,11 +1226,13 @@ private_extension_gtpc := * } } - template (value) GTPC_PDUs ts_RANInfoRelay(template (value) RANTransparentContainer transparentContainer) := { + template (value) GTPC_PDUs ts_RANInfoRelay(template (value) RANTransparentContainer transparentContainer, + template (omit) RIM_RoutingAddress ra := omit, + template (omit) RIM_RoutingAddress_Discriminator ra_discr := omit) := { ranInformationRelay := { transparentContainer := transparentContainer, - rIM_RoutingAddress := omit, - rIM_RoutingAddress_Discriminator := omit, + rIM_RoutingAddress := ra, + rIM_RoutingAddress_Discriminator := ra_discr, private_extension_gtpc := omit } } @@ -1242,9 +1244,11 @@ } template (value) Gtp1cUnitdata ts_GTPC_RANInfoRelay(template (value) GtpPeer peer, - template (value) RANTransparentContainer transparentContainer) := { + template (value) RANTransparentContainer transparentContainer, + template (omit) RIM_RoutingAddress ra := omit, + template (omit) RIM_RoutingAddress_Discriminator ra_discr := omit) := { peer := peer, - gtpc := ts_GTP1C_PDU(rANInformationRelay, '00000000'O, valueof(ts_RANInfoRelay(transparentContainer)), 0) + gtpc := ts_GTP1C_PDU(rANInformationRelay, '00000000'O, valueof(ts_RANInfoRelay(transparentContainer, ra, ra_discr)), 0) } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33894 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4d497389226b12368cc0ed4e3d469cde8e812ba6 Gerrit-Change-Number: 33894 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: GTP-Templates: fix incorrect comment
by dexter 24 Jul '23

24 Jul '23

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33893 ) Change subject: GTP-Templates: fix incorrect comment ...................................................................... GTP-Templates: fix incorrect comment Change-Id: I81c518a8ce23e3e830b173e4af34b3a5414148af Related: OS#5760 --- M library/GTP_Templates.ttcn 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/library/GTP_Templates.ttcn b/library/GTP_Templates.ttcn index 921d1e8..9782a3a 100644 --- a/library/GTP_Templates.ttcn +++ b/library/GTP_Templates.ttcn @@ -194,7 +194,7 @@ } - /* template matching reception of GTP-C echo-request */ + /* template matching reception of GTP-C unit-data */ template Gtp1cUnitdata tr_GTPC_MsgType(template GtpPeer peer, template OCT1 msg_type, template OCT4 teid, template GTPC_PDUs pdus := ?) := { peer := peer, gtpc := tr_GTP1C_PDU(msg_type, teid, pdus) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33893 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I81c518a8ce23e3e830b173e4af34b3a5414148af Gerrit-Change-Number: 33893 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-ttcn3-hacks[master]: S1AP_Templates: Add templates for MMEDirectInformationTransfer
by laforge 24 Jul '23

24 Jul '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33897 ) Change subject: S1AP_Templates: Add templates for MMEDirectInformationTransfer ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33897 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iebad3ab1f6a3bdf24dc2aead29652f98f3a92d75 Gerrit-Change-Number: 33897 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Jul 2023 13:03:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: GTP_Templates: add template tr_GTPC_RAN_Information_Request
by laforge 24 Jul '23

24 Jul '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33896 ) Change subject: GTP_Templates: add template tr_GTPC_RAN_Information_Request ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibf737ddc7a9867f0a73646bc0d86550fea6f6dbd Gerrit-Change-Number: 33896 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Jul 2023 13:03:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: GTP_Templates: Add RIM_RoutingAddress to RANInfoRelay templates
by laforge 24 Jul '23

24 Jul '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33894 ) Change subject: GTP_Templates: Add RIM_RoutingAddress to RANInfoRelay templates ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33894 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4d497389226b12368cc0ed4e3d469cde8e812ba6 Gerrit-Change-Number: 33894 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Jul 2023 13:03:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: GTP-Templates: fix incorrect comment
by laforge 24 Jul '23

24 Jul '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33893 ) Change subject: GTP-Templates: fix incorrect comment ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33893 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I81c518a8ce23e3e830b173e4af34b3a5414148af Gerrit-Change-Number: 33893 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Jul 2023 13:03:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0