Attention is currently required from: Hoernchen.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/33930 )
Change subject: transceiver: add experimental viterbi equalizer support
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
Patchset:
PS7:
I'm wondering: Why is it called VA if it's a Viterbi Equalizer?
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/33930
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I9d7a4ff72e323832a94d885d5714fcde01ceeb3d
Gerrit-Change-Number: 33930
Gerrit-PatchSet: 7
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 27 Jul 2023 07:04:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Hoernchen.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/33945 )
Change subject: ms/va: add test tool and data
......................................................................
Patch Set 3:
(1 comment)
File utils/va-test/burst-gen.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/33945/comment/190dee00_a09818b6
PS3, Line 21:
I think this deserves a bit of an explanation of what the tool does (yes, generate bursts... I can figure that from the name. But what bursts, and how is it typically used?
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/33945
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ie38ed4996134e84ad0481872a743299bb442b3db
Gerrit-Change-Number: 33945
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 27 Jul 2023 07:03:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Hoernchen.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/33944 )
Change subject: ms: restructure the va code to add rach support
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I think it's not the best of ideas to have multiple Change-ID lines in a single commit log message (not even sure what gerrit does at that point). Also, the commitlog should probably only contain information useful to the reader.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/33944
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I4a5cedc8c9a3289c75ce7b914eac286e601ebed0
Gerrit-Change-Number: 33944
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 27 Jul 2023 07:01:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Hoernchen.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/33926 )
Change subject: ms: drop the tx burst padding
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
commit log is missing the rationale why this is done
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/33926
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ied5c3ab5dde975e11b0ef6d9cbc86be19173c4e8
Gerrit-Change-Number: 33926
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 27 Jul 2023 06:59:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Hoernchen, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32958 )
Change subject: ms: xray
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
Patchset:
PS4:
> Does it make sense to merge it here then? or can be kept in your branch?
In general I'd agree, but if it significantly simplifies Hoernchen's workflow, I don't think it's critical.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32958
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I2039204860f1d6c4a7f4fe78200f560d75a8b90e
Gerrit-Change-Number: 32958
Gerrit-PatchSet: 6
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 27 Jul 2023 06:59:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment