July 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-tetra[master]: Added calls to stub decryption functions for MAC resources
by wbokslag 27 Jul '23

27 Jul '23

Attention is currently required from: laforge. wbokslag has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/33953 ) Change subject: Added calls to stub decryption functions for MAC resources ...................................................................... Patch Set 3: (1 comment) File src/tetra_upper_mac.c: https://gerrit.osmocom.org/c/osmo-tetra/+/33953/comment/35370629_c776ea50 PS3, Line 301: m > so you want to move the tail but not change the length (as msgb_get does). […] I agree, but it is in line with what's also present at several other locations in this file. I'd suggest I file a separate commit where I replace the "msg->tail -= var" construction with msgb_get(msg, var) calls. I can then also properly test the change doesn't inadvertedly break things. -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/33953 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I92d718789d6b7e84c1901d09165fce59cdf8c1ca Gerrit-Change-Number: 33953 Gerrit-PatchSet: 3 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 27 Jul 2023 13:54:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: pysim-test: rename pysim-test.sh to pySim-prog_test.sh
by dexter 27 Jul '23

27 Jul '23

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/33964 to look at the new patch set (#2). Change subject: pysim-test: rename pysim-test.sh to pySim-prog_test.sh ...................................................................... pysim-test: rename pysim-test.sh to pySim-prog_test.sh We now have pySim-shell and pySim-trace. Let's give pysim-test.sh a more distinctive name so that it is clear to which program it refers. Related: OS#6094 Change-Id: I438f63f9580ebd3c7cc78cc5dab13c9937ac6e3a --- M contrib/jenkins.sh R tests/pySim-prog_test.sh 2 files changed, 16 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/64/33964/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33964 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I438f63f9580ebd3c7cc78cc5dab13c9937ac6e3a Gerrit-Change-Number: 33964 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ci[master]: ansible/setup-simtest: add tshark
by osmith 27 Jul '23

27 Jul '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/33968 ) Change subject: ansible/setup-simtest: add tshark ...................................................................... ansible/setup-simtest: add tshark As requested by Philipp, add tshark to simtest. Change-Id: Ib330f08057888bab2253a9b38148eaa1a70f3800 --- M ansible/setup-simtest.yml 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved diff --git a/ansible/setup-simtest.yml b/ansible/setup-simtest.yml index edc250d..84087c5 100644 --- a/ansible/setup-simtest.yml +++ b/ansible/setup-simtest.yml @@ -18,6 +18,7 @@ - python3-pip - python3-serial - python3-pyscard + - tshark - virtualenv install_recommends: no -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33968 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib330f08057888bab2253a9b38148eaa1a70f3800 Gerrit-Change-Number: 33968 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ci[master]: ansible/setup-simtest: add tshark
by dexter 27 Jul '23

27 Jul '23

Attention is currently required from: osmith. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/33968 ) Change subject: ansible/setup-simtest: add tshark ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33968 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib330f08057888bab2253a9b38148eaa1a70f3800 Gerrit-Change-Number: 33968 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Jul 2023 13:45:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: ansible/setup-simtest: add tshark
by osmith 27 Jul '23

27 Jul '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/33968 ) Change subject: ansible/setup-simtest: add tshark ...................................................................... ansible/setup-simtest: add tshark As requested by Philipp, add tshark to simtest. Change-Id: Ib330f08057888bab2253a9b38148eaa1a70f3800 --- M ansible/setup-simtest.yml 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/68/33968/1 diff --git a/ansible/setup-simtest.yml b/ansible/setup-simtest.yml index edc250d..84087c5 100644 --- a/ansible/setup-simtest.yml +++ b/ansible/setup-simtest.yml @@ -18,6 +18,7 @@ - python3-pip - python3-serial - python3-pyscard + - tshark - virtualenv install_recommends: no -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33968 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib330f08057888bab2253a9b38148eaa1a70f3800 Gerrit-Change-Number: 33968 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ci[master]: ansible/setup-simtest: don't install deps for docs
by osmith 27 Jul '23

27 Jul '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/33969 ) Change subject: ansible/setup-simtest: don't install deps for docs ...................................................................... ansible/setup-simtest: don't install deps for docs The part of the jenkins job that generates documentation doesn't run on simtester anymore, so no need to install these dependencies anymore. Related: pysim.git I5245c529db729e209d78a02ab9c917a90d0e0206 Related: OS#5497 Change-Id: I0dc1c9f9fc87ae1832d836d98f06e798b51c7e2e --- M ansible/setup-simtest.yml 1 file changed, 14 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/69/33969/1 diff --git a/ansible/setup-simtest.yml b/ansible/setup-simtest.yml index 84087c5..7b6913c 100644 --- a/ansible/setup-simtest.yml +++ b/ansible/setup-simtest.yml @@ -32,16 +32,6 @@ executable: pip3 requirements: /tmp/pysim_requirements.txt - # https://gitea.osmocom.org/sim-card/pysim/src/branch/master/contrib/jenkins.… - - name: "pysim: install other deps needed for contrib/jenkins.sh" - pip: - executable: pip3 - name: - - "git+https://github.com/osmocom/sphinx-argparse@master#egg=sphinx-argparse" - - pylint - - sphinx - - sphinxcontrib-napoleon - roles: - name: osmocom-jenkins-slave generic_slave: false -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33969 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0dc1c9f9fc87ae1832d836d98f06e798b51c7e2e Gerrit-Change-Number: 33969 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-msc[master]: ASCI: Remove duplicated CLEAR COMMAND from VGCS/VBS channel handling
by jolly 27 Jul '23

27 Jul '23

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/33967 ) Change subject: ASCI: Remove duplicated CLEAR COMMAND from VGCS/VBS channel handling ...................................................................... ASCI: Remove duplicated CLEAR COMMAND from VGCS/VBS channel handling Change-Id: I5e4891091c2ce56d4fd4a7f5f67156a94ade852d Related: OS#4854 --- M src/libmsc/msc_vgcs.c 1 file changed, 10 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/67/33967/1 diff --git a/src/libmsc/msc_vgcs.c b/src/libmsc/msc_vgcs.c index aca7054..da0e6ef 100644 --- a/src/libmsc/msc_vgcs.c +++ b/src/libmsc/msc_vgcs.c @@ -2508,14 +2508,6 @@ LOG_CELL(cell, LOGL_NOTICE, "Received VGCS/VBS ASSIGNMENT FAILURE from BSS.\n"); channel_fail: bss = cell->bss; - /* Remove cell. */ - tx_ran_msg = (struct ran_msg){ - .msg_type = RAN_MSG_CLEAR_COMMAND, - .clear_command = { - .gsm0808_cause = GSM0808_CAUSE_PROTOCOL_ERROR_BETWEEN_BSS_AND_MSC, - }, - }; - ran_encode_and_send(fi, &tx_ran_msg, cell->conn, false); cell_clear(cell, GSM0808_CAUSE_PROTOCOL_ERROR_BETWEEN_BSS_AND_MSC); /* Notify BSS FSM about channel failure. */ if (bss) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33967 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I5e4891091c2ce56d4fd4a7f5f67156a94ade852d Gerrit-Change-Number: 33967 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-msc[master]: ASCI: Add debugging and error logging to VGCS/VBS call control
by jolly 27 Jul '23

27 Jul '23

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/33965 ) Change subject: ASCI: Add debugging and error logging to VGCS/VBS call control ...................................................................... ASCI: Add debugging and error logging to VGCS/VBS call control Change-Id: I3fbce71e47e9670f58e46e7c2a0f26a1bbc1a46e Related: OS#4854 --- M src/libmsc/msc_vgcs.c 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/65/33965/1 diff --git a/src/libmsc/msc_vgcs.c b/src/libmsc/msc_vgcs.c index f50753b..d206b55 100644 --- a/src/libmsc/msc_vgcs.c +++ b/src/libmsc/msc_vgcs.c @@ -636,6 +636,7 @@ } /* Create BSS list structures. */ + LOG_GCC(trans, LOGL_DEBUG, "Create BSS list structure with cell list structures.\n"); llist_for_each_entry(b, &gcr->bss_list, list) { LOG_GCC(trans, LOGL_DEBUG, " -> BSS with PC %s.\n", osmo_ss7_pointcode_print(NULL, b->pc)); /* Resolve ran_peer. */ @@ -668,12 +669,14 @@ /* Create ran connection. */ bss->conn = ran_conn_create_outgoing(rp); if (!bss->conn) { + LOG_GCC(trans, LOGL_ERROR, "Failed to create RAN connection.\n"); osmo_fsm_inst_free(bss->fi); continue; } bss->conn->vgcs.bss = bss; /* Create cell list structures. */ llist_for_each_entry(c, &b->cell_list, list) { + LOG_GCC(trans, LOGL_DEBUG, " -> Cell ID %d.\n", c->cell_id); /* Create state machine. */ fi = osmo_fsm_inst_alloc(&vgcs_cell_fsm, net, NULL, LOGL_DEBUG, NULL); if (!fi) { @@ -698,6 +701,7 @@ /* Create ran connection. */ cell->conn = ran_conn_create_outgoing(rp); if (!cell->conn) { + LOG_GCC(trans, LOGL_ERROR, "Failed to create RAN connection.\n"); osmo_fsm_inst_free(cell->fi); continue; } @@ -710,6 +714,7 @@ } /* No cell? */ if (llist_empty(&bss->cell_list)) { + LOG_GCC(trans, LOGL_DEBUG, " -> No Cell in this BSS.\n"); osmo_fsm_inst_free(bss->fi); break; } @@ -721,6 +726,7 @@ /* No BSS? */ if (llist_empty(&trans->gcc.bss_list)) { /* Also destroy MGW, because this list is empty too! */ + LOG_GCC(trans, LOGL_NOTICE, "No BSS found, please check your VTY configuration and add cells.\n"); goto err_mgw; } return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33965 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3fbce71e47e9670f58e46e7c2a0f26a1bbc1a46e Gerrit-Change-Number: 33965 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-msc[master]: ASCI: Add missing transaction ID to SET PARAMETER message
by jolly 27 Jul '23

27 Jul '23

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/33966 ) Change subject: ASCI: Add missing transaction ID to SET PARAMETER message ...................................................................... ASCI: Add missing transaction ID to SET PARAMETER message Change-Id: I1b692cee894826a306885253a53a351f952d52dc Related: OS#4854 --- M src/libmsc/msc_vgcs.c 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/66/33966/1 diff --git a/src/libmsc/msc_vgcs.c b/src/libmsc/msc_vgcs.c index d206b55..aca7054 100644 --- a/src/libmsc/msc_vgcs.c +++ b/src/libmsc/msc_vgcs.c @@ -890,7 +890,8 @@ uint8_t pdisc = (trans->type == TRANS_GCC) ? GSM48_PDISC_GROUP_CC : GSM48_PDISC_BCAST_CC; int rc; - rc = gsm44068_tx_set_parameter(trans, pdisc, !trans->gcc.mute_talker, 1, 1, trans->gcc.uplink_originator); + rc = gsm44068_tx_set_parameter(trans, pdisc | (trans->transaction_id << 4), + !trans->gcc.mute_talker, 1, 1, trans->gcc.uplink_originator); if (rc < 0) LOG_GCC(trans, LOGL_ERROR, "Failed to send SET PARAMETER towards MS.\n"); return rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33966 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I1b692cee894826a306885253a53a351f952d52dc Gerrit-Change-Number: 33966 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

1 0

[S] Change in pysim[master]: tests: add test script for pySim-trace
by dexter 27 Jul '23

27 Jul '23

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/33963 to look at the new patch set (#2). Change subject: tests: add test script for pySim-trace ...................................................................... tests: add test script for pySim-trace pySim-trace has no test coverage yet. Let's use a script to run a GSAMTAP pcacp through it and check that no exceptions are raised. Related: OS#6094 Change-Id: Icfabfa7c59968021eef0399991bd05b92467d8d2 --- M contrib/jenkins.sh A pysim-testdata/pySim-trace_test_gsmtap.pcapng A tests/pySim-trace_test.sh 3 files changed, 34 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/63/33963/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33963 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icfabfa7c59968021eef0399991bd05b92467d8d2 Gerrit-Change-Number: 33963 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0