Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33970 )
Change subject: sm: Introduce APIs to enc/dec QoS Profile
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Regarding endianness, should we disable the check? it will keep on failing in all future patches if either it's fixed or we disable the check.
Related: https://lists.osmocom.org/hyperkitty/list/openbsc@lists.osmocom.org/thread/…
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33970
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I6c0676e55bb1f0f424f41d8d04d4f5e5bf376f4f
Gerrit-Change-Number: 33970
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 28 Jul 2023 07:37:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: jolly, fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979 )
Change subject: ASCI: Add tests for voice group/broadcast calls at MSC
......................................................................
Patch Set 1:
(1 comment)
File msc/MSC_Tests_ASCI.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979/comment/11ca1583_6a84…
PS1, Line 50: type integer ASCI_TEST;
: const ASCI_TEST ASCI_TEST_NO_CALLREF := 1;
: const ASCI_TEST ASCI_TEST_SETUP_REFUSE := 2;
: const ASCI_TEST ASCI_TEST_ASSIGN_FAIL := 3;
: const ASCI_TEST ASCI_TEST_COMPLETE_VGCS := 4;
: const ASCI_TEST ASCI_TEST_COMPLETE_VBS := 5;
> Looks like it's done this way because the `BSC_ConnHdlr_Coord_PT` can only deliver charstrings and i […]
one could also simply add the new enum type as something that can be sent over the existing port coord_pt instead of the "int".
I will also try to revisit the existing code sending chartering over it. if it is a similar usage, it should also be modified (not in this patch series, of course)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4bbe739ea55ecf9f7ebf9ee413df69f29aa642f8
Gerrit-Change-Number: 33979
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 28 Jul 2023 07:26:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment