July 2023 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-gprs[master]: rlcmac: tbf_dl: Implement T3190
by pespin 05 Jul '23

05 Jul '23

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33554 ) Change subject: rlcmac: tbf_dl: Implement T3190 ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33554 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I3f69fde298dcd64d30b9d648a96717a8378864c4 Gerrit-Change-Number: 33554 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jul 2023 14:39:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-trx[master]: ms: fix blocking logging
by pespin 05 Jul '23

05 Jul '23

Attention is currently required from: Hoernchen, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/33558 ) Change subject: ms: fix blocking logging ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Isn't this controlled by the VTY config? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/33558 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I0f5dcb13d1bd9e626e1eeab6ca767ca1b5ae43b8 Gerrit-Change-Number: 33558 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 05 Jul 2023 14:36:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in osmo-trx[master]: devices: unify band handling
by pespin 05 Jul '23

05 Jul '23

Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32763 ) Change subject: devices: unify band handling ...................................................................... Patch Set 9: (1 comment) File Transceiver52M/device/lms/LMSDevice.h: https://gerrit.osmocom.org/c/osmo-trx/+/32763/comment/e8ef1363_478d0b06 PS5, Line 97: using dev_band_key = std::tuple<lms_dev_type, gsm_band>; > dev_band_key_t? Still unresolved. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32763 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I64f5a462451e967d4750d8e4f1d5832cbab41cff Gerrit-Change-Number: 32763 Gerrit-PatchSet: 9 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jul 2023 14:33:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-trx[master]: ms: fix startup & shutdown of blade
by pespin 05 Jul '23

05 Jul '23

Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32944 ) Change subject: ms: fix startup & shutdown of blade ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-trx/+/32944/comment/103f0f7f_e0bc227e PS1, Line 11: This is now fixed. can you perhaps explain the actual fix? File Transceiver52M/ms/ms.h: https://gerrit.osmocom.org/c/osmo-trx/+/32944/comment/deb8df3c_0bf41a66 PS1, Line 334: if (pthread_setaffinity_np(h, sizeof(cpuset), &cpuset) < 0) { this looks unrelated? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32944 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1cd8790191790f4861a70bc55c8f4c9993fa10c8 Gerrit-Change-Number: 32944 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jul 2023 14:31:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-trx[master]: ms: prettify scheduling + add odroid
by pespin 05 Jul '23

05 Jul '23

Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32943 ) Change subject: ms: prettify scheduling + add odroid ...................................................................... Patch Set 1: (3 comments) Patchset: PS1: Why not simply provide specific config files for specific platforms and keep the code generic? File Transceiver52M/ms/ms.h: https://gerrit.osmocom.org/c/osmo-trx/+/32943/comment/b4ed64ec_d0d593d9 PS1, Line 205: enum target { ODROID = 0, PI4 }; Do we really only want to be able to run this in ODROID or PI4? I don't see the point in having this kind of platform hardcoded here. https://gerrit.osmocom.org/c/osmo-trx/+/32943/comment/6922eb21_a747f2b6 PS1, Line 291: hw_target(hw_cpus > 4 ? sched_params::target::ODROID : sched_params::target::PI4) so any platform with more than 4 cpus is considered "ODROID"? why not simply "GENERIC" or "GENERAL" then? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32943 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Icaf42fd5f76dc2d53dc526558aa8ceaa9c190f7b Gerrit-Change-Number: 32943 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jul 2023 14:25:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-trx[master]: ms: fix the gain init for blade
by pespin 05 Jul '23

05 Jul '23

Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32942 ) Change subject: ms: fix the gain init for blade ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Can you explain where thoes 30 and 0 dB figures come from? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32942 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ic5a25d6f5606fba599b8144fbec7285047dca3c9 Gerrit-Change-Number: 32942 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jul 2023 14:17:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-trx[master]: ms : fix the template formatting
by pespin 05 Jul '23

05 Jul '23

Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32941 ) Change subject: ms : fix the template formatting ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32941 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I891bdf95004accebbbe54916e4472bd381fac545 Gerrit-Change-Number: 32941 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jul 2023 14:16:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-trx[master]: ms: update osmocom-bb submodule
by Hoernchen 05 Jul '23

05 Jul '23

Attention is currently required from: laforge. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/33561 ) Change subject: ms: update osmocom-bb submodule ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/33561 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5e1a5f385e7d5e041142e665181d68ad5bb22230 Gerrit-Change-Number: 33561 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 05 Jul 2023 14:15:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: */osmo-stp.cfg: Explicitly define role & sctp-role
by osmith 05 Jul '23

05 Jul '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33576 ) Change subject: */osmo-stp.cfg: Explicitly define role & sctp-role ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If48ca06f2cc3c0986daa5f6264d80138d468332a Gerrit-Change-Number: 33576 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jul 2023 14:14:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: */osmo-stp.cfg: Explicitly define role & sctp-role
by pespin 05 Jul '23

05 Jul '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33576 ) Change subject: */osmo-stp.cfg: Explicitly define role & sctp-role ...................................................................... */osmo-stp.cfg: Explicitly define role & sctp-role It was recently decided it's a good practice to always specify the role and sctp-role for all ASPs configured in the VTY, since it's an important configuration providing feedback on the network setup expectancies. Change-Id: If48ca06f2cc3c0986daa5f6264d80138d468332a --- M bsc/osmo-stp.cfg M hnbgw/osmo-stp.cfg M msc/osmo-stp.cfg M sgsn/osmo-stp.cfg M smlc/osmo-stp.cfg M stp/osmo-stp.cfg 6 files changed, 53 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/76/33576/1 diff --git a/bsc/osmo-stp.cfg b/bsc/osmo-stp.cfg index 21952dc..d936d4f 100644 --- a/bsc/osmo-stp.cfg +++ b/bsc/osmo-stp.cfg @@ -26,6 +26,8 @@ asp virt-msc0-0 23905 2905 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server as mahlzeit ipa routing-key 0 0.23.4 point-code override dpc 0.23.1 @@ -36,6 +38,8 @@ asp virt-msc1-0 23906 2905 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server as virt-msc1 m3ua asp virt-msc1-0 routing-key 2 0.0.2 @@ -43,6 +47,8 @@ asp virt-msc2-0 23907 2905 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server as virt-msc2 m3ua asp virt-msc2-0 routing-key 3 0.0.3 diff --git a/hnbgw/osmo-stp.cfg b/hnbgw/osmo-stp.cfg index 85d60e9..651975b 100644 --- a/hnbgw/osmo-stp.cfg +++ b/hnbgw/osmo-stp.cfg @@ -34,17 +34,20 @@ asp virt-msc0-0 23905 2905 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server as virt-msc0 m3ua asp virt-msc0-0 routing-key 1 0.23.4 asp virt-sgsn0-0 23906 2905 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server as virt-sgsn0 m3ua asp virt-sgsn0-0 routing-key 2 0.23.1 - route-table system update route 0.23.4 7.255.7 linkset virt-msc0 update route 0.23.1 7.255.7 linkset virt-sgsn0 diff --git a/msc/osmo-stp.cfg b/msc/osmo-stp.cfg index fc3cf54..772b6d1 100644 --- a/msc/osmo-stp.cfg +++ b/msc/osmo-stp.cfg @@ -26,18 +26,24 @@ asp virt-bsc0-0 23906 2905 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server as virt-bsc0 m3ua asp virt-bsc0-0 routing-key 0 0.24.1 asp virt-bsc1-0 23907 2905 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server as virt-bsc1 m3ua asp virt-bsc1-0 routing-key 1 0.24.2 asp virt-rnc0-0 23908 2905 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server as virt-rnc0 m3ua asp virt-rnc0-0 routing-key 2 0.24.3 diff --git a/sgsn/osmo-stp.cfg b/sgsn/osmo-stp.cfg index bf1148f..7823f2a 100644 --- a/sgsn/osmo-stp.cfg +++ b/sgsn/osmo-stp.cfg @@ -39,6 +39,8 @@ asp virt-rnc0-0 23908 2905 m3ua local-ip 127.0.0.200 remote-ip 127.0.0.103 + role sg + sctp-role server as virt-rnc0 m3ua asp virt-rnc0-0 routing-key 2 0.24.3 diff --git a/smlc/osmo-stp.cfg b/smlc/osmo-stp.cfg index 062bea5..e2568e2 100644 --- a/smlc/osmo-stp.cfg +++ b/smlc/osmo-stp.cfg @@ -34,6 +34,8 @@ asp virt-bsc0-0 23905 2905 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server as virt-bsc0 m3ua asp virt-bsc0-0 routing-key 1 0.23.3 diff --git a/stp/osmo-stp.cfg b/stp/osmo-stp.cfg index 427eb34..5f67dff 100644 --- a/stp/osmo-stp.cfg +++ b/stp/osmo-stp.cfg @@ -42,27 +42,33 @@ asp asp-sender 9999 2905 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server asp asp-receiver0 10000 2905 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server asp asp-receiver1 10001 2905 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server asp asp-client0 10002 2906 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 - sctp-role client role asp + sctp-role client asp asp-client60-norctx0 11060 2907 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 - sctp-role client role asp + sctp-role client asp asp-client61-norctx0 11061 2907 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 - sctp-role client role asp + sctp-role client as as-sender m3ua asp asp-sender routing-key 1023 23 @@ -85,6 +91,8 @@ asp ipa-asp-loadshare-sender 20000 5000 ipa local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server as ipa-as-loadshare-sender ipa routing-key 0 6 point-code override dpc 31 @@ -92,9 +100,13 @@ asp ipa-asp-loadshare-receiver0 20001 5000 ipa local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server asp ipa-asp-loadshare-receiver1 20002 5000 ipa local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server as ipa-as-loadshare-receiver ipa traffic-mode loadshare routing-key 0 7 @@ -105,6 +117,8 @@ asp ipa-asp-override-sender 20004 5000 ipa local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server as ipa-as-override-sender ipa routing-key 0 6 point-code override dpc 33 @@ -112,6 +126,8 @@ asp ipa-asp-override-receiver0 20005 5000 ipa local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server asp ipa-asp-override-receiver1 20006 5000 ipa local-ip 127.0.0.1 remote-ip 127.0.0.1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If48ca06f2cc3c0986daa5f6264d80138d468332a Gerrit-Change-Number: 33576 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0