Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-tetra/+/34000
to look at the new patch set (#2).
Change subject: Fixups and clarifying comments for msgb tail modifications
......................................................................
Fixups and clarifying comments for msgb tail modifications
Added fixups for msgb len field whenever the tail is modified
Also, added some clarifying comments
Change-Id: Ia725edbeafe26bd2ea9b5a1810d0b26bc79d84db
---
M src/lower_mac/tetra_lower_mac.c
M src/tetra_llc.c
M src/tetra_upper_mac.c
3 files changed, 30 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/00/34000/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/34000
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-tetra
Gerrit-Branch: master
Gerrit-Change-Id: Ia725edbeafe26bd2ea9b5a1810d0b26bc79d84db
Gerrit-Change-Number: 34000
Gerrit-PatchSet: 2
Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-tetra/+/34001
to look at the new patch set (#2).
Change subject: Added stub for decryption and full keystream application functions
......................................................................
Added stub for decryption and full keystream application functions
Added stub functions for keystream generation and identity decryption
Also added implementations for mac resource decryption, voice
decryption and identity decryption.
Change-Id: I4e6147f206ad6046f32e08015ec9721b64382ca1
---
M src/crypto/tetra_crypto.c
M src/crypto/tetra_crypto.h
2 files changed, 179 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/01/34001/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/34001
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-tetra
Gerrit-Branch: master
Gerrit-Change-Id: I4e6147f206ad6046f32e08015ec9721b64382ca1
Gerrit-Change-Number: 34001
Gerrit-PatchSet: 2
Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-tetra/+/33998
to look at the new patch set (#3).
Change subject: Added keyfile loading
......................................................................
Added keyfile loading
Added an additional command line flag -k to tetra-rx that allows for the
loading of a file containing network and key definitions.
Change-Id: I65b7ac8feb3c2a9a8cac95149f625e9ef534b66c
---
M src/tetra-rx.c
1 file changed, 16 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/98/33998/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/33998
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-tetra
Gerrit-Branch: master
Gerrit-Change-Id: I65b7ac8feb3c2a9a8cac95149f625e9ef534b66c
Gerrit-Change-Number: 33998
Gerrit-PatchSet: 3
Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-tetra/+/33997
to look at the new patch set (#2).
Change subject: Added keyfile parsing code and various crypto improvements
......................................................................
Added keyfile parsing code and various crypto improvements
Added keyfile parsing code, as well as various other improvements such as definition/enum updates and freeing the tetra_crypto_context when done
Change-Id: I1c7afeeb2dcf97ece44bb4b604f44ba88882b93f
---
M src/crypto/tetra_crypto.c
M src/crypto/tetra_crypto.h
M src/tetra-rx.c
3 files changed, 118 insertions(+), 16 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/97/33997/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/33997
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-tetra
Gerrit-Branch: master
Gerrit-Change-Id: I1c7afeeb2dcf97ece44bb4b604f44ba88882b93f
Gerrit-Change-Number: 33997
Gerrit-PatchSet: 2
Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-tetra/+/33998
to look at the new patch set (#2).
Change subject: Added keyfile loading in tetra-rx
......................................................................
Added keyfile loading in tetra-rx
Added an additional command line flag -k to tetra-rx that allows for the
loading of a file containing network and key definitions.
Change-Id: I65b7ac8feb3c2a9a8cac95149f625e9ef534b66c
---
M src/tetra-rx.c
1 file changed, 16 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/98/33998/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/33998
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-tetra
Gerrit-Branch: master
Gerrit-Change-Id: I65b7ac8feb3c2a9a8cac95149f625e9ef534b66c
Gerrit-Change-Number: 33998
Gerrit-PatchSet: 2
Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34002 )
Change subject: utils.py: remove superflouse import from itself
......................................................................
utils.py: remove superflouse import from itself
b2h() is already available.
Change-Id: Ied513a08cc8b5091dd467106250f1e6b5067c3a8
---
M pySim/utils.py
1 file changed, 11 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/02/34002/1
diff --git a/pySim/utils.py b/pySim/utils.py
index 735468e..c838a31 100644
--- a/pySim/utils.py
+++ b/pySim/utils.py
@@ -537,7 +537,6 @@
from Cryptodome.Cipher import AES
# pylint: disable=no-name-in-module
from Cryptodome.Util.strxor import strxor
- from pySim.utils import b2h
# We pass in hex string and now need to work on bytes
ki_bytes = bytes(h2b(ki_hex))
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/34002
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ied513a08cc8b5091dd467106250f1e6b5067c3a8
Gerrit-Change-Number: 34002
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-MessageType: newchange
Attention is currently required from: lynxis lazus.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/33985
to look at the new patch set (#2).
Change subject: Reimplement ust_service_activate and ust_service_deactivate for USIM/EF.UST
......................................................................
Reimplement ust_service_activate and ust_service_deactivate for USIM/EF.UST
Fixes: f8d2e2ba0892 ("split pySim/legacy/{cards,utils} from pySim/{cards,utils}")
Change-Id: I7a6a77b872a6f5d8c478ca75dcff8ea067b8203e
---
M pySim/ts_31_102.py
M pySim/ts_31_102_telecom.py
2 files changed, 33 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/85/33985/2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/33985
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I7a6a77b872a6f5d8c478ca75dcff8ea067b8203e
Gerrit-Change-Number: 33985
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-MessageType: newpatchset
Attention is currently required from: fixeria, pespin.
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/33944 )
Change subject: ms: restructure the va code to add rach support
......................................................................
Patch Set 8:
(6 comments)
File Transceiver52M/grgsm_vitac/grgsm_vitac.h:
https://gerrit.osmocom.org/c/osmo-trx/+/33944/comment/1d340463_adcb2a78
PS6, Line 61: MULTI_VER_TARGET_ATTR_CLANGONLY
> Why removing this? If on purpose, please explain in the commit message.
Done
https://gerrit.osmocom.org/c/osmo-trx/+/33944/comment/e1a195e2_e6f73de0
PS6, Line 62: detect_burst_access_burst
> `detect_burst_ab()` for consistency with `detect_burst_nb()` then?
Done
File Transceiver52M/grgsm_vitac/grgsm_vitac.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/33944/comment/3789d5b7_47636c20
PS6, Line 77: MULTI_VER_TARGET_ATTR NO_UBSAN
> Why removing this? If on purpose, please explain in the commit message.
Done
https://gerrit.osmocom.org/c/osmo-trx/+/33944/comment/0e60bd3a_b2b20e16
PS6, Line 42: d_sync_training_seq[N_ACCESS_BITS]; ///<encoded training sequence of a SCH burst
> I find this confusing: the comment mentions SCH, the symbol name contains `_sync_`, and the `N_ACCES […]
Done
https://gerrit.osmocom.org/c/osmo-trx/+/33944/comment/d8d832f5_153e8238
PS6, Line 71: gr_complex startpoint = train_seq[i][0] == 0 ? gr_complex(1.0, 0.0) : gr_complex(-1.0, 0.0);
> Unrelated spacing changes. […]
This file was mostly unformatted before to keep it "in sync" with gr-gsm, but now, due to all those changes, trying to keep the original formatting is pointless, which is why it now got automatically reformatted with the osmo-trx (kernel) coding style, which has longer line limits.
https://gerrit.osmocom.org/c/osmo-trx/+/33944/comment/08319b31_b6f07db3
PS6, Line 139: gmsk_output[i] = j * gr_complex(encoded_symbol, 0.0) * gmsk_output[i - 1];
> Again, I am fine with proper formatting, but it makes your patch harder to read.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/33944
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I4a5cedc8c9a3289c75ce7b914eac286e601ebed0
Gerrit-Change-Number: 33944
Gerrit-PatchSet: 8
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 28 Jul 2023 14:23:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment