July 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-tetra[master]: Fixups and clarifying comments for msgb tail modifications
by wbokslag 28 Jul '23

28 Jul '23

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-tetra/+/34000 to look at the new patch set (#2). Change subject: Fixups and clarifying comments for msgb tail modifications ...................................................................... Fixups and clarifying comments for msgb tail modifications Added fixups for msgb len field whenever the tail is modified Also, added some clarifying comments Change-Id: Ia725edbeafe26bd2ea9b5a1810d0b26bc79d84db --- M src/lower_mac/tetra_lower_mac.c M src/tetra_llc.c M src/tetra_upper_mac.c 3 files changed, 30 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/00/34000/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/34000 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: Ia725edbeafe26bd2ea9b5a1810d0b26bc79d84db Gerrit-Change-Number: 34000 Gerrit-PatchSet: 2 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-tetra[master]: Added stub for decryption and full keystream application functions
by wbokslag 28 Jul '23

28 Jul '23

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-tetra/+/34001 to look at the new patch set (#2). Change subject: Added stub for decryption and full keystream application functions ...................................................................... Added stub for decryption and full keystream application functions Added stub functions for keystream generation and identity decryption Also added implementations for mac resource decryption, voice decryption and identity decryption. Change-Id: I4e6147f206ad6046f32e08015ec9721b64382ca1 --- M src/crypto/tetra_crypto.c M src/crypto/tetra_crypto.h 2 files changed, 179 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/01/34001/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/34001 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I4e6147f206ad6046f32e08015ec9721b64382ca1 Gerrit-Change-Number: 34001 Gerrit-PatchSet: 2 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-tetra[master]: Added keyfile loading
by wbokslag 28 Jul '23

28 Jul '23

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-tetra/+/33998 to look at the new patch set (#3). Change subject: Added keyfile loading ...................................................................... Added keyfile loading Added an additional command line flag -k to tetra-rx that allows for the loading of a file containing network and key definitions. Change-Id: I65b7ac8feb3c2a9a8cac95149f625e9ef534b66c --- M src/tetra-rx.c 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/98/33998/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/33998 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I65b7ac8feb3c2a9a8cac95149f625e9ef534b66c Gerrit-Change-Number: 33998 Gerrit-PatchSet: 3 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-tetra[master]: Added keyfile parsing code and various crypto improvements
by wbokslag 28 Jul '23

28 Jul '23

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-tetra/+/33997 to look at the new patch set (#2). Change subject: Added keyfile parsing code and various crypto improvements ...................................................................... Added keyfile parsing code and various crypto improvements Added keyfile parsing code, as well as various other improvements such as definition/enum updates and freeing the tetra_crypto_context when done Change-Id: I1c7afeeb2dcf97ece44bb4b604f44ba88882b93f --- M src/crypto/tetra_crypto.c M src/crypto/tetra_crypto.h M src/tetra-rx.c 3 files changed, 118 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/97/33997/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/33997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I1c7afeeb2dcf97ece44bb4b604f44ba88882b93f Gerrit-Change-Number: 33997 Gerrit-PatchSet: 2 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-tetra[master]: Added keyfile loading in tetra-rx
by wbokslag 28 Jul '23

28 Jul '23

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-tetra/+/33998 to look at the new patch set (#2). Change subject: Added keyfile loading in tetra-rx ...................................................................... Added keyfile loading in tetra-rx Added an additional command line flag -k to tetra-rx that allows for the loading of a file containing network and key definitions. Change-Id: I65b7ac8feb3c2a9a8cac95149f625e9ef534b66c --- M src/tetra-rx.c 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/98/33998/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/33998 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I65b7ac8feb3c2a9a8cac95149f625e9ef534b66c Gerrit-Change-Number: 33998 Gerrit-PatchSet: 2 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in pysim[master]: utils.py: remove superflouse import from itself
by lynxis lazus 28 Jul '23

28 Jul '23

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34002 ) Change subject: utils.py: remove superflouse import from itself ...................................................................... utils.py: remove superflouse import from itself b2h() is already available. Change-Id: Ied513a08cc8b5091dd467106250f1e6b5067c3a8 --- M pySim/utils.py 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/02/34002/1 diff --git a/pySim/utils.py b/pySim/utils.py index 735468e..c838a31 100644 --- a/pySim/utils.py +++ b/pySim/utils.py @@ -537,7 +537,6 @@ from Cryptodome.Cipher import AES # pylint: disable=no-name-in-module from Cryptodome.Util.strxor import strxor - from pySim.utils import b2h # We pass in hex string and now need to work on bytes ki_bytes = bytes(h2b(ki_hex)) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34002 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ied513a08cc8b5091dd467106250f1e6b5067c3a8 Gerrit-Change-Number: 34002 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

1 0

[S] Change in pysim[master]: Reimplement ust_service_activate and ust_service_deactivate for USIM/...
by lynxis lazus 28 Jul '23

28 Jul '23

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/33985 to look at the new patch set (#2). Change subject: Reimplement ust_service_activate and ust_service_deactivate for USIM/EF.UST ...................................................................... Reimplement ust_service_activate and ust_service_deactivate for USIM/EF.UST Fixes: f8d2e2ba0892 ("split pySim/legacy/{cards,utils} from pySim/{cards,utils}") Change-Id: I7a6a77b872a6f5d8c478ca75dcff8ea067b8203e --- M pySim/ts_31_102.py M pySim/ts_31_102_telecom.py 2 files changed, 33 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/85/33985/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33985 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7a6a77b872a6f5d8c478ca75dcff8ea067b8203e Gerrit-Change-Number: 33985 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-tetra[master]: Added stub for decryption and full keystream application functions
by wbokslag 28 Jul '23

28 Jul '23

wbokslag has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-tetra/+/34001 ) Change subject: Added stub for decryption and full keystream application functions ...................................................................... Added stub for decryption and full keystream application functions Added stub functions for keystream generation and identity decryption Also added implementations for mac resource decryption, voice decryption and identity decryption. Change-Id: I4e6147f206ad6046f32e08015ec9721b64382ca1 --- M src/crypto/tetra_crypto.c M src/crypto/tetra_crypto.h 2 files changed, 179 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/01/34001/1 diff --git a/src/crypto/tetra_crypto.c b/src/crypto/tetra_crypto.c index 9515a25..d5edde7 100644 --- a/src/crypto/tetra_crypto.c +++ b/src/crypto/tetra_crypto.c @@ -150,19 +150,176 @@ return ((tm->tn - 1) | (tm->fn << 2) | (tm->mn << 7) | ((hn & 0x7FFF) << 13) | (dir << 28)); } -int decrypt_identity(struct tetra_crypto_state *tcs, struct tetra_addr *addr) +void tb5_stub(uint8_t *cn, uint8_t *la, uint8_t *cc, uint8_t *key, uint8_t *eck) { - return 0; + /* FIXME: implement */ + memset(eck, 0, 10); } -int decrypt_mac_element(struct tetra_crypto_state *tcs, struct tetra_tmvsap_prim *tmvp, struct tetra_key *key, int l1_len, int tmpdu_offset) +void ta61_stub(uint8_t *key, uint8_t *esi, uint8_t *ssi) { - return 0; + /* FIXME: implement */ + memcpy(ssi, esi, 3); } -int decrypt_voice_timeslot(struct tetra_crypto_state *tcs, struct tetra_tdma_time *tdma_time, int16_t *type1_block) +void tea1_stub(uint32_t iv, uint8_t *eck, uint32_t num_bytes, uint8_t *ks) { - return 0; + /* FIXME: implement */ + memset(ks, 0, num_bytes); +} + +void tea2_stub(uint32_t iv, uint8_t *eck, uint32_t num_bytes, uint8_t *ks) +{ + /* FIXME: implement */ + memset(ks, 0, num_bytes); +} + +void tea3_stub(uint32_t iv, uint8_t *eck, uint32_t num_bytes, uint8_t *ks) +{ + /* FIXME: implement */ + memset(ks, 0, num_bytes); +} + +static bool generate_keystream(struct tetra_crypto_state *tcs, struct tetra_key *key, struct tetra_tdma_time *t, uint16_t hn, int num_bits, uint8_t *ks_out) +{ + if (!key) + return false; + + /* Construct IV and prepare buf for bytewise keystream */ + int num_bytes = (num_bits + 7) / 8; + uint8_t ks_bytes[num_bytes]; + uint32_t iv = tea_build_iv(t, hn, 0); + + /* Compute ECK from net info and CK */ + if (tcs->cn < 0 || tcs->la < 0 || tcs->cc < 0) { + /* Missing data for TB5 */ + memset(ks_out, 0, num_bytes); + return false; + } + + uint8_t eck[10]; + uint8_t cn[2] = {(tcs->cn >> 8) & 0xFF, tcs->cn & 0xFF}; + uint8_t la[2] = {(tcs->la >> 8) & 0xFF, tcs->la & 0xFF}; + uint8_t cc[1] = {tcs->cc & 0xFF}; + tb5_stub(cn, la, cc, key->key, eck); + + switch (key->network_info->ksg_type) { + case KSG_TEA1: + tea1_stub(iv, eck, num_bytes, ks_bytes); + break; + case KSG_TEA2: + tea2_stub(iv, eck, num_bytes, ks_bytes); + break; + case KSG_TEA3: + tea3_stub(iv, eck, num_bytes, ks_bytes); + break; + default: + fprintf(stderr, "tetra_crypto: KSG type %d not supported\n", key->network_info->ksg_type); + return false; + } + + for (int i = 0; i < num_bytes; i++) + for (int j = 0; j < 8; j++) + ks_out[i * 8 + j] = (ks_bytes[i] >> (7-j)) & 1; + + /* Expand keystream bytes into ubit format */ + for (int i = 0; i < num_bits; i++) + ks_out[i] = (ks_bytes[num_bits / 8] >> (7-(num_bits % 8))) & 1; + + return true; +} + +bool decrypt_identity(struct tetra_crypto_state *tcs, struct tetra_addr *addr) +{ + /* TODO FIXME maybe extend tetra_addr to contain is_encrypted bool */ + if (!tcs->cck) + return false; + + // Perform in-place decryption + uint8_t ab_addr[3] = {addr->ssi >> 16, addr->ssi >> 8, addr->ssi}; + ta61_stub(tcs->cck->key, ab_addr, ab_addr); + addr->ssi = (ab_addr[0] << 16) | (ab_addr[1] << 8) | ab_addr[2]; + return true; +} + +bool decrypt_mac_element(struct tetra_crypto_state *tcs, struct tetra_tmvsap_prim *tmvp, struct tetra_key *key, int l1_len, int tmpdu_offset) +{ + if (!key || l1_len - tmpdu_offset <= 0) + return false; + + if (tcs->cn < 0 || tcs->la < 0 || tcs->cc < 0) { + printf("tetra_crypto: can't compute TB5 due to incomplete network info (carr %d la %d cc %d)\n", + tcs->cn, tcs->la, tcs->cc); + return false; + } + + struct tetra_tdma_time *tdma_time = &tmvp->u.unitdata.tdma_time; + + // Compute keystream offset to apply + /* TODO FIXME maybe we can rework channel type setting in lower mac, and + avoid using TETRA_LC_UNKNOWN below */ + uint32_t ks_skip_bits = 0; + if (tmvp->u.unitdata.blk_num == BLK_2 && ( + tmvp->u.unitdata.lchan == TETRA_LC_SCH_HD || + tmvp->u.unitdata.lchan == TETRA_LC_UNKNOWN)) { + ks_skip_bits = 216; + printf("tetra_crypto: 2nd half slot; skipping bits\n"); + } + + // Compute keystream + struct msgb *msg = tmvp->oph.msg; + int ct_len = l1_len - tmpdu_offset; + int ks_num_bits = ks_skip_bits + ct_len; + uint8_t *ct_start = msg->l1h + tmpdu_offset; + uint8_t ks[ks_num_bits]; + + if (!generate_keystream(tcs, key, tdma_time, tcs->hn, ks_num_bits, ks)) { + printf("tetra_crypto: addr %8d -> key %4d, time %5d/%s, tmpdu offset %d, FAILED\n", + key->addr, key->index, tcs->hn, tetra_tdma_time_dump(tdma_time), tmpdu_offset); + return false; + } + + // Apply keystream + for (int i = 0; i < ct_len; i++) + ct_start[i] = ct_start[i] ^ ks[i + ks_skip_bits]; + + printf("tetra_crypto: addr %8d -> key %4d, time %5d/%s, tmpdu offset %d, decrypting %d bits\n", + key->addr, key->index, tcs->hn, tetra_tdma_time_dump(tdma_time), tmpdu_offset, ct_len); + + return true; +} + +bool decrypt_voice_timeslot(struct tetra_crypto_state *tcs, struct tetra_tdma_time *tdma_time, int16_t *type1_block) +{ + /* TODO FIXME implement proper key selection for voice blocks */ + struct tetra_key *key = tcs->cck; + if (!key) + return false; + + if (tcs->cn < 0 || tcs->la < 0 || tcs->cc < 0) { + printf("tetra_crypto: can't compute TB5 due to incomplete network info (carr %d la %d cc %d)\n", + tcs->cn, tcs->la, tcs->cc); + return false; + } + + // Compute keystream + int ks_num_bits = 137*2; // two half slots of voice + uint8_t ks[ks_num_bits]; + if (!generate_keystream(tcs, key, tdma_time, tcs->hn, ks_num_bits, ks)) { + printf("tetra_crypto: addr %8d -> key %4d, time %5d/%s, traffic FAILED\n", + key->addr, key->index, tcs->hn, tetra_tdma_time_dump(tdma_time)); + return false; + } + + // Apply keystream + for (int i = 0; i < 137; i++) { + type1_block[i + 1] = type1_block[i + 1] ^ ks[i]; + type1_block[i + 139] = type1_block[i + 139] ^ ks[i + 137]; + } + + printf("tetra_crypto: addr %8d -> key %4d, time %5d/%s, decrypted voice\n", + key->addr, key->index, tcs->hn, tetra_tdma_time_dump(tdma_time)); + return true; } int load_keystore(char *tetra_keyfile) diff --git a/src/crypto/tetra_crypto.h b/src/crypto/tetra_crypto.h index e50a45e..ace4c04 100644 --- a/src/crypto/tetra_crypto.h +++ b/src/crypto/tetra_crypto.h @@ -111,9 +111,9 @@ /* Keystream generation and decryption functions */ uint32_t tea_build_iv(struct tetra_tdma_time *tm, uint16_t hn, uint8_t dir); -int decrypt_identity(struct tetra_crypto_state *tcs, struct tetra_addr *addr); -int decrypt_mac_element(struct tetra_crypto_state *tcs, struct tetra_tmvsap_prim *tmvp, struct tetra_key *key, int l1_len, int tmpdu_offset); -int decrypt_voice_timeslot(struct tetra_crypto_state *tcs, struct tetra_tdma_time *tdma_time, int16_t *type1_bits); +bool decrypt_identity(struct tetra_crypto_state *tcs, struct tetra_addr *addr); +bool decrypt_mac_element(struct tetra_crypto_state *tcs, struct tetra_tmvsap_prim *tmvp, struct tetra_key *key, int l1_len, int tmpdu_offset); +bool decrypt_voice_timeslot(struct tetra_crypto_state *tcs, struct tetra_tdma_time *tdma_time, int16_t *type1_bits); /* Key selection and crypto state management */ struct tetra_netinfo *get_network_info(int mcc, int mnc); -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/34001 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I4e6147f206ad6046f32e08015ec9721b64382ca1 Gerrit-Change-Number: 34001 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-tetra[master]: Fixed makefile to also clean crypto subdirectory
by pespin 28 Jul '23

28 Jul '23

Attention is currently required from: wbokslag. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/33996 ) Change subject: Fixed makefile to also clean crypto subdirectory ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/33996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: Ib2a404edece89d26d5369f4ff2ad7510611cac08 Gerrit-Change-Number: 33996 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Comment-Date: Fri, 28 Jul 2023 14:25:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-trx[master]: ms: restructure the va code to add rach support
by Hoernchen 28 Jul '23

28 Jul '23

Attention is currently required from: fixeria, pespin. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/33944 ) Change subject: ms: restructure the va code to add rach support ...................................................................... Patch Set 8: (6 comments) File Transceiver52M/grgsm_vitac/grgsm_vitac.h: https://gerrit.osmocom.org/c/osmo-trx/+/33944/comment/1d340463_adcb2a78 PS6, Line 61: MULTI_VER_TARGET_ATTR_CLANGONLY > Why removing this? If on purpose, please explain in the commit message. Done https://gerrit.osmocom.org/c/osmo-trx/+/33944/comment/e1a195e2_e6f73de0 PS6, Line 62: detect_burst_access_burst > `detect_burst_ab()` for consistency with `detect_burst_nb()` then? Done File Transceiver52M/grgsm_vitac/grgsm_vitac.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/33944/comment/3789d5b7_47636c20 PS6, Line 77: MULTI_VER_TARGET_ATTR NO_UBSAN > Why removing this? If on purpose, please explain in the commit message. Done https://gerrit.osmocom.org/c/osmo-trx/+/33944/comment/0e60bd3a_b2b20e16 PS6, Line 42: d_sync_training_seq[N_ACCESS_BITS]; ///<encoded training sequence of a SCH burst > I find this confusing: the comment mentions SCH, the symbol name contains `_sync_`, and the `N_ACCES […] Done https://gerrit.osmocom.org/c/osmo-trx/+/33944/comment/d8d832f5_153e8238 PS6, Line 71: gr_complex startpoint = train_seq[i][0] == 0 ? gr_complex(1.0, 0.0) : gr_complex(-1.0, 0.0); > Unrelated spacing changes. […] This file was mostly unformatted before to keep it "in sync" with gr-gsm, but now, due to all those changes, trying to keep the original formatting is pointless, which is why it now got automatically reformatted with the osmo-trx (kernel) coding style, which has longer line limits. https://gerrit.osmocom.org/c/osmo-trx/+/33944/comment/08319b31_b6f07db3 PS6, Line 139: gmsk_output[i] = j * gr_complex(encoded_symbol, 0.0) * gmsk_output[i - 1]; > Again, I am fine with proper formatting, but it makes your patch harder to read. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/33944 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I4a5cedc8c9a3289c75ce7b914eac286e601ebed0 Gerrit-Change-Number: 33944 Gerrit-PatchSet: 8 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Jul 2023 14:23:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0