July 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bsc[master]: ASCI: Add encoding of VGCS/VBS A-interface messages
by jolly 10 Jul '23

10 Jul '23

Attention is currently required from: jolly. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/33610 to look at the new patch set (#3). Change subject: ASCI: Add encoding of VGCS/VBS A-interface messages ...................................................................... ASCI: Add encoding of VGCS/VBS A-interface messages Change-Id: Ic2203a5119a226ac859a91dc42d81cbd71027ec8 Related: OS#4852 --- M src/osmo-bsc/osmo_bsc_bssap.c 1 file changed, 188 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/10/33610/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33610 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic2203a5119a226ac859a91dc42d81cbd71027ec8 Gerrit-Change-Number: 33610 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-bsc[master]: ASCI: Forward UPLINK RELEASE on dedicated channel to MSC
by jolly 10 Jul '23

10 Jul '23

Attention is currently required from: jolly. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/33609 to look at the new patch set (#3). Change subject: ASCI: Forward UPLINK RELEASE on dedicated channel to MSC ...................................................................... ASCI: Forward UPLINK RELEASE on dedicated channel to MSC If the phone is (still) on a dedicated channel, it may release the uplink in case of a voice group call. It depends on the MSC how to handle the situation. Currently it releases the call. Generally the phone is assigned to the VGCS/VBS channel before it releases the uplink. Change-Id: Ib91c282ed36e82b38c0e738533e3a421de81a9a8 Related: OS#4852 --- M src/osmo-bsc/gsm_04_08_rr.c 1 file changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/09/33609/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33609 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib91c282ed36e82b38c0e738533e3a421de81a9a8 Gerrit-Change-Number: 33609 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 0

[XL] Change in osmo-bsc[master]: ASCI: Add processing and FSMs for VGCS/VBS
by jolly 10 Jul '23

10 Jul '23

Attention is currently required from: jolly. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/33611 to look at the new patch set (#4). Change subject: ASCI: Add processing and FSMs for VGCS/VBS ...................................................................... ASCI: Add processing and FSMs for VGCS/VBS Change-Id: Id9e94fb4f27bb438b7093c031344a3400bfa34f1 Related: OS#4852 --- M include/osmocom/bsc/Makefile.am M include/osmocom/bsc/gsm_data.h A include/osmocom/bsc/vgcs_fsm.h M src/osmo-bsc/Makefile.am M src/osmo-bsc/bsc_subscr_conn_fsm.c M src/osmo-bsc/osmo_bsc_bssap.c A src/osmo-bsc/vgcs_fsm.c 7 files changed, 1,454 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/11/33611/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9e94fb4f27bb438b7093c031344a3400bfa34f1 Gerrit-Change-Number: 33611 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-bsc[master]: ASCI: Forward RLL to VGCS FSM
by jolly 10 Jul '23

10 Jul '23

Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/33613 to look at the new patch set (#4). Change subject: ASCI: Forward RLL to VGCS FSM ...................................................................... ASCI: Forward RLL to VGCS FSM RLL events are forwarded to VGCS FSM. Included L3 information are not forwarded to gsm0408_rcvmsg(), but forwarded to VGCS FSM only. Change-Id: I5e098a20225ba11206f43281f4da519a4086bae5 Related: OS#4852 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 53 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/13/33613/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33613 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5e098a20225ba11206f43281f4da519a4086bae5 Gerrit-Change-Number: 33613 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-bsc[master]: ASCI: Send release on VGCS/VBS channel via unit data
by jolly 10 Jul '23

10 Jul '23

Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/33617 to look at the new patch set (#4). Change subject: ASCI: Send release on VGCS/VBS channel via unit data ...................................................................... ASCI: Send release on VGCS/VBS channel via unit data Channel release is sent to MS that is in dedicated mode on the main DCCH. Additionally it is sent as unit data on a VGCS/VBS to notify all listeners that the channel has been released. All listeners return to IDLE mode. Change-Id: Ib777fe98c8ce2342082d88d227b796167d92cfe1 Related: OS#4852 --- M include/osmocom/bsc/gsm_04_08_rr.h M src/osmo-bsc/gsm_04_08_rr.c M src/osmo-bsc/lchan_fsm.c 3 files changed, 40 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/17/33617/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33617 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib777fe98c8ce2342082d88d227b796167d92cfe1 Gerrit-Change-Number: 33617 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-bsc[master]: ASCI: Make bssmap_handle_ass_req_ct_speech() publically available.
by jolly 10 Jul '23

10 Jul '23

Attention is currently required from: pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33603 ) Change subject: ASCI: Make bssmap_handle_ass_req_ct_speech() publically available. ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/osmo_bsc_bssap.c: https://gerrit.osmocom.org/c/osmo-bsc/+/33603/comment/f3ab07c8_81de1a2a PS2, Line 744: static int select_codecs(struct assignment_request *req, const struct gsm0808_channel_type *ct, > why this change? bts can already be obtained through conn like before? bssmap_handle_ass_req_ct_speech() is called by vgcs_fsm.c. At this point, there is no lchan assigned to the conn. This also means that there is no bts associated with the conn. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33603 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifc1e315d5282f01f8d1bd600d62476c2ae74eca9 Gerrit-Change-Number: 33603 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Jul 2023 11:04:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: pcu_sock: use PCUIF version 11 (direct TLLI)
by dexter 10 Jul '23

10 Jul '23

Attention is currently required from: fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33522 ) Change subject: pcu_sock: use PCUIF version 11 (direct TLLI) ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/33522/comment/257089d1_daf78d5e PS2, Line 10: OsmoPCU is still compatible to version 10 > What do you mean by "still compatible"? You're bumping the PCUIF version which is indicated in the ` […] At the moment OsmoPCU has support for v11 but still accepts v10 PCUIF. I thought I should mention this here. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33522 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I25816ac12e63cc6b641eb414e6bc7eaa9c85fc25 Gerrit-Change-Number: 33522 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Jul 2023 10:56:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-trx[master]: ms: make init call less confusing
by Hoernchen 10 Jul '23

10 Jul '23

Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32957 ) Change subject: ms: make init call less confusing ...................................................................... ms: make init call less confusing Change-Id: I122b0c8cf97e5efcbc60cd95e8bd06a50d57eb57 --- M Transceiver52M/ms/ms.cpp M Transceiver52M/ms/ms.h 2 files changed, 10 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/Transceiver52M/ms/ms.cpp b/Transceiver52M/ms/ms.cpp index e587c05..896928e 100644 --- a/Transceiver52M/ms/ms.cpp +++ b/Transceiver52M/ms/ms.cpp @@ -49,7 +49,7 @@ int ms_trx::init_dev_and_streams() { int status = 0; - status = base::init_device(rx_bh(), tx_bh()); + status = init_device(rx_bh(), tx_bh()); if (status < 0) { std::cerr << "failed to init dev!" << std::endl; return -1; diff --git a/Transceiver52M/ms/ms.h b/Transceiver52M/ms/ms.h index 926031e..1c210b0 100644 --- a/Transceiver52M/ms/ms.h +++ b/Transceiver52M/ms/ms.h @@ -293,7 +293,6 @@ SCH_STATE search_for_sch(dev_buf_t *rcd); void grab_bursts(dev_buf_t *rcd); - int init_device(); int init_dev_and_streams(); void stop_threads(); void *rx_cb(ms_trx *t); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32957 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I122b0c8cf97e5efcbc60cd95e8bd06a50d57eb57 Gerrit-Change-Number: 32957 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-trx[master]: ms: sch: drop intermediate softvector
by Hoernchen 10 Jul '23

10 Jul '23

Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32956 ) Change subject: ms: sch: drop intermediate softvector ...................................................................... ms: sch: drop intermediate softvector Change-Id: Iadc8f224f9e43282339197b11f388fc574656299 --- M Transceiver52M/ms/ms.h M Transceiver52M/ms/ms_rx_lower.cpp 2 files changed, 15 insertions(+), 10 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/Transceiver52M/ms/ms.h b/Transceiver52M/ms/ms.h index ad2d056..926031e 100644 --- a/Transceiver52M/ms/ms.h +++ b/Transceiver52M/ms/ms.h @@ -289,7 +289,7 @@ bool handle_sch_or_nb(); bool handle_sch(bool first = false); - bool decode_sch(float *bits, bool update_global_clock); + bool decode_sch(char *bits, bool update_global_clock); SCH_STATE search_for_sch(dev_buf_t *rcd); void grab_bursts(dev_buf_t *rcd); diff --git a/Transceiver52M/ms/ms_rx_lower.cpp b/Transceiver52M/ms/ms_rx_lower.cpp index 1872c6c..5a07df5 100644 --- a/Transceiver52M/ms/ms_rx_lower.cpp +++ b/Transceiver52M/ms/ms_rx_lower.cpp @@ -51,15 +51,16 @@ #endif #define PRINT_Q_OVERFLOW -bool ms_trx::decode_sch(float *bits, bool update_global_clock) + +bool ms_trx::decode_sch(char *bits, bool update_global_clock) { int fn; struct sch_info sch; ubit_t info[GSM_SCH_INFO_LEN]; sbit_t data[GSM_SCH_CODED_LEN]; - float_to_sbit(&bits[3], &data[0], 1, 39); - float_to_sbit(&bits[106], &data[39], 1, 39); + memcpy(&data[0], &bits[3], 39); + memcpy(&data[39], &bits[106], 39); if (!gsm_sch_decode(info, data)) { gsm_sch_parse(info, &sch); @@ -171,12 +172,7 @@ } detect_burst(&ss[start], &channel_imp_resp[0], 0, sch_demod_bits); - SoftVector bitss(148); - for (int i = 0; i < 148; i++) { - bitss[i] = (sch_demod_bits[i]); - } - - auto sch_decode_success = decode_sch(bitss.begin(), is_first_sch_acq); + auto sch_decode_success = decode_sch(sch_demod_bits, is_first_sch_acq); if (sch_decode_success) { const auto ts_offset_symb = 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32956 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Iadc8f224f9e43282339197b11f388fc574656299 Gerrit-Change-Number: 32956 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-trx[master]: ms: flexible template for value_type buffer sum
by Hoernchen 10 Jul '23

10 Jul '23

Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32955 ) Change subject: ms: flexible template for value_type buffer sum ...................................................................... ms: flexible template for value_type buffer sum Manual attempts to get the number of complex and single samples right turned out to be a bit error prone at times... Change-Id: I3c9953073555e3a7f70b78b0946dfdf949175a82 --- M Transceiver52M/ms/ms.h M Transceiver52M/ms/ms_rx_lower.cpp 2 files changed, 30 insertions(+), 10 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/Transceiver52M/ms/ms.h b/Transceiver52M/ms/ms.h index 8ca9b02..ad2d056 100644 --- a/Transceiver52M/ms/ms.h +++ b/Transceiver52M/ms/ms.h @@ -84,16 +84,19 @@ template <typename T> struct is_complex : std::false_type { using baset = T; + static const unsigned int len_mul = 1; }; template <typename T> struct is_complex<std::complex<T>> : std::true_type { using baset = typename std::complex<T>::value_type; + static const unsigned int len_mul = 2; }; template <typename T> struct is_complex<Complex<T>> : std::true_type { using baset = typename Complex<T>::value_type; + static const unsigned int len_mul = 2; }; } // namespace cvt_internal @@ -106,6 +109,19 @@ return cvt_internal::convert_and_scale_i((vd *)dst, (vs *)src, src_len, scale); } +template <typename array_t> +float normed_abs_sum(array_t *src, int len) +{ + using vd = typename cvt_internal::is_complex<array_t>::baset; + auto len_mul = cvt_internal::is_complex<array_t>::len_mul; + auto ptr = reinterpret_cast<const vd *>(src); + float sum = 0; + for (unsigned int i = 0; i < len * len_mul; i++) + sum += std::abs(ptr[i]); + sum /= len * len_mul; + return sum; +} + struct one_burst { one_burst() { diff --git a/Transceiver52M/ms/ms_rx_lower.cpp b/Transceiver52M/ms/ms_rx_lower.cpp index 26ee131..1872c6c 100644 --- a/Transceiver52M/ms/ms_rx_lower.cpp +++ b/Transceiver52M/ms/ms_rx_lower.cpp @@ -101,11 +101,7 @@ const unsigned int rx_max_cutoff = (rxFullScale * 2) / 3; static int gain_check = 0; static float runmean = 0; - float sum = 0; - for (auto i : brst.burst) - sum += abs(i.real()) + abs(i.imag()); - sum /= ONE_TS_BURST_LEN * 2; - + float sum = normed_abs_sum(&brst.burst[0], ONE_TS_BURST_LEN); runmean = gain_check ? (runmean * (gain_check + 2) - 1 + sum) / (gain_check + 2) : sum; if (gain_check == avgburst_num - 1) { @@ -231,12 +227,8 @@ sch_pos = 0; rcv_done = true; auto sch_search_fun = [this] { - auto ptr = reinterpret_cast<const int16_t *>(first_sch_buf); const auto target_val = rxFullScale / 8; - float sum = 0; - for (unsigned int i = 0; i < SCH_LEN_SPS * 2; i++) - sum += std::abs(ptr[i]); - sum /= SCH_LEN_SPS * 2; + float sum = normed_abs_sum(first_sch_buf, SCH_LEN_SPS); //FIXME: arbitrary value, gain cutoff if (sum > target_val || rxgain >= 60) // enough ? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32955 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I3c9953073555e3a7f70b78b0946dfdf949175a82 Gerrit-Change-Number: 32955 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0