July 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: osmo_io: Document expectation that segmentation_cb() can modify msgb
by daniel 11 Jul '23

11 Jul '23

Attention is currently required from: pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33685 ) Change subject: osmo_io: Document expectation that segmentation_cb() can modify msgb ...................................................................... Patch Set 1: (1 comment) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/33685/comment/af63c6a9_f95dd6f9 PS1, Line 264: memcpy(msgb_data(msg_pending), data + expected_len, extra_len); > shouldn't this actually be a memmove since they may overlap? No - msg_pending is a new msg allocation, data is from msg->data -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idd2115baae98a7818aabb26232d4423d2d48fb5c Gerrit-Change-Number: 33685 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Jul 2023 15:34:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: cosmetic: Fix doc comment
by pespin 11 Jul '23

11 Jul '23

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33687 ) Change subject: cosmetic: Fix doc comment ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iec614004a0382534f4bfcc375f4d89192d7f27aa Gerrit-Change-Number: 33687 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Jul 2023 15:17:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: osmo_io: Document expectation that segmentation_cb() can modify msgb
by pespin 11 Jul '23

11 Jul '23

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33685 ) Change subject: osmo_io: Document expectation that segmentation_cb() can modify msgb ...................................................................... Patch Set 1: (1 comment) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/33685/comment/8f3194f0_4fc7ef27 PS1, Line 264: memcpy(msgb_data(msg_pending), data + expected_len, extra_len); shouldn't this actually be a memmove since they may overlap? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idd2115baae98a7818aabb26232d4423d2d48fb5c Gerrit-Change-Number: 33685 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Jul 2023 15:17:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: osmo_io: Add function to change the tx_queue size
by pespin 11 Jul '23

11 Jul '23

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33686 ) Change subject: osmo_io: Add function to change the tx_queue size ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/33686/comment/340e4026_dddf9910 PS1, Line 549: void osmo_iofd_set_txqueue_size(struct osmo_io_fd *iofd, unsigned int size) osmo_iofd_set_txqueue_max_length()? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If3d1de8bffe1123002515878655ea9e02b482888 Gerrit-Change-Number: 33686 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Jul 2023 15:14:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: add role and sctp-role in osmo-stp.cfg
by pespin 11 Jul '23

11 Jul '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33669 ) Change subject: hnbgw: add role and sctp-role in osmo-stp.cfg ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33669 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1019c1d4ebb6183a389c655ea6716bfb0255721a Gerrit-Change-Number: 33669 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Jul 2023 15:08:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts/BTS_Tests.default: bump default PCUIF version to 11
by fixeria 11 Jul '23

11 Jul '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33684 ) Change subject: bts/BTS_Tests.default: bump default PCUIF version to 11 ...................................................................... bts/BTS_Tests.default: bump default PCUIF version to 11 Without this change I cannot run BTS_Tests manually anymore: Local verdict of MTC: fail reason: "BTS_Tests.ttcn:480 : Invalid PCU Version/BTS Number received" Change-Id: If0046b44adb93fba7dced1ce06d5ddb9d7c75269 Fixes: 3b4abb86 "BTS_Tests: Add support for PCUIF protocol version 11" --- M bts/BTS_Tests.default 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/bts/BTS_Tests.default b/bts/BTS_Tests.default index 0657b65..7c5230b 100644 --- a/bts/BTS_Tests.default +++ b/bts/BTS_Tests.default @@ -29,7 +29,7 @@ [MODULE_PARAMETERS] Osmocom_VTY_Functions.mp_prompt_prefix := "OsmoBTS"; -PCUIF_Types.mp_pcuif_version := 10; +PCUIF_Types.mp_pcuif_version := 11; # Configuration for each individual transceiver BTS_Tests.mp_trx_pars := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If0046b44adb93fba7dced1ce06d5ddb9d7c75269 Gerrit-Change-Number: 33684 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts/BTS_Tests.default: bump default PCUIF version to 11
by pespin 11 Jul '23

11 Jul '23

Attention is currently required from: fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33684 ) Change subject: bts/BTS_Tests.default: bump default PCUIF version to 11 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If0046b44adb93fba7dced1ce06d5ddb9d7c75269 Gerrit-Change-Number: 33684 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Jul 2023 15:07:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: jobs/ttcn3: add ttcn3-mme-test-ogs
by osmith 11 Jul '23

11 Jul '23

osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-ci/+/33688 ) Change subject: jobs/ttcn3: add ttcn3-mme-test-ogs ...................................................................... jobs/ttcn3: add ttcn3-mme-test-ogs Related: OS#5760 Related: https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-mme-test-ogs Change-Id: I503815ce4e244a0db0106b9c651f06ab2406c331 --- M jobs/ttcn3-testsuites.yml 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/88/33688/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33688 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I503815ce4e244a0db0106b9c651f06ab2406c331 Gerrit-Change-Number: 33688 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ci[master]: jobs/ttcn3: add ttcn3-mme-test
by osmith 11 Jul '23

11 Jul '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/33688 ) Change subject: jobs/ttcn3: add ttcn3-mme-test ...................................................................... jobs/ttcn3: add ttcn3-mme-test Related: OS#5760 Related: https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-mme-test-ogs Change-Id: I503815ce4e244a0db0106b9c651f06ab2406c331 --- M jobs/ttcn3-testsuites.yml 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/88/33688/1 diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 0503a54..14e1d6f 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -121,6 +121,11 @@ description: | Test open5gs-smfd + open5gs-upfd PGW main. email: jenkins-notifications(a)lists.osmocom.org acetcom(a)gmail.com + - ttcn3-mme-test-ogs: + timer: 15 14 * * * + description: | + Test open5gs-mme + email: jenkins-notifications(a)lists.osmocom.org acetcom(a)gmail.com # debian latest stable - nplab-m3ua-test-latest: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33688 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I503815ce4e244a0db0106b9c651f06ab2406c331 Gerrit-Change-Number: 33688 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: cosmetic: Fix doc comment
by daniel 11 Jul '23

11 Jul '23

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/33687 ) Change subject: cosmetic: Fix doc comment ...................................................................... cosmetic: Fix doc comment Change-Id: Iec614004a0382534f4bfcc375f4d89192d7f27aa --- M src/core/osmo_io.c 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/87/33687/1 diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index cab3457..606adfb 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -533,6 +533,7 @@ } /*! Set the size and headroom of the msgb allocated when receiving messages + * \param[in] iofd the file descriptor * \param[in] size the size of the msgb when receiving data * \param[in] headroom the headroom of the msgb when receiving data */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iec614004a0382534f4bfcc375f4d89192d7f27aa Gerrit-Change-Number: 33687 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

1 0