July 2023 - gerrit-log - lists.osmocom.org

[S] Change in libasn1c[master]: INTEGER: ignore warning for all GCC versions
by pespin 14 Jul '23

14 Jul '23

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libasn1c/+/33739 ) Change subject: INTEGER: ignore warning for all GCC versions ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/33739 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: I48d9d423df47f23a0ef3ea727a40b53d70aec48b Gerrit-Change-Number: 33739 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Jul 2023 12:04:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmocom-bb[master]: trxcon/l1sched: implement CSD scheduling support
by pespin 14 Jul '23

14 Jul '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32922 ) Change subject: trxcon/l1sched: implement CSD scheduling support ...................................................................... Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32922 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0d7389a9a5f7019b9316ab1c0115797ff54a0e41 Gerrit-Change-Number: 32922 Gerrit-PatchSet: 10 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Jul 2023 12:03:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in osmo-msc[master]: ASCI: Add call control for VGCS/VBS
by jolly 14 Jul '23

14 Jul '23

Attention is currently required from: neels, laforge, dexter. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/33511 to look at the new patch set (#16). Change subject: ASCI: Add call control for VGCS/VBS ...................................................................... ASCI: Add call control for VGCS/VBS Change-Id: I9947403fde8212b66758104443c60aaacc8b1e7b Related: OS#4854 --- M include/osmocom/msc/Makefile.am A include/osmocom/msc/msc_vgcs.h M include/osmocom/msc/ran_conn.h M include/osmocom/msc/transaction.h M src/libmsc/Makefile.am M src/libmsc/gsm_04_11_gsup.c A src/libmsc/msc_vgcs.c M src/libmsc/transaction.c 8 files changed, 3,023 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/11/33511/16 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9947403fde8212b66758104443c60aaacc8b1e7b Gerrit-Change-Number: 33511 Gerrit-PatchSet: 16 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-msc[master]: ASCI: Add function to receive VGCS/VBS messages from BSS
by jolly 14 Jul '23

14 Jul '23

Attention is currently required from: neels. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33504 ) Change subject: ASCI: Add function to receive VGCS/VBS messages from BSS ...................................................................... Patch Set 15: (2 comments) File src/libmsc/ran_peer.c: https://gerrit.osmocom.org/c/osmo-msc/+/33504/comment/703525ee_2c282e64 PS14, Line 396: > so below, there is a priority: 1.msc_role 2.vgcs.bss 3.vgcs.cell. […] A conn that is used for VGCS/VBS BSS connection (conn->vgcs.bss) and a conn that is used for VGCS/VBS channel connection (conn->vgcs.cell) does not have any transaction, nor subscriber. Both connection types are linked as sub structures to a VGCS/VBS transaction. (using lists) The VGCS/VBS transaction uses conn->msc_role until the caller is assigned to the VGCS/VBS channel. As said above, this channel (the caller is assigned to) has no transaction, nor subscriber linked to it, even if someone (the caller or other subscriber) is talking on the channel. https://gerrit.osmocom.org/c/osmo-msc/+/33504/comment/16549405_5b13b2ad PS14, Line 413: return > (now redundant) Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33504 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie4a2f19ba75140a6f2de02b709597239c01f02a2 Gerrit-Change-Number: 33504 Gerrit-PatchSet: 15 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Jul 2023 11:55:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[XL] Change in osmo-msc[master]: ASCI: Add call control for VGCS/VBS
by jolly 14 Jul '23

14 Jul '23

Attention is currently required from: neels, laforge, dexter. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33511 ) Change subject: ASCI: Add call control for VGCS/VBS ...................................................................... Patch Set 15: (10 comments) File src/libmsc/msc_vgcs.c: https://gerrit.osmocom.org/c/osmo-msc/+/33511/comment/942d0edb_d3f30f83 PS14, Line 179: OSMO_ASSERT(l3_msg); > this would abort the program on an encoding error? […] Done https://gerrit.osmocom.org/c/osmo-msc/+/33511/comment/81731566_381cbb13 PS14, Line 231: *callref = ntohl(*(uint32_t *)ie) >> 5; > maybe better use osmo_load32be() because it also works reliably when the pointer is not on a word bo […] Done https://gerrit.osmocom.org/c/osmo-msc/+/33511/comment/a0d9d210_a6fd0d95 PS14, Line 801: if (msc_a) { > (early exit pattern: 'if (!msc_a) return;' means less indent. […] Done https://gerrit.osmocom.org/c/osmo-msc/+/33511/comment/5f927165_643c96c3 PS14, Line 1628: OSMO_ASSERT(l3_msg); > encoding error: do not abort the program, log and return error Done https://gerrit.osmocom.org/c/osmo-msc/+/33511/comment/1f15e3fe_4a57750c PS14, Line 1666: OSMO_ASSERT > . Done https://gerrit.osmocom.org/c/osmo-msc/+/33511/comment/556aa72f_b079cfe5 PS14, Line 1727: osmo_fsm_inst_free(bss->fi); > rather use osmo_fsm_inst_term(). It terminates the instance gracefully and then frees it. […] Done https://gerrit.osmocom.org/c/osmo-msc/+/33511/comment/a2e129d8_36b77257 PS14, Line 1730: talloc_free(bss); > (hint, in case you like it too, i like to allocate the struct as a talloc child of the FSM instance, […] Ok, makes sense. (Alternatively one could do the talloc_free inside the destructor of the the FSM, if the FSM is a child of the allocated structure.) https://gerrit.osmocom.org/c/osmo-msc/+/33511/comment/379da719_327d5bc2 PS14, Line 1796: OSMO_ASSERT > . Done https://gerrit.osmocom.org/c/osmo-msc/+/33511/comment/ceaf9210_79a37efc PS14, Line 1938: OSMO_ASSERT > . Done https://gerrit.osmocom.org/c/osmo-msc/+/33511/comment/9a2c5337_477a8306 PS14, Line 1949: OSMO_ASSERT > . Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9947403fde8212b66758104443c60aaacc8b1e7b Gerrit-Change-Number: 33511 Gerrit-PatchSet: 15 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Jul 2023 11:54:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: ASCI: Add option to switch on or off ASCI support
by jolly 14 Jul '23

14 Jul '23

Attention is currently required from: neels. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33674 ) Change subject: ASCI: Add option to switch on or off ASCI support ...................................................................... Patch Set 2: (1 comment) File src/libmsc/msc_a.c: https://gerrit.osmocom.org/c/osmo-msc/+/33674/comment/f4c9050f_b8256981 PS2, Line 2088: struct msc_a *msc_a > ( […] msc_a_cm_service_type_to_use() is a function to be uses in conjunction with msc_a. I think that the caller should not know about what service is enabled or not. Using net instead of msc_a is ok, because msc_a_cm_service_type_to_use() does not use msc_a structure. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Id68deb69f7395f0f8f50b3820e9d51052a34f753 Gerrit-Change-Number: 33674 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Jul 2023 11:54:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[XL] Change in osmo-msc[master]: ASCI: Add call control for VGCS/VBS
by Jenkins Builder 14 Jul '23

14 Jul '23

Attention is currently required from: jolly, laforge, dexter. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33511 ) Change subject: ASCI: Add call control for VGCS/VBS ...................................................................... Patch Set 15: (2 comments) File src/libmsc/msc_vgcs.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-9648): https://gerrit.osmocom.org/c/osmo-msc/+/33511/comment/233cbd9b_6c2689d3 PS15, Line 1803: /* First message, so we must set "intial" to "true". */ 'intial' may be misspelled - perhaps 'initial'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-9648): https://gerrit.osmocom.org/c/osmo-msc/+/33511/comment/8e10e5b1_0084111e PS15, Line 2446: /* First message, so we must set "intial" to "true". */ 'intial' may be misspelled - perhaps 'initial'? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9947403fde8212b66758104443c60aaacc8b1e7b Gerrit-Change-Number: 33511 Gerrit-PatchSet: 15 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Jul 2023 11:45:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: ASCI: Add option to switch on or off ASCI support
by jolly 14 Jul '23

14 Jul '23

Attention is currently required from: jolly. Hello Jenkins Builder, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/33674 to look at the new patch set (#3). Change subject: ASCI: Add option to switch on or off ASCI support ...................................................................... ASCI: Add option to switch on or off ASCI support Switching ASCI support is controled via VTY. This added in a later patch. (Chg-Id: I5bd034a62fc8b483f550d29103c2f7587198f590) Change-Id: Id68deb69f7395f0f8f50b3820e9d51052a34f753 Related: OS#4854 --- M include/osmocom/msc/gsm_data.h M include/osmocom/msc/msc_a.h M src/libmsc/gsm_04_08.c M src/libmsc/msc_a.c 4 files changed, 27 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/74/33674/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Id68deb69f7395f0f8f50b3820e9d51052a34f753 Gerrit-Change-Number: 33674 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-msc[master]: ASCI: Add function to receive VGCS/VBS messages from BSS
by jolly 14 Jul '23

14 Jul '23

Attention is currently required from: jolly. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/33504 to look at the new patch set (#15). Change subject: ASCI: Add function to receive VGCS/VBS messages from BSS ...................................................................... ASCI: Add function to receive VGCS/VBS messages from BSS A voice group/broadcast call has no SCCP connection that is related 1:1 to a calling or called subscriber. Instead there are multiple connections between MSC and BSS. Some of them control the uplink for each BSS and some of them assign the channels for each BTS. SCCP connections are maintained by the VGCS call control. Message from the RAN are directly forwarded to the VGCS call control. Change-Id: Ie4a2f19ba75140a6f2de02b709597239c01f02a2 Related: OS#4854 --- M include/osmocom/msc/msc_a.h M src/libmsc/ran_peer.c 2 files changed, 38 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/04/33504/15 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33504 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie4a2f19ba75140a6f2de02b709597239c01f02a2 Gerrit-Change-Number: 33504 Gerrit-PatchSet: 15 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 0

[XL] Change in osmo-msc[master]: ASCI: Add call control for VGCS/VBS
by jolly 14 Jul '23

14 Jul '23

Attention is currently required from: jolly, laforge, dexter. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/33511 to look at the new patch set (#15). Change subject: ASCI: Add call control for VGCS/VBS ...................................................................... ASCI: Add call control for VGCS/VBS Change-Id: I9947403fde8212b66758104443c60aaacc8b1e7b Related: OS#4854 --- M include/osmocom/msc/Makefile.am A include/osmocom/msc/msc_vgcs.h M include/osmocom/msc/ran_conn.h M include/osmocom/msc/transaction.h M src/libmsc/Makefile.am M src/libmsc/gsm_04_11_gsup.c A src/libmsc/msc_vgcs.c M src/libmsc/transaction.c 8 files changed, 3,023 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/11/33511/15 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9947403fde8212b66758104443c60aaacc8b1e7b Gerrit-Change-Number: 33511 Gerrit-PatchSet: 15 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0