Attention is currently required from: pespin, fixeria, dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/33753 )
Change subject: gmm: Update DRX params during rx RAU REQ
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/sgsn/gprs_gmm.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/33753/comment/a038612f_bf332dbd
PS1, Line 1770: TLVP_PRESENT
> I thought that was already tested by tlv_parse? […]
ah, it is a fixed-length element. Then yes, that shold be guaranteed by tlv_parse. My comments were about fields with variable-length.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/33753
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I1dd7f8f161280dd017c337eacc3aa2be4ccd65ea
Gerrit-Change-Number: 33753
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 18 Jul 2023 06:24:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria, dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33690 )
Change subject: pySim/cards: Split legacy classes away from core SIM + UICC
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
File pySim/cards.py:
https://gerrit.osmocom.org/c/pysim/+/33690/comment/594e5e00_51673824
PS4, Line 319: SimCard
> I personally would put a comment into UiccCardBase that describes the situation. […]
I'll add that comment after the current patch series is merged to avoid too much fall-out.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/33690
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Id36140675def5fc44eedce81fc7b09e0adc527e1
Gerrit-Change-Number: 33690
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Jul 2023 17:47:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment