June 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: l1sap: use gsm0502_fn2ccch_block() from libosmogsm
by laforge 26 Jun '23

26 Jun '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33403 ) Change subject: l1sap: use gsm0502_fn2ccch_block() from libosmogsm ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33403 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7097ba87f42689d2336014da9173cadbdaa9fdab Gerrit-Change-Number: 33403 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jun 2023 08:37:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: layer23: cosmetic: move <lapdm.h> to other libosmo* imports
by laforge 26 Jun '23

26 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33404 ) Change subject: layer23: cosmetic: move <lapdm.h> to other libosmo* imports ...................................................................... layer23: cosmetic: move <lapdm.h> to other libosmo* imports Change-Id: Id4d8df3f230729dc2c65e1bedea705e28feaa029 --- M src/host/layer23/src/common/l1ctl.c 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/host/layer23/src/common/l1ctl.c b/src/host/layer23/src/common/l1ctl.c index 8e55b7b..55960e8 100644 --- a/src/host/layer23/src/common/l1ctl.c +++ b/src/host/layer23/src/common/l1ctl.c @@ -37,13 +37,13 @@ #include <osmocom/gsm/protocol/gsm_04_08.h> #include <osmocom/gsm/protocol/gsm_08_58.h> #include <osmocom/gsm/rsl.h> +#include <osmocom/gsm/lapdm.h> #include <osmocom/bb/common/l1ctl.h> #include <osmocom/bb/common/l23_app.h> #include <osmocom/bb/common/osmocom_data.h> #include <osmocom/bb/common/ms.h> #include <osmocom/bb/common/l1l2_interface.h> -#include <osmocom/gsm/lapdm.h> #include <osmocom/bb/common/logging.h> #define CB_FCCH -1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33404 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id4d8df3f230729dc2c65e1bedea705e28feaa029 Gerrit-Change-Number: 33404 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmocom-bb[master]: layer23: use gsm0502_fn2ccch_block() from libosmogsm
by laforge 26 Jun '23

26 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33405 ) Change subject: layer23: use gsm0502_fn2ccch_block() from libosmogsm ...................................................................... layer23: use gsm0502_fn2ccch_block() from libosmogsm Change-Id: I652a2ab9ddb3cb5082cce911a5cdb4cf8abcf552 Depends: libosmocore.git I8cbd31226754e95887358ed83a928e2f567f4cf3 --- M src/host/layer23/src/common/l1ctl.c 1 file changed, 12 insertions(+), 26 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/host/layer23/src/common/l1ctl.c b/src/host/layer23/src/common/l1ctl.c index 55960e8..7f15c39 100644 --- a/src/host/layer23/src/common/l1ctl.c +++ b/src/host/layer23/src/common/l1ctl.c @@ -38,6 +38,7 @@ #include <osmocom/gsm/protocol/gsm_08_58.h> #include <osmocom/gsm/rsl.h> #include <osmocom/gsm/lapdm.h> +#include <osmocom/gsm/gsm0502.h> #include <osmocom/bb/common/l1ctl.h> #include <osmocom/bb/common/l23_app.h> @@ -46,35 +47,10 @@ #include <osmocom/bb/common/l1l2_interface.h> #include <osmocom/bb/common/logging.h> -#define CB_FCCH -1 -#define CB_SCH -2 -#define CB_BCCH -3 -#define CB_IDLE -4 - -/* according to TS 05.02 Clause 7 Table 3 of 9 an Figure 8a */ -static const int ccch_block_table[51] = { - CB_FCCH, CB_SCH,/* 0..1 */ - CB_BCCH, CB_BCCH, CB_BCCH, CB_BCCH, /* 2..5: BCCH */ - 0, 0, 0, 0, /* 6..9: B0 */ - CB_FCCH, CB_SCH,/* 10..11 */ - 1, 1, 1, 1, /* 12..15: B1 */ - 2, 2, 2, 2, /* 16..19: B2 */ - CB_FCCH, CB_SCH,/* 20..21 */ - 3, 3, 3, 3, /* 22..25: B3 */ - 4, 4, 4, 4, /* 26..29: B4 */ - CB_FCCH, CB_SCH,/* 30..31 */ - 5, 5, 5, 5, /* 32..35: B5 */ - 6, 6, 6, 6, /* 36..39: B6 */ - CB_FCCH, CB_SCH,/* 40..41 */ - 7, 7, 7, 7, /* 42..45: B7 */ - 8, 8, 8, 8, /* 46..49: B8 */ - -4 /* 50: Idle */ -}; - /* determine the CCCH block number based on the frame number */ static unsigned int fn2ccch_block(uint32_t fn) { - int rc = ccch_block_table[fn%51]; + int rc = gsm0502_fn2ccch_block(fn); /* if FN is negative, we were called for something that's not CCCH! */ OSMO_ASSERT(rc >= 0); return rc; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33405 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I652a2ab9ddb3cb5082cce911a5cdb4cf8abcf552 Gerrit-Change-Number: 33405 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmocom-bb[master]: layer23: use gsm0502_fn2ccch_block() from libosmogsm
by laforge 26 Jun '23

26 Jun '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33405 ) Change subject: layer23: use gsm0502_fn2ccch_block() from libosmogsm ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33405 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I652a2ab9ddb3cb5082cce911a5cdb4cf8abcf552 Gerrit-Change-Number: 33405 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jun 2023 08:37:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in libosmo-netif[master]: stream: Add server-side (segmentation) support for IPAC
by laforge 26 Jun '23

26 Jun '23

Attention is currently required from: arehbein. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33197 ) Change subject: stream: Add server-side (segmentation) support for IPAC ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-netif/+/33197/comment/6c43cfbc_9e268141 PS2, Line 11: Depends on change I3a639e6896cc3b3fc8e9b2e1a58254710efa0d3f we typically write something like: Depends: libosmocore.git I3a639e6896cc3b3fc8e9b2e1a58254710efa0d3f or Depends: libosmocore.git Change-Id I3a639e6896cc3b3fc8e9b2e1a58254710efa0d3f -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I6c91ff385cb5f36ab6b6c96d0e44997995d0d24c Gerrit-Change-Number: 33197 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jun 2023 08:36:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in libosmo-netif[master]: stream: Fix endless loop on server on client disconnect
by laforge 26 Jun '23

26 Jun '23

Attention is currently required from: arehbein. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33196 ) Change subject: stream: Fix endless loop on server on client disconnect ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33196 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I012ddf14ae17642a52d34026d85ab6958cf488a1 Gerrit-Change-Number: 33196 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jun 2023 08:35:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmo-netif[master]: stream: Move some code in preparation of next commit
by laforge 26 Jun '23

26 Jun '23

Attention is currently required from: arehbein. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33195 ) Change subject: stream: Move some code in preparation of next commit ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33195 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ic3f21967fe929b17327eb95739ace16c9734a151 Gerrit-Change-Number: 33195 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jun 2023 08:34:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: ASCI: Add decoding of mobile identity in TALKER INDICATION
by jolly 26 Jun '23

26 Jun '23

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/33446 ) Change subject: ASCI: Add decoding of mobile identity in TALKER INDICATION ...................................................................... ASCI: Add decoding of mobile identity in TALKER INDICATION gsm48.c provides a function to decode mobile identity from various messages. TALKER INDICATION is sent by the talking subscriber of a voice group call to idenitfy the current talker. The mobile identity is required to distinguish between calling subscriber and other subscribers. Related: OS#4854 Change-Id: I331fac82e3c15abb01f554b2e70576100f2eea2d --- M src/gsm/gsm48.c 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/46/33446/1 diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c index 3ec7547..8f781e7 100644 --- a/src/gsm/gsm48.c +++ b/src/gsm/gsm48.c @@ -955,6 +955,15 @@ cm2_buf = (uint8_t*)&paging_response->cm2; goto got_cm2; + case GSM48_MT_RR_TALKER_IND: + if (l3_len < sizeof(*gh) + 4 + 2) + return -EBADMSG; + if (gh->data[0] != 3) + return -EBADMSG; + cm2_len = 3; + cm2_buf = gh->data + 1; + goto got_cm2; + default: break; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33446 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I331fac82e3c15abb01f554b2e70576100f2eea2d Gerrit-Change-Number: 33446 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: Allow 'configure <cr>' at VTY to enter config mode
by jolly 26 Jun '23

26 Jun '23

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/33445 ) Change subject: Allow 'configure <cr>' at VTY to enter config mode ...................................................................... Allow 'configure <cr>' at VTY to enter config mode Similar to HP/Aruba, only the word or abbreviation of 'configure' is required to enter config mode. This is the default. It is still possible to add other configuration sources than 'terminal' if implemented in the future. Change-Id: I56d5d1bd5526603a397c62542e667c413f4952ca --- M src/vty/command.c 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/45/33445/1 diff --git a/src/vty/command.c b/src/vty/command.c index e67fd86..a3e0e36 100644 --- a/src/vty/command.c +++ b/src/vty/command.c @@ -2997,7 +2997,7 @@ /* Configration from terminal */ DEFUN(config_terminal, config_terminal_cmd, - "configure terminal", + "configure [terminal]", "Configuration from vty interface\n" "Configuration terminal\n") { if (vty_config_lock(vty)) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33445 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I56d5d1bd5526603a397c62542e667c413f4952ca Gerrit-Change-Number: 33445 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: ASCI: Also display group/broadcast call message names
by jolly 26 Jun '23

26 Jun '23

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/33444 ) Change subject: ASCI: Also display group/broadcast call message names ...................................................................... ASCI: Also display group/broadcast call message names gsm48_pdisc_msgtype_name* will include group and broadcast call control message names too. Change-Id: I1874e61c24cd8e66b74171681d22f0bfe8069158 --- M src/gsm/gsm48.c 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/44/33444/1 diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c index 53e0989..3ec7547 100644 --- a/src/gsm/gsm48.c +++ b/src/gsm/gsm48.c @@ -42,6 +42,7 @@ #include <osmocom/gsm/protocol/gsm_08_58.h> #include <osmocom/gsm/protocol/gsm_04_08_gprs.h> #include <osmocom/gsm/protocol/gsm_23_003.h> +#include <osmocom/gsm/protocol/gsm_44_068.h> /*! \addtogroup gsm0408 * @{ @@ -1755,6 +1756,10 @@ case GSM48_PDISC_CC: msgt_names = gsm48_cc_msgtype_names; break; + case GSM48_PDISC_GROUP_CC: + case GSM48_PDISC_BCAST_CC: + msgt_names = osmo_gsm44068_msg_type_names; + break; case GSM48_PDISC_NC_SS: msgt_names = gsm48_nc_ss_msgtype_names; break; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33444 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1874e61c24cd8e66b74171681d22f0bfe8069158 Gerrit-Change-Number: 33444 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

1 0