Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33457 )
Change subject: osmo-bts-sysmo: mute PHY until OML is ready
......................................................................
Patch Set 3:
(1 comment)
File src/osmo-bts-sysmo/l1_if.c:
https://gerrit.osmocom.org/c/osmo-bts/+/33457/comment/6323e9f3_b4ab199b
PS3, Line 1264: if (!trx->mo.opstart_success)
IMHO you should move this trx_rf_lock up to line 1258, and you could even simply remove bts_update_status since you are locking now immediatelly.
Moreover, this "if (!trx->mo.opstart_success)" doesn't make sense to me, since for sure OPSTART is to be done far afterwards, you can simply drop the check.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33457
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ia1769f952fa787202a442a33db5ed4a1f7cbe9c3
Gerrit-Change-Number: 33457
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 26 Jun 2023 14:03:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33456 )
Change subject: osmo-bts-sysmo: activate_rf: no dispatch on fail
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33456
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I342187604f4c72303e393ce6925b94d610bfa8fa
Gerrit-Change-Number: 33456
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 26 Jun 2023 13:56:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33457 )
Change subject: osmo-bts-sysmo: mute PHY until OML is ready
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33457
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ia1769f952fa787202a442a33db5ed4a1f7cbe9c3
Gerrit-Change-Number: 33457
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Mon, 26 Jun 2023 13:53:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bts/+/33457 )
Change subject: osmo-bts-sysmo: mute PHY until OML is ready
......................................................................
osmo-bts-sysmo: mute PHY until OML is ready
Connecting to OML and PHY is done in parallel. Mute PHY if it is
connected first and the connection to OML is not established yet.
I've verified that if no OML connection can be established, the LED only
turns on briefly, and then switches to off until OML succeeds.
Fixes: SYS#6496
Change-Id: Ia1769f952fa787202a442a33db5ed4a1f7cbe9c3
---
M src/osmo-bts-sysmo/l1_if.c
1 file changed, 19 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/57/33457/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33457
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ia1769f952fa787202a442a33db5ed4a1f7cbe9c3
Gerrit-Change-Number: 33457
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33415 )
Change subject: tbf_ul: Avoid processing rx UL bocks for UL TBFs in RELEASING state
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
File src/tbf_ul.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/33415/comment/c90fba36_a8aa7d69
PS1, Line 264: requested
> may _have_ requested?
Done
File src/tbf_ul.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/33415/comment/78ca822b_aa96616b
PS2, Line 266: If this is the case, simply ignore the block
Don't you need to `return` from here?
You say ignore, but you're simply logging a message and the execution continues?
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33415
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I1da9b665b9ed83a644ea798008d456d6298b7460
Gerrit-Change-Number: 33415
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 26 Jun 2023 13:49:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/33460 )
Change subject: net/templates/run.sh: fix BSC_COUNT check
......................................................................
net/templates/run.sh: fix BSC_COUNT check
Use ${BSC_COUNT} instead of $BSC_COUNT, as otherwise the template code
doesn't replace the variable. Without this patch it always went into the
else code path.
Change-Id: I2b880a8da51f96c16fb56d9d6e3994ecc1b47ae7
---
M net/templates/run.sh
1 file changed, 14 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/60/33460/1
diff --git a/net/templates/run.sh b/net/templates/run.sh
index 1954cfb..d4edbaa 100755
--- a/net/templates/run.sh
+++ b/net/templates/run.sh
@@ -244,7 +244,7 @@
term "${CMD_HNBGW}" HNBGW
-if [ "$BSC_COUNT" = 1 ]; then
+if [ "${BSC_COUNT}" = 1 ]; then
term "${CMD_MGW} -c osmo-mgw-for-bsc-0.cfg" MGW4BSC
term "${CMD_BSC} -c osmo-bsc-0.cfg" BSC
else
--
To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/33460
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-Change-Id: I2b880a8da51f96c16fb56d9d6e3994ecc1b47ae7
Gerrit-Change-Number: 33460
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange
