June 2023 - gerrit-log - lists.osmocom.org

[M] Change in pysim[master]: cosmetic: Implement cmd2.Settable backwards-compat via wrapper class
by laforge 27 Jun '23

27 Jun '23

Attention is currently required from: laforge. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/33421 to look at the new patch set (#3). Change subject: cosmetic: Implement cmd2.Settable backwards-compat via wrapper class ...................................................................... cosmetic: Implement cmd2.Settable backwards-compat via wrapper class Let's avoid too many open-coded if-clauses and simply wrap it in a compatibility class. Change-Id: Id234f3fa56fe7eff8e1153d71b9be8a2e88dd112 --- M pySim-shell.py 1 file changed, 30 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/21/33421/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33421 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id234f3fa56fe7eff8e1153d71b9be8a2e88dd112 Gerrit-Change-Number: 33421 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in pysim[master]: ts_31_103: enable encode tests for files containing single TLV IE
by laforge 27 Jun '23

27 Jun '23

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/33452 to look at the new patch set (#2). Change subject: ts_31_103: enable encode tests for files containing single TLV IE ...................................................................... ts_31_103: enable encode tests for files containing single TLV IE Now that we have fixed OS#6073 in the previous commit, we can enable the so-far disabled encoder tests for EF.{DOMAIN,IMPU,IMPI} and remove associated FIXMEs. Change-Id: I79bfc5b77122907d6cc2f75605f9331b5e650286 --- M pySim/ts_31_103.py 1 file changed, 16 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/52/33452/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33452 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I79bfc5b77122907d6cc2f75605f9331b5e650286 Gerrit-Change-Number: 33452 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmo-pfcp[master]: Fix license information in dpkg + rpm packages: GPLv2+ and not AGPLv3+
by laforge 27 Jun '23

27 Jun '23

Attention is currently required from: laforge. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/33469 to look at the new patch set (#2). Change subject: Fix license information in dpkg + rpm packages: GPLv2+ and not AGPLv3+ ...................................................................... Fix license information in dpkg + rpm packages: GPLv2+ and not AGPLv3+ These look like copy+paste issues. We don't generally do AGPL for library code; libraries are typically under GPLv2+ for maximum compatibility. Change-Id: I94d0dda467b2c2b1c61ad1c6cb234cb66db46134 --- M contrib/libosmo-pfcp.spec.in M debian/copyright 2 files changed, 21 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/69/33469/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/33469 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I94d0dda467b2c2b1c61ad1c6cb234cb66db46134 Gerrit-Change-Number: 33469 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-mgw[master]: mgcp-client: Mark client as UP when keepalive request-interval/timeou...
by fixeria 27 Jun '23

27 Jun '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/33468 ) Change subject: mgcp-client: Mark client as UP when keepalive request-interval/timeout is disabled through VTY ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/33468 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I263d23885a1a967f844033f9810b96691b8e3b30 Gerrit-Change-Number: 33468 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Jun 2023 06:26:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-mgw[master]: mgcp-client: Always mark client as UP if keepalive request-interval d...
by fixeria 27 Jun '23

27 Jun '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/33467 ) Change subject: mgcp-client: Always mark client as UP if keepalive request-interval disabled ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/33467 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I290f7436f48418ee25179951359c76208796e279 Gerrit-Change-Number: 33467 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Jun 2023 06:25:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: pcu: Wait for USF before start using UL TBF
by fixeria 27 Jun '23

27 Jun '23

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33466 ) Change subject: pcu: Wait for USF before start using UL TBF ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File pcu/GPRS_Components.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33466/comment/14f59de7_cd38… PS2, Line 995: Handle groups of PKT NEIGHBOUR CELL DATA packets copy paste -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33466 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibe8f8c24b239715c0a43d52e59475011e78cb4eb Gerrit-Change-Number: 33466 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Jun 2023 06:21:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: tweak HNB name sent in HNBAP HNB Register
by neels 27 Jun '23

27 Jun '23

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33477 ) Change subject: hnbgw: tweak HNB name sent in HNBAP HNB Register ...................................................................... hnbgw: tweak HNB name sent in HNBAP HNB Register It helps when each distinct HNB has a different name showing in the osmo-hnbgw.log. Change-Id: I560415caba591a3f1139897c6ca4d31566f4c178 --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/77/33477/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 9b12f3a..67d979b 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -717,7 +717,7 @@ { timer T := 2.0; - HNBAP[hnb_idx].send(ts_HNBAP_HNBRegisterRequest(char2oct("TTCN3 HNodeB"), + HNBAP[hnb_idx].send(ts_HNBAP_HNBRegisterRequest(char2oct("TTCN3-HNB-" & int2str(hnb_idx)), '00F110'O, int2bit(1 + cell_id, 28), int2oct(2, 2), -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33477 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I560415caba591a3f1139897c6ca4d31566f4c178 Gerrit-Change-Number: 33477 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: fix PLMN in g_hnb_cfg
by neels 27 Jun '23

27 Jun '23

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33476 ) Change subject: hnbgw: fix PLMN in g_hnb_cfg ...................................................................... hnbgw: fix PLMN in g_hnb_cfg To get 001-01, we need to encode the placeholder 0xf nibble. Since recently, osmo-hnbgw cares about the PLMN in messages, in specific cases: in upcoming CN pool tests, the PLMN is part of the algorithm that picks the CN link. So let's encode 001-01 correctly. Change-Id: I5299c521479dc25ea0f82d7d294d53942960d2cf --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/76/33476/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index b3e6640..9b12f3a 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -337,7 +337,7 @@ for (var integer i := 0; i < g_num_hnbs; i := i+1) { g_hnb_cfg[i] := { lai := { - mcc_mnc := '00101'H, + mcc_mnc := '00F110'H, lac := 2342 + i }, sac := 55 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33476 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5299c521479dc25ea0f82d7d294d53942960d2cf Gerrit-Change-Number: 33476 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: move f_str_split() from UPF_Tests to Osmocom_VTY_Functions
by neels 27 Jun '23

27 Jun '23

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33478 ) Change subject: move f_str_split() from UPF_Tests to Osmocom_VTY_Functions ...................................................................... move f_str_split() from UPF_Tests to Osmocom_VTY_Functions I want to use it in a new function f_verify_talloc_bytes() added to Osmocom_VTY_Functions.ttcn in I2948ee6f167369a2252f85b493e9653b93c7e4e9. Change-Id: I9ddd9977734efd7599481261f04df82620845cef --- M library/Osmocom_VTY_Functions.ttcn M upf/UPF_Tests.ttcn 2 files changed, 32 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/78/33478/1 diff --git a/library/Osmocom_VTY_Functions.ttcn b/library/Osmocom_VTY_Functions.ttcn index c7df53c..1bbe647 100644 --- a/library/Osmocom_VTY_Functions.ttcn +++ b/library/Osmocom_VTY_Functions.ttcn @@ -15,6 +15,7 @@ import from TELNETasp_PortType all; import from Osmocom_Types all; import from TCCConversion_Functions all; + import from Socket_API_Definitions all; modulepar { charstring mp_prompt_prefix := "OpenBSC"; @@ -291,4 +292,23 @@ mtc.stop; } +public function f_str_split(charstring str, charstring delim := "\n") return ro_charstring +{ + var integer pos := 0; + var ro_charstring parts := {}; + var integer delim_pos; + var integer end := lengthof(str); + while (pos < end) { + delim_pos := f_strstr(str, delim, pos); + if (delim_pos < 0) { + delim_pos := end; + } + if (delim_pos > pos) { + parts := parts & { substr(str, pos, delim_pos - pos) }; + } + pos := delim_pos + 1; + } + return parts; +} + } diff --git a/upf/UPF_Tests.ttcn b/upf/UPF_Tests.ttcn index 5db143a..7dc01bb 100644 --- a/upf/UPF_Tests.ttcn +++ b/upf/UPF_Tests.ttcn @@ -76,23 +76,6 @@ f_vty_transceive(pt, "logp lglobal notice TTCN3 f_logp(): " & log_msg); } -private function f_str_split(charstring str, charstring delim := "\n") return ro_charstring -{ - var integer pos := 0; - var ro_charstring parts := {}; - var integer delim_pos; - var integer end := lengthof(str); - while (pos < end) { - delim_pos := f_strstr(str, delim, pos); - if (delim_pos < 0) { - delim_pos := end; - } - parts := parts & { substr(str, pos, delim_pos - pos) }; - pos := delim_pos + 1; - } - return parts; -} - private function f_get_name_val(out charstring val, charstring str, charstring name, charstring sep := ":", charstring delim := " ") return boolean { var charstring labl := name & sep; var integer namepos := f_strstr(str, labl); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33478 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9ddd9977734efd7599481261f04df82620845cef Gerrit-Change-Number: 33478 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: verify empty talloc asn1_context at end of tests
by neels 27 Jun '23

27 Jun '23

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33479 ) Change subject: hnbgw: verify empty talloc asn1_context at end of tests ...................................................................... hnbgw: verify empty talloc asn1_context at end of tests This allowed me to find massive memory leaks in osmo-hnbgw: at the end of each test, run f_shutdown_helper(), and in it query 'show talloc' for an empty asn1_context. Hence verify that all the scenarios run in these ttcn3 tests have no asn1 de/encoding memory leaks. Change-Id: I2948ee6f167369a2252f85b493e9653b93c7e4e9 --- M hnbgw/HNBGW_Tests.ttcn M library/Osmocom_VTY_Functions.ttcn 2 files changed, 73 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/79/33479/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 67d979b..66d0ef2 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -61,6 +61,8 @@ import from PFCP_Templates all; import from PFCP_CodecPort all; +import from TCCConversion_Functions all; + modulepar { /* IP address at which the HNodeB can be reached */ charstring mp_hnodeb_ip := "127.0.0.1"; @@ -372,6 +374,8 @@ } friend function f_shutdown_helper() runs on test_CT { + f_verify_talloc_bytes(HNBGWVTY, {"asn1_context"}, 1); + all component.stop; setverdict(pass); mtc.stop; diff --git a/library/Osmocom_VTY_Functions.ttcn b/library/Osmocom_VTY_Functions.ttcn index 1bbe647..160ea29 100644 --- a/library/Osmocom_VTY_Functions.ttcn +++ b/library/Osmocom_VTY_Functions.ttcn @@ -311,4 +311,57 @@ return parts; } +public function f_verify_talloc_bytes(TELNETasp_PT pt, ro_charstring object_strs, integer expect_bytes := 0, + integer attempts := 5, float wait_time := 3.0) +{ + var charstring show_cmd := "show talloc-context application brief"; + + while (attempts > 0) { + attempts := attempts - 1; + var charstring ret := f_vty_transceive_ret(pt, show_cmd); + + var ro_charstring lines := f_str_split(ret); + + var boolean ok := true; + for (var integer i := 0; i < lengthof(object_strs); i := i + 1) { + var charstring object_str := object_strs[i]; + + var integer bytes := 0; + + for (var integer j := 0; j < lengthof(lines); j := j + 1) { + var charstring line := lines[j]; + if (f_strstr(line, object_str) < 0) { + continue; + } + var ro_charstring tokens := f_str_split(line, " "); + if (lengthof(tokens) < 4) { + continue; + } + if (tokens[3] != "bytes") { + continue; + } + bytes := f_str2int(tokens[2]); + } + + if (bytes != expect_bytes) { + ok := false; + log("ERROR: talloc reports ", object_str, " = ", bytes, " bytes, expecting ", expect_bytes, + " from VTY response ", lines); + } else { + log("ok: talloc reports ", object_str, " = ", bytes, " bytes"); + } + } + if (ok) { + return; + } + if (attempts == 0) { + break; + } + log("bytes count mismatch, retrying in ", wait_time); + f_sleep(wait_time); + } + setverdict(fail, "talloc bytes count mismatch"); + mtc.stop; +} + } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33479 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2948ee6f167369a2252f85b493e9653b93c7e4e9 Gerrit-Change-Number: 33479 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0