June 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: DAHDI gerrit verification job diversification
by laforge 07 Jun '23

07 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/33191 ) Change subject: DAHDI gerrit verification job diversification ...................................................................... DAHDI gerrit verification job diversification * we never really wanted to build against fixed tags but branches, i.e. "the latest tag within a given stable series", so switch from a fixed tag like "v5.10" in torvalds/linux.git to "linux-5.10.y" in stable/linux.git * we also want to build against 6.1.y, as that is what upcoming Debian bookworm will ship Change-Id: I60aa61cb5020c9ce50126b048a0fa546a535236f --- M jobs/gerrit-verifications-dahdi.yml 1 file changed, 34 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/jobs/gerrit-verifications-dahdi.yml b/jobs/gerrit-verifications-dahdi.yml index 76657f1..88971b8 100644 --- a/jobs/gerrit-verifications-dahdi.yml +++ b/jobs/gerrit-verifications-dahdi.yml @@ -1,14 +1,26 @@ - project: - name: gerrit-dahdi-linux + name: gerrit-dahdi-linux-stable + type: stable + repo: 'https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git' linux-ver: - - "v4.19" - - "v5.10" + - "linux-4.19.y" + - "linux-5.10.y" + - "linux-6.1.y" + jobs: + - 'gerrit-dahdi-linux-{type}-{linux-ver}' + +- project: + name: gerrit-dahdi-linux-torvalds + type: torvalds + repo: 'https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git' + linux-ver: - "master" jobs: - - 'gerrit-dahdi-linux-{linux-ver}' + - 'gerrit-dahdi-linux-{type}-{linux-ver}' + - job-template: - name: 'gerrit-dahdi-linux-{linux-ver}' + name: 'gerrit-dahdi-linux-{type}-{linux-ver}' project-type: freestyle node: osmocom-gerrit concurrent: true @@ -31,7 +43,7 @@ # the shell part below. - git: basedir: 'linux' - url: 'https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git' + url: '{repo}' branches: - '{linux-ver}' refspec: '{linux-ver}' -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33191 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I60aa61cb5020c9ce50126b048a0fa546a535236f Gerrit-Change-Number: 33191 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ci[master]: DAHDI master build diversification
by laforge 07 Jun '23

07 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/33190 ) Change subject: DAHDI master build diversification ...................................................................... DAHDI master build diversification * we never really wanted to build against fixed tags but branches, i.e. "the latest tag within a given stable series", so switch from a fixed tag like "v5.10" in torvalds/linux.git to "linux-5.10.y" in stable/linux.git * we also want to build against 6.1.y, as that is what upcoming Debian bookworm will ship Change-Id: Ibc0527a6f7d11c4f99c19e73c948b9baacd4e5a2 --- M jobs/master-builds-dahdi.yml 1 file changed, 33 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/jobs/master-builds-dahdi.yml b/jobs/master-builds-dahdi.yml index 37d48b7..8a39c32 100644 --- a/jobs/master-builds-dahdi.yml +++ b/jobs/master-builds-dahdi.yml @@ -1,14 +1,25 @@ - project: - name: master-builds-dahdi-linux + name: master-builds-dahdi-linux-stable + type: stable + repo: 'https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git' linux-ver: - - "v4.19" - - "v5.10" + - "linux-4.19.y" + - "linux-5.10.y" + - "linux-6.1.y" + jobs: + - 'master-dahdi-linux-{type}-{linux-ver}' + +- project: + name: master-builds-dahdi-linux-torvalds + type: torvalds + repo: 'https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git' + linux-ver: - "master" jobs: - - 'master-dahdi-linux-{linux-ver}' + - 'master-dahdi-linux-{type}-{linux-ver}' - job-template: - name: 'master-dahdi-linux-{linux-ver}' + name: 'master-dahdi-linux-{type}-{linux-ver}' project-type: freestyle node: osmocom-master concurrent: true @@ -31,7 +42,7 @@ # the shell part below. - git: basedir: 'linux' - url: 'https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git' + url: '{repo}' branches: - '{linux-ver}' refspec: '{linux-ver}' -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ibc0527a6f7d11c4f99c19e73c948b9baacd4e5a2 Gerrit-Change-Number: 33190 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ci[master]: DAHDI master build diversification
by laforge 07 Jun '23

07 Jun '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/33190 ) Change subject: DAHDI master build diversification ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ibc0527a6f7d11c4f99c19e73c948b9baacd4e5a2 Gerrit-Change-Number: 33190 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Jun 2023 12:08:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: DAHDI gerrit verification job diversification
by laforge 07 Jun '23

07 Jun '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/33191 ) Change subject: DAHDI gerrit verification job diversification ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33191 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I60aa61cb5020c9ce50126b048a0fa546a535236f Gerrit-Change-Number: 33191 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Jun 2023 12:08:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: lapdm: Do not return an error when enqueuing a frame
by jolly 07 Jun '23

07 Jun '23

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/33217 ) Change subject: lapdm: Do not return an error when enqueuing a frame ...................................................................... lapdm: Do not return an error when enqueuing a frame If tx_ph_data_enqueue() is called, frames will be written into a queue, if there is a pending frame or if polling of TX frames is used. In this case the return value must be 0. Sending a RSL_MT_UNIT_DATA_REQ from upper layer causes a call to tx_ph_data_enqueue(). The return code is returned to the sender. The sender must not get an error returned, if the message is enqueued. Change-Id: Iaeaf7c66cb3cf5cc81bc8e15d468e8e7704c1407 --- M src/gsm/lapdm.c 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/17/33217/1 diff --git a/src/gsm/lapdm.c b/src/gsm/lapdm.c index 8ca1342..e8d9e78 100644 --- a/src/gsm/lapdm.c +++ b/src/gsm/lapdm.c @@ -362,7 +362,7 @@ *msgb_push(msg, 1) = link_id; *msgb_push(msg, 1) = chan_nr; msgb_enqueue(&dl->dl.tx_queue, msg); - return -EBUSY; + return 0; } osmo_prim_init(&pp.oph, SAP_GSM_PH, PRIM_PH_DATA, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33217 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iaeaf7c66cb3cf5cc81bc8e15d468e8e7704c1407 Gerrit-Change-Number: 33217 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

1 0

[L] Change in libosmocore[master]: ASCI: Add message definition and encoding according to 3GPP TS 48.008
by jolly 07 Jun '23

07 Jun '23

Attention is currently required from: jolly, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/32932 to look at the new patch set (#7). Change subject: ASCI: Add message definition and encoding according to 3GPP TS 48.008 ...................................................................... ASCI: Add message definition and encoding according to 3GPP TS 48.008 Change-Id: Ib94c64136c31ce4af67c314a8550d93946cc844f --- M include/osmocom/gsm/gsm0808.h M include/osmocom/gsm/protocol/gsm_08_08.h M src/gsm/gsm0808.c M src/gsm/libosmogsm.map 4 files changed, 929 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/32/32932/7 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32932 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib94c64136c31ce4af67c314a8550d93946cc844f Gerrit-Change-Number: 32932 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmo-sccp[master]: osmo_sccp_simple_client_on_ss7_id(): Fail to start a client on an ASP...
by pespin 07 Jun '23

07 Jun '23

Attention is currently required from: neels, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/33216 ) Change subject: osmo_sccp_simple_client_on_ss7_id(): Fail to start a client on an ASP explicitly configured as sctp server ...................................................................... Patch Set 2: (1 comment) File src/sccp_user.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/33216/comment/e415036e_5c891767 PS1, Line 633: if (default_local_ip) we could simply move the line 652 "asp->cfg.is_server = false;" in here and support both SCTP-role client and server in osmo_sccp_simple_client_on_ss7_id() in case where the ASP was explicitly configured. pro: potentially supporting SCTP-role server in osmo-bsc/osmo-msc/osmo-hnbgw cons: confusing, since the function is about creating a client but instead a server is created (which may be fine if user explicitly configured it as such...) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/33216 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I20de33edb8751a515d6719c49efadfc387dd85f8 Gerrit-Change-Number: 33216 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 07 Jun 2023 11:39:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in libosmo-sccp[master]: osmo_sccp_simple_client_on_ss7_id(): Fail to start a client on an ASP...
by pespin 07 Jun '23

07 Jun '23

Attention is currently required from: neels, laforge. Hello Jenkins Builder, neels, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/33216 to look at the new patch set (#2). Change subject: osmo_sccp_simple_client_on_ss7_id(): Fail to start a client on an ASP explicitly configured as sctp server ...................................................................... osmo_sccp_simple_client_on_ss7_id(): Fail to start a client on an ASP explicitly configured as sctp server Right now, if a user configures an cs7 instance, as and asp (with sctp-role server) in the VTY, then the function osmo_sccp_simple_client_on_ss7_id() (used by osmo-bsc, osmo-msc, osmo-hnbgw, etc.) will silently change the config to be SCTP client. This is really confusing, since the user configured explicitly the ASP as server but ends up running as client. Instead, if the user explicitly configured the ASP as SCTP server, return an error asking the user to apply changes to its config file. Change-Id: I20de33edb8751a515d6719c49efadfc387dd85f8 --- M src/sccp_user.c 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/16/33216/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/33216 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I20de33edb8751a515d6719c49efadfc387dd85f8 Gerrit-Change-Number: 33216 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmo-sccp[master]: osmo_sccp_simple_client_on_ss7_id(): Fail to start a client on an ASP...
by pespin 07 Jun '23

07 Jun '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/33216 ) Change subject: osmo_sccp_simple_client_on_ss7_id(): Fail to start a client on an ASP explicitly configured as sctp server ...................................................................... osmo_sccp_simple_client_on_ss7_id(): Fail to start a client on an ASP explicitly configured as sctp server Right now, if a user configures an cs7 instance, as and asp (with sctp-role server) in the VTY, then the function osmo_sccp_simple_client_on_ss7_id() (used by osmo-bsc, osmo-msc, osmo-hnbgw, etc.) will silently change the config to be SCTP client. This is really confusing, since the user configured explicitly the ASP as server but ends up running as client. Instead, if the user explicitly configured the ASP as SCTP server, return an error asking the user to apply changes to its config file. Change-Id: I20de33edb8751a515d6719c49efadfc387dd85f8 --- M src/sccp_user.c 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/16/33216/1 diff --git a/src/sccp_user.c b/src/sccp_user.c index a04a1c3..1de919b 100644 --- a/src/sccp_user.c +++ b/src/sccp_user.c @@ -643,6 +643,12 @@ } /* Ensure that the ASP we use is set to client mode. */ + if (!asp_created) { + LOGP(DLSCCP, LOGL_ERROR, + "%s: Requesting an SCCP simple client on ASP %s previously configured with 'sctp-role server'!\n", + name, asp->cfg.name); + goto out_asp; + } asp->cfg.is_server = false; /* Make sure that the role of this ASP is set to ASP unless the user -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/33216 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I20de33edb8751a515d6719c49efadfc387dd85f8 Gerrit-Change-Number: 33216 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bts[master]: paging: do not confirm PAGING COMMAND messages
by dexter 07 Jun '23

07 Jun '23

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32734 ) Change subject: paging: do not confirm PAGING COMMAND messages ...................................................................... Patch Set 14: Verified+1 (1 comment) Patchset: PS14: I have verified this once more with real hardware. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8b8264d28b1b1deb08774cdba58dd4c6dafe115d Gerrit-Change-Number: 32734 Gerrit-PatchSet: 14 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Jun 2023 10:55:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0