June 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-pcu[master]: ms_need_dl_tbf(): Fix state checks and document function
by osmith 29 Jun '23

29 Jun '23

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33524 ) Change subject: ms_need_dl_tbf(): Fix state checks and document function ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/33524/comment/2d76d76a_9c452adf PS1, Line 13: neel need (not related to Neels) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33524 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I96f311480d036859511c6ba825ccd36bdc71190b Gerrit-Change-Number: 33524 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 29 Jun 2023 11:52:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: mobile: Fix gsm_refer_pcs(): PCS can only be ARFCN 512..810
by jolly 29 Jun '23

29 Jun '23

Attention is currently required from: laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33532 ) Change subject: mobile: Fix gsm_refer_pcs(): PCS can only be ARFCN 512..810 ...................................................................... Patch Set 2: (1 comment) File src/host/layer23/src/common/sysinfo.c: https://gerrit.osmocom.org/c/osmocom-bb/+/33532/comment/9d87c4ec_4f8e21b0 PS2, Line 65: (arfcn >= 512 && arfcn <= 810) > I guess the only clean solution is to add one additional argument to the function (and document what […] Yes this makes it simpler. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33532 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id99c8534bf853f4f24f99364790c1ac1df6cc007 Gerrit-Change-Number: 33532 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 29 Jun 2023 09:23:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: mobile: Fix gsm_refer_pcs(): PCS can only be ARFCN 512..810
by laforge 29 Jun '23

29 Jun '23

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33532 ) Change subject: mobile: Fix gsm_refer_pcs(): PCS can only be ARFCN 512..810 ...................................................................... Patch Set 2: (1 comment) File src/host/layer23/src/common/sysinfo.c: https://gerrit.osmocom.org/c/osmocom-bb/+/33532/comment/7a77fb85_7c46bd38 PS2, Line 65: (arfcn >= 512 && arfcn <= 810) > This would only allow cells in the DCS range to refer to cells with PCS frequencies. […] I guess the only clean solution is to add one additional argument to the function (and document what it actually is supposed to do). That additional argument is the *arfcn of the cell through which we have received an ARFCN (assignment, SI, ...). In this case we can use the sending-cell-bcch-arfcn and the sending-cell-si1ro-band_ind to determine whether the ARFCN in question is PCS or not. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33532 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id99c8534bf853f4f24f99364790c1ac1df6cc007 Gerrit-Change-Number: 33532 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 29 Jun 2023 09:14:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: comment

1 0

[M] Change in osmocom-bb[master]: layer23: migrate away from gsm48_generate_mid_from_*
by pespin 29 Jun '23

29 Jun '23

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33318 ) Change subject: layer23: migrate away from gsm48_generate_mid_from_* ...................................................................... Patch Set 3: (1 comment) File src/host/layer23/src/mobile/gsm48_mm.c: https://gerrit.osmocom.org/c/osmocom-bb/+/33318/comment/5114eb91_0e89e0a5 PS3, Line 2816: buf[1] = osmo_mobile_identity_encode_buf(buf+2, sizeof(buf)-2, &mi, false); what if osmo_mobile_identity_encode_buf returns negative (error)? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33318 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib0d7f76cd635e8d1092ffc1d07ecb29ec0435dda Gerrit-Change-Number: 33318 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 29 Jun 2023 08:57:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: mobile: Fix gsm_refer_pcs(): PCS can only be ARFCN 512..810
by jolly 29 Jun '23

29 Jun '23

Attention is currently required from: laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33532 ) Change subject: mobile: Fix gsm_refer_pcs(): PCS can only be ARFCN 512..810 ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: This would only allow cells in the DCS range to refer to cells with PCS frequencies. This makes no sense, because you cannot have DCS and PCS cells mixed in the same network. We want non DCS/PCS cells refer to DCS or PCS depending on the band indicator when they talk about ARFCN 512..885. The actual fix must be done in several locations at layer23/src/mobile/gsm48_rr.c: if (gsm_refer_pcs(CELL-ARFCN, s) && REFER-ARFCN >= 512 && REFER-ARFCN <= 810) REFER-ARFCN |= ARFCN_PCS; Where CELL-ARFCN is the frequency of the cell and REFER-ARFCN is a frequency the cell talks about. File src/host/layer23/src/common/sysinfo.c: https://gerrit.osmocom.org/c/osmocom-bb/+/33532/comment/ee7545ef_f64fb346 PS2, Line 65: (arfcn >= 512 && arfcn <= 810) This would only allow cells in the DCS range to refer to cells with PCS frequencies. This makes no sense, because you cannot have DCS and PCS cells mixed in the same network. We want non DCS/PCS cells refer to DCS or PCS depending on the band indicator when they talk about ARFCN 512..885. The actual fix must be done in several locations at layer23/src/mobile/gsm48_rr.c: if (gsm_refer_pcs(CELL-ARFCN, s) && REFER-ARFCN >= 512 && REFER-ARFCN <= 810) REFER-ARFCN |= ARFCN_PCS; Where CELL-ARFCN is the frequency of the cell and REFER-ARFCN is a frequency the cell talks about. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33532 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id99c8534bf853f4f24f99364790c1ac1df6cc007 Gerrit-Change-Number: 33532 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 29 Jun 2023 08:57:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: layer23: migrate away from deprecated gsm48_mi_to_string
by pespin 29 Jun '23

29 Jun '23

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33317 ) Change subject: layer23: migrate away from deprecated gsm48_mi_to_string ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33317 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ida67adaa61689c55505a89e1a1bebde041c91139 Gerrit-Change-Number: 33317 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 29 Jun 2023 08:55:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: gsmtap_source_free(): Don't crash if NULL is passed
by pespin 29 Jun '23

29 Jun '23

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33531 ) Change subject: gsmtap_source_free(): Don't crash if NULL is passed ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33531 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If0f6c11ac6ad987368e1d5c63a07fc456f89db2a Gerrit-Change-Number: 33531 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 29 Jun 2023 08:54:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: mobile: Fix gsm_refer_pcs(): PCS can only be ARFCN 512..810
by jolly 29 Jun '23

29 Jun '23

Attention is currently required from: laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33532 ) Change subject: mobile: Fix gsm_refer_pcs(): PCS can only be ARFCN 512..810 ...................................................................... Patch Set 2: Code-Review-1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33532 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id99c8534bf853f4f24f99364790c1ac1df6cc007 Gerrit-Change-Number: 33532 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 29 Jun 2023 08:54:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: mobile: Fix gsm_refer_pcs(): PCS can only be ARFCN 512..810
by jolly 29 Jun '23

29 Jun '23

Attention is currently required from: laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33532 ) Change subject: mobile: Fix gsm_refer_pcs(): PCS can only be ARFCN 512..810 ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: This would only allow cells in the DCS range to refer to cells with PCS frequencies. This makes no sense, because you cannot have DCS and PCS cells mixed in the same network. We want non DCS/PCS cells refer to DCS or PCS depending on the band indicator when they talk about ARFCN 512..885. The actual fix must be done in several locations at layer23/src/mobile/gsm48_rr.c: if (gsm_refer_pcs(CELL-ARFCN, s) && REFER-ARFCN >= 512 && REFER-ARFCN <= 810) REFER-ARFCN |= ARFCN_PCS; Where CELL-ARFCN is the frequency of the cell and REFER-ARFCN is a frequency the cell talks about. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33532 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id99c8534bf853f4f24f99364790c1ac1df6cc007 Gerrit-Change-Number: 33532 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 29 Jun 2023 08:52:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: Avoid re-assigning DL TBF over PACCH upon duplicate FinalACKs received
by laforge 29 Jun '23

29 Jun '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33454 ) Change subject: Avoid re-assigning DL TBF over PACCH upon duplicate FinalACKs received ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Idc204aba61ad98f75853dcd46200f5dcc4139203 Gerrit-Change-Number: 33454 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 29 Jun 2023 08:28:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0