May 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: gsm0503_tch_hr_encode(): accept both TS101318 and RFC5993 payloads

by falconia

Attention is currently required from: pespin. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32961 ) Change subject: gsm0503_tch_hr_encode(): accept both TS101318 and RFC5993 payloads ...................................................................... Patch Set 2: (1 comment) File src/coding/gsm0503_coding.c: https://gerrit.osmocom.org/c/libosmocore/+/32961/comment/0014945e_1d4d67d7 PS2, Line 2093: > I find it a bit weird that you are adding spaces here while in the fallthrough case you don't. […] I see your point - I'll make a new version without those spaces. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32961 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I13eaad366f9f68615b9e9e4a5f87396a0e9dea0f Gerrit-Change-Number: 32961 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 May 2023 16:36:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in libosmocore[master]: gsm0503_tch_hr_decode2(): new function, emits TS101318 format

by falconia

Attention is currently required from: pespin, fixeria. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32962 ) Change subject: gsm0503_tch_hr_decode2(): new function, emits TS101318 format ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: > Do you plan to submit patches for current gsm0503_tch_hr_decode() users to migrate to gsm0503_tch_hr […] osmo-bts-trx: yes, as detailed in my "blueprint" comment in the OS#5688 ticket. trxcon: I do not feel qualified to touch that one, but I realize that I become kinda responsible for transitioning it into the state of using a deprecated API. Calling out to @fixeria - Vadim, *if* you agree in principle with my approach to OS#5688, would you be willing to work with me on bringing trxcon (and the path feeding the resulting HR codec frames to gapk) into alignment? File include/osmocom/coding/gsm0503_coding.h: https://gerrit.osmocom.org/c/libosmocore/+/32962/comment/1dfd48f5_6a821334 PS1, Line 52: int gsm0503_tch_hr_decode(uint8_t *tch_data, const sbit_t *bursts, int odd, > mark as OSMO_DEPRECATED? Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32962 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If28ddb20789e8993b7558ca08020478615b4c708 Gerrit-Change-Number: 32962 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 May 2023 16:32:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in libosmocore[master]: gsm0503_tch_hr_decode2(): new function, emits TS101318 format

by pespin

Attention is currently required from: falconia. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32962 ) Change subject: gsm0503_tch_hr_decode2(): new function, emits TS101318 format ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: Do you plan to submit patches for current gsm0503_tch_hr_decode() users to migrate to gsm0503_tch_hr_decode2()? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32962 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If28ddb20789e8993b7558ca08020478615b4c708 Gerrit-Change-Number: 32962 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 23 May 2023 16:15:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in libosmocore[master]: gsm0503_tch_hr_encode(): accept both TS101318 and RFC5993 payloads

by pespin

Attention is currently required from: falconia. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32961 ) Change subject: gsm0503_tch_hr_encode(): accept both TS101318 and RFC5993 payloads ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/coding/gsm0503_coding.c: https://gerrit.osmocom.org/c/libosmocore/+/32961/comment/3535723b_f5e98875 PS2, Line 2093: I find it a bit weird that you are adding spaces here while in the fallthrough case you don't. I think I'm fine with dropping the old spaces like you did, but I'd be better with no new ones being added. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32961 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I13eaad366f9f68615b9e9e4a5f87396a0e9dea0f Gerrit-Change-Number: 32961 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 23 May 2023 16:14:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in libosmocore[master]: gsm0503_tch_hr_decode2(): new function, emits TS101318 format

by falconia

Attention is currently required from: falconia. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/32962 to look at the new patch set (#2). Change subject: gsm0503_tch_hr_decode2(): new function, emits TS101318 format ...................................................................... gsm0503_tch_hr_decode2(): new function, emits TS101318 format The original design of gsm0503_tch_hr_{en,de}code() functions contains a mistake in that a pseudo-RFC5993 format was chosen for HR codec frame input and output, instead of "pure" (agnostic to outer RTP encoding) form of 14 bytes. We would like to change this design so that we can feed pure 14-byte HR codec frames to the channel coding function and get such frames back from the channel decoding function - however, we cannot break libosmocoding API for existing users. In the decoding direction, create a new function that emits TS 101 318 format, and turn the legacy gsm0503_tch_hr_decode() API into a wrapper function for backward compatibility. Related: OS#5688 Change-Id: If28ddb20789e8993b7558ca08020478615b4c708 --- M TODO-RELEASE M include/osmocom/coding/gsm0503_coding.h M src/coding/gsm0503_coding.c 3 files changed, 62 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/62/32962/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32962 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If28ddb20789e8993b7558ca08020478615b4c708 Gerrit-Change-Number: 32962 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[S] Change in libosmocore[master]: gsm0503_tch_hr_encode(): accept both TS101318 and RFC5993 payloads

by falconia

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/32961 to look at the new patch set (#2). Change subject: gsm0503_tch_hr_encode(): accept both TS101318 and RFC5993 payloads ...................................................................... gsm0503_tch_hr_encode(): accept both TS101318 and RFC5993 payloads The original design of gsm0503_tch_hr_{en,de}code() functions contains a mistake in that a pseudo-RFC5993 format was chosen for HR codec frame input and output, instead of "pure" (agnostic to outer RTP encoding) form of 14 bytes. We would like to change this design so that we can feed pure 14-byte HR codec frames to the channel coding function and get such frames back from the channel decoding function - however, we cannot break libosmocoding API for existing users. In the encoding direction, make the new format our preferred one, but support the extra-octet format for backward compatibility. Related: OS#5688 Change-Id: I13eaad366f9f68615b9e9e4a5f87396a0e9dea0f --- M src/coding/gsm0503_coding.c 1 file changed, 29 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/61/32961/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32961 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I13eaad366f9f68615b9e9e4a5f87396a0e9dea0f Gerrit-Change-Number: 32961 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[S] Change in libosmocore[master]: gsm0503_tch_hr_encode(): accept both TS101318 and RFC5993 payloads

by falconia

Attention is currently required from: pespin. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32961 ) Change subject: gsm0503_tch_hr_encode(): accept both TS101318 and RFC5993 payloads ...................................................................... Patch Set 1: (2 comments) File src/coding/gsm0503_coding.c: https://gerrit.osmocom.org/c/libosmocore/+/32961/comment/ef3b095d_3df90f13 PS1, Line 1591: for (i = 0; i < 112; i++) > iiuc here we are removing 1 byte with this change. Yes, I am changing the internal static function to take unprefixed 14-byte payloads as input, rather than prefixed 15-byte kind with the prefix byte content ignored. https://gerrit.osmocom.org/c/libosmocore/+/32961/comment/9a370f79_71206d60 PS1, Line 2068: case GSM_HR_BYTES: /* TCH HR in "pure" form */ > case GSM_HR_BYTES_RTP_RFC5993: /* TCH HR with RFC 5993 prefix */ […] Good idea, I'll change the code like you suggest. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32961 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I13eaad366f9f68615b9e9e4a5f87396a0e9dea0f Gerrit-Change-Number: 32961 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 May 2023 15:55:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-trx[master]: ms: block burst q to upper layer

by Hoernchen

Attention is currently required from: laforge, dexter. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32945 ) Change subject: ms: block burst q to upper layer ...................................................................... Patch Set 1: (1 comment) This change is ready for review. Commit Message: https://gerrit.osmocom.org/c/osmo-trx/+/32945/comment/90bfea67_5a1a8808 PS1, Line 8: > Ack accidentally not marked as wip because this is the secodn time in a row pushing as %wip failed and i had to manully mark afterwards... -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32945 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Id0aad606a296b2885617013ce6637204357b13d7 Gerrit-Change-Number: 32945 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 May 2023 15:51:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in libosmocore[master]: gsm0503_tch_hr_decode2(): new function, emits TS101318 format

by pespin

Attention is currently required from: falconia. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32962 ) Change subject: gsm0503_tch_hr_decode2(): new function, emits TS101318 format ...................................................................... Patch Set 1: (1 comment) File include/osmocom/coding/gsm0503_coding.h: https://gerrit.osmocom.org/c/libosmocore/+/32962/comment/5af6ea1a_1d4e1e9c PS1, Line 52: int gsm0503_tch_hr_decode(uint8_t *tch_data, const sbit_t *bursts, int odd, mark as OSMO_DEPRECATED? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32962 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If28ddb20789e8993b7558ca08020478615b4c708 Gerrit-Change-Number: 32962 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 23 May 2023 15:41:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in libosmocore[master]: gsm0503_tch_hr_encode(): accept both TS101318 and RFC5993 payloads

by pespin

Attention is currently required from: falconia. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32961 ) Change subject: gsm0503_tch_hr_encode(): accept both TS101318 and RFC5993 payloads ...................................................................... Patch Set 1: (2 comments) File src/coding/gsm0503_coding.c: https://gerrit.osmocom.org/c/libosmocore/+/32961/comment/40923ceb_8a4aa902 PS1, Line 1591: for (i = 0; i < 112; i++) iiuc here we are removing 1 byte with this change. https://gerrit.osmocom.org/c/libosmocore/+/32961/comment/17449589_901d5c26 PS1, Line 2068: case GSM_HR_BYTES: /* TCH HR in "pure" form */ case GSM_HR_BYTES_RTP_RFC5993: /* TCH HR with RFC 5993 prefix */ tch_data++ /* fall-through */ case GSM_HR_BYTES: .... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32961 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I13eaad366f9f68615b9e9e4a5f87396a0e9dea0f Gerrit-Change-Number: 32961 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 23 May 2023 15:37:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2023