May 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-hlr[master]: systemd: depend on networking-online.target

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/33020 ) Change subject: systemd: depend on networking-online.target ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/33020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I29e547242b2ed1cfc4750c7d7e5f8636c2e8f3dc Gerrit-Change-Number: 33020 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 26 May 2023 12:31:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-bts[master]: systemd: depend on networking-online.target

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33014 ) Change subject: systemd: depend on networking-online.target ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33014 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I9c0cc0779f9ddb7520a565668b7cde07c6ad55d8 Gerrit-Change-Number: 33014 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 26 May 2023 12:31:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-ggsn[master]: systemd: depend on networking-online.target

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/33019 ) Change subject: systemd: depend on networking-online.target ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/33019 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I29e547242b2ed1cfc4750c7d7e5f8636c2e8f3dc Gerrit-Change-Number: 33019 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 26 May 2023 12:31:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library: add RSL_IE_ChannelMode templates for CSD

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33033 ) Change subject: library: add RSL_IE_ChannelMode templates for CSD ...................................................................... library: add RSL_IE_ChannelMode templates for CSD Change-Id: Ic10b3d791b6e9553dddf7d55f097483164fc9d4d Related: OS#1572, OS#4396 --- M library/RSL_Types.ttcn 1 file changed, 37 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/33/33033/1 diff --git a/library/RSL_Types.ttcn b/library/RSL_Types.ttcn index ceb6adb..c1b7a80 100644 --- a/library/RSL_Types.ttcn +++ b/library/RSL_Types.ttcn @@ -450,6 +450,33 @@ u := { sign := RSL_CMOD_NO_RESOURCE } } + template (value) RSL_IE_ChannelMode + ts_RSL_ChanMode_DATA(template (value) RSL_ChanRateType t, + template (value) RSL_ChanModeOct6DataRate r, + template (value) boolean dtxd := false, + template (value) boolean dtxu := false) := { + len := 0, /* overwritten */ + reserved := '000000'B, + dtx_d := dtxd, + dtx_u := dtxu, + spd_ind := RSL_SPDI_DATA, + ch_rate_type := t, + u := { data := r } + } + template RSL_IE_ChannelMode + tr_RSL_ChanMode_DATA(template (present) RSL_ChanRateType t := ?, + template (present) RSL_ChanModeOct6DataRate r := ?, + template (present) boolean dtxd := ?, + template (present) boolean dtxu := ?) := { + len := ?, + reserved := ?, + dtx_d := dtxd, + dtx_u := dtxu, + spd_ind := RSL_SPDI_DATA, + ch_rate_type := t, + u := { data := r } + } + template (value) RSL_IE_ChannelMode ts_RSL_ChanMode(RSL_ChanRateType t, RSL_ChanModeOct6SpeechAlgo alg, boolean dtx_downlink := false) := { len := 0, /* overwritten */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33033 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic10b3d791b6e9553dddf7d55f097483164fc9d4d Gerrit-Change-Number: 33033 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library: add a receive equivalent for ts_RSL_ChanMode_SIGN

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33034 ) Change subject: library: add a receive equivalent for ts_RSL_ChanMode_SIGN ...................................................................... library: add a receive equivalent for ts_RSL_ChanMode_SIGN Also take a chance to enrich the already existing send template. Change-Id: Id39ca75a9194d7c62b9e5e2d96e766c4940c8281 Related: OS#1572, OS#4396 --- M bts/BTS_Tests.ttcn M library/RSL_Types.ttcn 2 files changed, 31 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/34/33034/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 8fc0fa9..a0d2cfe 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -7921,7 +7921,7 @@ var ConnHdlrPars pars; pars.t_guard := 60.0; f_init(); - ch_mode := ts_RSL_ChanMode_SIGN(dtx_downlink := dtxd); + ch_mode := ts_RSL_ChanMode_SIGN(dtxd := dtxd); for (var integer i := 0; i < sizeof(g_AllChannels); i := i + 1) { pars := valueof(t_Pars(g_AllChannels[i], ch_mode)); if (dtxd) { diff --git a/library/RSL_Types.ttcn b/library/RSL_Types.ttcn index c1b7a80..08e49b5 100644 --- a/library/RSL_Types.ttcn +++ b/library/RSL_Types.ttcn @@ -439,12 +439,26 @@ data, spd_ind = RSL_SPDI_DATA; )"} - template (value) RSL_IE_ChannelMode ts_RSL_ChanMode_SIGN(RSL_ChanRateType t := RSL_CHRT_SDCCH, - boolean dtx_downlink := false) := { + template (value) RSL_IE_ChannelMode + ts_RSL_ChanMode_SIGN(template (value) RSL_ChanRateType t := RSL_CHRT_SDCCH, + template (value) boolean dtxd := false, + template (value) boolean dtxu := false) := { len := 0, /* overwritten */ reserved := '000000'B, - dtx_d := dtx_downlink, - dtx_u := false, + dtx_d := dtxd, + dtx_u := dtxu, + spd_ind := RSL_SPDI_SIGN, + ch_rate_type := t, + u := { sign := RSL_CMOD_NO_RESOURCE } + } + template RSL_IE_ChannelMode + tr_RSL_ChanMode_SIGN(template (present) RSL_ChanRateType t := ?, + template (present) boolean dtxd := ?, + template (present) boolean dtxu := ?) := { + len := ?, + reserved := ?, + dtx_d := dtxd, + dtx_u := dtxu, spd_ind := RSL_SPDI_SIGN, ch_rate_type := t, u := { sign := RSL_CMOD_NO_RESOURCE } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33034 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id39ca75a9194d7c62b9e5e2d96e766c4940c8281 Gerrit-Change-Number: 33034 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: BTS_Tests: f_est_dchan(): add support for CSD channel modes

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33035 ) Change subject: BTS_Tests: f_est_dchan(): add support for CSD channel modes ...................................................................... BTS_Tests: f_est_dchan(): add support for CSD channel modes Change-Id: I066657941dd751183aa5e937a6bfe9ab7837d46b Related: OS#1572, OS#4396 --- M bts/BTS_Tests.ttcn M library/L1CTL_Types.ttcn 2 files changed, 42 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/35/33035/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index a0d2cfe..8dcfb01 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -2542,24 +2542,35 @@ var uint8_t amr_start_codec := 0; var BIT8 amr_codecs_bitmask := '00000000'B; - if (ischosen(g_pars.chan_mode.u.sign) and g_pars.chan_mode.u.sign == RSL_CMOD_NO_RESOURCE) { - tch_mode := L1CTL_CHAN_MODE_SIGN; - } else if (ischosen(g_pars.chan_mode.u.speech)) { - select (g_pars.chan_mode.u.speech) { - case (RSL_CMOD_SP_GSM1) { tch_mode := L1CTL_CHAN_MODE_SPEECH_V1; } - case (RSL_CMOD_SP_GSM2) { tch_mode := L1CTL_CHAN_MODE_SPEECH_V2; } - case (RSL_CMOD_SP_GSM3) { tch_mode := L1CTL_CHAN_MODE_SPEECH_V3; - amr_codecs_bitmask := g_pars.mr_conf.codec_modes; - } - case else { - log("RSL channel mode := ", g_pars.chan_mode.u.speech, - " is not supported by the L1, falling back to signalling"); - tch_mode := L1CTL_CHAN_MODE_SIGN; - } - } - } else { + select (g_pars.chan_mode) { + case (tr_RSL_ChanMode_SIGN) + { tch_mode := L1CTL_CHAN_MODE_SIGN; } + /* Speech modes */ + case (tr_RSL_ChanMode((RSL_CHRT_TCH_F, RSL_CHRT_TCH_H), RSL_CMOD_SP_GSM1)) + { tch_mode := L1CTL_CHAN_MODE_SPEECH_V1; } + case (tr_RSL_ChanMode((RSL_CHRT_TCH_F, RSL_CHRT_TCH_H), RSL_CMOD_SP_GSM2)) + { tch_mode := L1CTL_CHAN_MODE_SPEECH_V2; } + case (tr_RSL_ChanMode((RSL_CHRT_TCH_F, RSL_CHRT_TCH_H), RSL_CMOD_SP_GSM3)) + { tch_mode := L1CTL_CHAN_MODE_SPEECH_V3; + amr_codecs_bitmask := g_pars.mr_conf.codec_modes; } + /* Data modes */ + case (tr_RSL_ChanMode_DATA(RSL_CHRT_TCH_F, /* TCH/F14.4 */ + (RSL_CMOD_CSD_T_14k4, RSL_CMOD_CSD_NT_14k5))) + { tch_mode := L1CTL_CHAN_MODE_DATA_14k5; } + case (tr_RSL_ChanMode_DATA(RSL_CHRT_TCH_F, /* TCH/F9.6 */ + (RSL_CMOD_CSD_T_9k6, RSL_CMOD_CSD_NT_12k0))) + { tch_mode := L1CTL_CHAN_MODE_DATA_12k0; } + case (tr_RSL_ChanMode_DATA((RSL_CHRT_TCH_F, RSL_CHRT_TCH_H), /* TCH/[FH]4.8 */ + (RSL_CMOD_CSD_T_4k8, RSL_CMOD_CSD_NT_6k0))) + { tch_mode := L1CTL_CHAN_MODE_DATA_6k0; } + case (tr_RSL_ChanMode_DATA((RSL_CHRT_TCH_F, RSL_CHRT_TCH_H), /* TCH/[FH]2.4 */ + (RSL_CMOD_CSD_T_2k4, RSL_CMOD_CSD_T_1k2, + RSL_CMOD_CSD_T_600, RSL_CMOD_CSD_T_1200_75))) + { tch_mode := L1CTL_CHAN_MODE_DATA_3k6; } + case else { log("RSL channel mode is not supported by the L1, falling back to signalling"); tch_mode := L1CTL_CHAN_MODE_SIGN; + } } f_L1CTL_TCH_MODE(L1CTL, diff --git a/library/L1CTL_Types.ttcn b/library/L1CTL_Types.ttcn index 192091e..fe56459 100644 --- a/library/L1CTL_Types.ttcn +++ b/library/L1CTL_Types.ttcn @@ -127,8 +127,11 @@ L1CTL_CHAN_MODE_SIGN ('00000000'B), /* Signalling */ L1CTL_CHAN_MODE_SPEECH_V1 ('00000001'B), /* FR or HR codec */ L1CTL_CHAN_MODE_SPEECH_V2 ('00100001'B), /* EFR codec */ - L1CTL_CHAN_MODE_SPEECH_V3 ('01000001'B) /* AMR codec */ - /* Other modes are not supported for now */ + L1CTL_CHAN_MODE_SPEECH_V3 ('01000001'B), /* AMR codec */ + L1CTL_CHAN_MODE_DATA_14k5 ('00001111'B), /* CSD: TCH/F14.4 */ + L1CTL_CHAN_MODE_DATA_12k0 ('00000011'B), /* CSD: TCH/F9.6 */ + L1CTL_CHAN_MODE_DATA_6k0 ('00001011'B), /* CSD: TCH/{FH}4.8 */ + L1CTL_CHAN_MODE_DATA_3k6 ('00010011'B) /* CSD: TCH/{FH}2.4 */ } with { variant "FIELDLENGTH(8)" }; type enumerated L1ctlLoopMode { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33035 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I066657941dd751183aa5e937a6bfe9ab7837d46b Gerrit-Change-Number: 33035 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in osmo-gbproxy[master]: systemd: depend on networking-online.target

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/33018 ) Change subject: systemd: depend on networking-online.target ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/33018 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I29e547242b2ed1cfc4750c7d7e5f8636c2e8f3dc Gerrit-Change-Number: 33018 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 26 May 2023 12:31:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-upf[master]: systemd: depend on networking-online.target

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/33032 ) Change subject: systemd: depend on networking-online.target ...................................................................... systemd: depend on networking-online.target Related: SYS#6400 Change-Id: Idadcbbf55e976ae035cfac4b85ccd870e0f27b82 --- M contrib/systemd/osmo-upf.service 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/32/33032/1 diff --git a/contrib/systemd/osmo-upf.service b/contrib/systemd/osmo-upf.service index acc7bf4..717a681 100644 --- a/contrib/systemd/osmo-upf.service +++ b/contrib/systemd/osmo-upf.service @@ -1,5 +1,7 @@ [Unit] Description=Osmocom User Plane Function (UPF) +After=network-online.target +Wants=network-online.target [Service] Type=simple -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/33032 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Idadcbbf55e976ae035cfac4b85ccd870e0f27b82 Gerrit-Change-Number: 33032 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in osmo-trx[master]: systemd: depend on networking-online.target

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/33031 ) Change subject: systemd: depend on networking-online.target ...................................................................... systemd: depend on networking-online.target Related: SYS#6400 Change-Id: Idadcbbf55e976ae035cfac4b85ccd870e0f27b82 --- M contrib/systemd/osmo-trx-ipc.service M contrib/systemd/osmo-trx-lms.service M contrib/systemd/osmo-trx-uhd.service M contrib/systemd/osmo-trx-usrp1.service 4 files changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/31/33031/1 diff --git a/contrib/systemd/osmo-trx-ipc.service b/contrib/systemd/osmo-trx-ipc.service index 8828393..c7f7c17 100644 --- a/contrib/systemd/osmo-trx-ipc.service +++ b/contrib/systemd/osmo-trx-ipc.service @@ -1,5 +1,7 @@ [Unit] Description=Osmocom SDR BTS L1 Transceiver (IPC Backend) +After=network-online.target +Wants=network-online.target [Service] Type=simple diff --git a/contrib/systemd/osmo-trx-lms.service b/contrib/systemd/osmo-trx-lms.service index 93e4407..f51bd45 100644 --- a/contrib/systemd/osmo-trx-lms.service +++ b/contrib/systemd/osmo-trx-lms.service @@ -1,5 +1,7 @@ [Unit] Description=Osmocom SDR BTS L1 Transceiver (LimeSuite backend) +After=network-online.target +Wants=network-online.target [Service] Type=simple diff --git a/contrib/systemd/osmo-trx-uhd.service b/contrib/systemd/osmo-trx-uhd.service index f78888c..34ba74a 100644 --- a/contrib/systemd/osmo-trx-uhd.service +++ b/contrib/systemd/osmo-trx-uhd.service @@ -1,5 +1,7 @@ [Unit] Description=Osmocom SDR BTS L1 Transceiver (UHD Backend) +After=network-online.target +Wants=network-online.target [Service] Type=simple diff --git a/contrib/systemd/osmo-trx-usrp1.service b/contrib/systemd/osmo-trx-usrp1.service index 401139e..988c053 100644 --- a/contrib/systemd/osmo-trx-usrp1.service +++ b/contrib/systemd/osmo-trx-usrp1.service @@ -1,5 +1,7 @@ [Unit] Description=Osmocom SDR BTS L1 Transceiver (libusrp backend) +After=network-online.target +Wants=network-online.target [Service] Type=simple -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/33031 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Idadcbbf55e976ae035cfac4b85ccd870e0f27b82 Gerrit-Change-Number: 33031 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in osmo-smlc[master]: systemd: depend on networking-online.target

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-smlc/+/33030 ) Change subject: systemd: depend on networking-online.target ...................................................................... systemd: depend on networking-online.target Related: SYS#6400 Change-Id: Idadcbbf55e976ae035cfac4b85ccd870e0f27b82 --- M contrib/systemd/osmo-smlc.service 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-smlc refs/changes/30/33030/1 diff --git a/contrib/systemd/osmo-smlc.service b/contrib/systemd/osmo-smlc.service index ce5a9d3..65e552f 100644 --- a/contrib/systemd/osmo-smlc.service +++ b/contrib/systemd/osmo-smlc.service @@ -1,5 +1,7 @@ [Unit] Description=Osmocom Serving Mobile Location Center (SMLC) +After=network-online.target +Wants=network-online.target [Service] Type=simple -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/33030 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: Idadcbbf55e976ae035cfac4b85ccd870e0f27b82 Gerrit-Change-Number: 33030 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2023