May 2023 - gerrit-log - lists.osmocom.org

[L] Change in osmo-bsc[master]: ctrl: drop deprecated neighbor resolution interface

by msuraev

Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32277 ) Change subject: ctrl: drop deprecated neighbor resolution interface ...................................................................... Patch Set 8: (1 comment) File src/osmo-bsc/neighbor_ident_ctrl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/32277/comment/d92b42fd_b24d4ad7 PS8, Line 553: /* This and the following: Add/Remove a CGI-PS as neighbor */ > why are you dropping this? This code is independent from the inteface you are removing. You mean parse_cgi_ps()? It's only used by deprecated ctrl commands which are removed by this patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32277 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I93e25856eede4b2f5aa36d8a16714b43d37b4fd0 Gerrit-Change-Number: 32277 Gerrit-PatchSet: 8 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 May 2023 06:44:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-hnbgw[master]: actually run vty-tests: VTY transcript tests

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32623 ) Change subject: actually run vty-tests: VTY transcript tests ...................................................................... Patch Set 1: (1 comment) This change is ready for review. Patchset: PS1: well ok, even a successful "enable" does test *something*. Also for CN pooling being implemented there will be a lot of new VTY transcript tests. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32623 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ie9fc8f29b84e1dffea000fea11e0afe285c1df39 Gerrit-Change-Number: 32623 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 05 May 2023 00:38:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-hnbgw[master]: vty: fix doc strings for 'show {hnb,ue}'

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32627 ) Change subject: vty: fix doc strings for 'show {hnb,ue}' ...................................................................... vty: fix doc strings for 'show {hnb,ue}' Change-Id: I79f8b13a9f22fb8311017005cc0a3ac3a7e78983 --- M src/osmo-hnbgw/hnbgw_vty.c 1 file changed, 17 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/27/32627/1 diff --git a/src/osmo-hnbgw/hnbgw_vty.c b/src/osmo-hnbgw/hnbgw_vty.c index 8d2366f..70c2d13 100644 --- a/src/osmo-hnbgw/hnbgw_vty.c +++ b/src/osmo-hnbgw/hnbgw_vty.c @@ -221,7 +221,10 @@ hnb_context_name(ue->hnb), VTY_NEWLINE); } -DEFUN(show_hnb, show_hnb_cmd, "show hnb all", SHOW_STR "Display information about all HNB") +#define SHOW_HNB_STR SHOW_STR "Display information about HNB\n" + +DEFUN(show_hnb, show_hnb_cmd, "show hnb all", + SHOW_HNB_STR "All HNB\n") { struct hnb_context *hnb; unsigned int count = 0; @@ -241,7 +244,8 @@ return CMD_SUCCESS; } -DEFUN(show_one_hnb, show_one_hnb_cmd, "show hnb NAME ", SHOW_STR "Display information about a HNB") +DEFUN(show_one_hnb, show_one_hnb_cmd, "show hnb NAME ", + SHOW_HNB_STR "HNB name\n") { struct hnb_context *hnb; const char *identity_info = argv[0]; @@ -261,7 +265,8 @@ return CMD_SUCCESS; } -DEFUN(show_ue, show_ue_cmd, "show ue all", SHOW_STR "Display information about a UE") +DEFUN(show_ue, show_ue_cmd, "show ue all", + SHOW_STR "Display HNBAP information about UE\n" "All UE\n") { struct ue_context *ue; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32627 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I79f8b13a9f22fb8311017005cc0a3ac3a7e78983 Gerrit-Change-Number: 32627 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in osmo-hnbgw[master]: actually run vty-tests: osmotestconfig.py

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32625 ) Change subject: actually run vty-tests: osmotestconfig.py ...................................................................... actually run vty-tests: osmotestconfig.py Change-Id: Id60e5dfb22b7cea33c53388d339838add101de44 --- M tests/Makefile.am 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/25/32625/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index 23fcd8a..a5d33ce 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -38,7 +38,7 @@ python-tests: $(MAKE) vty-test osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v -# osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v + osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v # $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v else python-tests: -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32625 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Id60e5dfb22b7cea33c53388d339838add101de44 Gerrit-Change-Number: 32625 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in osmo-hnbgw[master]: actually run vty-tests: VTY transcript tests

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32623 ) Change subject: actually run vty-tests: VTY transcript tests ...................................................................... actually run vty-tests: VTY transcript tests There have been VTY transcript tests around for a long time, but we are not running them. Change-Id: Ie9fc8f29b84e1dffea000fea11e0afe285c1df39 --- M tests/Makefile.am 1 file changed, 13 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/23/32623/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index 806bfb1..26c01b6 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -36,9 +36,7 @@ if ENABLE_EXT_TESTS python-tests: - echo "" -# TODO: Enable once we have a VTY/CTRL interface: -# $(MAKE) vty-test + $(MAKE) vty-test # osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v # osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v # $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32623 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ie9fc8f29b84e1dffea000fea11e0afe285c1df39 Gerrit-Change-Number: 32623 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in osmo-hnbgw[master]: actually run vty-tests: osmotestvty.py

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32624 ) Change subject: actually run vty-tests: osmotestvty.py ...................................................................... actually run vty-tests: osmotestvty.py Change-Id: Iab84af37488b5ec1000162d945f909f9ab05dad8 --- M tests/Makefile.am 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/24/32624/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index 26c01b6..23fcd8a 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -37,7 +37,7 @@ if ENABLE_EXT_TESTS python-tests: $(MAKE) vty-test -# osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v + osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v # osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v # $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v else -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32624 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iab84af37488b5ec1000162d945f909f9ab05dad8 Gerrit-Change-Number: 32624 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[M] Change in osmo-hnbgw[master]: drop ctrl_test_runner.py

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32626 ) Change subject: drop ctrl_test_runner.py ...................................................................... drop ctrl_test_runner.py Unused and contains no actual tests. Change-Id: If3d6614334b692e49efcc45d1e4fb29a00c68602 --- M tests/Makefile.am D tests/ctrl_test_runner.py 2 files changed, 11 insertions(+), 208 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/26/32626/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index a5d33ce..bc7acec 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -39,7 +39,6 @@ $(MAKE) vty-test osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v -# $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v else python-tests: echo "Not running python-based tests (determined at configure-time)" diff --git a/tests/ctrl_test_runner.py b/tests/ctrl_test_runner.py deleted file mode 100755 index 701bd89..0000000 --- a/tests/ctrl_test_runner.py +++ /dev/null @@ -1,207 +0,0 @@ -#!/usr/bin/env python3 - -# (C) 2013 by Jacob Erlbeck <jerlbeck(a)sysmocom.de> -# (C) 2014 by Holger Hans Peter Freyther -# based on vty_test_runner.py: -# (C) 2013 by Katerina Barone-Adesi <kat.obsc(a)gmail.com> -# (C) 2013 by Holger Hans Peter Freyther -# based on bsc_control.py. - -# This program is free software: you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation, either version 3 of the License, or -# (at your option) any later version. - -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. - -# You should have received a copy of the GNU General Public License -# along with this program. If not, see <http://www.gnu.org/licenses/>. - -import os -import time -import unittest -import socket -import sys -import struct - -import osmopy.obscvty as obscvty -import osmopy.osmoutil as osmoutil -from osmopy.osmo_ipa import Ctrl, IPA - -# to be able to find $top_srcdir/doc/... -confpath = os.path.join(sys.path[0], '..') -verbose = False - -class TestCtrlBase(unittest.TestCase): - - def ctrl_command(self): - raise Exception("Needs to be implemented by a subclass") - - def ctrl_app(self): - raise Exception("Needs to be implemented by a subclass") - - def setUp(self): - osmo_ctrl_cmd = self.ctrl_command()[:] - config_index = osmo_ctrl_cmd.index('-c') - if config_index: - cfi = config_index + 1 - osmo_ctrl_cmd[cfi] = os.path.join(confpath, osmo_ctrl_cmd[cfi]) - - try: - self.proc = osmoutil.popen_devnull(osmo_ctrl_cmd) - except OSError: - print("Current directory: %s" % os.getcwd(), file=sys.stderr) - print("Consider setting -b", file=sys.stderr) - - appstring = self.ctrl_app()[2] - appport = self.ctrl_app()[0] - self.connect("127.0.0.1", appport) - self.next_id = 1000 - - def tearDown(self): - self.disconnect() - osmoutil.end_proc(self.proc) - - def disconnect(self): - if not (self.sock is None): - self.sock.close() - - def connect(self, host, port): - if verbose: - print("Connecting to host %s:%i" % (host, port)) - - retries = 30 - while True: - try: - sck = socket.socket(socket.AF_INET, socket.SOCK_STREAM) - sck.setblocking(1) - sck.connect((host, port)) - except IOError: - retries -= 1 - if retries <= 0: - raise - time.sleep(.1) - continue - break - self.sock = sck - return sck - - def send(self, data): - if verbose: - print("Sending \"%s\"" %(data)) - data = Ctrl().add_header(data) - return self.sock.send(data) == len(data) - - def send_set(self, var, value, id): - setmsg = "SET %s %s %s" %(id, var, value) - return self.send(setmsg) - - def send_get(self, var, id): - getmsg = "GET %s %s" %(id, var) - return self.send(getmsg) - - def do_set(self, var, value): - id = self.next_id - self.next_id += 1 - self.send_set(var, value, id) - return self.recv_msgs()[id] - - def do_get(self, var): - id = self.next_id - self.next_id += 1 - self.send_get(var, id) - return self.recv_msgs()[id] - - def recv_msgs(self): - responses = {} - data = self.sock.recv(4096) - while (len(data)>0): - (head, data) = IPA().split_combined(data) - answer = Ctrl().rem_header(head).decode() - if verbose: - print("Got message:", answer) - (mtype, id, msg) = answer.split(None, 2) - id = int(id) - rsp = {'mtype': mtype, 'id': id} - if mtype == "ERROR": - rsp['error'] = msg - else: - split = msg.split(None, 1) - rsp['var'] = split[0] - if len(split) > 1: - rsp['value'] = split[1] - else: - rsp['value'] = None - responses[id] = rsp - - if verbose: - print("Decoded replies: ", responses) - - return responses - - -class TestCtrlHNB(TestCtrlBase): - - def tearDown(self): - TestCtrlBase.tearDown(self) - os.unlink("tmp_dummy_sock") - - def ctrl_command(self): - return ["./src/osmo-hnbgw/osmo-hnbgw", "-r", "tmp_dummy_sock", "-c", - "doc/examples/osmo-hnbgw/osmo-hnbgw.cfg"] - - def ctrl_app(self): - return (4249, "./src/osmo-hnbgw/osmo-hnbgw", "OsmoHNBGW", "hnb") - - def testCtrlErrs(self): - r = self.do_get('invalid') - self.assertEqual(r['mtype'], 'ERROR') - self.assertEqual(r['error'], 'Command not found') - - r = self.do_get('hnbgw.999') - self.assertEqual(r['mtype'], 'ERROR') - self.assertEqual(r['error'], 'Error while resolving object') - -def add_hnbgw_test(suite, workdir, klass): - if not os.path.isfile(os.path.join(workdir, "src/osmo-hnbgw/osmo-hnbgw")): - print("Skipping the HNBGW test") - return - test = unittest.TestLoader().loadTestsFromTestCase(klass) - suite.addTest(test) - -if __name__ == '__main__': - import argparse - import sys - - workdir = '.' - - parser = argparse.ArgumentParser() - parser.add_argument("-v", "--verbose", dest="verbose", - action="store_true", help="verbose mode") - parser.add_argument("-p", "--pythonconfpath", dest="p", - help="searchpath for config") - parser.add_argument("-w", "--workdir", dest="w", - help="Working directory") - args = parser.parse_args() - - verbose_level = 1 - if args.verbose: - verbose_level = 2 - verbose = True - - if args.w: - workdir = args.w - - if args.p: - confpath = args.p - - print("confpath %s, workdir %s" % (confpath, workdir)) - os.chdir(workdir) - print("Running tests for specific control commands") - suite = unittest.TestSuite() - add_hnbgw_test(suite, workdir, TestCtrlHNB) - res = unittest.TextTestRunner(verbosity=verbose_level).run(suite) - sys.exit(len(res.errors) + len(res.failures)) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32626 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If3d6614334b692e49efcc45d1e4fb29a00c68602 Gerrit-Change-Number: 32626 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in osmo-smlc[master]: ctrl-test: drop bogus 'rm -f $(CTRL_TEST_DB)'

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-smlc/+/32622 ) Change subject: ctrl-test: drop bogus 'rm -f $(CTRL_TEST_DB)' ...................................................................... ctrl-test: drop bogus 'rm -f $(CTRL_TEST_DB)' That is a copy-paste artifact from osmo-hlr.git and looks pretty dangerous when CTRL_TEST_DB is not defined. Change-Id: Idcf9296a6e7e520c2f0b42f8aace01d616bcfc56 --- M tests/Makefile.am 1 file changed, 12 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-smlc refs/changes/22/32622/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index b2e1bee..5ced1ea 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -63,13 +63,10 @@ # pass -u to ctrl_script_runner.py by doing: # make ctrl-test U=-u ctrl-test: $(top_builddir)/src/osmo-smlc/osmo-smlc - -rm -f $(CTRL_TEST_DB) osmo_verify_transcript_ctrl.py -v \ -p 4272 \ -r "$(top_builddir)/src/osmo-smlc/osmo-smlc -c $(top_srcdir)/tests/osmo-smlc.cfg" \ $(U) $(srcdir)/*.ctrl - -rm -f $(CTRL_TEST_DB) - -rm $(CTRL_TEST_DB)-* check-local: atconfig $(TESTSUITE) $(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS) -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/32622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: Idcf9296a6e7e520c2f0b42f8aace01d616bcfc56 Gerrit-Change-Number: 32622 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[L] Change in osmo-hnbgw[master]: move main() to separate file

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32620 ) Change subject: move main() to separate file ...................................................................... Patch Set 1: (2 comments) File src/osmo-hnbgw/osmo_hnbgw_main.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-6790): https://gerrit.osmocom.org/c/osmo-hnbgw/+/32620/comment/dbf034d3_70e8be05 PS1, Line 65: static void print_usage() Bad function definition - void print_usage() should probably be void print_usage(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-6790): https://gerrit.osmocom.org/c/osmo-hnbgw/+/32620/comment/d5db598a_32042d20 PS1, Line 70: static void print_help() Bad function definition - void print_help() should probably be void print_help(void) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32620 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I5f26a6b68f0d380617d73371f40f3b9055cac362 Gerrit-Change-Number: 32620 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 04 May 2023 23:22:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[L] Change in osmo-hnbgw[master]: simplify: one g_hnbgw as global state and root ctx

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32618 ) Change subject: simplify: one g_hnbgw as global state and root ctx ...................................................................... Patch Set 1: (1 comment) File src/osmo-hnbgw/hnbgw_vty.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-6788): https://gerrit.osmocom.org/c/osmo-hnbgw/+/32618/comment/eb6adbe1_11a656b7 PS1, Line 294: talloc_free((void*)g_hnbgw->config.iuh_local_ip); "(foo*)" should be "(foo *)" -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32618 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3d54a5bb30c16a990c6def2a0ed207f60a95ef5d Gerrit-Change-Number: 32618 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 04 May 2023 23:22:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2023