May 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bts[master]: trx: remove model-specific BFI packet formats

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32788 ) Change subject: trx: remove model-specific BFI packet formats ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8f9fb5b8c5b2cad4b92ac693c0040779f811981a Gerrit-Change-Number: 32788 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator(a)gmail.com> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <axilirator(a)gmail.com> Gerrit-Comment-Date: Fri, 19 May 2023 08:46:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-ci[master]: data/build_rpm: force refresh of package indexes

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/32789 ) Change subject: data/build_rpm: force refresh of package indexes ...................................................................... data/build_rpm: force refresh of package indexes The yum-builddep command already has a mechanism to update the package index data if the last update (when the docker image was built) was some time ago. However when the packages we use happened to be updated in that timeframe, the indexes are not updated and attempting to download them leads to 404 errors. Force refresh all package indexes to avoid this. Fixes: OS#6038 Change-Id: I6e2592466b6190782cdd93e00b3d5020fd665372 --- M scripts/obs/data/build_rpm.sh 1 file changed, 20 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/scripts/obs/data/build_rpm.sh b/scripts/obs/data/build_rpm.sh index 77efef2..63c3638 100755 --- a/scripts/obs/data/build_rpm.sh +++ b/scripts/obs/data/build_rpm.sh @@ -21,6 +21,9 @@ su "$BUILDUSER" -c "cp _temp/srcpkgs/$PACKAGE/rpmlintrc ~/rpmbuild/SOURCES" su "$BUILDUSER" -c "cp /obs/data/rpmmacros ~/.rpmmacros" +# Force refresh of package index data (OS#6038) +dnf makecache --refresh + $yum_builddep "/home/$BUILDUSER/rpmbuild/SPECS/$spec" su "$BUILDUSER" -c "rpmbuild -bb ~/rpmbuild/SPECS/$spec" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32789 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6e2592466b6190782cdd93e00b3d5020fd665372 Gerrit-Change-Number: 32789 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

[S] Change in osmo-ci[master]: data/build_rpm: force refresh of package indexes

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/32789 ) Change subject: data/build_rpm: force refresh of package indexes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32789 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6e2592466b6190782cdd93e00b3d5020fd665372 Gerrit-Change-Number: 32789 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 May 2023 08:44:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in libosmocore[master]: coding: fix decoding of EFR triplicated bits

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32767 ) Change subject: coding: fix decoding of EFR triplicated bits ...................................................................... coding: fix decoding of EFR triplicated bits In GSM 05.03 channel coding for EFR, there are 4 bits out of the 244-bit EFR codec frame that are triplicated before FR-like encoding, and the decoder needs to apply a 2-out-of-3 majority voting function to each of these triplicated bits after the FR-like decoding step. For one of those 4 bits, this majority voting function was wrong in the decoder implemented in gsm0503_tch_fr_decode() - fix it. Change-Id: I47def75cdb066ed6372df4567404cc828589ed53 --- M src/coding/gsm0503_coding.c 1 file changed, 17 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/coding/gsm0503_coding.c b/src/coding/gsm0503_coding.c index 07c8c98..1ef6393 100644 --- a/src/coding/gsm0503_coding.c +++ b/src/coding/gsm0503_coding.c @@ -1804,7 +1804,7 @@ s[119] = (sum >= 2); memcpy(s + 121, w + 125, 53); sum = s[172] + w[178] + w[179]; - s[172] = (sum > 2); + s[172] = (sum >= 2); memcpy(s + 174, w + 180, 50); sum = s[222] + w[230] + w[231]; s[222] = (sum >= 2); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I47def75cdb066ed6372df4567404cc828589ed53 Gerrit-Change-Number: 32767 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

[S] Change in libosmocore[master]: coding: fix decoding of EFR triplicated bits

by laforge

Attention is currently required from: falconia, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32767 ) Change subject: coding: fix decoding of EFR triplicated bits ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I47def75cdb066ed6372df4567404cc828589ed53 Gerrit-Change-Number: 32767 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 May 2023 08:44:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-ci[master]: data/build_rpm: force refresh of package indexes

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/32789 ) Change subject: data/build_rpm: force refresh of package indexes ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32789 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6e2592466b6190782cdd93e00b3d5020fd665372 Gerrit-Change-Number: 32789 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 May 2023 08:28:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in osmo-bts[master]: trx: remove model-specific BFI packet formats

by pespin

Attention is currently required from: falconia. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32788 ) Change subject: trx: remove model-specific BFI packet formats ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8f9fb5b8c5b2cad4b92ac693c0040779f811981a Gerrit-Change-Number: 32788 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Fri, 19 May 2023 08:25:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in libosmocore[master]: gsm_04_08_gprs: add IEI "GMM TMSI Based NRI Container"

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32787 ) Change subject: gsm_04_08_gprs: add IEI "GMM TMSI Based NRI Container" ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32787 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id661abfdb2c81a92c9046542bbc08d6ccd39f073 Gerrit-Change-Number: 32787 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 May 2023 08:23:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[L] Change in osmo-bts[master]: TCH DL, FR & EFR: reshape SIDs per 06.31/06.81 section 5.1.2

by pespin

Attention is currently required from: falconia, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32714 ) Change subject: TCH DL, FR & EFR: reshape SIDs per 06.31/06.81 section 5.1.2 ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32714 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I924ab21952dcf8bb03ba7ccef790474bf66fc9e5 Gerrit-Change-Number: 32714 Gerrit-PatchSet: 6 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 May 2023 08:22:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-ci[master]: data/build_rpm: force refresh of package indexes

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/32789 ) Change subject: data/build_rpm: force refresh of package indexes ...................................................................... data/build_rpm: force refresh of package indexes The yum-builddep command already has a mechanism to update the package index data if the last update (when the docker image was built) was some time ago. However when the packages we use happened to be updated in that timeframe, the indexes are not updated and attempting to download them leads to 404 errors. Force refresh all package indexes to avoid this. Fixes: OS#6038 Change-Id: I6e2592466b6190782cdd93e00b3d5020fd665372 --- M scripts/obs/data/build_rpm.sh 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/89/32789/1 diff --git a/scripts/obs/data/build_rpm.sh b/scripts/obs/data/build_rpm.sh index 77efef2..63c3638 100755 --- a/scripts/obs/data/build_rpm.sh +++ b/scripts/obs/data/build_rpm.sh @@ -21,6 +21,9 @@ su "$BUILDUSER" -c "cp _temp/srcpkgs/$PACKAGE/rpmlintrc ~/rpmbuild/SOURCES" su "$BUILDUSER" -c "cp /obs/data/rpmmacros ~/.rpmmacros" +# Force refresh of package index data (OS#6038) +dnf makecache --refresh + $yum_builddep "/home/$BUILDUSER/rpmbuild/SPECS/$spec" su "$BUILDUSER" -c "rpmbuild -bb ~/rpmbuild/SPECS/$spec" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32789 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6e2592466b6190782cdd93e00b3d5020fd665372 Gerrit-Change-Number: 32789 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2023