March 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[2023q1]: contrib/jenkins: build libosmo-abis without dahdi
by laforge 24 Mar '23

24 Mar '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32055 ) Change subject: contrib/jenkins: build libosmo-abis without dahdi ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: why is it "not needed"? DAHDI is used in production systems that sysmocom sells, maitanins and supports. I don't see why we would disable it in any part of our CI? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32055 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: 2023q1 Gerrit-Change-Id: I61c483983a4793e0429bb37804dee0a128125daf Gerrit-Change-Number: 32055 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Mar 2023 17:01:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: doc: overview: put BTS and PCU on the same rank
by dexter 24 Mar '23

24 Mar '23

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32047 ) Change subject: doc: overview: put BTS and PCU on the same rank ...................................................................... doc: overview: put BTS and PCU on the same rank The manual so far describes how OsmoPCU is run in co-location with the BTS but Figure 1 shows the PCU next to the BSC. Lets put BTS and PCU on the same rank so that they appear next to each other. This reflects the reality better. Change-Id: Ifa170f3956b4629765a88ed62e877a204541d9ea --- M doc/manuals/chapters/overview.adoc 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/doc/manuals/chapters/overview.adoc b/doc/manuals/chapters/overview.adoc index 6ae6f7e..5b831d3 100644 --- a/doc/manuals/chapters/overview.adoc +++ b/doc/manuals/chapters/overview.adoc @@ -27,6 +27,7 @@ PCU->SGSN [label="Gb"] SGSN->GGSN [label="GTP"] PCU [color=red] + { rank=same BTS PCU } } ---- -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32047 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ifa170f3956b4629765a88ed62e877a204541d9ea Gerrit-Change-Number: 32047 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmocore[master]: rate_ctr: Add rate_ctr_add2() similar to rate_ctr_inc2()
by fixeria 24 Mar '23

24 Mar '23

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32048 ) Change subject: rate_ctr: Add rate_ctr_add2() similar to rate_ctr_inc2() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32048 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If93e8b4fb0b86a87358f32d2b45438ca1887e9f3 Gerrit-Change-Number: 32048 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 24 Mar 2023 16:13:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: scripts/manuals: fix missing UserKnownHostsFile
by fixeria 24 Mar '23

24 Mar '23

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/32046 ) Change subject: scripts/manuals: fix missing UserKnownHostsFile ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32046 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I485e2268eec50f46ed0436d4b3a5cedfab20af96 Gerrit-Change-Number: 32046 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Mar 2023 16:12:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[2023q1]: bts-trx: Avoid pushing interf_meas for disabled TRX
by fixeria 24 Mar '23

24 Mar '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32054 ) Change subject: bts-trx: Avoid pushing interf_meas for disabled TRX ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32054 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: 2023q1 Gerrit-Change-Id: Ie3fd80970585cb30808b0644568dbc8936a57721 Gerrit-Change-Number: 32054 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Mar 2023 16:12:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[2023q1]: Avoid tx RF Resource Ind for disabled TRX
by fixeria 24 Mar '23

24 Mar '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32053 ) Change subject: Avoid tx RF Resource Ind for disabled TRX ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32053 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: 2023q1 Gerrit-Change-Id: I887e0cb03b2a5654accccf7a55fac51319981bfb Gerrit-Change-Number: 32053 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Mar 2023 16:11:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[2023q1]: bts-trx: Fix no NM Radio{Carrier,Channel} switching to Enabled if one...
by fixeria 24 Mar '23

24 Mar '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32052 ) Change subject: bts-trx: Fix no NM Radio{Carrier,Channel} switching to Enabled if one TRX is rf_locked ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32052 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: 2023q1 Gerrit-Change-Id: Ie4836f5721ce8227a63c267730aeb17228994214 Gerrit-Change-Number: 32052 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Mar 2023 16:11:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[2023q1]: contrib/jenkins: build libosmo-abis without dahdi
by fixeria 24 Mar '23

24 Mar '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32055 ) Change subject: contrib/jenkins: build libosmo-abis without dahdi ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32055 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: 2023q1 Gerrit-Change-Id: I61c483983a4793e0429bb37804dee0a128125daf Gerrit-Change-Number: 32055 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Mar 2023 16:11:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[2023q1]: contrib/jenkins: build libosmo-abis without dahdi
by pespin 24 Mar '23

24 Mar '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/32055 ) Change subject: contrib/jenkins: build libosmo-abis without dahdi ...................................................................... contrib/jenkins: build libosmo-abis without dahdi Looks like this is not needed, so make the jenkins build work without installing dahdi-source. Related: OS#5863 Change-Id: I61c483983a4793e0429bb37804dee0a128125daf (cherry picked from commit 07017887245f24b94eb7cea8fbcc2151d5ce3cbf) --- M contrib/jenkins_bts_trx.sh M contrib/jenkins_lc15.sh M contrib/jenkins_oc2g.sh M contrib/jenkins_oct.sh M contrib/jenkins_oct_and_bts_trx.sh M contrib/jenkins_sysmobts.sh 6 files changed, 20 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/55/32055/1 diff --git a/contrib/jenkins_bts_trx.sh b/contrib/jenkins_bts_trx.sh index a98a633..9ac820d 100755 --- a/contrib/jenkins_bts_trx.sh +++ b/contrib/jenkins_bts_trx.sh @@ -9,7 +9,7 @@ osmo-build-dep.sh libosmocore "" --disable-doxygen -osmo-build-dep.sh libosmo-abis +osmo-build-dep.sh libosmo-abis "" --disable-dahdi osmo-build-dep.sh libosmo-netif "" --disable-doxygen cd "$deps" diff --git a/contrib/jenkins_lc15.sh b/contrib/jenkins_lc15.sh index 4454f65..89dd54b 100755 --- a/contrib/jenkins_lc15.sh +++ b/contrib/jenkins_lc15.sh @@ -9,7 +9,7 @@ export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH" export LD_LIBRARY_PATH="$inst/lib" -osmo-build-dep.sh libosmo-abis +osmo-build-dep.sh libosmo-abis "" --disable-dahdi osmo-build-dep.sh libosmo-netif "" --disable-doxygen cd "$deps" diff --git a/contrib/jenkins_oc2g.sh b/contrib/jenkins_oc2g.sh index af2f8a0..e4795cf 100755 --- a/contrib/jenkins_oc2g.sh +++ b/contrib/jenkins_oc2g.sh @@ -9,7 +9,7 @@ export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH" export LD_LIBRARY_PATH="$inst/lib" -osmo-build-dep.sh libosmo-abis +osmo-build-dep.sh libosmo-abis "" --disable-dahdi osmo-build-dep.sh libosmo-netif "" --disable-doxygen cd "$deps" diff --git a/contrib/jenkins_oct.sh b/contrib/jenkins_oct.sh index 0984e20..d1b6aee 100755 --- a/contrib/jenkins_oct.sh +++ b/contrib/jenkins_oct.sh @@ -9,7 +9,7 @@ export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH" export LD_LIBRARY_PATH="$inst/lib" -osmo-build-dep.sh libosmo-abis +osmo-build-dep.sh libosmo-abis "" --disable-dahdi osmo-build-dep.sh libosmo-netif "" --disable-doxygen cd "$deps" diff --git a/contrib/jenkins_oct_and_bts_trx.sh b/contrib/jenkins_oct_and_bts_trx.sh index 3f4efae..f188147 100755 --- a/contrib/jenkins_oct_and_bts_trx.sh +++ b/contrib/jenkins_oct_and_bts_trx.sh @@ -9,7 +9,7 @@ osmo-build-dep.sh libosmocore "" --disable-doxygen -osmo-build-dep.sh libosmo-abis +osmo-build-dep.sh libosmo-abis "" --disable-dahdi osmo-build-dep.sh libosmo-netif "" --disable-doxygen cd "$deps" diff --git a/contrib/jenkins_sysmobts.sh b/contrib/jenkins_sysmobts.sh index 2e5ab8d..87a98f3 100755 --- a/contrib/jenkins_sysmobts.sh +++ b/contrib/jenkins_sysmobts.sh @@ -9,7 +9,7 @@ export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH" export LD_LIBRARY_PATH="$inst/lib" -osmo-build-dep.sh libosmo-abis +osmo-build-dep.sh libosmo-abis "" --disable-dahdi osmo-build-dep.sh libosmo-netif "" --disable-doxygen cd "$deps" -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32055 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: 2023q1 Gerrit-Change-Id: I61c483983a4793e0429bb37804dee0a128125daf Gerrit-Change-Number: 32055 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-pcu[master]: doc: Add details regarding BSC co-location
by dexter 24 Mar '23

24 Mar '23

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32049 to look at the new patch set (#3). Change subject: doc: Add details regarding BSC co-location ...................................................................... doc: Add details regarding BSC co-location As of now the manual only focusses on the BTS co-located scenario. Since we recently introduced support for Ericsson RBS 2000/6000 base stations, we also had to add support for the BSC co-located scenario. Let's update the manual accordingly. Related: OS#5198 Change-Id: Ib2a3b60849fd312b21073a3511b8ca36b4536343 --- M doc/manuals/chapters/configuration.adoc M doc/manuals/chapters/overview.adoc 2 files changed, 103 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/49/32049/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32049 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib2a3b60849fd312b21073a3511b8ca36b4536343 Gerrit-Change-Number: 32049 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0