March 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: pcu_sock: fix PCU socket accept behavior
by fixeria 06 Mar '23

06 Mar '23

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31678 ) Change subject: pcu_sock: fix PCU socket accept behavior ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/31678/comment/ba14c9d3_05cf13ee PS1, Line 10: then the new connection should replace the old one This is weird, I am surprised we're doing it this way. Starting an additional instance of osmo-pcu (e.g. by accident) will drop currently active PCU connection (and this drop the state of all TBFs), and then both PCUs will be kicking each other off one after another? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31678 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I695b93fd8109ef4943f36716563c147927611e85 Gerrit-Change-Number: 31678 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 06 Mar 2023 13:33:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: pcu_sock: cosmetic: remove unnecessary line breaks
by fixeria 06 Mar '23

06 Mar '23

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31677 ) Change subject: pcu_sock: cosmetic: remove unnecessary line breaks ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31677 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8cb2979c62ebb05d06af49b40b145b7dee826cb1 Gerrit-Change-Number: 31677 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 06 Mar 2023 13:28:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: gsm: gsm_gsmtime2fn(): constify param
by pespin 06 Mar '23

06 Mar '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31681 ) Change subject: gsm: gsm_gsmtime2fn(): constify param ...................................................................... gsm: gsm_gsmtime2fn(): constify param Change-Id: Ib29d5a8e7dcf50fb086f967857b0afa076573163 --- M include/osmocom/gsm/gsm_utils.h M src/gsm/gsm_utils.c 2 files changed, 11 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/include/osmocom/gsm/gsm_utils.h b/include/osmocom/gsm/gsm_utils.h index 8e346c7..721456d 100644 --- a/include/osmocom/gsm/gsm_utils.h +++ b/include/osmocom/gsm/gsm_utils.h @@ -181,7 +181,7 @@ char *gsm_fn_as_gsmtime_str(uint32_t fn); /* Convert from GSM time to frame number */ -uint32_t gsm_gsmtime2fn(struct gsm_time *time); +uint32_t gsm_gsmtime2fn(const struct gsm_time *time); /* Returns static buffer with string representation of a GSM Time */ char *osmo_dump_gsmtime(const struct gsm_time *tm); diff --git a/src/gsm/gsm_utils.c b/src/gsm/gsm_utils.c index 48341ae..06b2406 100644 --- a/src/gsm/gsm_utils.c +++ b/src/gsm/gsm_utils.c @@ -885,7 +885,7 @@ /*! Encode decoded \ref gsm_time to Frame Number * \param[in] time GSM Time in decoded structure * \returns GSM Frame Number */ -uint32_t gsm_gsmtime2fn(struct gsm_time *time) +uint32_t gsm_gsmtime2fn(const struct gsm_time *time) { uint32_t fn; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31681 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib29d5a8e7dcf50fb086f967857b0afa076573163 Gerrit-Change-Number: 31681 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmocore[master]: gsm: gsm_gsmtime2fn(): constify param
by fixeria 06 Mar '23

06 Mar '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31681 ) Change subject: gsm: gsm_gsmtime2fn(): constify param ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31681 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib29d5a8e7dcf50fb086f967857b0afa076573163 Gerrit-Change-Number: 31681 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 06 Mar 2023 13:23:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: gsm: gsm_gsmtime2fn(): constify param
by pespin 06 Mar '23

06 Mar '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31681 ) Change subject: gsm: gsm_gsmtime2fn(): constify param ...................................................................... gsm: gsm_gsmtime2fn(): constify param Change-Id: Ib29d5a8e7dcf50fb086f967857b0afa076573163 --- M include/osmocom/gsm/gsm_utils.h M src/gsm/gsm_utils.c 2 files changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/81/31681/1 diff --git a/include/osmocom/gsm/gsm_utils.h b/include/osmocom/gsm/gsm_utils.h index 8e346c7..721456d 100644 --- a/include/osmocom/gsm/gsm_utils.h +++ b/include/osmocom/gsm/gsm_utils.h @@ -181,7 +181,7 @@ char *gsm_fn_as_gsmtime_str(uint32_t fn); /* Convert from GSM time to frame number */ -uint32_t gsm_gsmtime2fn(struct gsm_time *time); +uint32_t gsm_gsmtime2fn(const struct gsm_time *time); /* Returns static buffer with string representation of a GSM Time */ char *osmo_dump_gsmtime(const struct gsm_time *tm); diff --git a/src/gsm/gsm_utils.c b/src/gsm/gsm_utils.c index 48341ae..06b2406 100644 --- a/src/gsm/gsm_utils.c +++ b/src/gsm/gsm_utils.c @@ -885,7 +885,7 @@ /*! Encode decoded \ref gsm_time to Frame Number * \param[in] time GSM Time in decoded structure * \returns GSM Frame Number */ -uint32_t gsm_gsmtime2fn(struct gsm_time *time) +uint32_t gsm_gsmtime2fn(const struct gsm_time *time) { uint32_t fn; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31681 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib29d5a8e7dcf50fb086f967857b0afa076573163 Gerrit-Change-Number: 31681 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bts[master]: osmo-bts-{trx,virtual}: check lchan against NULL in bts_model_l1sap_d...
by fixeria 06 Mar '23

06 Mar '23

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31671 ) Change subject: osmo-bts-{trx,virtual}: check lchan against NULL in bts_model_l1sap_down() ...................................................................... Patch Set 1: (2 comments) File src/osmo-bts-trx/l1_if.c: https://gerrit.osmocom.org/c/osmo-bts/+/31671/comment/1cb78fb4_26d79f7c PS1, Line 408: rc > (reading this makes me think that.... Done https://gerrit.osmocom.org/c/osmo-bts/+/31671/comment/aa803d22_cefc2589 PS1, Line 423: bre > .... […] Ack, see: https://gerrit.osmocom.org/c/osmo-bts/+/31680. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31671 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1a815c9675eebc16640b62308499dd784fc206bd Gerrit-Change-Number: 31671 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 06 Mar 2023 12:47:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: osmo-bts-{trx,virtual}: set rc on error in bts_model_l1sap_down()
by fixeria 06 Mar '23

06 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/31680 ) Change subject: osmo-bts-{trx,virtual}: set rc on error in bts_model_l1sap_down() ...................................................................... osmo-bts-{trx,virtual}: set rc on error in bts_model_l1sap_down() Change-Id: If3016bae9d03a9972c04b748fc9efab56a412e0e Related: OS#1572 --- M src/osmo-bts-trx/l1_if.c M src/osmo-bts-virtual/l1_if.c 2 files changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/80/31680/1 diff --git a/src/osmo-bts-trx/l1_if.c b/src/osmo-bts-trx/l1_if.c index 7652117..2b0c723 100644 --- a/src/osmo-bts-trx/l1_if.c +++ b/src/osmo-bts-trx/l1_if.c @@ -420,6 +420,7 @@ if ((chan_nr & 0xE0) == 0x80) { LOGPLCHAN(lchan, DL1C, LOGL_ERROR, "Cannot activate" " channel %s\n", rsl_chan_nr_str(chan_nr)); + rc = -EPERM; break; } @@ -480,6 +481,7 @@ if ((chan_nr & 0xE0) == 0x80) { LOGPLCHAN(lchan, DL1C, LOGL_ERROR, "Cannot deactivate" " channel %s\n", rsl_chan_nr_str(chan_nr)); + rc = -EPERM; break; } /* clear ECU state (if any) */ diff --git a/src/osmo-bts-virtual/l1_if.c b/src/osmo-bts-virtual/l1_if.c index 235c399..b578ca0 100644 --- a/src/osmo-bts-virtual/l1_if.c +++ b/src/osmo-bts-virtual/l1_if.c @@ -375,6 +375,7 @@ if ((chan_nr & 0xE0) == 0x80) { LOGPLCHAN(lchan, DL1C, LOGL_ERROR, "Cannot activate" " channel %s\n", rsl_chan_nr_str(chan_nr)); + rc = -EPERM; break; } /* activate dedicated channel */ @@ -420,6 +421,7 @@ if ((chan_nr & 0xE0) == 0x80) { LOGPLCHAN(lchan, DL1C, LOGL_ERROR, "Cannot deactivate" " channel %s\n", rsl_chan_nr_str(chan_nr)); + rc = -EPERM; break; } /* deactivate associated channel */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31680 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If3016bae9d03a9972c04b748fc9efab56a412e0e Gerrit-Change-Number: 31680 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[L] Change in osmo-bts[master]: osmo-bts-{trx,virtual}: clean up bts_model_l1sap_down()
by fixeria 06 Mar '23

06 Mar '23

Attention is currently required from: fixeria. Hello Jenkins Builder, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/31670 to look at the new patch set (#2). Change subject: osmo-bts-{trx,virtual}: clean up bts_model_l1sap_down() ...................................................................... osmo-bts-{trx,virtual}: clean up bts_model_l1sap_down() Having a common body for PRIM_INFO_{ACTIVATE,DEACTIVATE,MODIFY}, but then branching using if-statements is a bit confusing. Change-Id: I915c8a541249249e3c0b1f2eda4535e7c52db79f Related: OS#1572 --- M src/osmo-bts-trx/l1_if.c M src/osmo-bts-virtual/l1_if.c 2 files changed, 128 insertions(+), 128 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/70/31670/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31670 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I915c8a541249249e3c0b1f2eda4535e7c52db79f Gerrit-Change-Number: 31670 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-bts[master]: osmo-bts-{trx,virtual}: check lchan against NULL in bts_model_l1sap_d...
by fixeria 06 Mar '23

06 Mar '23

Attention is currently required from: fixeria. Hello Jenkins Builder, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/31671 to look at the new patch set (#2). Change subject: osmo-bts-{trx,virtual}: check lchan against NULL in bts_model_l1sap_down() ...................................................................... osmo-bts-{trx,virtual}: check lchan against NULL in bts_model_l1sap_down() Even though it's unlikely, get_lchan_by_chan_nr() *may* return NULL. Change-Id: I1a815c9675eebc16640b62308499dd784fc206bd Related: OS#1572 --- M src/osmo-bts-trx/l1_if.c M src/osmo-bts-virtual/l1_if.c 2 files changed, 26 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/71/31671/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31671 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1a815c9675eebc16640b62308499dd784fc206bd Gerrit-Change-Number: 31671 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-bts[master]: pcu_sock: cosmetic: remove whitespace after type cast
by dexter 06 Mar '23

06 Mar '23

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31675 ) Change subject: pcu_sock: cosmetic: remove whitespace after type cast ...................................................................... pcu_sock: cosmetic: remove whitespace after type cast Change-Id: I373b510efab4874f59f75385bd0e1229692299ec --- M src/common/pcu_sock.c 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c index b0fd936..7f0af56 100644 --- a/src/common/pcu_sock.c +++ b/src/common/pcu_sock.c @@ -1163,7 +1163,7 @@ int fd; len = sizeof(un_addr); - fd = accept(bfd->fd, (struct sockaddr *) &un_addr, &len); + fd = accept(bfd->fd, (struct sockaddr *)&un_addr, &len); if (fd < 0) { LOGP(DPCU, LOGL_ERROR, "Failed to accept a new connection\n"); return -1; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31675 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I373b510efab4874f59f75385bd0e1229692299ec Gerrit-Change-Number: 31675 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: merged

1 0