March 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-pcu[master]: pcu_l1_if_phy: support multiple BTS (in theory)
by laforge 06 Mar '23

06 Mar '23

Attention is currently required from: fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31649 ) Change subject: pcu_l1_if_phy: support multiple BTS (in theory) ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31649 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I33518cbbe83f7f8c071afa5e995d30930099ba92 Gerrit-Change-Number: 31649 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 06 Mar 2023 17:10:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: gsm_08_58: Document IPAC RTP CSD modes in at least a few words
by laforge 06 Mar '23

06 Mar '23

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31690 ) Change subject: gsm_08_58: Document IPAC RTP CSD modes in at least a few words ...................................................................... gsm_08_58: Document IPAC RTP CSD modes in at least a few words Let's clarify what those modes mean Change-Id: I77fc7b24ccd387f54a7c7edad666737252af6bd9 --- M include/osmocom/gsm/protocol/gsm_08_58.h 1 file changed, 15 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/90/31690/1 diff --git a/include/osmocom/gsm/protocol/gsm_08_58.h b/include/osmocom/gsm/protocol/gsm_08_58.h index 67b76f8..e932ff8 100644 --- a/include/osmocom/gsm/protocol/gsm_08_58.h +++ b/include/osmocom/gsm/protocol/gsm_08_58.h @@ -744,10 +744,10 @@ /* RSL_IE_IPAC_RTP_CSD_FMT, lower four bits */ enum rsl_ipac_rtp_csd_format_d { - RSL_IPAC_RTP_CSD_EXT_TRAU = 0, - RSL_IPAC_RTP_CSD_NON_TRAU = 1, - RSL_IPAC_RTP_CSD_TRAU_BTS = 2, - RSL_IPAC_RTP_CSD_IWF_FREE = 3, + RSL_IPAC_RTP_CSD_EXT_TRAU = 0, /*!< TRAU-like RTP format, without leading zero-bits */ + RSL_IPAC_RTP_CSD_NON_TRAU = 1, /*!< packed 16k (252/288 bit) / 8k (126 bit) in RTP */ + RSL_IPAC_RTP_CSD_TRAU_BTS = 2, /*!< TRAU in BTS; V.110 in RTP/CLEARMODE */ + RSL_IPAC_RTP_CSD_IWF_FREE = 3, /*!< unknown proprietary IWF-free BTS-BTS data */ }; /* RSL_IE_IPAC_RTP_CSD_FMT, upper four bits */ enum rsl_ipac_rtp_csd_format_ir { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31690 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I77fc7b24ccd387f54a7c7edad666737252af6bd9 Gerrit-Change-Number: 31690 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: Makefile.am: Make libraries depend on .map files
by laforge 06 Mar '23

06 Mar '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31667 ) Change subject: Makefile.am: Make libraries depend on .map files ...................................................................... Makefile.am: Make libraries depend on .map files Without this, an update to the .map file doesn't re-trigger a re-link of the library. Change-Id: If0ea6f41730a28b04562d45efa6ca376abaf3f6b --- M src/coding/Makefile.am M src/core/Makefile.am M src/ctrl/Makefile.am M src/gb/Makefile.am M src/gsm/Makefile.am M src/isdn/Makefile.am 6 files changed, 19 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve msuraev: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/coding/Makefile.am b/src/coding/Makefile.am index 42b16e8..905d684 100644 --- a/src/coding/Makefile.am +++ b/src/coding/Makefile.am @@ -37,3 +37,4 @@ $(NULL) EXTRA_DIST = libosmocoding.map +EXTRA_libosmocoding_la_DEPENDENCIES = libosmocoding.map diff --git a/src/core/Makefile.am b/src/core/Makefile.am index 7e24013..50c39d1 100644 --- a/src/core/Makefile.am +++ b/src/core/Makefile.am @@ -111,6 +111,8 @@ libosmocore.map \ $(NULL) +EXTRA_libosmocore_la_DEPENDENCIES = libosmocore.map + libosmocore_la_LDFLAGS = \ $(LTLDFLAGS_OSMOCORE) \ -version-info \ diff --git a/src/ctrl/Makefile.am b/src/ctrl/Makefile.am index e1c6587..29f867e 100644 --- a/src/ctrl/Makefile.am +++ b/src/ctrl/Makefile.am @@ -22,5 +22,6 @@ endif EXTRA_DIST = libosmoctrl.map +EXTRA_libosmoctrl_la_DEPENDENCIES = libosmoctrl.map endif diff --git a/src/gb/Makefile.am b/src/gb/Makefile.am index 1818db7..3a64a71 100644 --- a/src/gb/Makefile.am +++ b/src/gb/Makefile.am @@ -40,3 +40,4 @@ endif EXTRA_DIST = libosmogb.map +EXTRA_libosmogb_la_DEPENDENCIES = libosmogb.map diff --git a/src/gsm/Makefile.am b/src/gsm/Makefile.am index cff089b..79c5f04 100644 --- a/src/gsm/Makefile.am +++ b/src/gsm/Makefile.am @@ -52,6 +52,7 @@ endif EXTRA_DIST = libosmogsm.map +EXTRA_libosmogsm_la_DEPENDENCIES = libosmogsm.map # Convolutional codes generation gsm0503_conv.c: $(top_srcdir)/utils/conv_gen.py $(top_srcdir)/utils/conv_codes_gsm.py diff --git a/src/isdn/Makefile.am b/src/isdn/Makefile.am index 97e7a28..2aed0bf 100644 --- a/src/isdn/Makefile.am +++ b/src/isdn/Makefile.am @@ -23,3 +23,4 @@ libosmoisdn_la_LIBADD = libisdnint.la $(TALLOC_LIBS) EXTRA_DIST = libosmoisdn.map +EXTRA_libosmoisdn_la_DEPENDENCIES = libosmoisdn.map -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31667 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If0ea6f41730a28b04562d45efa6ca376abaf3f6b Gerrit-Change-Number: 31667 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmocore[master]: Makefile.am: Make libraries depend on .map files
by laforge 06 Mar '23

06 Mar '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31667 ) Change subject: Makefile.am: Make libraries depend on .map files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31667 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If0ea6f41730a28b04562d45efa6ca376abaf3f6b Gerrit-Change-Number: 31667 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 06 Mar 2023 17:07:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-pcu[master]: bts: add IMMEDIATE ASSIGNMENT via PCH transmission
by dexter 06 Mar '23

06 Mar '23

Attention is currently required from: neels, pespin, fixeria, dexter. Hello Jenkins Builder, laforge, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 to look at the new patch set (#24). Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission ...................................................................... bts: add IMMEDIATE ASSIGNMENT via PCH transmission In situations where the PCU is co-located to the BSC, the IMMEDIATE ASSIGNMENT for downlink TBFs must be sent via RSL and the BSC also must instruct the BTS to transmit the IMMEDIATE ASSIGNMENT via PCH instead of AGCH. Eventually the BSC must sent a confirmation message (follow-up patch) where the TLLI is used as an identifer. This new method will eventually replace the previous method that uses the MAC block as an identifier. To remain compatible with older versions of osmo-bsc, we will keep the old method until osmo-bts is migrated as well. This patch also requires new features to be added to the PCU socket interface the version number of the protocol is incremented from 0x0a to 0x0b. Version 0x0a will remain compatible and use the old method, while version 0x0b will use the new method introduced with this patch. Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Related: OS#5198 --- M include/osmocom/pcu/pcuif_proto.h M src/bts.cpp M src/gprs_pcu.h M src/pcu_l1_if.cpp M src/pcu_l1_if.h 5 files changed, 77 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/45/31145/24 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Gerrit-Change-Number: 31145 Gerrit-PatchSet: 24 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-pcu[master]: bts: add IMMEDIATE ASSIGNMENT via PCH transmission
by dexter 06 Mar '23

06 Mar '23

Attention is currently required from: neels, pespin, fixeria, dexter. Hello Jenkins Builder, laforge, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 to look at the new patch set (#23). Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission ...................................................................... bts: add IMMEDIATE ASSIGNMENT via PCH transmission In situations where the PCU is co-located to the BSC, the IMMEDIATE ASSIGNMENT for downlink TBFs must be sent via RSL and the BSC also must instruct the BTS to transmit the IMMEDIATE ASSIGNMENT via PCH instead of AGCH. Eventually the BSC must sent a confirmation message (follow-up patch) where the TLLI is used as an identifer. This new method will eventually replace the previous method that uses the MAC block as an identifier. To remain compatible with older versions of osmo-bsc, we will keep the old method until osmo-bts is migrated as well. This patch also requires new features to be added to the PCU socket interface the version number of the protocol is incremented from 0x0a to 0x0b. Version 0x0a will remain compatible and use the old method, while version 0x0b will use the new method introduced with this patch. Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Related: OS#5198 --- M include/osmocom/pcu/pcuif_proto.h M src/bts.cpp M src/gprs_pcu.h M src/pcu_l1_if.cpp M src/pcu_l1_if.h 5 files changed, 78 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/45/31145/23 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Gerrit-Change-Number: 31145 Gerrit-PatchSet: 23 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-gsm-manuals[master]: Change upload path to project/master/
by osmith 06 Mar '23

06 Mar '23

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31688 to look at the new patch set (#2). Change subject: Change upload path to project/master/ ...................................................................... Change upload path to project/master/ Don't upload the manuals for master to "latest" anymore, this is confusing given that we also refer to the most recent release as "latest". Add the "master" directory to prepare a directory structure where we can have manuals for each release: osmo-hlr/ osmo-hlr/master/ osmo-hlr/master/osmohlr-usermanual.pdf osmo-hlr/master/osmohlr-vty-reference.pdf Related: OS#5902 Change-Id: Id090422afbd7b91ac78cc30e19372ac1c828cb6b --- M build/Makefile.common.inc 1 file changed, 33 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/88/31688/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31688 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Id090422afbd7b91ac78cc30e19372ac1c828cb6b Gerrit-Change-Number: 31688 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in osmocom-bb[master]: mobile: allow configuring local GSMTAP address
by msuraev 06 Mar '23

06 Mar '23

Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31661 ) Change subject: mobile: allow configuring local GSMTAP address ...................................................................... Patch Set 2: (1 comment) This change is ready for review. File src/host/layer23/src/common/vty.c: https://gerrit.osmocom.org/c/osmocom-bb/+/31661/comment/cd503c3a_d39de3cd PS1, Line 436: vty_out(vty, "gsmtap%s", VTY_NEWLINE); > You also need to print `local-host SOURCE` here if it's not NULL. Done -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31661 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia1555db653cf0bb20af74617f33aad31c971bfdb Gerrit-Change-Number: 31661 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 06 Mar 2023 16:08:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-gsm-manuals[master]: editorconfig: new file
by osmith 06 Mar '23

06 Mar '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31689 ) Change subject: editorconfig: new file ...................................................................... editorconfig: new file Add an editorconfig file so editors can figure out that the *.inc files should be indented with tabs. At least neovim would use spaces otherwise. Change-Id: I93f8fa0c1f2721d12183f33f4a14e13b2deed80b --- A .editorconfig 1 file changed, 26 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/89/31689/1 diff --git a/.editorconfig b/.editorconfig new file mode 100644 index 0000000..4da10e7 --- /dev/null +++ b/.editorconfig @@ -0,0 +1,13 @@ +; This file is for unifying the coding style for different editors and IDEs. +; See http://editorconfig.org for details. + +# Top-most EditorConfig file. +root = true + +[build/*.inc] +indent_size = 8 +indent_style = tab +end_of_line = lf +insert_final_newline = true +trim_trailing_whitespace = true + -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31689 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I93f8fa0c1f2721d12183f33f4a14e13b2deed80b Gerrit-Change-Number: 31689 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-gsm-manuals[master]: Change upload path to project/master/
by osmith 06 Mar '23

06 Mar '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31688 ) Change subject: Change upload path to project/master/ ...................................................................... Change upload path to project/master/ Don't upload the manuals for master to "latest" anymore, this is confusing given that we also refer to the most recent release as "latest". Add the "master" directory to prepare a directory structure where we can have manuals for each release: osmo-hlr/ osmo-hlr/master/ osmo-hlr/master/osmohlr-usermanual.pdf osmo-hlr/master/osmohlr-vty-reference.pdf Related: OS#5902 Change-Id: Id090422afbd7b91ac78cc30e19372ac1c828cb6b --- M build/Makefile.common.inc 1 file changed, 33 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/88/31688/1 diff --git a/build/Makefile.common.inc b/build/Makefile.common.inc index 0fda918..610361f 100644 --- a/build/Makefile.common.inc +++ b/build/Makefile.common.inc @@ -12,6 +12,8 @@ CLEAN_FILES += $(SYMLINKS) PDF_FILES = $(patsubst %.adoc,%.pdf,$(ASCIIDOC)) $(patsubst %.xml,%.pdf,$(VTY_REFERENCE)) OSMO_REPOSITORY ?= osmo-gsm-manuals +PUBLISH_REF ?= master +PUBLISH_TEMPDIR = _publish_tmpdir # Prefix (Makefile.am sets this to configure's --prefix when including) prefix ?= /usr/local @@ -28,7 +30,17 @@ distclean: clean publish: $(UPLOAD_FILES) - rsync -avz -e "$(SSH_COMMAND)" $(UPLOAD_FILES) docs@ftp.osmocom.org:web-files/latest/ + [ -n "$(OSMO_REPOSITORY)" ] || exit 1 + rm -rf "$(PUBLISH_TEMPDIR)" + mkdir -p "$(PUBLISH_TEMPDIR)/$(OSMO_REPOSITORY)/$(PUBLISH_REF)" + cp $(UPLOAD_FILES) "$(PUBLISH_TEMPDIR)/$(OSMO_REPOSITORY)/$(PUBLISH_REF)" + cd "$(PUBLISH_TEMPDIR)" && \ + rsync \ + -avzR \ + -e "$(SSH_COMMAND)" \ + "$(OSMO_REPOSITORY)" \ + docs@ftp.osmocom.org:web-files/ + rm -rf "$(PUBLISH_TEMPDIR)" # Install and uninstall targets # Notes about OSMO_GSM_MANUALS_NO_INSTALL: -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31688 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Id090422afbd7b91ac78cc30e19372ac1c828cb6b Gerrit-Change-Number: 31688 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0