March 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-msc[master]: codecs: compose HO Req Ch Type from cc.codecs
by pespin 07 Mar '23

07 Mar '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31703 ) Change subject: codecs: compose HO Req Ch Type from cc.codecs ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31703 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iba7a1a87ec5e6b487f763e84d60ed285da7b8fe1 Gerrit-Change-Number: 31703 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 11:41:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in osmo-msc[master]: [codecs filter] msc_vlr_test_call: test codecs resolution
by pespin 07 Mar '23

07 Mar '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31702 ) Change subject: [codecs filter] msc_vlr_test_call: test codecs resolution ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31702 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I879ec61f523ad4ffc69a0b02810591f7c0261ff9 Gerrit-Change-Number: 31702 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 11:41:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: mncc_recvmsg(): log caller file,line
by pespin 07 Mar '23

07 Mar '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31701 ) Change subject: mncc_recvmsg(): log caller file,line ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31701 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3755eb35b504f2f2580e0ba43dfa41f16087decc Gerrit-Change-Number: 31701 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 11:40:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-msc[master]: [codecs filter] use codecs filter on crcx ok
by pespin 07 Mar '23

07 Mar '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31700 ) Change subject: [codecs filter] use codecs filter on crcx ok ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31700 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I03753df567d1dc24852e6fbb681fbba81d2a545d Gerrit-Change-Number: 31700 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 11:39:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ci[master]: jobs: tweak build-discarder values
by fixeria 07 Mar '23

07 Mar '23

Attention is currently required from: osmith, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/31717 ) Change subject: jobs: tweak build-discarder values ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31717 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iec5c22c7fcf6c1fd2db71611045f15dc6580ed86 Gerrit-Change-Number: 31717 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 11:39:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-msc[master]: msc_vlr_tests: confirm crcx by RAN/CN side separately
by pespin 07 Mar '23

07 Mar '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31699 ) Change subject: msc_vlr_tests: confirm crcx by RAN/CN side separately ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31699 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I972e7426006e5b62f81ccfe4fa224ee9eed7a7ac Gerrit-Change-Number: 31699 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 11:37:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-msc[master]: [codecs filter] send + receive SDP via MNCC
by pespin 07 Mar '23

07 Mar '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31698 ) Change subject: [codecs filter] send + receive SDP via MNCC ...................................................................... Patch Set 3: (4 comments) File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/31698/comment/fa703bdc_dcd929f3 PS3, Line 633: codec_filter_run(&trans->cc.codecs); You are already calling codec_filter_run in line 621, why calling this again here? https://gerrit.osmocom.org/c/osmo-msc/+/31698/comment/0691b10a_6c2749c3 PS3, Line 935: codec_filter_run(&trans->cc.codecs); as usual, why is filter_run called here? is new_cc_state() changing it? https://gerrit.osmocom.org/c/osmo-msc/+/31698/comment/f0c76022_3b15e188 PS3, Line 973: codec_filter_run(&trans->cc.codecs); in here it makes sense to call _run() because you are calling set_remote() before? Or actually it has nothing to do with filtering codecs here. https://gerrit.osmocom.org/c/osmo-msc/+/31698/comment/57c0c86e_ef938ba3 PS3, Line 1084: codec_filter_run(&trans->cc.codecs); same ehre, why is all full of codec_filter_run? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31698 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie0668c0e079ec69da1532b52d00621efe114fc2c Gerrit-Change-Number: 31698 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 11:36:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-msc[master]: [codecs filter] use filter result in Assignment
by pespin 07 Mar '23

07 Mar '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30126 ) Change subject: [codecs filter] use filter result in Assignment ...................................................................... Patch Set 4: (2 comments) File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/30126/comment/f373c10f_ed1fb046 PS4, Line 1797: codec_filter_run(&trans->cc.codecs); why does this need to be called here? I see no codec being changed before it? File src/libmsc/msc_a.c: https://gerrit.osmocom.org/c/osmo-msc/+/30126/comment/3b25fee9_f06c8515 PS4, Line 1826: /* Make sure an MGW endpoint towards RAN is present, and when the RTP to RAN is set up, an Assignment Request is not sure what this comment is about. Is this a TODO? or is is it describing the code below? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30126 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I66e7c8c5e401f4f3a7d3d42b9525b2c6e99691d9 Gerrit-Change-Number: 30126 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 11:31:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-msc[master]: [codecs filter] use filter result in MT DTAP CC Setup
by pespin 07 Mar '23

07 Mar '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31697 ) Change subject: [codecs filter] use filter result in MT DTAP CC Setup ...................................................................... Patch Set 3: (2 comments) File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/31697/comment/5366c4c7_6a9f9af3 PS3, Line 711: .speech_ver = { -1 }, everything is starting to be full of magic values (-1). some UNSET defines would be great. https://gerrit.osmocom.org/c/osmo-msc/+/31697/comment/8d00e923_473951c4 PS3, Line 727: * finding a matching codec. */ but we can actually do some transoding already, like AMR BWE<->OA and AMR<->IuUP. Is this not contemplated here? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31697 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9586221ef56352b7ce4b2604ae0dc04554145a78 Gerrit-Change-Number: 31697 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 11:23:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-gsm-manuals[master]: Change upload path to project/master/
by osmith 07 Mar '23

07 Mar '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31688 ) Change subject: Change upload path to project/master/ ...................................................................... Change upload path to project/master/ Don't upload the manuals for master to "latest" anymore, this is confusing given that we also refer to the most recent release as "latest". Add the "master" directory to prepare a directory structure where we can have manuals for each release: osmo-hlr/ osmo-hlr/master/ osmo-hlr/master/osmohlr-usermanual.pdf osmo-hlr/master/osmohlr-vty-reference.pdf Related: OS#5902 Change-Id: Id090422afbd7b91ac78cc30e19372ac1c828cb6b --- M build/Makefile.common.inc 1 file changed, 33 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved msuraev: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/build/Makefile.common.inc b/build/Makefile.common.inc index 0fda918..a9a8ddf 100644 --- a/build/Makefile.common.inc +++ b/build/Makefile.common.inc @@ -12,6 +12,8 @@ CLEAN_FILES += $(SYMLINKS) PDF_FILES = $(patsubst %.adoc,%.pdf,$(ASCIIDOC)) $(patsubst %.xml,%.pdf,$(VTY_REFERENCE)) OSMO_REPOSITORY ?= osmo-gsm-manuals +PUBLISH_REF ?= master +PUBLISH_TEMPDIR = _publish_tmpdir # Prefix (Makefile.am sets this to configure's --prefix when including) prefix ?= /usr/local @@ -28,7 +30,17 @@ distclean: clean publish: $(UPLOAD_FILES) - rsync -avz -e "$(SSH_COMMAND)" $(UPLOAD_FILES) docs@ftp.osmocom.org:web-files/latest/ + [ -n "$(OSMO_REPOSITORY)" ] || exit 1 + rm -rf "$(PUBLISH_TEMPDIR)" + mkdir -p "$(PUBLISH_TEMPDIR)/$(OSMO_REPOSITORY)/$(PUBLISH_REF)" + cp $(UPLOAD_FILES) "$(PUBLISH_TEMPDIR)/$(OSMO_REPOSITORY)/$(PUBLISH_REF)" + cd "$(PUBLISH_TEMPDIR)" && \ + rsync \ + -avzR \ + -e "$(SSH_COMMAND)" \ + "$(OSMO_REPOSITORY)" \ + docs@ftp.osmocom.org:web-files/ + rm -rf "$(PUBLISH_TEMPDIR)" # Install and uninstall targets # Notes about OSMO_GSM_MANUALS_NO_INSTALL: -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31688 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Id090422afbd7b91ac78cc30e19372ac1c828cb6b Gerrit-Change-Number: 31688 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0