March 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-trx[master]: tests/CommonLibs: clean up Makefile.am
by fixeria 16 Mar '23

16 Mar '23

fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/31799 ) Change subject: tests/CommonLibs: clean up Makefile.am ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/31799 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I42713edd17a510aea8558c8b0f9cca98c46979b3 Gerrit-Change-Number: 31799 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon

1 0

[S] Change in osmo-gsm-manuals[master]: Fix mistypes
by vp 16 Mar '23

16 Mar '23

vp has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31925 ) Change subject: Fix mistypes ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Thanks for going the extra mile to not only report, but even submit a patch to our gerrit! That's a small "thank you" for all the effort put into making the documentation available. :) Also, I love that you self-host instead of going the easy, albeit short-sighted way of relying on the proprietary and unfortunately very popular Git hosting service. After account setup (which worked fine following the instructions), the actual changeset submission is simpler and faster than the PR workflow. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31925 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I87da6bec137c7be37ec748ec1f9f8d072517022d Gerrit-Change-Number: 31925 Gerrit-PatchSet: 1 Gerrit-Owner: vp <vilius(a)elitnet.lt> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Mar 2023 12:11:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: obs: add --git-skip-checkout argument
by fixeria 16 Mar '23

16 Mar '23

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/31934 ) Change subject: obs: add --git-skip-checkout argument ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31934 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ifc963daf51ba3542f67420daaf7b29745404a92e Gerrit-Change-Number: 31934 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Mar 2023 11:46:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: Fix Lb SCCP conn lookup after recent regression in optimization patch
by osmith 16 Mar '23

16 Mar '23

Attention is currently required from: neels, laforge, pespin, daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31940 ) Change subject: Fix Lb SCCP conn lookup after recent regression in optimization patch ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/bsc_sccp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31940/comment/afca7291_572032ad PS1, Line 91: "Trying to reserve already reserved conn_id %u\n", conn_id); > it's not really that important since anyway you can infer it from looking at the file+line number. Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If42d93adee71d646766929a09bc01ae92b734ef3 Gerrit-Change-Number: 31940 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Mar 2023 11:19:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: Fix Lb SCCP conn lookup after recent regression in optimization patch
by pespin 16 Mar '23

16 Mar '23

Attention is currently required from: osmith, neels, laforge, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31940 ) Change subject: Fix Lb SCCP conn lookup after recent regression in optimization patch ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/bsc_sccp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31940/comment/925b0d9b_8d58c5dd PS1, Line 91: "Trying to reserve already reserved conn_id %u\n", conn_id); > might be useful to mention in the log message that this is for Lb? it's not really that important since anyway you can infer it from looking at the file+line number. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If42d93adee71d646766929a09bc01ae92b734ef3 Gerrit-Change-Number: 31940 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Mar 2023 11:17:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: Fix Lb SCCP conn lookup after recent regression in optimization patch
by osmith 16 Mar '23

16 Mar '23

Attention is currently required from: osmith, neels, laforge, pespin, daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31940 ) Change subject: Fix Lb SCCP conn lookup after recent regression in optimization patch ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-bsc/bsc_sccp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31940/comment/6ec341de_4362ddd6 PS1, Line 91: "Trying to reserve already reserved conn_id %u\n", conn_id); might be useful to mention in the log message that this is for Lb? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If42d93adee71d646766929a09bc01ae92b734ef3 Gerrit-Change-Number: 31940 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Mar 2023 11:12:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: Limit maximum number of open file descriptors to overcome titan bug
by pespin 16 Mar '23

16 Mar '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31944 ) Change subject: Limit maximum number of open file descriptors to overcome titan bug ...................................................................... Limit maximum number of open file descriptors to overcome titan bug Without this, titan tries to allocate too much memory and triggers OOM under some systems (happening here with 16GB of RAM). Related: https://gitlab.eclipse.org/eclipse/titan/titan.core/-/issues/690 Change-Id: Iafa8cfa769386e63e1d879d8cce6e24b244d9a6f --- M start-testsuite.sh 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/44/31944/1 diff --git a/start-testsuite.sh b/start-testsuite.sh index a1e753d..4b88501 100755 --- a/start-testsuite.sh +++ b/start-testsuite.sh @@ -45,6 +45,10 @@ #TITAN_LIBRARY_PATH="$TTCN3_DIR/lib" #TTCN3_BIN_DIR="$TTCN3_DIR/bin" +# Limit max num of open file descriptors to workaround titan.core bug: +# https://gitlab.eclipse.org/eclipse/titan/titan.core/-/issues/690 +ulimit -n 100000 + # below is for the debian packages TTCN3_BIN_DIR="${TTCN3_BIN_DIR:-/usr/bin}" TITAN_LIBRARY_PATH="${TITAN_LIBRARY_PATH:-/usr/lib/titan:/usr/ttcn3/lib}" -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31944 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iafa8cfa769386e63e1d879d8cce6e24b244d9a6f Gerrit-Change-Number: 31944 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-upf[master]: contrib/jenkins: clone netfilter repos with https
by osmith 16 Mar '23

16 Mar '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/31941 ) Change subject: contrib/jenkins: clone netfilter repos with https ...................................................................... contrib/jenkins: clone netfilter repos with https Change-Id: Id50c5dac3cfebdf5cf33467ef24d7c4cf5984cdc --- M contrib/jenkins.sh 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 87290b3..8739baa 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -47,7 +47,7 @@ if [ -d "./$project" ]; then rm -rf "./$project" fi - git clone "git://git.netfilter.org/$project" "$project" + git clone "https://git.netfilter.org/$project" "$project" cd "$project" autoreconf --install --force ./configure \ -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/31941 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Id50c5dac3cfebdf5cf33467ef24d7c4cf5984cdc Gerrit-Change-Number: 31941 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-upf[master]: contrib/jenkins: build nftables without python
by osmith 16 Mar '23

16 Mar '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/31942 ) Change subject: contrib/jenkins: build nftables without python ...................................................................... contrib/jenkins: build nftables without python We don't use the python bindings of nftables with osmo-upf, so don't build them. Without this, it tries to build them with python2 for some reason and since a recent nftables commit it fails with: running install Checking .pth file support in /build/deps/install/stow/nftables/lib/python2.7/site-packages/ /usr/bin/python -E -c pass TEST FAILED: /build/deps/install/stow/nftables/lib/python2.7/site-packages/ does NOT support .pth files error: bad install directory or PYTHONPATH Change-Id: Ie172dca3e6953c353239173bca07b1f62fbf4c34 --- M contrib/jenkins.sh 1 file changed, 24 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index beb74dc..87290b3 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -50,7 +50,11 @@ git clone "git://git.netfilter.org/$project" "$project" cd "$project" autoreconf --install --force - ./configure --prefix="$inst/stow/$project" --without-cli --disable-man-doc + ./configure \ + --prefix="$inst/stow/$project" \ + --without-cli \ + --disable-man-doc \ + --enable-python=no $MAKE install STOW_DIR="$inst/stow" stow --restow $project } -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/31942 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ie172dca3e6953c353239173bca07b1f62fbf4c34 Gerrit-Change-Number: 31942 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-upf[master]: contrib/jenkins: netfilter: use PARALLEL_MAKE
by osmith 16 Mar '23

16 Mar '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/31943 ) Change subject: contrib/jenkins: netfilter: use PARALLEL_MAKE ...................................................................... contrib/jenkins: netfilter: use PARALLEL_MAKE Change-Id: Ia707f7411548c6d82bbb06b835a1930b30c447ec --- M contrib/jenkins.sh 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 8739baa..3b395ef 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -55,7 +55,7 @@ --without-cli \ --disable-man-doc \ --enable-python=no - $MAKE install + $MAKE $PARALLEL_MAKE install STOW_DIR="$inst/stow" stow --restow $project } build_from_netfilter libnftnl -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/31943 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ia707f7411548c6d82bbb06b835a1930b30c447ec Gerrit-Change-Number: 31943 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0