February 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-hnbgw[master]: add design charts for new context map FSMs

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31430 ) Change subject: add design charts for new context map FSMs ...................................................................... add design charts for new context map FSMs Planning new connection-oriented RUA and SCCP FSMs to - conquer confusion about hnbgw_context_map release behavior, and - eradicate SCCP connection leaks. Related: SYS#6297 Change-Id: I661bf65d79972a732c52732934095e8bfcd99694 --- M configure.ac M doc/Makefile.am A doc/charts/Makefile.am A doc/charts/hnbgw_context_map.msc A doc/charts/hnbgw_context_map_fsm.dot 5 files changed, 206 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 2027e9e..c23a90d 100644 --- a/configure.ac +++ b/configure.ac @@ -233,6 +233,7 @@ doc/Makefile doc/examples/Makefile doc/manuals/Makefile + doc/charts/Makefile contrib/Makefile contrib/systemd/Makefile contrib/osmo-hnbgw.spec diff --git a/doc/Makefile.am b/doc/Makefile.am index 15f36b7..66103ba 100644 --- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -1,4 +1,5 @@ SUBDIRS = \ examples \ manuals \ + charts \ $(NULL) diff --git a/doc/charts/Makefile.am b/doc/charts/Makefile.am new file mode 100644 index 0000000..52b111f --- /dev/null +++ b/doc/charts/Makefile.am @@ -0,0 +1,19 @@ +msc: \ + $(builddir)/hnbgw_context_map.png \ + $(NULL) + +dot: \ + $(builddir)/hnbgw_context_map_fsm.png \ + $(NULL) + +$(builddir)/%.png: $(srcdir)/%.msc + mscgen -T png -o $@ $< + +$(builddir)/%.png: $(srcdir)/%.dot + dot -Tpng $< > $@ + +.PHONY: poll +# remember current dir: in case the build process removes and recreates the dir, re-enter the new dir +W := "$(PWD)" +poll: + while true; do $(MAKE) -C $W msc dot; sleep 1; done diff --git a/doc/charts/hnbgw_context_map.msc b/doc/charts/hnbgw_context_map.msc new file mode 100644 index 0000000..7a4da55 --- /dev/null +++ b/doc/charts/hnbgw_context_map.msc @@ -0,0 +1,109 @@ +msc { + hscale="2"; + hnb[label="HNB"],rua[label="OsmoHNBGW\nRUA FSM / HNBAP"],sccp[label="OsmoHNBGW\nSCCP FSM"],cn[label="CN"]; + + hnb <=> rua [label="RANAP/RUA\n(Iuh)"]; + rua <=> sccp [label="FSM events"]; + sccp <=> cn [label="RANAP/SCCP/M3UA\n(IuCS, IuPS)"]; + + ...; + ...; + --- [label="Create a new context map (always from HNB)"]; + hnb => rua [label="RUA Connect\nRANAP InitialUE-Message\nDTAP Location Updating Request"]; + rua rbox sccp [label="hnbgw_context_map_alloc()"]; + rua abox rua [label="MAP_RUA_ST_INIT"]; + sccp abox sccp [label="MAP_SCCP_ST_INIT"]; + rua rbox rua [label="MAP_RUA_EV_RX_CONNECT\ndata = ranap_msg"]; + rua abox rua [label="MAP_RUA_ST_CONNECTED"]; + rua => sccp [label="MAP_SCCP_EV_TX_RANAP_MSG\ndata = ranap_msg"]; + sccp abox sccp [label="MAP_SCCP_ST_WAIT_CC"]; + sccp => cn [label="SCCP Connection Request\nRANAP InitialUE-Message\nDTAP Location Updating Request"]; + ...; + sccp <= cn [label="SCCP Connection Confirm"]; + sccp abox sccp [label="MAP_SCCP_ST_CONNECTED"]; + --- [label="if SCCP CC with payload"]; + rua <= sccp [label="MAP_RUA_EV_TX_RANAP_MSG\ndata = ranap_msg"]; + hnb <= rua [label="RUA DirectTransfer"]; + + ...; + ...; + --- [label="Layer 3 communication"]; + sccp <= cn [label="SCCP Data Form 1"]; + rua <= sccp [label="MAP_RUA_EV_TX_RANAP_MSG\ndata = ranap_msg"]; + hnb <= rua [label="RUA DirectTransfer"]; + ...; + hnb => rua [label="RUA DirectTransfer"]; + rua => sccp [label="MAP_SCCP_EV_TX_RANAP_MSG\ndata = ranap_msg"]; + sccp => cn [label="SCCP Data Form 1"]; + + ...; + ...; + --- [label="Usual release"]; + sccp <= cn [label="SCCP Data Form 1\nIu-ReleaseCommand"]; + rua <= sccp [label="MAP_RUA_EV_TX_RANAP_MSG\ndata = ranap_msg"]; + hnb <= rua [label="RUA DirectTransfer\nIu-ReleaseCommand"]; + ...; + hnb => rua [label="RUA Disconnect\nIu-ReleaseComplete"]; + rua rbox rua [label="MAP_RUA_EV_RX_DISCONNECT"]; + rua abox rua [label="MAP_RUA_ST_DISCONNECTED"]; + rua => sccp [label="MAP_SCCP_EV_RAN_DISC\ndata = ranap_msg"]; + sccp => cn [label="SCCP Data Form 1\nIu-ReleaseComplete\nNOT 'SCCP Released'! See 3GPP TS 48.006 9.2"]; + sccp abox sccp [label="MAP_SCCP_ST_WAIT_RLSD"]; + ...; + sccp <= cn [label="SCCP Released"]; + sccp abox sccp [label="MAP_SCCP_ST_DISCONNECTED"]; + rua rbox sccp [label="map_check_released()"]; + rua rbox sccp [label="hnbgw_context_map_free()"]; + + ...; + ...; + --- [label="Ungraceful release from CN"]; + sccp <= cn [label="SCCP Released"]; + sccp => cn [label="SCCP Release Complete\n(implicit by libosmo-sigtran)"]; + sccp rbox sccp [label="MAP_SCCP_EV_RX_RELEASED"]; + sccp note sccp [label="In SCCP there is no \"link loss\".\nIn every case, we will be notified\nvia N-Disconnect prim per SCCP conn."]; + sccp abox sccp [label="MAP_SCCP_ST_DISCONNECTED"]; + rua <= sccp [label="MAP_RUA_EV_CN_DISC"]; + hnb <= rua [label="RUA Disconnect"]; + rua abox rua [label="MAP_RUA_ST_DISCONNECTED"]; + rua rbox sccp [label="map_check_released()"]; + rua rbox sccp [label="hnbgw_context_map_free()"]; + + ...; + ...; + ...; + --- [label="PCSTATE handling"]; + sccp << cn [label="N-PCSTATE.indication\npoint-code unreachable"]; + sccp note sccp [label="currently ignored"]; + + ...; + ...; + --- [label="Ungraceful release from HNB"]; + hnb -x rua [label="link loss"]; + rua rbox rua [label="MAP_RUA_EV_HNB_LINK_LOST"]; + rua => sccp [label="MAP_SCCP_EV_RAN_DISC"]; + sccp => cn [label="SCCP Released"]; + sccp abox sccp [label="MAP_SCCP_ST_DISCONNECTED"]; + rua abox rua [label="MAP_RUA_ST_DISCONNECTED"]; + rua rbox sccp [label="map_check_released()"]; + rua rbox sccp [label="hnbgw_context_map_free()"]; + + ...; + ...; + --- [label="Ungraceful release from HNB De-Register"]; + hnb => rua [label="HNBAP HNB De-Register"]; + --- [label="or"]; + hnb => rua [label="HNBAP HNB Register\n(HNB restarted)"]; + ---; + rua rbox rua [label="MAP_RUA_EV_HNB_LINK_LOST"]; + hnb <= rua [label="RUA Disconnect"]; + hnb note rua [label="TODO: does it make sense to send\nRUA Disconnect per context when HNB is/was gone?\nOr has the HNB implicitly discarded these?"]; + rua abox rua [label="MAP_RUA_ST_DISCONNECTED"]; + rua => sccp [label="MAP_SCCP_EV_RAN_DISC\nfrom map_rua_disconnected_onenter()"]; + sccp abox sccp [label="MAP_SCCP_ST_WAIT_RLSD"]; + rua => sccp [label="MAP_SCCP_EV_RAN_DISC\nto skip waiting for SCCP Released from CN"]; + sccp => cn [label="SCCP Released"]; + sccp abox sccp [label="MAP_SCCP_ST_DISCONNECTED"]; + rua rbox sccp [label="map_check_released()"]; + rua rbox sccp [label="hnbgw_context_map_free()"]; +} diff --git a/doc/charts/hnbgw_context_map_fsm.dot b/doc/charts/hnbgw_context_map_fsm.dot new file mode 100644 index 0000000..c71032b --- /dev/null +++ b/doc/charts/hnbgw_context_map_fsm.dot @@ -0,0 +1,62 @@ +digraph G { +rankdir=TB +labelloc=t +label="hnb_context_map\nRUA and SCCP FSMs" + +HNB_connect [label="HNB",shape=box3d] +rua_to_scu_connect [label="rua_to_scu()",shape=box] +HNB_DT [label="HNB",shape=box3d] +rua_to_scu_DT [label="rua_to_scu()",shape=box] +HNB_DT2 [label="HNB",shape=box3d] +HNB_disconnect [label="HNB",shape=box3d] +rua_to_scu_disconnect [label="rua_to_scu()",shape=box] +CN [shape=box3d] +CN2 [label="CN",shape=box3d] +CN3 [label="CN",shape=box3d] +CN4 [label="CN",shape=box3d] + +HNB_connect -> rua_to_scu_connect [label="RUA Connect",style=dotted] +rua_to_scu_connect -> create [label="(1)",style=dotted] +create [label="hnbgw_context_map_alloc()",shape=box] +create -> {RUA_INIT,SCCP_INIT} [label="(1)",style="dashed,bold"] + +rua_to_scu_connect -> RUA_CONNECTED [label="(2)\nMAP_RUA_EV_RX_CONNECT",style=dashed] +RUA_CONNECTED -> SCCP_WAIT_CC [label="(2)\nMAP_SCCP_EV_TX_RANAP_MSG",style=dashed] + +RUA_INIT -> RUA_CONNECTED -> RUA_DISCONNECTED [style=bold] + +SCCP_INIT -> SCCP_WAIT_CC -> SCCP_CONNECTED -> SCCP_WAIT_RLSD -> SCCP_DISCONNECTED [style=bold] +SCCP_CONNECTED -> SCCP_DISCONNECTED [label="SCCP RLSD"] + +SCCP_WAIT_CC -> CN [label="(2) SCCP CR",style=dotted] +CN -> SCCP_CONNECTED [label="(3) SCCP CC",style=dashed] + +CN4 -> SCCP_CONNECTED [label="(4) SCCP\nData Form 1",style=dotted] +SCCP_CONNECTED -> RUA_CONNECTED [label="(4)\nMAP_RUA_EV_TX_RANAP_MSG",style=dotted] +RUA_CONNECTED -> HNB_DT2 [label="(4)\nRUA DirectTransfer",style=dotted] + +HNB_DT -> rua_to_scu_DT [label="(5)\nRUA DirectTransfer",style=dotted] +rua_to_scu_DT -> RUA_CONNECTED [label="(5)\nMAP_RUA_EV_RX_DIRECT_TRANSFER",style=dotted] +RUA_CONNECTED -> SCCP_CONNECTED [label="(5)\nMAP_SCCP_EV_TX_RANAP_MSG",style=dotted] +SCCP_CONNECTED -> CN3 [label="(5) SCCP\nData Form 1",style=dotted] + +HNB_disconnect -> rua_to_scu_disconnect [label="(6) RUA Id-Disconnect",style=dotted] +rua_to_scu_disconnect -> RUA_DISCONNECTED [label="(6) MAP_RUA_EV_RX_DISCONNECT",style=dashed] +RUA_DISCONNECTED -> SCCP_WAIT_RLSD [label="(6) MAP_SCCP_EV_RAN_DISC",style=dashed] + +CN2 -> SCCP_DISCONNECTED [label="(7) SCCP RLSD",style=dashed] + +{RUA_DISCONNECTED,SCCP_DISCONNECTED} -> release [label="onenter",style="dotted,bold"] +release [label="map_check_released()",shape=box] +release -> terminate [label="when both RUA and\nSCCP disconnected",style=dotted] +terminate [label="hnbgw_context_map_free()",shape=octagon] + +subgraph cluster_legend { + label="" + style=invisible + A, B, C, D [style=invisible] + A -> B [label="event without\nstate change",style=dotted] + C -> D [label="event changes\nstate to...",style=dashed] +} + +} -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31430 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I661bf65d79972a732c52732934095e8bfcd99694 Gerrit-Change-Number: 31430 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: cosmetic: regroup members of hnbgw_context_map

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31463 ) Change subject: cosmetic: regroup members of hnbgw_context_map ...................................................................... cosmetic: regroup members of hnbgw_context_map Change the order in the struct definition so that the items for RUA and for SCCP are grouped together. Tweak comments. Change-Id: I84424617996d8e1a6814aa122e63454c0666b724 --- M include/osmocom/hnbgw/context_map.h 1 file changed, 23 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/include/osmocom/hnbgw/context_map.h b/include/osmocom/hnbgw/context_map.h index 97e1b09..7bcdf57 100644 --- a/include/osmocom/hnbgw/context_map.h +++ b/include/osmocom/hnbgw/context_map.h @@ -28,23 +28,26 @@ struct hnbgw_context_map { /* entry in the per-CN list of mappings */ struct llist_head cn_list; - /* entry in the per-HNB list of mappings */ + /* entry in the per-HNB list of mappings. */ struct llist_head hnb_list; - /* pointer to HNB */ + + /* Pointer to HNB for this map, to transceive RUA. */ struct hnb_context *hnb_ctx; - /* pointer to CN */ - struct hnbgw_cnlink *cn_link; - /* RUA contxt ID */ + /* RUA context ID used in RUA messages to/from the hnb_gw. */ uint32_t rua_ctx_id; - /* False for CS, true for PS */ - bool is_ps; - /* SCCP User SAP connection ID */ + + /* Pointer to CN, to transceive SCCP. */ + struct hnbgw_cnlink *cn_link; + /* SCCP User SAP connection ID used in SCCP messages to/from the cn_link. */ uint32_t scu_conn_id; /* Set to true on SCCP Conn Conf, set to false when an OSMO_SCU_PRIM_N_DISCONNECT has been sent for the SCCP * User SAP conn. Useful to avoid leaking SCCP connections: guarantee that an OSMO_SCU_PRIM_N_DISCONNECT gets * sent, even when RUA fails to gracefully disconnect. */ bool scu_conn_active; + /* False for CS, true for PS */ + bool is_ps; + enum hnbgw_context_map_state state; /* FSM instance for the MGW, handles the async MGCP communication necessary to intercept CS RAB Assignment and -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I84424617996d8e1a6814aa122e63454c0666b724 Gerrit-Change-Number: 31463 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

[M] Change in osmo-hnbgw[master]: use RUA procedure code for rua_to_scu() arg

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31462 ) Change subject: use RUA procedure code for rua_to_scu() arg ...................................................................... use RUA procedure code for rua_to_scu() arg Instead of osmo_scu_prim_type, use RUA_ProcedureCode to tell rua_to_scu() the RUA message type being handled. Cosmetically prepare for upcoming patch that completely moves osmo_scu_prim composition from rua_to_scu() to a new context map SCCP FSM. Related: I6ff7e36532ff57c6f2d3e7e419dd22ef27dafd19 Change-Id: I28735945844f732e7bd7f09db1f453c608415b84 --- M src/osmo-hnbgw/hnbgw_rua.c 1 file changed, 51 insertions(+), 16 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-hnbgw/hnbgw_rua.c b/src/osmo-hnbgw/hnbgw_rua.c index b979cd1..97ced4a 100644 --- a/src/osmo-hnbgw/hnbgw_rua.c +++ b/src/osmo-hnbgw/hnbgw_rua.c @@ -174,13 +174,27 @@ return hnbgw_rua_tx(hnb, msg); } +static struct value_string rua_procedure_code_names[] = { + { RUA_ProcedureCode_id_Connect, "Connect" }, + { RUA_ProcedureCode_id_DirectTransfer, "DirectTransfer" }, + { RUA_ProcedureCode_id_Disconnect, "Disconnect" }, + { RUA_ProcedureCode_id_ConnectionlessTransfer, "ConnectionlessTransfer" }, + { RUA_ProcedureCode_id_ErrorIndication, "ErrorIndication" }, + { RUA_ProcedureCode_id_privateMessage, "PrivateMessage" }, + {} +}; + +static inline const char *rua_procedure_code_name(enum RUA_ProcedureCode val) +{ + return get_value_string(rua_procedure_code_names, val); +} /* dispatch a RUA connection-oriented message received from a HNB to a context mapping's RUA FSM, so that it is * forwarded to the CN via SCCP connection-oriented messages. * Connectionless messages are handled in hnbgw_ranap_rx() instead, not here. */ static int rua_to_scu(struct hnb_context *hnb, RUA_CN_DomainIndicator_t cN_DomainIndicator, - enum osmo_scu_prim_type type, + enum RUA_ProcedureCode rua_procedure, uint32_t context_id, uint32_t cause, const uint8_t *data, unsigned int len) { @@ -216,20 +230,18 @@ msg = msgb_alloc(1500, "rua_to_sccp"); prim = (struct osmo_scu_prim *) msgb_put(msg, sizeof(*prim)); - osmo_prim_init(&prim->oph, SCCP_SAP_USER, type, PRIM_OP_REQUEST, msg); - - /* Only connection-oriented messages are handled by this function */ - OSMO_ASSERT(type != OSMO_SCU_PRIM_N_UNITDATA); map = context_map_alloc_by_hnb(hnb, context_id, is_ps, cn); OSMO_ASSERT(map); - LOGHNB(hnb, DRUA, LOGL_DEBUG, "rua_to_scu() %s to %s, rua_ctx_id %u scu_conn_id %u\n", - cn_domain_indicator_to_str(cN_DomainIndicator), osmo_sccp_addr_dump(remote_addr), - map->rua_ctx_id, map->scu_conn_id); + + LOG_MAP(map, DRUA, LOGL_DEBUG, "rx RUA %s with %u bytes RANAP data\n", + rua_procedure_code_name(rua_procedure), data ? len : 0); /* add primitive header */ - switch (type) { - case OSMO_SCU_PRIM_N_CONNECT: + switch (rua_procedure) { + + case RUA_ProcedureCode_id_Connect: + osmo_prim_init(&prim->oph, SCCP_SAP_USER, OSMO_SCU_PRIM_N_CONNECT, PRIM_OP_REQUEST, msg); prim->u.connect.called_addr = *remote_addr; prim->u.connect.calling_addr = cn->gw->sccp.local_addr; prim->u.connect.sccp_class = 2; @@ -240,18 +252,24 @@ LOGHNB(hnb, DRUA, LOGL_DEBUG, "RUA to SCCP N_CONNECT: calling_addr:%s\n", osmo_sccp_addr_dump(&prim->u.connect.calling_addr)); break; - case OSMO_SCU_PRIM_N_DATA: + + case RUA_ProcedureCode_id_DirectTransfer: + osmo_prim_init(&prim->oph, SCCP_SAP_USER, OSMO_SCU_PRIM_N_DATA, PRIM_OP_REQUEST, msg); prim->u.data.conn_id = map->scu_conn_id; break; - case OSMO_SCU_PRIM_N_DISCONNECT: + + case RUA_ProcedureCode_id_Disconnect: + osmo_prim_init(&prim->oph, SCCP_SAP_USER, OSMO_SCU_PRIM_N_DISCONNECT, PRIM_OP_REQUEST, msg); prim->u.disconnect.conn_id = map->scu_conn_id; prim->u.disconnect.cause = cause; release_context_map = true; /* Mark SCCP conn as gracefully disconnected */ map->scu_conn_active = false; break; + default: - return -EINVAL; + /* No caller may ever pass a different RUA procedure code */ + OSMO_ASSERT(false); } /* If there is RANAP data, include it in the msgb. Usually there is data, but this could also be an SCCP CR @@ -385,7 +403,7 @@ cn_domain_indicator_to_str(ies.cN_DomainIndicator), context_id, ies.establishment_Cause == RUA_Establishment_Cause_emergency_call ? "emergency" : "normal"); - rc = rua_to_scu(hnb, ies.cN_DomainIndicator, OSMO_SCU_PRIM_N_CONNECT, + rc = rua_to_scu(hnb, ies.cN_DomainIndicator, RUA_ProcedureCode_id_Connect, context_id, 0, ies.ranaP_Message.buf, ies.ranaP_Message.size); @@ -420,7 +438,7 @@ } rc = rua_to_scu(hnb, ies.cN_DomainIndicator, - OSMO_SCU_PRIM_N_DISCONNECT, + RUA_ProcedureCode_id_Disconnect, context_id, scu_cause, ranap_data, ranap_len); rua_free_disconnecties(&ies); @@ -445,7 +463,7 @@ rc = rua_to_scu(hnb, ies.cN_DomainIndicator, - OSMO_SCU_PRIM_N_DATA, + RUA_ProcedureCode_id_DirectTransfer, context_id, 0, ies.ranaP_Message.buf, ies.ranaP_Message.size); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31462 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I28735945844f732e7bd7f09db1f453c608415b84 Gerrit-Change-Number: 31462 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: cosmetic: rename context_map_deactivate

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31459 ) Change subject: cosmetic: rename context_map_deactivate ...................................................................... cosmetic: rename context_map_deactivate Rename context_map_deactivate() to context_map_hnb_released(). This function is called only when the HNB is released / lost. Change-Id: I6dcb26c94558fff28faf8f823e490967a9baf2ec --- M include/osmocom/hnbgw/context_map.h M src/osmo-hnbgw/context_map.c M src/osmo-hnbgw/hnbgw.c M src/osmo-hnbgw/hnbgw_rua.c 4 files changed, 17 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/include/osmocom/hnbgw/context_map.h b/include/osmocom/hnbgw/context_map.h index 3a145b6..97e1b09 100644 --- a/include/osmocom/hnbgw/context_map.h +++ b/include/osmocom/hnbgw/context_map.h @@ -79,6 +79,6 @@ struct hnbgw_context_map * context_map_by_cn(struct hnbgw_cnlink *cn, uint32_t scu_conn_id); -void context_map_deactivate(struct hnbgw_context_map *map); +void context_map_hnb_released(struct hnbgw_context_map *map); int context_map_init(struct hnb_gw *gw); diff --git a/src/osmo-hnbgw/context_map.c b/src/osmo-hnbgw/context_map.c index 96365fb..9816918 100644 --- a/src/osmo-hnbgw/context_map.c +++ b/src/osmo-hnbgw/context_map.c @@ -150,7 +150,7 @@ return NULL; } -void context_map_deactivate(struct hnbgw_context_map *map) +void context_map_hnb_released(struct hnbgw_context_map *map) { LOG_MAP(map, DMAIN, LOGL_INFO, "Deactivating\n"); diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c index da6df43..322dabe 100644 --- a/src/osmo-hnbgw/hnbgw.c +++ b/src/osmo-hnbgw/hnbgw.c @@ -402,7 +402,7 @@ * map garbage collector works fine? */ llist_del(&map->hnb_list); llist_del(&map->cn_list); - context_map_deactivate(map); + context_map_hnb_released(map); } ue_context_free_by_hnb(ctx->gw, ctx); } diff --git a/src/osmo-hnbgw/hnbgw_rua.c b/src/osmo-hnbgw/hnbgw_rua.c index 5581148..3af0ad6 100644 --- a/src/osmo-hnbgw/hnbgw_rua.c +++ b/src/osmo-hnbgw/hnbgw_rua.c @@ -313,7 +313,7 @@ rc = osmo_sccp_user_sap_down(cn->sccp_user, &prim->oph); if (map && release_context_map) - context_map_deactivate(map); + context_map_hnb_released(map); return rc; } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31459 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I6dcb26c94558fff28faf8f823e490967a9baf2ec Gerrit-Change-Number: 31459 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: rua_to_scu(): drop dead code for connection-less

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31461 ) Change subject: rua_to_scu(): drop dead code for connection-less ...................................................................... rua_to_scu(): drop dead code for connection-less From rua_to_scu(), drop dead code for connection-less messages. In fact, rua_to_scu() is only used for connection-oriented messages. Clarify that. Change-Id: Id03c412cde066a6b2bbc26cb6b87053aa2408cba --- M src/osmo-hnbgw/hnbgw_rua.c 1 file changed, 24 insertions(+), 23 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-hnbgw/hnbgw_rua.c b/src/osmo-hnbgw/hnbgw_rua.c index 6ef7d30..b979cd1 100644 --- a/src/osmo-hnbgw/hnbgw_rua.c +++ b/src/osmo-hnbgw/hnbgw_rua.c @@ -175,8 +175,9 @@ } - -/* forward a RUA message to the SCCP User API to SCCP */ +/* dispatch a RUA connection-oriented message received from a HNB to a context mapping's RUA FSM, so that it is + * forwarded to the CN via SCCP connection-oriented messages. + * Connectionless messages are handled in hnbgw_ranap_rx() instead, not here. */ static int rua_to_scu(struct hnb_context *hnb, RUA_CN_DomainIndicator_t cN_DomainIndicator, enum osmo_scu_prim_type type, @@ -217,18 +218,14 @@ prim = (struct osmo_scu_prim *) msgb_put(msg, sizeof(*prim)); osmo_prim_init(&prim->oph, SCCP_SAP_USER, type, PRIM_OP_REQUEST, msg); - switch (type) { - case OSMO_SCU_PRIM_N_UNITDATA: - LOGHNB(hnb, DRUA, LOGL_DEBUG, "rua_to_scu() %s to %s, rua_ctx_id %u (unitdata, no scu_conn_id)\n", - cn_domain_indicator_to_str(cN_DomainIndicator), osmo_sccp_addr_dump(remote_addr), context_id); - break; - default: - map = context_map_alloc_by_hnb(hnb, context_id, is_ps, cn); - OSMO_ASSERT(map); - LOGHNB(hnb, DRUA, LOGL_DEBUG, "rua_to_scu() %s to %s, rua_ctx_id %u scu_conn_id %u\n", - cn_domain_indicator_to_str(cN_DomainIndicator), osmo_sccp_addr_dump(remote_addr), - map->rua_ctx_id, map->scu_conn_id); - } + /* Only connection-oriented messages are handled by this function */ + OSMO_ASSERT(type != OSMO_SCU_PRIM_N_UNITDATA); + + map = context_map_alloc_by_hnb(hnb, context_id, is_ps, cn); + OSMO_ASSERT(map); + LOGHNB(hnb, DRUA, LOGL_DEBUG, "rua_to_scu() %s to %s, rua_ctx_id %u scu_conn_id %u\n", + cn_domain_indicator_to_str(cN_DomainIndicator), osmo_sccp_addr_dump(remote_addr), + map->rua_ctx_id, map->scu_conn_id); /* add primitive header */ switch (type) { @@ -253,15 +250,6 @@ /* Mark SCCP conn as gracefully disconnected */ map->scu_conn_active = false; break; - case OSMO_SCU_PRIM_N_UNITDATA: - prim->u.unitdata.called_addr = *remote_addr; - prim->u.unitdata.calling_addr = cn->gw->sccp.local_addr; - /* Two separate logs because of osmo_sccp_addr_dump(). */ - LOGHNB(hnb, DRUA, LOGL_DEBUG, "RUA to SCCP N_UNITDATA: called_addr:%s\n", - osmo_sccp_addr_dump(&prim->u.unitdata.called_addr)); - LOGHNB(hnb, DRUA, LOGL_DEBUG, "RUA to SCCP N_UNITDATA: calling_addr:%s\n", - osmo_sccp_addr_dump(&prim->u.unitdata.calling_addr)); - break; default: return -EINVAL; } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31461 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Id03c412cde066a6b2bbc26cb6b87053aa2408cba Gerrit-Change-Number: 31461 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: fix deprecation: use ranap_cn_rx_co_decode2()

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31460 ) Change subject: fix deprecation: use ranap_cn_rx_co_decode2() ...................................................................... fix deprecation: use ranap_cn_rx_co_decode2() Change-Id: I867cbf174beab1eefddc682c1420737e49f9e50d --- M src/osmo-hnbgw/hnbgw_rua.c M tests/ranap_rab_ass/ranap_rab_ass_test.c 2 files changed, 15 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-hnbgw/hnbgw_rua.c b/src/osmo-hnbgw/hnbgw_rua.c index 3af0ad6..6ef7d30 100644 --- a/src/osmo-hnbgw/hnbgw_rua.c +++ b/src/osmo-hnbgw/hnbgw_rua.c @@ -278,7 +278,7 @@ if (data && len && map && !release_context_map) { if (!map->is_ps) { message = talloc_zero(map, ranap_message); - rc = ranap_cn_rx_co_decode(map, message, msgb_l2(prim->oph.msg), msgb_l2len(prim->oph.msg)); + rc = ranap_cn_rx_co_decode2(message, msgb_l2(prim->oph.msg), msgb_l2len(prim->oph.msg)); if (rc == 0) { switch (message->procedureCode) { @@ -294,7 +294,7 @@ } else if (hnb_gw_is_gtp_mapping_enabled(hnb->gw)) { /* map->is_ps == true and PFCP is enabled in osmo-hnbgw.cfg */ message = talloc_zero(map, ranap_message); - rc = ranap_cn_rx_co_decode(map, message, msgb_l2(prim->oph.msg), msgb_l2len(prim->oph.msg)); + rc = ranap_cn_rx_co_decode2(message, msgb_l2(prim->oph.msg), msgb_l2len(prim->oph.msg)); if (rc == 0) { switch (message->procedureCode) { diff --git a/tests/ranap_rab_ass/ranap_rab_ass_test.c b/tests/ranap_rab_ass/ranap_rab_ass_test.c index f4e7999..03b0836 100644 --- a/tests/ranap_rab_ass/ranap_rab_ass_test.c +++ b/tests/ranap_rab_ass/ranap_rab_ass_test.c @@ -86,7 +86,7 @@ }; uint8_t encoded[sizeof(testvec)]; - rc = ranap_cn_rx_co_decode(talloc_asn1_ctx, &message, testvec, sizeof(testvec)); + rc = ranap_cn_rx_co_decode2(&message, testvec, sizeof(testvec)); OSMO_ASSERT(rc == 0); rc = ranap_rab_ass_resp_encode(encoded, sizeof(encoded), &message.msg.raB_AssignmentResponseIEs); @@ -145,7 +145,7 @@ 0x00, 0x40, 0x04, 0x0a, 0x00, 0x00 }; - rc = ranap_cn_rx_co_decode(talloc_asn1_ctx, &message, testvec, sizeof(testvec)); + rc = ranap_cn_rx_co_decode2(&message, testvec, sizeof(testvec)); OSMO_ASSERT(rc == 0); rc = ranap_rab_ass_resp_ies_extract_inet_addr(&addr, &message.msg.raB_AssignmentResponseIEs, 7); osmo_sockaddr_str_from_sockaddr(&addr_str, &addr.u.sas); @@ -245,7 +245,7 @@ 0x00, 0x40, 0x04, 0xd2, 0x00, 0x00 }; - rc = ranap_cn_rx_co_decode(talloc_asn1_ctx, &message, testvec_in, sizeof(testvec_in)); + rc = ranap_cn_rx_co_decode2(&message, testvec_in, sizeof(testvec_in)); OSMO_ASSERT(rc == 0); rc = ranap_rab_ass_resp_ies_extract_inet_addr(&addr, &message.msg.raB_AssignmentResponseIEs, 6); @@ -285,7 +285,7 @@ 0x40, 0x03, 0x05, 0xd0, 0x00 }; - rc = ranap_cn_rx_co_decode(talloc_asn1_ctx, &message, testvec, sizeof(testvec)); + rc = ranap_cn_rx_co_decode2(&message, testvec, sizeof(testvec)); OSMO_ASSERT(rc == 0); rab_failed_at_hnb = -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31460 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I867cbf174beab1eefddc682c1420737e49f9e50d Gerrit-Change-Number: 31460 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

[XL] Change in osmo-hnbgw[master]: context map: introduce RUA and SCCP FSMs to fix leaks

by neels

Attention is currently required from: laforge, pespin, msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431 ) Change subject: context map: introduce RUA and SCCP FSMs to fix leaks ...................................................................... Patch Set 6: (5 comments) File include/osmocom/hnbgw/context_map.h: https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431/comment/48b49e44_1257e896 PS6, Line 18: * - For events that may send a RANAP message towards CN via SCCP, the msgb shall have reserved headrom to fit a struct > typo: headroom lol head-ROM =) File src/osmo-hnbgw/context_map_rua.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431/comment/25581165_5e5caf15 PS6, Line 57: * Assumes local variable fi exists. */ > That's very confusing - better make no assumptions and pass all variables explicitly. […] I agree with the principle but this one is the exception; 'fi' is literally everywhere in an fsm implementation .c file. We use a macro like this in pretty much all osmo_fsm implementation .c files. File src/osmo-hnbgw/context_map_sccp.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431/comment/0054f0c6_281a465d PS6, Line 63: * Assumes local variable fi exists. */ > Same here. Done File src/osmo-hnbgw/hnbgw.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431/comment/058fe4fa_a38f7bce PS6, Line 862: ranap_msg = msgb_alloc_c(OTC_SELECT, sizeof(struct osmo_scu_prim) + 1500, name); > Where does 1500 comes from? that's a good question, I took it from prior code. Actually, before, osmo-hnbgw would reserve 1500 in *total*, and would even subtract from that the headroom required for osmo_scu_prim; so apparently all RANAP messages that osmo-hnbgw processed so far are way shorter than that. Maybe it comes from the common MTU = 1500? File src/osmo-hnbgw/hnbgw_rua.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431/comment/0082d02a_a53af90a PS6, Line 230: msg = msgb_alloc(1500, "rua_to_sccp"); (this is where I took 1500 from; note that it first puts the prim, and then the ranap in l2h below) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I6ff7e36532ff57c6f2d3e7e419dd22ef27dafd19 Gerrit-Change-Number: 31431 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Feb 2023 14:19:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[XL] Change in osmo-hnbgw[master]: context map: introduce RUA and SCCP FSMs to fix leaks

by neels

Attention is currently required from: neels, laforge, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431 to look at the new patch set (#7). Change subject: context map: introduce RUA and SCCP FSMs to fix leaks ...................................................................... context map: introduce RUA and SCCP FSMs to fix leaks Refactor the entire RUA <-> SCCP connection-oriented message forwarding: - conquer confusion about hnbgw_context_map release behavior, and - eradicate SCCP connection leaks. Finer points: == Context map state == So far, we had a single context map state and some flags to keep track of both the RUA and the SCCP connections. It was easy to miss connection cleanup steps, especially on the SCCP side. Instead, the two FSMs clearly define the RUA and SCCP conn states separately, and each side takes care of its own release needs for all possible scenarios. - When both RUA and SCCP are released, the context map is discarded. - A context map can stay around to wait for proper SCCP release, even if the RUA side has lost the HNB connection. - Completely drop the async "context mapper garbage collection", because the FSMs clarify the release and free steps, synchronously. - We still keep a (simplified) enum for global context map state, but this is only used so that VTY reporting remains mostly unchanged. == Context map cleanup confusion == The function context_map_hnb_released() was the general cleanup function for a context map. Instead, add separate context_map_free(). == Free context maps separately from HNB == When a HNB releases, talloc_steal() the context maps out of the HNB specific hnb_ctx, so that they are not freed along with the HNB state, possibly leaving SCCP connections afloat. (It is still nice to normally keep context maps as talloc children of their respective hnb_ctx, so talloc reports show which belongs to which.) So far, context map handling found the global hnb_gw pointer via map->hnb_ctx->gw. But in fact, a HNB may disappear at any point in time. Instead, use a separate hnb_gw pointer in map->gw. == RUA procedure codes vs. SCCP prims == So far, the RUA rx side composed SCCP prims to pass on: RUA rx ---SCCP-prim--> RANAP handling ---SCCP-prim--> SCCP tx That is a source of confusion: a RUA procedure code should not translate 1:1 to SCCP prims, especially for RUA id-Disconnect (see release charts below). Instead, move SCCP prim composition over to the SCCP side, using FSM events to forward: RUA rx --event--> RUA FSM --event--> SCCP FSM --SCCP-prim--> SCCP tx +RANAP +RANAP +RANAP RUA tx <--RUA---- RUA FSM <--event-- SCCP FSM <--event-- SCCP rx +RANAP +RANAP +RANAP Hence choose the correct prim according to the SCCP FSM state. - in hnbgw_rua.c, use RUA procedure codes, not prim types. - via the new FSM events' data args, pass msgb containing RANAP PDUs. == Fix SCCP Release behavior == So far, the normal conn release behavior was HNB HNBGW CN | --id-Disconnect--> | ---SCCP-Released--> | Iu-ReleaseComplete | | <--SCCP-RLC-------- | (no data) Instead, the SCCP release is now in accordance with 3GPP TS 48.006 9.2 'Connection release': The MSC sends a SCCP released message. This message shall not contain any user data field. i.e.: HNB HNBGW CN | --id-Disconnect--> | ---Data-Form-1(!)--> | Iu-ReleaseComplete | | <--SCCP-Released---- | (no data) | | ---SCCP-RLC--------> | (no data) (Side note, the final SCCP Release Confirm step is taken care of implicitly by libosmo-sigtran's sccp_scoc.c FSM.) If the CN fails to respond with SCCP-Released, on new X31 timeout, osmo-hnbgw will send an SCCP Released to the CN as fallback. == Memory model for message dispatch == So far, an osmo_scu_prim aka "oph" was passed between RUA and SCCP handling code, and the final dispatch freed it. Every error path had to take care not to leak any oph. Instead, use a much easier and much more leakage proof memory model, inspired by fixeria: - on rx, dispatch RANAP msgb that live in OTC_SELECT. - no code path needs to msgb_free() -- the msgb is discarded via OTC_SELECT when handling is done, error or no error. - any code path may also choose to store the msgb for async dispatch, using talloc_steal(). The user plane mapping via MGW and UPF do that. - if any code path does msgb_free(), that would be no problem either (but none do so now, for simplicity). == Layer separation == Dispatch *all* connection-oriented RUA tx via the RUA FSM and SCCP tx via the SCCP FSM, do not call rua_tx_dt() or osmo_sccp_user_sap_down() directly. == Memory model for decoded ranap_message IEs == Use a talloc destructor to make sure that the ranap_message IEs are always implicitly freed upon talloc_free(), so that no code path can possibly forget to do so. == Implicit cleanup by talloc == Use talloc scoping to remove a bunch of explicit cleanup code. For example, make a chached message a talloc child of its handler: talloc_steal(mgw_fsm_priv, message); mgw_fsm_priv->ranap_rab_ass_req_message = message; and later implicitly free 'message' by only freeing the handler: talloc_free(mgw_fsm_priv) Related: SYS#6297 Change-Id: I6ff7e36532ff57c6f2d3e7e419dd22ef27dafd19 --- M include/osmocom/hnbgw/context_map.h M include/osmocom/hnbgw/hnbgw.h M include/osmocom/hnbgw/hnbgw_cn.h M include/osmocom/hnbgw/mgw_fsm.h M include/osmocom/hnbgw/ps_rab_ass_fsm.h M include/osmocom/hnbgw/tdefs.h M src/osmo-hnbgw/Makefile.am M src/osmo-hnbgw/context_map.c A src/osmo-hnbgw/context_map_rua.c A src/osmo-hnbgw/context_map_sccp.c M src/osmo-hnbgw/hnbgw.c M src/osmo-hnbgw/hnbgw_cn.c M src/osmo-hnbgw/hnbgw_rua.c M src/osmo-hnbgw/hnbgw_vty.c M src/osmo-hnbgw/mgw_fsm.c M src/osmo-hnbgw/ps_rab_ass_fsm.c M src/osmo-hnbgw/ps_rab_fsm.c M src/osmo-hnbgw/tdefs.c 18 files changed, 1,397 insertions(+), 375 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/31/31431/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I6ff7e36532ff57c6f2d3e7e419dd22ef27dafd19 Gerrit-Change-Number: 31431 Gerrit-PatchSet: 7 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: bts_features: Add features for HR formats (TS 101813 vs. RFC5993)

by fixeria

Attention is currently required from: pespin, msuraev, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31415 ) Change subject: bts_features: Add features for HR formats (TS 101813 vs. RFC5993) ...................................................................... Patch Set 8: (1 comment) File include/osmocom/gsm/bts_features.h: https://gerrit.osmocom.org/c/libosmocore/+/31415/comment/2dd6a3ed_ad8184c5 PS7, Line 39: _TX > The BTS will accept both formats since it is easy to detect and convert from one to the other. […] As I said, this is an implementation detail (converting between formats on the fly). The PHY of each particular BTS models still does emit/expect only a specific format. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I05e4ed7a85f3a0451de7cd07380503a7ac76d043 Gerrit-Change-Number: 31415 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Feb 2023 13:54:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: bts_features: Add features for HR formats (TS 101813 vs. RFC5993)

by dexter

Attention is currently required from: fixeria, pespin, msuraev. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31415 ) Change subject: bts_features: Add features for HR formats (TS 101813 vs. RFC5993) ...................................................................... Patch Set 8: (2 comments) File include/osmocom/gsm/bts_features.h: https://gerrit.osmocom.org/c/libosmocore/+/31415/comment/294d4ae9_9319f923 PS7, Line 39: _TX > IMO, the '_TX_' part should be removed. […] The BTS will accept both formats since it is easy to detect and convert from one to the other. So the BTS will not care. However the BTS will still transmit in one of the two formats. That why we opted to have a _TX_ in the name. File src/gsm/bts_features.c: https://gerrit.osmocom.org/c/libosmocore/+/31415/comment/5376aab1_a4b18fe7 PS7, Line 49: { BTS_FEAT_VBS, "Voice Broadcast Service" }, > That's a duplicate from the entry above. Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I05e4ed7a85f3a0451de7cd07380503a7ac76d043 Gerrit-Change-Number: 31415 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Feb 2023 13:47:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023