February 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ggsn[rel-1.9.1]: Bump version: 1.9.0.1-921b → 1.9.1

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/31561 ) Change subject: Bump version: 1.9.0.1-921b → 1.9.1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/31561 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: rel-1.9.1 Gerrit-Change-Id: Ibbf1b867c1784ad0d1834a87cab6e1e09eb71f63 Gerrit-Change-Number: 31561 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Feb 2023 15:20:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in osmo-ggsn[rel-1.9.1]: Bump version: 1.9.0.1-921b → 1.9.1

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/31561 ) Change subject: Bump version: 1.9.0.1-921b → 1.9.1 ...................................................................... Bump version: 1.9.0.1-921b → 1.9.1 Change-Id: Ibbf1b867c1784ad0d1834a87cab6e1e09eb71f63 --- M debian/changelog 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/61/31561/1 diff --git a/debian/changelog b/debian/changelog index 08cfb0b..8b10af0 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +osmo-ggsn (1.9.1) unstable; urgency=medium + + * lib/icmpv6.h: fix struct icmpv6_{radv_hdr,opt_prefix} + + -- Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Mon, 27 Feb 2023 22:14:59 +0700 + osmo-ggsn (1.9.0) unstable; urgency=medium [ Pau Espin Pedrol ] -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/31561 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: rel-1.9.1 Gerrit-Change-Id: Ibbf1b867c1784ad0d1834a87cab6e1e09eb71f63 Gerrit-Change-Number: 31561 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 3 months

1
0
0 0

[S] Change in osmo-ggsn[rel-1.9.1]: lib/icmpv6.h: fix struct icmpv6_{radv_hdr,opt_prefix}

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/31560 ) Change subject: lib/icmpv6.h: fix struct icmpv6_{radv_hdr,opt_prefix} ...................................................................... lib/icmpv6.h: fix struct icmpv6_{radv_hdr,opt_prefix} Fix wrong field order in the big-endian variants. Change-Id: Ifaa63bb5496e056805bd13b964c8b430fb11c24c (cherry picked from commit 99afe979efec7bf3bd0dbd2da2c00df71e5f474d) --- M lib/icmpv6.h 1 file changed, 18 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/60/31560/1 diff --git a/lib/icmpv6.h b/lib/icmpv6.h index 4b4dc37..ee5ef29 100644 --- a/lib/icmpv6.h +++ b/lib/icmpv6.h @@ -44,10 +44,9 @@ uint8_t res:6, m:1, o:1; -#else - uint8_t m:1, - o:1, - res:6; +#elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianness.py) */ + uint8_t o:1, m:1, res:6; #endif uint16_t router_lifetime; uint32_t reachable_time; @@ -72,10 +71,9 @@ uint8_t res:6, a:1, l:1; -#else - uint8_t l:1, - a:1, - res:6; +#elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianness.py) */ + uint8_t l:1, a:1, res:6; #endif uint32_t valid_lifetime; uint32_t preferred_lifetime; -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/31560 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: rel-1.9.1 Gerrit-Change-Id: Ifaa63bb5496e056805bd13b964c8b430fb11c24c Gerrit-Change-Number: 31560 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 3 months

1
0
0 0

[S] Change in osmo-ggsn[rel-1.10.1]: lib/icmpv6.h: fix struct icmpv6_{radv_hdr,opt_prefix}

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/31559 ) Change subject: lib/icmpv6.h: fix struct icmpv6_{radv_hdr,opt_prefix} ...................................................................... lib/icmpv6.h: fix struct icmpv6_{radv_hdr,opt_prefix} Fix wrong field order in the big-endian variants. Change-Id: Ifaa63bb5496e056805bd13b964c8b430fb11c24c (cherry picked from commit 99afe979efec7bf3bd0dbd2da2c00df71e5f474d) --- M lib/icmpv6.h 1 file changed, 18 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/59/31559/1 diff --git a/lib/icmpv6.h b/lib/icmpv6.h index 4b4dc37..ee5ef29 100644 --- a/lib/icmpv6.h +++ b/lib/icmpv6.h @@ -44,10 +44,9 @@ uint8_t res:6, m:1, o:1; -#else - uint8_t m:1, - o:1, - res:6; +#elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianness.py) */ + uint8_t o:1, m:1, res:6; #endif uint16_t router_lifetime; uint32_t reachable_time; @@ -72,10 +71,9 @@ uint8_t res:6, a:1, l:1; -#else - uint8_t l:1, - a:1, - res:6; +#elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianness.py) */ + uint8_t l:1, a:1, res:6; #endif uint32_t valid_lifetime; uint32_t preferred_lifetime; -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/31559 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: rel-1.10.1 Gerrit-Change-Id: Ifaa63bb5496e056805bd13b964c8b430fb11c24c Gerrit-Change-Number: 31559 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 3 months

1
0
0 0

[S] Change in osmocom-bb[master]: modem: Use libosmo-gprs-rlcmac L1CTL primitives

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31359 ) Change subject: modem: Use libosmo-gprs-rlcmac L1CTL primitives ...................................................................... modem: Use libosmo-gprs-rlcmac L1CTL primitives Related: OS#5500 Change-Id: I9d3066f19077796b2ccf70b15cc57b6488f015be --- M src/host/layer23/src/modem/app_modem.c 1 file changed, 20 insertions(+), 11 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/host/layer23/src/modem/app_modem.c b/src/host/layer23/src/modem/app_modem.c index 28984e7..b55768f 100644 --- a/src/host/layer23/src/modem/app_modem.c +++ b/src/host/layer23/src/modem/app_modem.c @@ -39,6 +39,7 @@ #include <osmocom/gsm/gsm48.h> #include <osmocom/gsm/protocol/gsm_04_08.h> #include <osmocom/gprs/rlcmac/csn1_defs.h> +#include <osmocom/gprs/rlcmac/rlcmac_prim.h> #include <osmocom/bb/common/osmocom_data.h> #include <osmocom/bb/common/ms.h> @@ -230,6 +231,7 @@ static int handle_si13(struct osmocom_ms *ms, struct msgb *msg) { int rc; + struct osmo_gprs_rlcmac_prim *rlcmac_prim; if (msgb_l3len(msg) != GSM_MACBLOCK_LEN) return -EINVAL; @@ -240,7 +242,10 @@ if (rc != 0) return rc; - return 0; + /* Forward SI13 to RLC/MAC layer */ + rlcmac_prim = osmo_gprs_rlcmac_prim_alloc_l1ctl_ccch_data_ind(0 /* TODO: fn */, msgb_l3(msg)); + rc = osmo_gprs_rlcmac_prim_lower_up(rlcmac_prim); + return rc; } static int modem_rx_bcch(struct osmocom_ms *ms, struct msgb *msg) @@ -275,6 +280,7 @@ struct gsm48_rrlayer *rr = &ms->rrlayer; uint8_t ch_type, ch_subch, ch_ts; int rc; + struct osmo_gprs_rlcmac_prim *rlcmac_prim; /* Discard CS channel assignment */ if ((ia->page_mode >> 4) == 0) @@ -340,17 +346,10 @@ ia->chan_desc.h1.tsc, GSM48_CMODE_SIGN, 0); } - const uint8_t *data = msgb_l3(msg) + sizeof(*ia) + ia->mob_alloc_len; - size_t data_len = msgb_l3len(msg) - (sizeof(*ia) + ia->mob_alloc_len); - IA_RestOctets_t iaro; - - rc = osmo_gprs_rlcmac_decode_imm_ass_ro(&iaro, data, data_len); - if (rc != 0) { - LOGP(DRR, LOGL_ERROR, "Failed to decode IA Rest Octets IE\n"); + rlcmac_prim = osmo_gprs_rlcmac_prim_alloc_l1ctl_ccch_data_ind(0 /* TODO: fn */, (uint8_t *)ia); + rc = osmo_gprs_rlcmac_prim_lower_up(rlcmac_prim); + if (rc < 0) return rc; - } - - /* TODO: deliver decoded params to the RLC/MAC layer */ rr->state = GSM48_RR_ST_DEDICATED; return 0; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31359 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9d3066f19077796b2ccf70b15cc57b6488f015be Gerrit-Change-Number: 31359 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

[S] Change in osmo-pcu[master]: pcu_l1_if_phy: add header file for struct gsmtap_inst

by fixeria

Attention is currently required from: pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31558 ) Change subject: pcu_l1_if_phy: add header file for struct gsmtap_inst ...................................................................... Patch Set 2: (1 comment) File src/pcu_l1_if_phy.h: https://gerrit.osmocom.org/c/osmo-pcu/+/31558/comment/4ff0ef29_5c0884d1 PS2, Line 4: #include <osmocom/core/gsmtap_util.h> It would be enough to add a forward declaration. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31558 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9b859c4f7906f31547549d4ff7751fb720519270 Gerrit-Change-Number: 31558 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Feb 2023 14:47:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in osmo-pcu[master]: pcu_l1_if: use only the term "direct PHY access"

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31361 ) Change subject: pcu_l1_if: use only the term "direct PHY access" ...................................................................... pcu_l1_if: use only the term "direct PHY access" The log messages and code comments sometimes refer to the direct PHY access feature as "direct DSP access". Lets use only the term "direct PHY access" Change-Id: I121ad85cd8581c40f390dbaad0d6a028d68b095e --- M src/pcu_l1_if.cpp 1 file changed, 16 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp index 62f02d9..fdee83d 100644 --- a/src/pcu_l1_if.cpp +++ b/src/pcu_l1_if.cpp @@ -610,7 +610,7 @@ return rc; } -/* C -> C++ adapter for direct DSP access code (e.g. osmo-bts-sysmo) */ +/* C -> C++ adapter for direct PHY access code (e.g. osmo-bts-sysmo) */ extern "C" int pcu_rx_rach_ind_ptcch(struct gprs_rlcmac_bts *bts, uint8_t trx_nr, uint8_t ts_nr, uint32_t fn, int16_t qta) { struct rach_ind_params rip = { @@ -869,11 +869,11 @@ the_pcu->gsmtap); if (!bts->trx[trx_nr].fl1h) { LOGP(DL1IF, LOGL_FATAL, "Failed to open direct " - "DSP access for PDCH.\n"); + "PHY access for PDCH.\n"); exit(0); } #else - LOGP(DL1IF, LOGL_FATAL, "Compiled without direct DSP " + LOGP(DL1IF, LOGL_FATAL, "Compiled without direct PHY " "access for PDCH, but enabled at " "BTS. Please deactivate it!\n"); exit(0); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31361 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I121ad85cd8581c40f390dbaad0d6a028d68b095e Gerrit-Change-Number: 31361 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

[S] Change in osmo-pcu[master]: pcu_l1_if: use only the term "direct PHY access"

by dexter

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31361 ) Change subject: pcu_l1_if: use only the term "direct PHY access" ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31361 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I121ad85cd8581c40f390dbaad0d6a028d68b095e Gerrit-Change-Number: 31361 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Feb 2023 14:31:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in osmo-pcu[master]: pcu_l1_if: use only the term "direct PHY access"

by dexter

Attention is currently required from: dexter. Hello Jenkins Builder, neels, pespin, msuraev, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/31361 to look at the new patch set (#5). Change subject: pcu_l1_if: use only the term "direct PHY access" ...................................................................... pcu_l1_if: use only the term "direct PHY access" The log messages and code comments sometimes refer to the direct PHY access feature as "direct DSP access". Lets use only the term "direct PHY access" Change-Id: I121ad85cd8581c40f390dbaad0d6a028d68b095e --- M src/pcu_l1_if.cpp 1 file changed, 16 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/61/31361/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31361 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I121ad85cd8581c40f390dbaad0d6a028d68b095e Gerrit-Change-Number: 31361 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 3 months

1
0
0 0

[S] Change in osmo-pcu[master]: pcu_l1_if_phy: add header file for struct gsmtap_inst

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31558 ) Change subject: pcu_l1_if_phy: add header file for struct gsmtap_inst ...................................................................... pcu_l1_if_phy: add header file for struct gsmtap_inst Lets include the header file that contains the definition of struct gsmtap_inst since this struct is directly used with l1if_open_pdch. Change-Id: I9b859c4f7906f31547549d4ff7751fb720519270 Related: OS#5198 --- M src/pcu_l1_if_phy.h 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/58/31558/1 diff --git a/src/pcu_l1_if_phy.h b/src/pcu_l1_if_phy.h index f25bf7b..73d0b6f 100644 --- a/src/pcu_l1_if_phy.h +++ b/src/pcu_l1_if_phy.h @@ -1,6 +1,7 @@ #pragma once #include <stdint.h> +#include <osmocom/core/gsmtap_util.h> void *l1if_open_pdch(uint8_t trx_no, uint32_t hlayer1, struct gsmtap_inst *gsmtap); int l1if_connect_pdch(void *obj, uint8_t ts); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31558 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9b859c4f7906f31547549d4ff7751fb720519270 Gerrit-Change-Number: 31558 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023