February 2023 - gerrit-log - lists.osmocom.org

Change in osmo-pcu[master]: pcu_l1_if.cpp: handle TLLI based IMMEDIATE ASSIGNMENT confirmation

by dexter

Attention is currently required from: laforge, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31148 ) Change subject: pcu_l1_if.cpp: handle TLLI based IMMEDIATE ASSIGNMENT confirmation ...................................................................... Patch Set 5: (1 comment) File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31148/comment/0f1157f8_df796f1c PS3, Line 542: bts_rcv_imm_ass_cnf(bts, data_cnf->data, 0, data_cnf->fn); > $ grep -r GSM_RESERVED_TMSI | wc -l […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31148 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Icf7ca34500984239ee877ee71fd9c126b5eb3480 Gerrit-Change-Number: 31148 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 06 Feb 2023 12:58:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-upf[master]: tunmap: refactor nft ruleset: fix "martians" and "1024"

by neels

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-upf/+/31165 to look at the new patch set (#4). Change subject: tunmap: refactor nft ruleset: fix "martians" and "1024" ...................................................................... tunmap: refactor nft ruleset: fix "martians" and "1024" Take care of two problems: - limitation of <= 1024 base chains in nftables, so far meaning we can establish at most 1024 GTP tunnel mappings. - mangling of source IP in prerouting so far meaning that the system needs to be configured to permit 'martian' packets The new ruleset separates in pre- and post-routing, so that we set a new destination IP address in pre-routing, and set a new source IP address in post-routing. Hence no problem with martian packet rejection. The new ruleset uses verdict maps, which are more efficient, and do not hit a limit of 1024 as base chains do. Related: SYS#6327 SYS#6264 Change-Id: Iccb975a1c0f8a2087f7b7dc4942a6b41f5675a13 --- M include/osmocom/upf/upf.h M include/osmocom/upf/upf_nft.h M src/osmo-upf/up_gtp_action.c M src/osmo-upf/upf.c M src/osmo-upf/upf_nft.c M src/osmo-upf/upf_vty.c M tests/nft-rule.vty 7 files changed, 245 insertions(+), 82 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/65/31165/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/31165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Iccb975a1c0f8a2087f7b7dc4942a6b41f5675a13 Gerrit-Change-Number: 31165 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in osmo-upf[master]: tunmap: refactor nft ruleset: fix "martians" and "1024"

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/31165 ) Change subject: tunmap: refactor nft ruleset: fix "martians" and "1024" ...................................................................... Patch Set 3: (2 comments) Patchset: PS3: thx File src/osmo-upf/upf_nft.c: https://gerrit.osmocom.org/c/osmo-upf/+/31165/comment/7bc0e079_88d2ec33 PS3, Line 345: static uint32_t chain_id_next() > > Bad function definition - uint32_t chain_id_next() should probably be uint32_t chain_id_next(void) […] (no need to repeat jenkins for me) -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/31165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Iccb975a1c0f8a2087f7b7dc4942a6b41f5675a13 Gerrit-Change-Number: 31165 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 06 Feb 2023 12:39:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-pcu[master]: bts: add IMMEDIATE ASSIGNMENT via PCH transmission

by dexter

Attention is currently required from: laforge, fixeria, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31145 ) Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission ...................................................................... Patch Set 5: (1 comment) File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/afe10b67_1d9131b2 PS5, Line 1105: #ifdef ENABLE_ERICSSON_RBS > Agreeing with Pau here, maybe make the BTS type configurable somehow? Or even better: make BSC/BTS i […] I have eliminated the need for compile time IF here now but I still wondering, we have different phy implementations for litecell, sysmo-bts and oc2g. As far as I am aware its a compile-time distinction there as well. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Gerrit-Change-Number: 31145 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 06 Feb 2023 12:33:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-remsim[master]: bankd_main: Avoid uninitialized variable

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/31182 ) Change subject: bankd_main: Avoid uninitialized variable ...................................................................... bankd_main: Avoid uninitialized variable There's not really any ResultCode for the kind of error we encounter, but sending some uninitialized memory clearly is not the right way either. >>> CID 307528: Uninitialized variables (UNINIT) >>> Using uninitialized value "res". Closes: CID#307528 Change-Id: I29f911cb2c8ad67cf1ce4486e1583612fb0b98a6 --- M src/bankd/bankd_main.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index 90b05d8..e002b94 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -716,6 +716,7 @@ if (worker->state != BW_ST_CONN_WAIT_ID) { LOGW(worker, "Unexpected connectClientReq\n"); + res = ResultCode_illegalClientId; rc = -102; goto respond_and_err; } 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/31182 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I29f911cb2c8ad67cf1ce4486e1583612fb0b98a6 Gerrit-Change-Number: 31182 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in osmo-remsim[master]: rest_api: strtoul canot return negative

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/31179 ) Change subject: rest_api: strtoul canot return negative ...................................................................... rest_api: strtoul canot return negative >>> CID 307538: Control flow issues (NO_EFFECT) >>> This less-than-zero comparison of an unsigned value is never true. "map_id < 0UL". Closes: CID#307538 Change-Id: Ic5019e216dd7b26be0bd988df218a2cb5775e411 --- M src/server/rest_api.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/server/rest_api.c b/src/server/rest_api.c index d3279c4..6e025ad 100644 --- a/src/server/rest_api.c +++ b/src/server/rest_api.c @@ -410,7 +410,7 @@ goto err; } map_id = strtoul(slotmap_id_str, NULL, 10); - if (map_id < 0) { + if (map_id == ULONG_MAX && errno != 0) { status = 400; goto err; } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/31179 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ic5019e216dd7b26be0bd988df218a2cb5775e411 Gerrit-Change-Number: 31179 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in osmo-remsim[master]: rspro_server: Handle ipa_server_link_open() error case

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/31181 ) Change subject: rspro_server: Handle ipa_server_link_open() error case ...................................................................... rspro_server: Handle ipa_server_link_open() error case >>> CID 307530: Error handling issues (CHECKED_RETURN) >>> Calling "ipa_server_link_open" without checking return value (as is done elsewhere 4 out of 5 times). while at it, also add a missing pthread_rwlock_destroy() call which was missing in the existing ipa_server_link_create() error path. Closes: CID#307530 Change-Id: Ic32d53a236b80711651fb4ee196ac3b95148e61f --- M src/server/rspro_server.c 1 file changed, 14 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/server/rspro_server.c b/src/server/rspro_server.c index 550179d..da27a2d 100644 --- a/src/server/rspro_server.c +++ b/src/server/rspro_server.c @@ -844,6 +844,7 @@ { struct rspro_server *srv = talloc_zero(ctx, struct rspro_server); + int rc; OSMO_ASSERT(srv); pthread_rwlock_init(&srv->rwlock, NULL); @@ -854,14 +855,22 @@ pthread_rwlock_unlock(&srv->rwlock); srv->link = ipa_server_link_create(ctx, NULL, host, port, accept_cb, srv); - if (!srv->link) { - talloc_free(srv); - return NULL; - } + if (!srv->link) + goto out_free; - ipa_server_link_open(srv->link); + rc = ipa_server_link_open(srv->link); + if (rc < 0) + goto out_destroy; return srv; + +out_destroy: + ipa_server_link_destroy(srv->link); +out_free: + pthread_rwlock_destroy(&srv->rwlock); + talloc_free(srv); + + return NULL; } void rspro_server_destroy(struct rspro_server *srv) -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/31181 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ic32d53a236b80711651fb4ee196ac3b95148e61f Gerrit-Change-Number: 31181 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in osmo-remsim[master]: remsim_server: handle osmo_fd_register() failure case

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/31180 ) Change subject: remsim_server: handle osmo_fd_register() failure case ...................................................................... remsim_server: handle osmo_fd_register() failure case >>> CID 307531: Error handling issues (CHECKED_RETURN) >>> Calling "osmo_fd_register" without checking return value (as is done elsewhere 83 out of 97 times). Closes: CID#307531 Change-Id: I7c2448303fba7caa27df65ac5f4d91ddf232ceb6 --- M src/server/remsim_server.c 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/server/remsim_server.c b/src/server/remsim_server.c index fad0b14..3687f15 100644 --- a/src/server/remsim_server.c +++ b/src/server/remsim_server.c @@ -124,13 +124,15 @@ if (rc < 0) goto out_rps; osmo_fd_setup(&g_event_ofd, rc, OSMO_FD_READ, event_fd_cb, g_rps, 0); - osmo_fd_register(&g_event_ofd); + rc = osmo_fd_register(&g_event_ofd); + if (rc < 0) + goto out_eventfd; signal(SIGUSR1, handle_sig_usr1); rc = rest_api_init(talloc_rest_ctx, 9997); if (rc < 0) - goto out_eventfd; + goto out_unregister; while (1) { osmo_select_main(0); @@ -140,6 +142,8 @@ exit(0); +out_unregister: + osmo_fd_unregister(&g_event_ofd); out_eventfd: close(g_event_ofd.fd); out_rps: 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/31180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I7c2448303fba7caa27df65ac5f4d91ddf232ceb6 Gerrit-Change-Number: 31180 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in osmo-remsim[master]: rspro_server: Handle ipa_server_link_open() error case

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/31181 ) Change subject: rspro_server: Handle ipa_server_link_open() error case ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/31181 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ic32d53a236b80711651fb4ee196ac3b95148e61f Gerrit-Change-Number: 31181 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 06 Feb 2023 12:18:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-remsim[master]: rest_api: strtoul canot return negative

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/31179 ) Change subject: rest_api: strtoul canot return negative ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/31179 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ic5019e216dd7b26be0bd988df218a2cb5775e411 Gerrit-Change-Number: 31179 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 06 Feb 2023 12:17:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023