February 2023 - gerrit-log - lists.osmocom.org

Change in libosmo-abis[master]: Reworked mi_e1_line_update() and some of its sub routines

by neels

Attention is currently required from: jolly. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31296 ) Change subject: Reworked mi_e1_line_update() and some of its sub routines ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: it still shows "Merge Conflict" even after re-submitting. Maybe you forgot to 'git fetch' and 'git rebase -i origin/master' ? -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31296 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Iab0776fce6921661b39e9e53376cf01a80bcd42c Gerrit-Change-Number: 31296 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 14 Feb 2023 21:04:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmo-abis[master]: misdn driver: printf and fprintf are replaced by logging functions

by neels

Attention is currently required from: jolly. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31319 ) Change subject: misdn driver: printf and fprintf are replaced by logging functions ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/input/misdn.c: https://gerrit.osmocom.org/c/libosmo-abis/+/31319/comment/7e5b4bc5_fe6da992 PS2, Line 728: fprintf(stdout, "activate bchan\n"); are you dropping this one on purpose? -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31319 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I313c0bf2b8a93febed73b4ea447f6552216095b6 Gerrit-Change-Number: 31319 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 14 Feb 2023 21:02:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Introduce initial poll answer infrastructure

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31325 to look at the new patch set (#3). Change subject: rlcmac: Introduce initial poll answer infrastructure ...................................................................... rlcmac: Introduce initial poll answer infrastructure This commit imports pdch_ul_controller.{c,h} from osmo-pcu.git d8cea3c618dbd2a343e6c012e5545006d44fc244 and adapts it to be of use on the MS side. Related: OS#5500 Change-Id: I9d38a8de4240e65585cc8bbe3c044473af5a83e5 --- M include/osmocom/gprs/rlcmac/Makefile.am A include/osmocom/gprs/rlcmac/pdch_ul_controller.h M include/osmocom/gprs/rlcmac/rlcmac_private.h M include/osmocom/gprs/rlcmac/sched.h M include/osmocom/gprs/rlcmac/tbf_dl.h M include/osmocom/gprs/rlcmac/types_private.h M src/rlcmac/Makefile.am A src/rlcmac/pdch_ul_controller.c M src/rlcmac/rlcmac.c M src/rlcmac/sched.c M src/rlcmac/tbf_dl.c M tests/rlcmac/rlcmac_prim_test.c M tests/rlcmac/rlcmac_prim_test.err 13 files changed, 425 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/25/31325/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31325 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I9d38a8de4240e65585cc8bbe3c044473af5a83e5 Gerrit-Change-Number: 31325 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Implement initial DL rx data path

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31320 to look at the new patch set (#2). Change subject: rlcmac: Implement initial DL rx data path ...................................................................... rlcmac: Implement initial DL rx data path This code imports code from osmo-pcu.git d8cea3c618dbd2a343e6c012e5545006d44fc244 (heavy modified to adapt to current code base). With this patch the RLCMAC layer is already capable of decoding RLC/MAC GPRS data blocks and submit them as LLC frames to the upper layer. Related: OS#5500 Change-Id: Ie7535606916c0800c0e1bd9555be022c81ea257d --- M include/osmocom/gprs/rlcmac/Makefile.am M include/osmocom/gprs/rlcmac/rlc.h A include/osmocom/gprs/rlcmac/rlc_window_dl.h A include/osmocom/gprs/rlcmac/rlcmac_dec.h M include/osmocom/gprs/rlcmac/rlcmac_private.h M include/osmocom/gprs/rlcmac/tbf_dl.h M src/rlcmac/Makefile.am A src/rlcmac/rlc_window_dl.c M src/rlcmac/rlcmac.c A src/rlcmac/rlcmac_dec.c M src/rlcmac/rlcmac_enc.c M src/rlcmac/tbf_dl.c M tests/rlcmac/rlcmac_prim_test.c M tests/rlcmac/rlcmac_prim_test.err M tests/rlcmac/rlcmac_prim_test.ok 15 files changed, 980 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/20/31320/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31320 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ie7535606916c0800c0e1bd9555be022c81ea257d Gerrit-Change-Number: 31320 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Introduce DL TBF creation through PCH ImmAss

by pespin

Attention is currently required from: neels, pespin, msuraev. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31286 to look at the new patch set (#9). Change subject: rlcmac: Introduce DL TBF creation through PCH ImmAss ...................................................................... rlcmac: Introduce DL TBF creation through PCH ImmAss This patch only introduces the gprs_rlcmac_dl_tbf subclass and allocates/frees it based on PCH ImmAss, and adds initial paths for received blocks. It also provides a unit test to showcase the scenario. Change-Id: I7f98e3456ef35d80becdad3481afeb771457b0ef --- M include/osmocom/gprs/rlcmac/Makefile.am M include/osmocom/gprs/rlcmac/coding_scheme.h M include/osmocom/gprs/rlcmac/gre.h M include/osmocom/gprs/rlcmac/rlcmac.h M include/osmocom/gprs/rlcmac/rlcmac_private.h A include/osmocom/gprs/rlcmac/tbf_dl.h A include/osmocom/gprs/rlcmac/tbf_dl_fsm.h M include/osmocom/gprs/rlcmac/types_private.h M src/rlcmac/Makefile.am M src/rlcmac/coding_scheme.c M src/rlcmac/gre.c M src/rlcmac/misc.c M src/rlcmac/rlcmac.c M src/rlcmac/rlcmac_prim.c A src/rlcmac/tbf_dl.c A src/rlcmac/tbf_dl_fsm.c M tests/rlcmac/Makefile.am M tests/rlcmac/rlcmac_prim_test.c M tests/rlcmac/rlcmac_prim_test.err M tests/rlcmac/rlcmac_prim_test.ok 20 files changed, 709 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/86/31286/9 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31286 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I7f98e3456ef35d80becdad3481afeb771457b0ef Gerrit-Change-Number: 31286 Gerrit-PatchSet: 9 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Introduce initial poll answer infrastructure

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31325 to look at the new patch set (#2). Change subject: rlcmac: Introduce initial poll answer infrastructure ...................................................................... rlcmac: Introduce initial poll answer infrastructure This commit imports pdch_ul_controller.{c,h} from osmo-pcu.git d8cea3c618dbd2a343e6c012e5545006d44fc244 and adapts it to be of use on the MS side. Related: OS#5500 Change-Id: I9d38a8de4240e65585cc8bbe3c044473af5a83e5 --- M include/osmocom/gprs/rlcmac/Makefile.am A include/osmocom/gprs/rlcmac/pdch_ul_controller.h M include/osmocom/gprs/rlcmac/rlcmac_private.h M include/osmocom/gprs/rlcmac/sched.h M include/osmocom/gprs/rlcmac/tbf_dl.h M include/osmocom/gprs/rlcmac/types_private.h M src/rlcmac/Makefile.am A src/rlcmac/pdch_ul_controller.c M src/rlcmac/rlcmac.c M src/rlcmac/sched.c M src/rlcmac/tbf_dl.c M tests/rlcmac/rlcmac_prim_test.c M tests/rlcmac/rlcmac_prim_test.err 13 files changed, 424 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/25/31325/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31325 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I9d38a8de4240e65585cc8bbe3c044473af5a83e5 Gerrit-Change-Number: 31325 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in libosmocore[master]: i460_mux: make osmo_i460_subchan_count public

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31324 ) Change subject: i460_mux: make osmo_i460_subchan_count public ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31324 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0454ffe5809f21504c1e263a781c06596d452d4b Gerrit-Change-Number: 31324 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Feb 2023 15:04:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-mgw[master]: mgcp_e1: be more frugal withe E1 line resources

by osmith

Attention is currently required from: dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31269 ) Change subject: mgcp_e1: be more frugal withe E1 line resources ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File src/libosmo-mgcp/mgcp_e1.c: https://gerrit.osmocom.org/c/osmo-mgw/+/31269/comment/3ea37678_62b48be7 PS4, Line 660: do don't? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31269 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie6a32abbc5cd984f6d72a384e3b47c1b82ce7058 Gerrit-Change-Number: 31269 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Feb 2023 14:10:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Introduce initial poll answer infrastructure

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31325 ) Change subject: rlcmac: Introduce initial poll answer infrastructure ...................................................................... rlcmac: Introduce initial poll answer infrastructure This commit imports pdch_ul_controller.{c,h} from osmo-pcu.git d8cea3c618dbd2a343e6c012e5545006d44fc244 and adapts it to be of use on the MS side. Related: OS#5500 Change-Id: I9d38a8de4240e65585cc8bbe3c044473af5a83e5 --- M include/osmocom/gprs/rlcmac/Makefile.am A include/osmocom/gprs/rlcmac/pdch_ul_controller.h M include/osmocom/gprs/rlcmac/rlcmac_private.h M include/osmocom/gprs/rlcmac/sched.h M include/osmocom/gprs/rlcmac/tbf_dl.h M include/osmocom/gprs/rlcmac/types_private.h M src/rlcmac/Makefile.am A src/rlcmac/pdch_ul_controller.c M src/rlcmac/rlcmac.c M src/rlcmac/sched.c M src/rlcmac/tbf_dl.c M tests/rlcmac/rlcmac_prim_test.c 12 files changed, 404 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/25/31325/1 diff --git a/include/osmocom/gprs/rlcmac/Makefile.am b/include/osmocom/gprs/rlcmac/Makefile.am index e061bf0..29b6332 100644 --- a/include/osmocom/gprs/rlcmac/Makefile.am +++ b/include/osmocom/gprs/rlcmac/Makefile.am @@ -3,6 +3,7 @@ coding_scheme.h \ gre.h \ llc_queue.h \ + pdch_ul_controller.h \ rlc.h \ rlc_window.h \ rlc_window_dl.h \ diff --git a/include/osmocom/gprs/rlcmac/pdch_ul_controller.h b/include/osmocom/gprs/rlcmac/pdch_ul_controller.h new file mode 100644 index 0000000..d430803 --- /dev/null +++ b/include/osmocom/gprs/rlcmac/pdch_ul_controller.h @@ -0,0 +1,65 @@ +/* pdch_ul_controller.h + * + * Copyright (C) 2021-2023 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> + * Author: Pau Espin Pedrol <pespin(a)sysmocom.de> + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation; either version 2 + * of the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ +#pragma once + +#include <stdint.h> +#include <stdbool.h> + +#include <osmocom/core/linuxrbtree.h> +#include <osmocom/core/utils.h> + +struct gprs_rlcmac_dl_tbf; + +struct gprs_rlcmac_pdch_ulc { + uint8_t ts_nr; + struct rb_root tree_root; + void *pool_ctx; /* talloc pool of struct pdch_ulc_node */ +}; + + +enum gprs_rlcmac_pdch_ulc_poll_reason { + GPRS_RLCMAC_PDCH_ULC_POLL_UL_ASS, /* Tx CTRL ACK for received UL ASS */ + GPRS_RLCMAC_PDCH_ULC_POLL_DL_ASS, /* Tx CTRL ACK for received DL ASS */ + GPRS_RLCMAC_PDCH_ULC_POLL_UL_ACK, /* Tx CTRL ACK (or PKT RES REQ on final UL ACK/NACK) for received UL ACK/NACK */ + GPRS_RLCMAC_PDCH_ULC_POLL_DL_ACK, /* Tx DL ACK/NACK (or others 8.1.2.2) for received data block */ + GPRS_RLCMAC_PDCH_ULC_POLL_CELL_CHG_CONTINUE, /* Tx CTRL ACK for received Pkt cell Change Continue */ +}; +extern const struct value_string gprs_rlcmac_pdch_ulc_poll_reason_names[]; + +struct gprs_rlcmac_pdch_ulc_node { + struct rb_node node; /*! entry in gprs_rlcmac_pdch_ulc->tree_root */ + uint32_t fn; + enum gprs_rlcmac_pdch_ulc_poll_reason reason; + struct gprs_rlcmac_tbf *tbf; + //union { + // struct { + // struct gprs_rlcmac_dl_tbf *dl_tbf; + // } dl_ack; + //}; +}; + +struct gprs_rlcmac_pdch_ulc *gprs_rlcmac_pdch_ulc_alloc(void *ctx, uint8_t ts_nr); + +int gprs_rlcmac_pdch_ulc_reserve(struct gprs_rlcmac_pdch_ulc *ulc, uint32_t fn, enum gprs_rlcmac_pdch_ulc_poll_reason reason, struct gprs_rlcmac_tbf *tbf); + +struct gprs_rlcmac_pdch_ulc_node *gprs_rlcmac_pdch_ulc_get_node(struct gprs_rlcmac_pdch_ulc *ulc, uint32_t fn); +struct gprs_rlcmac_pdch_ulc_node *gprs_rlcmac_pdch_ulc_pop_node(struct gprs_rlcmac_pdch_ulc *ulc, uint32_t fn); + +void gprs_rlcmac_pdch_ulc_release_node(struct gprs_rlcmac_pdch_ulc *ulc, struct gprs_rlcmac_pdch_ulc_node *item); +void gprs_rlcmac_pdch_ulc_release_tbf(struct gprs_rlcmac_pdch_ulc *ulc, const struct gprs_rlcmac_tbf *tbf); +int gprs_rlcmac_pdch_ulc_release_fn(struct gprs_rlcmac_pdch_ulc *ulc, uint32_t fn); + +void gprs_rlcmac_pdch_ulc_expire_fn(struct gprs_rlcmac_pdch_ulc *ulc, uint32_t fn); diff --git a/include/osmocom/gprs/rlcmac/rlcmac_private.h b/include/osmocom/gprs/rlcmac/rlcmac_private.h index fc65753..f5bbfb0 100644 --- a/include/osmocom/gprs/rlcmac/rlcmac_private.h +++ b/include/osmocom/gprs/rlcmac/rlcmac_private.h @@ -69,6 +69,10 @@ uint8_t next_ul_tbf_nr; uint8_t next_dl_tbf_nr; + + struct { + struct gprs_rlcmac_pdch_ulc *ulc[8]; + } sched; }; extern struct gprs_rlcmac_ctx *g_ctx; diff --git a/include/osmocom/gprs/rlcmac/sched.h b/include/osmocom/gprs/rlcmac/sched.h index d344aea..c7fa82a 100644 --- a/include/osmocom/gprs/rlcmac/sched.h +++ b/include/osmocom/gprs/rlcmac/sched.h @@ -9,4 +9,6 @@ uint8_t usf; }; +uint32_t rrbp2fn(uint32_t cur_fn, uint8_t rrbp); + int gprs_rlcmac_rcv_rts_block(struct gprs_rlcmac_rts_block_ind *bi); diff --git a/include/osmocom/gprs/rlcmac/tbf_dl.h b/include/osmocom/gprs/rlcmac/tbf_dl.h index 6421030..d94169f 100644 --- a/include/osmocom/gprs/rlcmac/tbf_dl.h +++ b/include/osmocom/gprs/rlcmac/tbf_dl.h @@ -42,7 +42,7 @@ int gprs_rlcmac_dl_tbf_rcv_data_block(struct gprs_rlcmac_dl_tbf *dl_tbf, const struct gprs_rlcmac_rlc_data_info *rlc, - uint8_t *data); + uint8_t *data, uint32_t fn, uint8_t ts_nr); static inline struct gprs_rlcmac_tbf *dl_tbf_as_tbf(struct gprs_rlcmac_dl_tbf *dl_tbf) { diff --git a/include/osmocom/gprs/rlcmac/types_private.h b/include/osmocom/gprs/rlcmac/types_private.h index 8450d08..77a0504 100644 --- a/include/osmocom/gprs/rlcmac/types_private.h +++ b/include/osmocom/gprs/rlcmac/types_private.h @@ -3,6 +3,14 @@ #include <osmocom/gprs/rlcmac/types.h> +/* TS 44.060 able 10.4.5.1 RRBP offsets */ +enum gprs_rlcmac_rrbp_field { + GPRS_RLCMAC_RRBP_N_plus_13 = 0x0, + GPRS_RLCMAC_RRBP_N_plus_17_18 = 0x1, + GPRS_RLCMAC_RRBP_N_plus_21_22 = 0x2, + GPRS_RLCMAC_RRBP_N_plus_26 = 0x3, +}; + /* TS 44.060 Section 10.4.7 Table 10.4.7.1: Payload Type field */ enum gprs_rlcmac_payload_type { GPRS_RLCMAC_PT_DATA_BLOCK = 0x0, diff --git a/src/rlcmac/Makefile.am b/src/rlcmac/Makefile.am index a940b97..4649f52 100644 --- a/src/rlcmac/Makefile.am +++ b/src/rlcmac/Makefile.am @@ -30,6 +30,7 @@ csn1_ts_44_018.c \ csn1_ts_44_060.c \ gre.c \ + pdch_ul_controller.c \ llc_queue.c \ rlc_window.c \ rlc_window_dl.c \ diff --git a/src/rlcmac/pdch_ul_controller.c b/src/rlcmac/pdch_ul_controller.c new file mode 100644 index 0000000..7a3b753 --- /dev/null +++ b/src/rlcmac/pdch_ul_controller.c @@ -0,0 +1,212 @@ +/* pdch_ul_controller.c + * + * Copyright (C) 2021-2023 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> + * Author: Pau Espin Pedrol <pespin(a)sysmocom.de> + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation; either version 2 + * of the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <inttypes.h> +#include <unistd.h> +#include <talloc.h> + +#include <osmocom/core/logging.h> +#include <osmocom/core/linuxlist.h> +#include <osmocom/core/linuxrbtree.h> +#include <osmocom/gsm/gsm_utils.h> + +#include <osmocom/gprs/rlcmac/pdch_ul_controller.h> +#include <osmocom/gprs/rlcmac/rlcmac_private.h> +#include <osmocom/gprs/rlcmac/types_private.h> + +/* TS 44.060 Table 10.4.5.1 states maximum RRBP is N + 26. Give extra space for time diff between Tx and Rx? */ +#define MAX_FN_RESERVED (27 + 50) + +const struct value_string gprs_rlcmac_pdch_ulc_poll_reason_names[] = { + { GPRS_RLCMAC_PDCH_ULC_POLL_UL_ASS, "UL_ASS" }, + { GPRS_RLCMAC_PDCH_ULC_POLL_DL_ASS, "DL_ASS" }, + { GPRS_RLCMAC_PDCH_ULC_POLL_UL_ACK, "UL_ACK" }, + { GPRS_RLCMAC_PDCH_ULC_POLL_DL_ACK, "DL_ACK" }, + { GPRS_RLCMAC_PDCH_ULC_POLL_CELL_CHG_CONTINUE, "CELL_CHG_CONTINUE" }, + { 0, NULL } +}; + +#define GSM_MAX_FN_THRESH (GSM_MAX_FN >> 1) +/* 0: equal, -1: fn1 BEFORE fn2, 1: fn1 AFTER fn2 */ +static inline int fn_cmp(uint32_t fn1, uint32_t fn2) +{ + if (fn1 == fn2) + return 0; + /* FN1 goes before FN2: */ + if ((fn1 < fn2 && (fn2 - fn1) < GSM_MAX_FN_THRESH) || + (fn1 > fn2 && (fn1 - fn2) > GSM_MAX_FN_THRESH)) + return -1; + /* FN1 goes after FN2: */ + return 1; +} + +struct gprs_rlcmac_pdch_ulc *gprs_rlcmac_pdch_ulc_alloc(void *ctx, uint8_t ts_nr) +{ + struct gprs_rlcmac_pdch_ulc *ulc; + ulc = talloc_zero(ctx, struct gprs_rlcmac_pdch_ulc); + if (!ulc) + return ulc; + + ulc->ts_nr = ts_nr; + ulc->pool_ctx = talloc_pool(ulc, sizeof(struct gprs_rlcmac_pdch_ulc_node) * MAX_FN_RESERVED); + return ulc; +} + +struct gprs_rlcmac_pdch_ulc_node *gprs_rlcmac_pdch_ulc_get_node(struct gprs_rlcmac_pdch_ulc *ulc, uint32_t fn) +{ + OSMO_ASSERT(ulc); + struct rb_node *node = ulc->tree_root.rb_node; + struct gprs_rlcmac_pdch_ulc_node *it; + int res; + + while (node) { + it = rb_entry(node, struct gprs_rlcmac_pdch_ulc_node, node); + res = fn_cmp(it->fn, fn); + if (res > 0) /* it->fn AFTER fn */ + node = node->rb_left; + else if (res < 0) /* it->fn BEFORE fn */ + node = node->rb_right; + else /* it->fn == fn */ + return it; + } + return NULL; +} +struct gprs_rlcmac_pdch_ulc_node *gprs_rlcmac_pdch_ulc_pop_node(struct gprs_rlcmac_pdch_ulc *ulc, uint32_t fn) +{ + struct gprs_rlcmac_pdch_ulc_node *item = gprs_rlcmac_pdch_ulc_get_node(ulc, fn); + if (!item) + return NULL; + rb_erase(&item->node, &ulc->tree_root); + return item; +} + +struct rrbp_opt { + uint8_t offset; + enum gprs_rlcmac_rrbp_field coding; +}; + +static struct gprs_rlcmac_pdch_ulc_node *_alloc_node(struct gprs_rlcmac_pdch_ulc *ulc, uint32_t fn) +{ + struct gprs_rlcmac_pdch_ulc_node *node; + node = talloc_zero(ulc->pool_ctx, struct gprs_rlcmac_pdch_ulc_node); + node->fn = fn; + return node; +} + +static int gprs_rlcmac_pdch_ulc_add_node(struct gprs_rlcmac_pdch_ulc *ulc, struct gprs_rlcmac_pdch_ulc_node *item) +{ + struct rb_node **n = &(ulc->tree_root.rb_node); + struct rb_node *parent = NULL; + + while (*n) { + struct gprs_rlcmac_pdch_ulc_node *it; + int res; + + it = container_of(*n, struct gprs_rlcmac_pdch_ulc_node, node); + + parent = *n; + res = fn_cmp(item->fn, it->fn); + if (res < 0) { /* item->fn "BEFORE" it->fn */ + n = &((*n)->rb_left); + } else if (res > 0) { /* item->fn "AFTER" it->fn */ + n = &((*n)->rb_right); + } else { + LOGRLCMAC(LOGL_ERROR, "TS=%" PRIu8 " Trying to reserve already reserved FN %u\n", + ulc->ts_nr, item->fn); + return -EEXIST; + } + } + + rb_link_node(&item->node, parent, n); + rb_insert_color(&item->node, &ulc->tree_root); + return 0; +} + +int gprs_rlcmac_pdch_ulc_reserve(struct gprs_rlcmac_pdch_ulc *ulc, uint32_t fn, + enum gprs_rlcmac_pdch_ulc_poll_reason reason, + struct gprs_rlcmac_tbf *tbf) +{ + struct gprs_rlcmac_pdch_ulc_node *item = _alloc_node(ulc, fn); + item->reason = reason; + item->tbf = tbf; + LOGRLCMAC(LOGL_DEBUG, "Register POLL (TS=%u FN=%u, reason=%s)\n", + ulc->ts_nr, item->fn, + get_value_string(gprs_rlcmac_pdch_ulc_poll_reason_names, item->reason)); + return gprs_rlcmac_pdch_ulc_add_node(ulc, item); +} + +void gprs_rlcmac_pdch_ulc_release_node(struct gprs_rlcmac_pdch_ulc *ulc, struct gprs_rlcmac_pdch_ulc_node *item) +{ + rb_erase(&item->node, &ulc->tree_root); + talloc_free(item); +} + +int gprs_rlcmac_pdch_ulc_release_fn(struct gprs_rlcmac_pdch_ulc *ulc, uint32_t fn) +{ + struct gprs_rlcmac_pdch_ulc_node *item = gprs_rlcmac_pdch_ulc_get_node(ulc, fn); + if (!item) + return -ENOKEY; + gprs_rlcmac_pdch_ulc_release_node(ulc, item); + return 0; +} + +void gprs_rlcmac_pdch_ulc_release_tbf(struct gprs_rlcmac_pdch_ulc *ulc, const struct gprs_rlcmac_tbf *tbf) +{ + bool tree_modified; + do { + struct rb_node *node; + struct gprs_rlcmac_pdch_ulc_node *item; + + tree_modified = false; + for (node = rb_first(&ulc->tree_root); node; node = rb_next(node)) { + item = container_of(node, struct gprs_rlcmac_pdch_ulc_node, node); + if (item->tbf != tbf) + continue; + /* One entry found, remove it from tree and restart + * search from start (to avoid traverse continue from + * no-more existent node */ + tree_modified = true; + gprs_rlcmac_pdch_ulc_release_node(ulc, item); + break; + } + } while (tree_modified); +} + +void gprs_rlcmac_pdch_ulc_expire_fn(struct gprs_rlcmac_pdch_ulc *ulc, uint32_t fn) +{ + struct gprs_rlcmac_pdch_ulc_node *item; + int res; + + struct rb_node *first; + while ((first = rb_first(&ulc->tree_root))) { + item = container_of(first, struct gprs_rlcmac_pdch_ulc_node, node); + res = fn_cmp(item->fn, fn); + if (res > 0) /* item->fn AFTER fn */ + break; + if (res < 0) { /* item->fn BEFORE fn */ + /* Sanity check: */ + LOGRLCMAC(LOGL_ERROR, + "TS=%" PRIu8 " Expiring FN=%" PRIu32 " but previous FN=%" PRIu32 " is still reserved!\n", + ulc->ts_nr, fn, item->fn); + } + rb_erase(&item->node, &ulc->tree_root); + + LOGRLCMAC(LOGL_NOTICE, "TS=%u Timeout for registered POLL (FN=%u, reason=%s)\n", + ulc->ts_nr, item->fn, get_value_string(gprs_rlcmac_pdch_ulc_poll_reason_names, item->reason)); + + talloc_free(item); + } +} diff --git a/src/rlcmac/rlcmac.c b/src/rlcmac/rlcmac.c index c9d9634..b7f1261 100644 --- a/src/rlcmac/rlcmac.c +++ b/src/rlcmac/rlcmac.c @@ -27,6 +27,7 @@ #include <osmocom/gprs/rlcmac/rlcmac_prim.h> #include <osmocom/gprs/rlcmac/rlcmac_private.h> #include <osmocom/gprs/rlcmac/rlcmac_dec.h> +#include <osmocom/gprs/rlcmac/pdch_ul_controller.h> #include <osmocom/gprs/rlcmac/tbf_ul_fsm.h> #include <osmocom/gprs/rlcmac/tbf_ul_ass_fsm.h> #include <osmocom/gprs/rlcmac/gre.h> @@ -58,6 +59,7 @@ { bool first_init = true; int rc; + unsigned int i; OSMO_ASSERT(location == OSMO_GPRS_RLCMAC_LOCATION_MS || location == OSMO_GPRS_RLCMAC_LOCATION_PCU) if (g_ctx) { @@ -89,6 +91,11 @@ } } + for (i = 0; i < ARRAY_SIZE(g_ctx->sched.ulc); i++) { + g_ctx->sched.ulc[i] = gprs_rlcmac_pdch_ulc_alloc(g_ctx, i); + OSMO_ASSERT(g_ctx->sched.ulc[i]); + } + return 0; } @@ -319,7 +326,8 @@ return -ENOENT; } LOGPTBFDL(dl_tbf, LOGL_DEBUG, "Rx new DL data\n"); - rc = gprs_rlcmac_dl_tbf_rcv_data_block(dl_tbf, &rlc_dec, rlcmac_prim->l1ctl.pdch_data_ind.data); + rc = gprs_rlcmac_dl_tbf_rcv_data_block(dl_tbf, &rlc_dec, rlcmac_prim->l1ctl.pdch_data_ind.data, + rlcmac_prim->l1ctl.pdch_data_ind.fn, rlcmac_prim->l1ctl.pdch_data_ind.ts_nr); return rc; } diff --git a/src/rlcmac/sched.c b/src/rlcmac/sched.c index ea133c5..58a3673 100644 --- a/src/rlcmac/sched.c +++ b/src/rlcmac/sched.c @@ -27,17 +27,75 @@ #include <osmocom/gprs/rlcmac/gre.h> #include <osmocom/gprs/rlcmac/tbf_ul.h> #include <osmocom/gprs/rlcmac/tbf_ul_ass_fsm.h> +#include <osmocom/gprs/rlcmac/types_private.h> +#include <osmocom/gprs/rlcmac/pdch_ul_controller.h> struct tbf_sched_ctrl_candidates { + struct gprs_rlcmac_ul_tbf *poll_dl_ack_final_ack; /* 8.1.2.2 1) */ + struct gprs_rlcmac_ul_tbf *poll_dl_ack; /* 8.1.2.2 7) */ struct gprs_rlcmac_ul_tbf *ul_ass; }; +static inline uint32_t next_fn(uint32_t fn, uint32_t offset) +{ + return (fn + offset) % GSM_MAX_FN; +} + +static inline bool fn_valid(uint32_t fn) +{ + uint32_t f = fn % 13; + return f == 0 || f == 4 || f == 8; +} + +uint32_t rrbp2fn(uint32_t cur_fn, uint8_t rrbp) +{ + uint32_t poll_fn; + static const uint8_t rrbp_list[] = { + 13, /* GPRS_RLCMAC_RRBP_N_plus_13 */ + 17, /* GPRS_RLCMAC_RRBP_N_plus_17_18 */ + 21, /* GPRS_RLCMAC_RRBP_N_plus_21_22 */ + 26, /* GPRS_RLCMAC_RRBP_N_plus_26 */ + }; + + OSMO_ASSERT(rrbp < ARRAY_SIZE(rrbp_list)); + + poll_fn = next_fn(cur_fn, rrbp_list[rrbp]); + if (!fn_valid(poll_fn)) { + /* 17 -> 18, 21 -> 22: */ + poll_fn = next_fn(poll_fn, 1); + OSMO_ASSERT(fn_valid(poll_fn)); + } + return poll_fn; +} + static void get_ctrl_msg_tbf_candidates(const struct gprs_rlcmac_rts_block_ind *bi, struct tbf_sched_ctrl_candidates *tbfs) { struct gprs_rlcmac_entity *gre; struct gprs_rlcmac_ul_tbf *ul_tbf; + struct gprs_rlcmac_pdch_ulc_node *node; + node = gprs_rlcmac_pdch_ulc_get_node(g_ctx->sched.ulc[bi->ts], bi->fn); + if (node) { + switch (node->reason) { + case GPRS_RLCMAC_PDCH_ULC_POLL_UL_ASS: + /* TODO */ + break; + case GPRS_RLCMAC_PDCH_ULC_POLL_DL_ASS: + /* TODO */ + break; + case GPRS_RLCMAC_PDCH_ULC_POLL_UL_ACK: + /* TODO */ + break; + case GPRS_RLCMAC_PDCH_ULC_POLL_DL_ACK: + /* 8.1.2.2 Polling for Packet Downlink Ack/Nack */ + break; + case GPRS_RLCMAC_PDCH_ULC_POLL_CELL_CHG_CONTINUE: + /* TODO */ + break; + } + gprs_rlcmac_pdch_ulc_release_node(g_ctx->sched.ulc[bi->ts], node); + } /* Iterate over UL TBFs: */ llist_for_each_entry(gre, &g_ctx->gre_list, entry) { @@ -75,13 +133,34 @@ return NULL; } + static struct msgb *sched_select_ctrl_msg(const struct gprs_rlcmac_rts_block_ind *bi, struct tbf_sched_ctrl_candidates *tbfs) { struct msgb *msg = NULL; - if (tbfs->ul_ass) + /* 8.1.2.2 1) (EGPRS) PACKET DOWNLINK ACK/NACK w/ FinalAckInd=1 */ + if (tbfs->poll_dl_ack_final_ack) { + msg = NULL; /* TODO: generate DL ACK/NACK ctrl block */ + if (msg) + return msg; + } + + /* 8.1.2.2 5) Any other RLC/MAC control message, other than a (EGPRS) PACKET DOWNLINK ACK/NACK */ + if (tbfs->ul_ass) { msg = gprs_rlcmac_tbf_ul_ass_create_rlcmac_msg(tbfs->ul_ass, bi); - return msg; + if (msg) + return msg; + } + + /* 8.1.2.2 7) A (EGPRS) PACKET DOWNLINK ACK/NACK message not containing a Final Ack Indicator or a + * Channel Request Description IE */ + if (tbfs->poll_dl_ack) { + msg = NULL; /* TODO: generate DL ACK/NACK ctrl block */ + if (msg) + return msg; + } + + return NULL; } static struct msgb *sched_select_ul_data_msg(const struct gprs_rlcmac_rts_block_ind *bi) @@ -116,7 +195,7 @@ struct msgb *msg = NULL; struct tbf_sched_ctrl_candidates tbf_cand = {0}; struct osmo_gprs_rlcmac_prim *rlcmac_prim_tx; - int rc; + int rc = 0; get_ctrl_msg_tbf_candidates(bi, &tbf_cand); @@ -126,17 +205,20 @@ if ((msg = sched_select_ul_data_msg(bi))) goto tx_msg; - /* Prio 3: send dummy control message (or nothing depending on EXT_UTBF_NODATA) */ + /* Lowest prio: send dummy control message (or nothing depending on EXT_UTBF_NODATA) */ if ((msg = sched_select_ul_dummy_ctrl_blk(bi))) goto tx_msg; /* Nothing to transmit */ - return 0; + goto ret_rc; tx_msg: rlcmac_prim_tx = gprs_rlcmac_prim_alloc_l1ctl_pdch_data_req(bi->ts, bi->fn, msgb_data(msg), 0); rlcmac_prim_tx->l1ctl.pdch_data_req.data_len = msgb_length(msg); rc = gprs_rlcmac_prim_call_down_cb(rlcmac_prim_tx); msgb_free(msg); + +ret_rc: + gprs_rlcmac_pdch_ulc_expire_fn(g_ctx->sched.ulc[bi->ts], bi->fn); return rc; } diff --git a/src/rlcmac/tbf_dl.c b/src/rlcmac/tbf_dl.c index 0eb58ee..1032ac8 100644 --- a/src/rlcmac/tbf_dl.c +++ b/src/rlcmac/tbf_dl.c @@ -24,6 +24,7 @@ #include <osmocom/gprs/rlcmac/gre.h> #include <osmocom/gprs/rlcmac/rlc_window_dl.h> #include <osmocom/gprs/rlcmac/rlcmac_dec.h> +#include <osmocom/gprs/rlcmac/pdch_ul_controller.h> struct gprs_rlcmac_dl_tbf *gprs_rlcmac_dl_tbf_alloc(struct gprs_rlcmac_entity *gre) { @@ -166,7 +167,7 @@ int gprs_rlcmac_dl_tbf_rcv_data_block(struct gprs_rlcmac_dl_tbf *dl_tbf, const struct gprs_rlcmac_rlc_data_info *rlc, - uint8_t *data) + uint8_t *data, uint32_t fn, uint8_t ts_nr) { const struct gprs_rlcmac_rlc_block_info *rdbi; struct gprs_rlcmac_rlc_block *block; @@ -256,7 +257,13 @@ } } - /* TODO: if RRBP contains valid data, schedule a DL ACK/NACK. */ + /* If RRBP contains valid data, schedule a DL ACK/NACK. */ + if (rlc->es_p) { + uint32_t poll_fn = rrbp2fn(fn, rlc->rrbp); + gprs_rlcmac_pdch_ulc_reserve(g_ctx->sched.ulc[ts_nr], poll_fn, + GPRS_RLCMAC_PDCH_ULC_POLL_DL_ACK, + dl_tbf_as_tbf(dl_tbf)); + } return 0; } diff --git a/tests/rlcmac/rlcmac_prim_test.c b/tests/rlcmac/rlcmac_prim_test.c index 283227b..ff2dbc0 100644 --- a/tests/rlcmac/rlcmac_prim_test.c +++ b/tests/rlcmac/rlcmac_prim_test.c @@ -25,6 +25,7 @@ #include <osmocom/gprs/rlcmac/rlcmac.h> #include <osmocom/gprs/rlcmac/gre.h> #include <osmocom/gprs/rlcmac/rlc.h> +#include <osmocom/gprs/rlcmac/types_private.h> static void *tall_ctx = NULL; @@ -241,7 +242,7 @@ 0x43, 0xc0, 0x01, 0x2b, 0x2b, 0x2b }; -static struct msgb *create_dl_data_block(uint8_t dl_tfi, uint8_t usf, enum gprs_rlcmac_coding_scheme cs, uint8_t bsn, bool fbi) +static struct msgb *create_dl_data_block(uint8_t dl_tfi, uint8_t usf, enum gprs_rlcmac_coding_scheme cs, uint8_t bsn, bool fbi, bool s_p, uint8_t rrbp) { struct msgb *msg = msgb_alloc(128, __func__); struct gprs_rlcmac_rlc_dl_data_header *hdr; @@ -249,8 +250,8 @@ hdr = (struct gprs_rlcmac_rlc_dl_data_header *)msgb_put(msg, gprs_rlcmac_mcs_size_dl(cs)); hdr->pt = 0; /* RLC/MAC block contains an RLC data block */ - hdr->rrbp = 0; - hdr->s_p = 0; + hdr->rrbp = rrbp; + hdr->s_p = s_p ? 1 : 0; hdr->usf = usf; hdr->pr = 0; hdr->tfi = dl_tfi; @@ -341,7 +342,7 @@ OSMO_ASSERT(rc == 0); /* Transmit some DL LLC data MS<-PCU */ - dl_data_msg = create_dl_data_block(dl_tfi, usf, GPRS_RLCMAC_CS_1, 0, 1); + dl_data_msg = create_dl_data_block(dl_tfi, usf, GPRS_RLCMAC_CS_1, 0, 1, true, GPRS_RLCMAC_RRBP_N_plus_17_18); rlcmac_prim = osmo_gprs_rlcmac_prim_alloc_l1ctl_pdch_data_ind(ts_nr, rts_fn, 0, 0, 0, msgb_data(dl_data_msg), msgb_length(dl_data_msg)); -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31325 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I9d38a8de4240e65585cc8bbe3c044473af5a83e5 Gerrit-Change-Number: 31325 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-mgw[master]: mgcp_e1: be more frugal withe E1 line resources

by dexter

Attention is currently required from: osmith, dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/31269 to look at the new patch set (#4). Change subject: mgcp_e1: be more frugal withe E1 line resources ...................................................................... mgcp_e1: be more frugal withe E1 line resources At the moment we open an E1 timeslot when needed, but we never close it even when it is not needed anymore. This may block other entities from using it. Lets add some logic to detect whether the E1 timeslot is still needed and make sure that it is closed when it is no longer needed. Depends: libosmo-abis.git I073cfaba0d5073447842f22665e213135ea3f635 Change-Id: Ie6a32abbc5cd984f6d72a384e3b47c1b82ce7058 Related: OS#5198 --- M include/osmocom/mgcp/mgcp_e1.h M include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/mgcp_e1.c M src/libosmo-mgcp/mgcp_endp.c 4 files changed, 78 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/69/31269/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31269 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie6a32abbc5cd984f6d72a384e3b47c1b82ce7058 Gerrit-Change-Number: 31269 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023