February 2023 - gerrit-log - lists.osmocom.org

[M] Change in docker-playground[master]: debian-bullseye-*: apt-key is deprecated, use [signed-by] instead

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, msuraev, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/31366 to look at the new patch set (#3). Change subject: debian-bullseye-*: apt-key is deprecated, use [signed-by] instead ...................................................................... debian-bullseye-*: apt-key is deprecated, use [signed-by] instead The following warning message appears when running apt-key: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead The apt-key man page mentions that the "use of apt-key is deprecated, except for the use of apt-key del in maintainer scripts to remove existing keys from the main keyring". What's more, "apt-key will last be available in Debian 11 and Ubuntu 22.04". Additionally, while the deprecation message says to "manage keyring files in trusted.gpg.d instead", the Debian wiki states otherwise. It's recommended to store the keys in /usr/share/keyrings instead, and then use the 'signed-by' option to reference them. https://salsa.debian.org/apt-team/apt/-/commit/ee284d5917d09649b68ff1632d44… Change-Id: I1cae4f49e72f5e4f9d703cdb8f6d117e18e3567c --- M debian-bullseye-build/Dockerfile M debian-bullseye-erlang/Dockerfile M debian-bullseye-jenkins/Dockerfile M debian-bullseye-obs-latest/Dockerfile M debian-bullseye-titan/Dockerfile M open5gs-latest/Dockerfile 6 files changed, 52 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/66/31366/3 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31366 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1cae4f49e72f5e4f9d703cdb8f6d117e18e3567c Gerrit-Change-Number: 31366 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-pgw-test: allow using osmo-uecups from the latest feed

by fixeria

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/31388 to look at the new patch set (#2). Change subject: ttcn3-pgw-test: allow using osmo-uecups from the latest feed ...................................................................... ttcn3-pgw-test: allow using osmo-uecups from the latest feed Change-Id: I4f92577f062e8a9be29af83026214636dff19d78 --- M ttcn3-pgw-test/jenkins.sh 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/88/31388/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4f92577f062e8a9be29af83026214636dff19d78 Gerrit-Change-Number: 31388 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: libosmogb.pc.in: Fix missing dependency on libosmogsm

by dexter

Attention is currently required from: pespin, daniel. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31357 ) Change subject: libosmogb.pc.in: Fix missing dependency on libosmogsm ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5efa04d1c5cabc65b42de624b26fdbf9ebe746b1 Gerrit-Change-Number: 31357 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Feb 2023 09:33:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-pgw-test: allow using osmo-uecups from the latest feed

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/31388 ) Change subject: ttcn3-pgw-test: allow using osmo-uecups from the latest feed ...................................................................... ttcn3-pgw-test: allow using osmo-uecups from the latest feed Change-Id: I4f92577f062e8a9be29af83026214636dff19d78 --- M ttcn3-pgw-test/jenkins.sh 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/88/31388/1 diff --git a/ttcn3-pgw-test/jenkins.sh b/ttcn3-pgw-test/jenkins.sh index a61584d..58cfbbd 100755 --- a/ttcn3-pgw-test/jenkins.sh +++ b/ttcn3-pgw-test/jenkins.sh @@ -4,7 +4,7 @@ IMAGE_SUFFIX="${IMAGE_SUFFIX:-master}" docker_images_require \ "open5gs-$IMAGE_SUFFIX" \ - "osmo-uecups-master" \ + "osmo-uecups-$IMAGE_SUFFIX" \ "ttcn3-pgw-test" mkdir $VOL_BASE_DIR/pgw-tester @@ -70,7 +70,7 @@ -e "WORKDIR=/data" \ --name ${BUILD_TAG}-uecups -d \ $DOCKER_ARGS \ - $REPO_USER/osmo-uecups-master \ + $REPO_USER/osmo-uecups-$IMAGE_SUFFIX \ /bin/sh -c "osmo-uecups-daemon -c /data/osmo-uecups-daemon.cfg >/data/osmo-uecups-daemon.log 2>&1" # start docker container with testsuite in foreground -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4f92577f062e8a9be29af83026214636dff19d78 Gerrit-Change-Number: 31388 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[M] Change in docker-playground[master]: debian-bullseye-*: apt-key is deprecated, use [signed-by] instead

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, msuraev, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/31366 to look at the new patch set (#2). Change subject: debian-bullseye-*: apt-key is deprecated, use [signed-by] instead ...................................................................... debian-bullseye-*: apt-key is deprecated, use [signed-by] instead The following warning message appears when running apt-key: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead The apt-key man page mentions that the "use of apt-key is deprecated, except for the use of apt-key del in maintainer scripts to remove existing keys from the main keyring". What's more, "apt-key will last be available in Debian 11 and Ubuntu 22.04". Additionally, while the deprecation message says to "manage keyring files in trusted.gpg.d instead", the Debian wiki states otherwise. It's recommended to store the keys in /usr/share/keyrings instead, and then use the 'signed-by' option to reference them. Change-Id: I1cae4f49e72f5e4f9d703cdb8f6d117e18e3567c --- M debian-bullseye-build/Dockerfile M debian-bullseye-erlang/Dockerfile M debian-bullseye-jenkins/Dockerfile M debian-bullseye-obs-latest/Dockerfile M debian-bullseye-titan/Dockerfile M open5gs-latest/Dockerfile 6 files changed, 50 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/66/31366/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31366 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1cae4f49e72f5e4f9d703cdb8f6d117e18e3567c Gerrit-Change-Number: 31366 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: gsmtap_util: remove whitespace at the end of line

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31387 ) Change subject: gsmtap_util: remove whitespace at the end of line ...................................................................... gsmtap_util: remove whitespace at the end of line Change-Id: Ib7afbfb1f7a95beab16fed11d07ae244b4fcfcdc --- M src/core/gsmtap_util.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/87/31387/1 diff --git a/src/core/gsmtap_util.c b/src/core/gsmtap_util.c index cb7538b..4e66b23 100644 --- a/src/core/gsmtap_util.c +++ b/src/core/gsmtap_util.c @@ -232,7 +232,7 @@ #include <sys/socket.h> #include <netinet/in.h> -/*! Create a new (sending) GSMTAP source socket +/*! Create a new (sending) GSMTAP source socket * \param[in] host host name or IP address in string format * \param[in] port UDP port number in host byte order * \return file descriptor of the new socket -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib7afbfb1f7a95beab16fed11d07ae244b4fcfcdc Gerrit-Change-Number: 31387 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[M] Change in libosmocore[master]: GSMTAP: add gsmtap_source_init*2()

by dexter

Attention is currently required from: msuraev. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31385 ) Change subject: GSMTAP: add gsmtap_source_init*2() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I51b3604ba79e42c474aa17007e7e308a12afcea8 Gerrit-Change-Number: 31385 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Feb 2023 09:29:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: libosmogb.pc.in: Fix missing dependency on libosmogsm

by osmith

Attention is currently required from: pespin, daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31357 ) Change subject: libosmogb.pc.in: Fix missing dependency on libosmogsm ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5efa04d1c5cabc65b42de624b26fdbf9ebe746b1 Gerrit-Change-Number: 31357 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Feb 2023 08:25:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: gsm0808_enc_channel_type: Add spare byte

by osmith

Attention is currently required from: Matan Perelman. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31382 ) Change subject: gsm0808_enc_channel_type: Add spare byte ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31382 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6e05e4989924b2258122113eb134e946e9cf0107 Gerrit-Change-Number: 31382 Gerrit-PatchSet: 1 Gerrit-Owner: Matan Perelman <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Matan Perelman <matan1008(a)gmail.com> Gerrit-Comment-Date: Mon, 20 Feb 2023 08:24:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-bts[master]: bts-virtual: fix segfault

by fixeria

Attention is currently required from: pespin, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31383 ) Change subject: bts-virtual: fix segfault ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31383 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I116c2548dd4d05df90c16e81fa2e85ed6027a2e1 Gerrit-Change-Number: 31383 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 19 Feb 2023 18:19:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023