November 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: msc: test re-assignment to match codec with MT

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053?usp=email ) Change subject: msc: test re-assignment to match codec with MT ...................................................................... Patch Set 2: Code-Review+1 (4 comments) File msc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053/comment/6719b952_5351… PS2, Line 987: ass_compl_chosen_codec > "the one" Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053/comment/3eabe1cc_75e1… PS2, Line 995: re_ass_compl_chosen_codec > "the other" Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053/comment/a387204f_cced… PS2, Line 1723: cpars.re_ass_compl_chosen_codec > yes, there are two different phases where _handle_assignment_request happens. […] Ah, I see. Thanks for explaining. Fine with me then. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053/comment/b2fd2b19_1589… PS2, Line 1730: ass_compl_chosen_co > "the one" Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I402ed0523a2a87b83f29c5577b2c828102005d53 Gerrit-Change-Number: 35053 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Nov 2023 05:51:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: msc: test re-assignment to match codec with MT

by neels

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053?usp=email ) Change subject: msc: test re-assignment to match codec with MT ...................................................................... Patch Set 2: (4 comments) File msc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053/comment/6ef8a812_408c… PS2, Line 987: ass_compl_chosen_codec "the one" https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053/comment/fa8d2da6_4af7… PS2, Line 995: re_ass_compl_chosen_codec "the other" https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053/comment/6d626557_de39… PS2, Line 1723: cpars.re_ass_compl_chosen_codec > Now that this argument is part of the `cpars`, is there still a need to pass it separately, given th […] yes, there are two different phases where _handle_assignment_request happens. *The one* is for the actual normal Assignment, *the other* is for the expected re-assignment if the test feeds in SDP that informs of MT codecs mismatch. That is actually the single main reason to have separated the __handle_assignment_request() function apart from below altstep. (the src line of this comment shows "the other".) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053/comment/3db793b7_a2a1… PS2, Line 1730: ass_compl_chosen_co "the one" -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I402ed0523a2a87b83f29c5577b2c828102005d53 Gerrit-Change-Number: 35053 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Nov 2023 01:12:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: msc: split off f_mo_call_establish__handle_assignment_request()

by neels

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052?usp=email ) Change subject: msc: split off f_mo_call_establish__handle_assignment_request() ...................................................................... Patch Set 2: (4 comments) File msc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052/comment/5a570a53_ec3c… PS2, Line 1666: ts_CodecFR for illustration, this hardcoded FR is what I ultimately want to vary in the upcoming patch, because TCH assignment may want to test for correct codec decisions. The CSData two lines above will always stay constant AFAICT. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052/comment/b6ae4d7a_3141… PS2, Line 1557: f_mo_call_establish__handle_assignment_request > Hmm, I find the double low-dash a bit weird, but guessing you did it intentionally? yes, the idea is that it is a sub-part of f_mo_call_establish(), and to not confuse the reader into "what, establish a handle?". let me know if that's fine. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052/comment/69c7529b_345b… PS2, Line 1573: not match(ass_req.pdu.bssmap.assignmentRequest.aoIPTransportLayer, tla_ass1 > btw, this matching statement can be simplified a bit to: […] ah i see. i agree; but not going to change it in this patch. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052/comment/bf7d5dc7_7fc2… PS2, Line 1690: valueof(ts_CodecFR > Hmm, so now you're explicitly passing `ts_CodecFR`, but the new function may overwrite it to `ts_Cod […] i did consider that. i kept it this way because only TCH needs various codecs, and csd ALWAYS needs CSData; so one could consider the arg to pass in the default TCH codec, and CSD uses CSData always anyway. The argument you make weighs about the same. So then I chose to not invest time... does that sound good or a lame excuse? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I98c6171a592dfe1573e15136c4ecf4ff234048d7 Gerrit-Change-Number: 35052 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Nov 2023 01:06:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[L] Change in libosmocore[master]: core: Add software UART implementation

by fixeria

Attention is currently required from: jolly, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email ) Change subject: core: Add software UART implementation ...................................................................... Patch Set 3: (1 comment) File src/core/soft_uart.c: https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/0c052f98_c59b7946 PS3, Line 138: fprintf(stderr, "framing e > link is unfortunately a 404 Somehow Gerrit made the closing parenthesis ')' part of the link, here it is: https://gerrit.osmocom.org/c/libosmocore/+/35022 I40ab5d12b6f7087daa51405468f5c4ea639561ea > I think there's no need to log the errors if they get reported to the application Ack. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2ca95963fd5852ddb89bdd35b86b31489127fe84 Gerrit-Change-Number: 30763 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 19 Nov 2023 13:02:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[L] Change in libosmocore[master]: soft_uart: add unit tests for the receiver and transmitter

by Jenkins Builder

Attention is currently required from: fixeria, jolly. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35046?usp=email ) Change subject: soft_uart: add unit tests for the receiver and transmitter ...................................................................... Patch Set 4: (9 comments) File tests/soft_uart/soft_uart_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12476): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/a730edf7_1f35bb69 PS4, Line 111: "F" /* flush! (for sanity) */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12476): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/236c1092_b5f1f17d PS4, Line 124: "0 11110010 1F" /* 'O', flush! */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12476): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/40377751_0765055f PS4, Line 131: "F" /* flush! */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12476): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/ddb642ce_09509596 PS4, Line 144: "0 11110010 1F1F" /* 'O', flush! */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12476): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/ddf1eb91_ef3ca6fc PS4, Line 152: "F" /* flush! (for sanity) */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12476): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/531fcf81_65585460 PS4, Line 163: "F" /* flush! (for sanity) */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12476): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/a2f5d5e0_d385e982 PS4, Line 175: "F" /* flush! */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12476): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/8af0b194_f609e1a9 PS4, Line 185: "F" /* flush! (for sanity) */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12476): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/3b6fdfd4_a4f1c7f6 PS4, Line 197: "F" /* flush! */ ); space prohibited before that close parenthesis ')' -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35046?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icdfa0c644548964d37940c32dc9dcfcfc53c3a19 Gerrit-Change-Number: 35046 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 19 Nov 2023 11:03:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[L] Change in libosmocore[master]: core: Add software UART implementation

by laforge

Attention is currently required from: fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email ) Change subject: core: Add software UART implementation ...................................................................... Patch Set 3: (1 comment) File src/core/soft_uart.c: https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/ddd6eda2_70e85507 PS3, Line 138: fprintf(stderr, "framing e > This one is going be removed by a follow-up patch (see https://gerrit.osmocom. […] link is unfortunately a 404. I think there's no need to log the errors if they get reported to the application. The logging was just an early hack during development when that capability didn't exist yet. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2ca95963fd5852ddb89bdd35b86b31489127fe84 Gerrit-Change-Number: 30763 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 19 Nov 2023 10:43:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[M] Change in libosmocore[master]: soft_uart: implement OSMO_SUART_PARITY_{MARK,SPACE}

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35067?usp=email ) Change subject: soft_uart: implement OSMO_SUART_PARITY_{MARK,SPACE} ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35067?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4c8fe5bfdcc2f4eb52c259d1e62d06684cd8f823 Gerrit-Change-Number: 35067 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 19 Nov 2023 10:40:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in libosmocore[master]: soft_uart: fix handling of num_data_bits < 8

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35066?usp=email ) Change subject: soft_uart: fix handling of num_data_bits < 8 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35066?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ife13b1f2d9063ba7253d01523ca9ecb15e9eaf07 Gerrit-Change-Number: 35066 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 19 Nov 2023 10:30:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in libosmocore[master]: soft_uart: fix Rx buffer flushing logic in suart_rx_ch()

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35065?usp=email ) Change subject: soft_uart: fix Rx buffer flushing logic in suart_rx_ch() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35065?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I73fab1a5c196d2dbdfe98b0c20d8dadbd22f4f64 Gerrit-Change-Number: 35065 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 19 Nov 2023 10:30:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[L] Change in libosmocore[master]: soft_uart: add unit tests for the receiver and transmitter

by laforge

Attention is currently required from: fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35046?usp=email ) Change subject: soft_uart: add unit tests for the receiver and transmitter ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35046?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icdfa0c644548964d37940c32dc9dcfcfc53c3a19 Gerrit-Change-Number: 35046 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 19 Nov 2023 10:30:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2023