November 2023 - gerrit-log - lists.osmocom.org

[M] Change in libosmocore[master]: soft_uart: demonstrate a problem with osmo_soft_uart_tx_ubits()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35074?usp=email ) Change subject: soft_uart: demonstrate a problem with osmo_soft_uart_tx_ubits() ...................................................................... soft_uart: demonstrate a problem with osmo_soft_uart_tx_ubits() As can be seen, pulling a small number of bits at a time (smaller than a single UART frame would fit into) results in calling the .tx_cb() with a msgb having no room at all, and thus pulling the stop bits instead of the actual data. Change-Id: Icfee378f0fdc5e32fe9ce0afab5f75bc278653a9 Related: OS#4396 --- M tests/soft_uart/soft_uart_test.c M tests/soft_uart/soft_uart_test.ok 2 files changed, 85 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/74/35074/1 diff --git a/tests/soft_uart/soft_uart_test.c b/tests/soft_uart/soft_uart_test.c index 20df207..4e85fe9 100644 --- a/tests/soft_uart/soft_uart_test.c +++ b/tests/soft_uart/soft_uart_test.c @@ -293,10 +293,30 @@ osmo_soft_uart_free(suart); } +static void test_tx_one_bit(void) +{ + struct osmo_soft_uart *suart; + ubit_t tx_buf[48]; + + suart = osmo_soft_uart_alloc(NULL, __func__, &suart_test_default_cfg); + OSMO_ASSERT(suart != NULL); + + osmo_soft_uart_set_tx(suart, true); + + g_tx_cb_cfg.data = (void *)"\xde\xad\xbe\xef"; + g_tx_cb_cfg.data_len = 4; + + printf("======== %s(): pulling %lu bits (one at a time)\n", __func__, sizeof(tx_buf)); + for (unsigned int i = 0; i < sizeof(tx_buf); i++) + osmo_soft_uart_tx_ubits(suart, &tx_buf[i], 1); + printf("%s\n", osmo_ubit_dump(&tx_buf[0], sizeof(tx_buf))); +} + int main(int argc, char **argv) { test_rx(); test_tx_rx(); + test_tx_one_bit(); return 0; } diff --git a/tests/soft_uart/soft_uart_test.ok b/tests/soft_uart/soft_uart_test.ok index e041104..5bde3fc 100644 --- a/tests/soft_uart/soft_uart_test.ok +++ b/tests/soft_uart/soft_uart_test.ok @@ -171,3 +171,53 @@ test_tx_rx_exec_one(n_bits_total=32): 00000101 00000011 00000001 00000001 suart_tx_cb(len=0/4): test_tx_rx_exec_one(n_bits_total=32): 11111111 11111111 11111111 11111111 +======== test_tx_one_bit(): pulling 48 bits (one at a time) +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +111111111111111111111111111111111111111111111111 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35074?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icfee378f0fdc5e32fe9ce0afab5f75bc278653a9 Gerrit-Change-Number: 35074 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 7 months

1
0
0 0

[M] Change in libosmocore[master]: soft_uart: implement the transmitter

by fixeria

Attention is currently required from: jolly, laforge. Hello jolly, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35044?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by jolly, Code-Review+1 by laforge Change subject: soft_uart: implement the transmitter ...................................................................... soft_uart: implement the transmitter Change-Id: Ibcd9643227e5616efd8bbd7a1430feda6fcef45c Related: OS#4396 --- M include/osmocom/core/soft_uart.h M src/core/libosmocore.map M src/core/soft_uart.c 3 files changed, 96 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/44/35044/5 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35044?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibcd9643227e5616efd8bbd7a1430feda6fcef45c Gerrit-Change-Number: 35044 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 year, 7 months

1
0
0 0

[M] Change in libosmocore[master]: soft_uart: implement the transmitter

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35044?usp=email ) Change subject: soft_uart: implement the transmitter ...................................................................... Patch Set 4: (1 comment) File src/core/soft_uart.c: https://gerrit.osmocom.org/c/libosmocore/+/35044/comment/10132040_afdd4a54 PS4, Line 206: msgb_pull_u8 > what if the msgb doesn't have anything to pull anymore? Ah, I guess that's why you check msg->len above. Exactly. `msg->len` gets decremented every time we do `msgb_pull_u8()`. If there is still some data (`if msg->len > 0`), we pull one byte from the beginning and transmit a UART frame going via all those flow states. If the `msg` has no more data, we remain in `IDLE` and transmit stop bits. > It would be more elegant to avoid dereferencing msgb internals and instead use msgb_length(msg) here. What I don't like about `msgb_length()` is that it's not a `static inline` function, but a regular function defined in `core/msgb.c`. I was afraid of a negative performance impact, but I hope the compiler is smart enough to optimize out a function call. Will migrate to `msgb_length()`. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35044?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibcd9643227e5616efd8bbd7a1430feda6fcef45c Gerrit-Change-Number: 35044 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 20 Nov 2023 16:16:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests_LAPDm.TC_nr_seq_error: Fix test

by fixeria

Attention is currently required from: jolly, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35047?usp=email ) Change subject: BTS_Tests_LAPDm.TC_nr_seq_error: Fix test ...................................................................... Patch Set 1: -Code-Review (1 comment) Patchset: PS1: Comments marked as resolved/done, but not actually addresses. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4cdff6ab607e158d4956a1bd87f74e9e75579cff Gerrit-Change-Number: 35047 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 20 Nov 2023 16:10:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in libosmocore[master]: osmo_io: rename unsupported SCTP mode to OSMO_IO_FD_MODE_SCTP_RECVMSG...

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35062?usp=email ) Change subject: osmo_io: rename unsupported SCTP mode to OSMO_IO_FD_MODE_SCTP_RECVMSG_SEND ...................................................................... Patch Set 1: (1 comment) File include/osmocom/core/osmo_io.h: https://gerrit.osmocom.org/c/libosmocore/+/35062/comment/a7fd4ed1_f86fd297 PS1, Line 25: OSMO_IO_FD_MODE_SCTP_RECVMSG_SENDMSG Don't we need to add a backwards compatibility alias? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35062?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie2d1c7ce6f211dbe025a0e843ad733443102ea15 Gerrit-Change-Number: 35062 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 20 Nov 2023 16:03:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in libosmo-netif[master]: stream_{cli,srv}: Add support for SCTP in OSMO_IO mode

by fixeria

Attention is currently required from: arehbein, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35069?usp=email ) Change subject: stream_{cli,srv}: Add support for SCTP in OSMO_IO mode ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35069?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I6cf5bad5f618e71c80017960c38009b089dbd6a1 Gerrit-Change-Number: 35069 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Nov 2023 15:58:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[M] Change in libosmo-netif[master]: Introduce generic osmo_stream_{cli,srv}_get_fd() API

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35072?usp=email ) Change subject: Introduce generic osmo_stream_{cli,srv}_get_fd() API ...................................................................... Patch Set 1: (2 comments) File src/stream_cli.c: https://gerrit.osmocom.org/c/libosmo-netif/+/35072/comment/0c640730_d73060b5 PS1, Line 214: to modify unrelated? https://gerrit.osmocom.org/c/libosmo-netif/+/35072/comment/8d13a6fe_eb824e47 PS1, Line 215: File descriptor `... or negative on error` -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35072?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ib0737f21150f6ac8d524b92c7ddb098f2afdeaab Gerrit-Change-Number: 35072 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 20 Nov 2023 15:54:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in libosmo-netif[master]: stream_srv: osmo_stream_srv_get_ofd() works only in OSMO_FD mode

by fixeria

Attention is currently required from: arehbein, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35071?usp=email ) Change subject: stream_srv: osmo_stream_srv_get_ofd() works only in OSMO_FD mode ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35071?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I50df259040e011135a31fe1aee231eba430fa94a Gerrit-Change-Number: 35071 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 20 Nov 2023 15:50:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[M] Change in osmo-bts[master]: Use polling based LAPDm with frame numbers

by fixeria

Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35007?usp=email ) Change subject: Use polling based LAPDm with frame numbers ...................................................................... Patch Set 4: (1 comment) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/35007/comment/0a08b568_ef82e035 PS2, Line 1975: (fn + GSM_MAX_FN - 1) % GSM_MAX_FN > Done Hmm, I don't see any changes. Did you forget to push an updated version? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35007?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic6d7902b13cf491daaa8752db78f9875387aeffd Gerrit-Change-Number: 35007 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 20 Nov 2023 15:27:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in libosmo-netif[master]: stream_{cli,srv}: Add support for SCTP in OSMO_IO mode

by daniel

Attention is currently required from: arehbein, laforge, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35069?usp=email ) Change subject: stream_{cli,srv}: Add support for SCTP in OSMO_IO mode ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Just to clarify, the expectation is that `msgb_sctp_{ppid,stream}()` will be set prior to calling the write function / before the read callback is called, similar to how it was in the ofd code path (only there read was implemented by the user)? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35069?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I6cf5bad5f618e71c80017960c38009b089dbd6a1 Gerrit-Change-Number: 35069 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Nov 2023 14:09:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2023